lttng-tools.git
5 years agoFix: illegal memory access in add_uri_to_consumer
Mathieu Desnoyers [Tue, 17 May 2016 01:42:43 +0000 (21:42 -0400)] 
Fix: illegal memory access in add_uri_to_consumer

Found by Coverity:

CID 1243038 (#1 of 1): Buffer not null terminated
(BUFFER_SIZE_WARNING)15. buffer_size_warning: Calling strncpy with a
maximum size argument of 4096 bytes on destination array
consumer->dst.trace_path of size 4096 bytes might leave the destination
string unterminated.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoFix: illegal memory access in init_ust_event_from_agent_event
Mathieu Desnoyers [Tue, 17 May 2016 01:42:42 +0000 (21:42 -0400)] 
Fix: illegal memory access in init_ust_event_from_agent_event

Found by Coverity:
CID 1321741 (#1 of 1): Buffer not null terminated
(BUFFER_SIZE_WARNING)1. buffer_size_warning: Calling strncpy with a
maximum size argument of 256 bytes on destination array
ust_event->attr.name of size 256 bytes might leave the destination
string unterminated.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoSimplify free() of channel attribute
Jérémie Galarneau [Tue, 17 May 2016 02:39:59 +0000 (22:39 -0400)] 
Simplify free() of channel attribute

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoFix: illegal memory access in _cmd_enable_event
Mathieu Desnoyers [Tue, 17 May 2016 01:42:41 +0000 (21:42 -0400)] 
Fix: illegal memory access in _cmd_enable_event

Found by Coverity:

CID 1321742 (#1 of 2): Buffer not null terminated
(BUFFER_SIZE_WARNING)21. buffer_size_warning: Calling strncpy with a
maximum size argument of 256 bytes on destination array attr->name of
size 256 bytes might leave the destination string unterminated.

CID 1321742 (#2 of 2): Buffer not null terminated
(BUFFER_SIZE_WARNING)22. buffer_size_warning: Calling strncpy with a
maximum size argument of 256 bytes on destination array attr->name of
size 256 bytes might leave the destination string unterminated.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoImplement lttng_strncpy safe string copy
Mathieu Desnoyers [Tue, 17 May 2016 01:42:40 +0000 (21:42 -0400)] 
Implement lttng_strncpy safe string copy

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoAdd missing symbol to preserve ABI compatibility of liblttng-ctl
Jérémie Galarneau [Mon, 16 May 2016 18:10:54 +0000 (14:10 -0400)] 
Add missing symbol to preserve ABI compatibility of liblttng-ctl

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoFix: loading a session prints an error message but the load is successful
Jérémie Galarneau [Mon, 16 May 2016 16:10:19 +0000 (12:10 -0400)] 
Fix: loading a session prints an error message but the load is successful

Fixes #1013

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoSnapshot warning if there are no events in one of the domains
Jérémie Galarneau [Mon, 16 May 2016 05:20:47 +0000 (01:20 -0400)] 
Snapshot warning if there are no events in one of the domains

Remove the "no data" check from the UST snapshot code since

1) It would report that no data was recorded in the snapshot even
   if the kernel tracer had recorded events,
2) The kernel consumer does not seem to report such a condition,
   making it hard to perform the check without modifying the
   consumer.

The consumer interfaces could be modified to reliably provide
this information in the future.

However, this warning is not provided in the other tracing
modes, making its usefulness questionable. An empty snapshot is
still a valid trace and users should not always expect a trace
to contain events. Moreover, "warning" that no data was produced
implies an error may have occured and is probably as confusing
as opening an empty trace to the average user.

Fixes #1012

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoClarify kernel version check error messages
Jérémie Galarneau [Mon, 16 May 2016 04:21:20 +0000 (00:21 -0400)] 
Clarify kernel version check error messages

Refs #949

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoTests: same event name with different descriptor on load
Jonathan Rajotte [Mon, 26 Oct 2015 14:21:05 +0000 (10:21 -0400)] 
Tests: same event name with different descriptor on load

Refs #959

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoFix: load event state (enabled/disabled) correctly
Jonathan Rajotte [Fri, 23 Oct 2015 15:32:44 +0000 (11:32 -0400)] 
Fix: load event state (enabled/disabled) correctly

This bug fix is a workaround due to limitations of lttng_disable_event_ext
regarding the disabling of events with similar name but different
characteristics. Although lttng_disable_event_ext provides support for
disabling by name and filter string it does not support exclusion.

The loading of events is cut in 3 phases.

1 - Create all events regardless of their state.
2 - Disable all events.
3 - Enable only the events with the 'enabled' state.

Fixes #959

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoFix: Error reported if no domain is provided for start/stop
Jérémie Galarneau [Mon, 16 May 2016 02:06:01 +0000 (22:06 -0400)] 
Fix: Error reported if no domain is provided for start/stop

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoHandle unknown domain in MI
Jérémie Galarneau [Sun, 15 May 2016 21:38:55 +0000 (17:38 -0400)] 
Handle unknown domain in MI

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoHandle unknown domain on session start
Jérémie Galarneau [Sun, 15 May 2016 21:38:41 +0000 (17:38 -0400)] 
Handle unknown domain on session start

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoFix: loading of live session within userspace domains
Jérémie Galarneau [Thu, 5 Nov 2015 21:19:38 +0000 (16:19 -0500)] 
Fix: loading of live session within userspace domains

The output of a session is session-specific and not bound to
a domain. The "lttng_set_consumer_url" already acts on a
session-wide basis.

Fixes #973

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoTest: expose session url bug on load with multiple domains
Jonathan Rajotte [Thu, 5 Nov 2015 21:42:50 +0000 (16:42 -0500)] 
Test: expose session url bug on load with multiple domains

When loading a live session with multiple domain lttng return code
21 which corresponds to the URL being already set.

Refs #973

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoOOT build fix: asciidoc.conf is now generated at configure
Jérémie Galarneau [Sun, 15 May 2016 20:20:48 +0000 (16:20 -0400)] 
OOT build fix: asciidoc.conf is now generated at configure

asciidoc.conf is now generated at configure-time and must be
retrieved from the build directory, not the source directory.
This causes the out-of-tree build to fail.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoSnapshot: record: use same datetime for snapshot folder output
Jonathan Rajotte [Fri, 13 Nov 2015 15:36:47 +0000 (10:36 -0500)] 
Snapshot: record: use same datetime for snapshot folder output

Make sure that the ust snapshot is put under the same folder as the
kernel snapshot.

Fixes #970

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoRefactor: move the snapshot type check into output type check
Jonathan Rajotte [Fri, 13 Nov 2015 15:30:01 +0000 (10:30 -0500)] 
Refactor: move the snapshot type check into output type check

Since for both sub-session type the boilerplate is the same
simply move the check for sub-session type presence to the inner
check of type output.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoust-metadata.c: nest/indent enumeration entries
Philippe Proulx [Thu, 7 Apr 2016 03:57:36 +0000 (23:57 -0400)] 
ust-metadata.c: nest/indent enumeration entries

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agolttng.c: show basic help when no arguments are provided
Philippe Proulx [Tue, 10 May 2016 19:31:58 +0000 (15:31 -0400)] 
lttng.c: show basic help when no arguments are provided

Fixes #1011

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoDefine command short descriptions in configure.ac
Philippe Proulx [Tue, 10 May 2016 19:08:00 +0000 (15:08 -0400)] 
Define command short descriptions in configure.ac

Refs #1011

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agolttng-relayd(8): $HOME -> $LTTNG_HOME
Philippe Proulx [Wed, 4 May 2016 20:48:28 +0000 (16:48 -0400)] 
lttng-relayd(8): $HOME -> $LTTNG_HOME

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agodoc/man: use propagated default values in man pages
Philippe Proulx [Wed, 4 May 2016 20:47:51 +0000 (16:47 -0400)] 
doc/man: use propagated default values in man pages

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoPropagate default values from configure.ac to asciidoc.conf
Philippe Proulx [Wed, 4 May 2016 20:24:10 +0000 (16:24 -0400)] 
Propagate default values from configure.ac to asciidoc.conf

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoDefine default values in configure.ac
Philippe Proulx [Wed, 4 May 2016 19:57:36 +0000 (15:57 -0400)] 
Define default values in configure.ac

This patch moves the definitions of the various default values of
LTTng-tools to configure.ac, so that the code and the man pages can
share the same default values.

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agolttng-load(1): use lists to explain the input path behaviour
Philippe Proulx [Wed, 4 May 2016 16:39:03 +0000 (12:39 -0400)] 
lttng-load(1): use lists to explain the input path behaviour

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agolttng-sessiond(8): fix load directories and behaviour
Philippe Proulx [Wed, 4 May 2016 16:35:47 +0000 (12:35 -0400)] 
lttng-sessiond(8): fix load directories and behaviour

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agolttng-load(1): specify default search order
Philippe Proulx [Wed, 4 May 2016 15:19:32 +0000 (11:19 -0400)] 
lttng-load(1): specify default search order

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agodoc/man: use configured directories in man pages
Philippe Proulx [Wed, 4 May 2016 15:00:50 +0000 (11:00 -0400)] 
doc/man: use configured directories in man pages

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agodoc/man/asciidoc.conf: add doctype-manpage conditions
Philippe Proulx [Thu, 7 Apr 2016 07:19:29 +0000 (03:19 -0400)] 
doc/man/asciidoc.conf: add doctype-manpage conditions

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agodoc/man: linklttng macro -> man macro
Philippe Proulx [Thu, 7 Apr 2016 07:17:21 +0000 (03:17 -0400)] 
doc/man: linklttng macro -> man macro

This macro is shorter, and some referenced man pages are not
LTTng man pages, so the linklttng name makes little sense.

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agodoc/man/Makefile.am: add failing dist-hook on --disable-man-pages
Philippe Proulx [Thu, 7 Apr 2016 07:13:14 +0000 (03:13 -0400)] 
doc/man/Makefile.am: add failing dist-hook on --disable-man-pages

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agodoc/man/Makefile.am: fix top comment
Philippe Proulx [Thu, 7 Apr 2016 07:13:03 +0000 (03:13 -0400)] 
doc/man/Makefile.am: fix top comment

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoconfigure.ac: fix --enable-man-pages help string
Philippe Proulx [Thu, 7 Apr 2016 07:12:44 +0000 (03:12 -0400)] 
configure.ac: fix --enable-man-pages help string

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoFix: standardize parser/lexer building
Philippe Proulx [Sat, 2 Apr 2016 20:14:17 +0000 (16:14 -0400)] 
Fix: standardize parser/lexer building

This patch makes the build system act as follows:

    if in Git repo:
        require bison/flex (configure)
        build parser/lexer (make, make clean)
    else:
        if bison exists:
            build parser (make, make clean)
        else:
            warn that bison is missing (configure)
            create "error" parser target in Makefile (make)
            do not clean parser (make clean not available)

        if flex exists:
            build lexer (make, make clean)
        else:
            warn that flex is missing (configure)
            create "error" lexer target in Makefile (make)
            do not clean lexer (make clean not available)

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoFix: standardize man pages building/installing
Philippe Proulx [Sat, 2 Apr 2016 02:15:53 +0000 (22:15 -0400)] 
Fix: standardize man pages building/installing

This patch makes the build system act as follows:

    if --enable-man-pages:
        if in Git repo:
            require asciidoc/xmlto (configure)
            build man pages (make, make clean)
            install man pages (make install)
            distribute man pages (make dist)
        else:
            if asciidoc/xmlto both exist:
                build man pages (make, make clean)
                install man pages (make install)
                distribute man pages (make dist)
            else:
                warn that asciidoc/xmlto are missing (configure)
                create "error" man page targets in Makefile (make)
                do not clean man pages (make clean not available)
                install distributed man pages (make install)
                distribute distributed man pages (make dist)
    else if --disable-man-pages:
        do not build man pages (make, make clean not available)
        do not install man pages (make install not available)
        do not distribute man pages (make dist not available)

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoconfigure.ac: check for an existing liburcu-cds symbol
Philippe Proulx [Tue, 10 May 2016 20:00:28 +0000 (16:00 -0400)] 
configure.ac: check for an existing liburcu-cds symbol

Fixes #1001

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoconfigure.ac: use macro for wrong liburcu error message
Philippe Proulx [Tue, 10 May 2016 19:51:17 +0000 (15:51 -0400)] 
configure.ac: use macro for wrong liburcu error message

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoHide parse_application_context utility function
Jérémie Galarneau [Sat, 14 May 2016 21:31:39 +0000 (17:31 -0400)] 
Hide parse_application_context utility function

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoRe-add deprecated MI symbols to preserve ABI compatibility
Jérémie Galarneau [Sat, 14 May 2016 21:29:15 +0000 (17:29 -0400)] 
Re-add deprecated MI symbols to preserve ABI compatibility

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoHide new MI symbols introduced as part of 2.8
Jérémie Galarneau [Sat, 14 May 2016 21:28:35 +0000 (17:28 -0400)] 
Hide new MI symbols introduced as part of 2.8

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoRe-add default size symbols which were erroneously exposed
Jérémie Galarneau [Sat, 14 May 2016 21:23:34 +0000 (17:23 -0400)] 
Re-add default size symbols which were erroneously exposed

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoHide config symbols introduced in 2.8
Jérémie Galarneau [Sat, 14 May 2016 21:09:45 +0000 (17:09 -0400)] 
Hide config symbols introduced in 2.8

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoHide internal _lttng_destroy_session symbol
Jérémie Galarneau [Sat, 14 May 2016 21:01:43 +0000 (17:01 -0400)] 
Hide internal _lttng_destroy_session symbol

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoHide bytecode symbol iterator API symbols
Jérémie Galarneau [Sat, 14 May 2016 21:01:16 +0000 (17:01 -0400)] 
Hide bytecode symbol iterator API symbols

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoTests: wording of trace_matches is misleading
Jérémie Galarneau [Sat, 14 May 2016 20:27:20 +0000 (16:27 -0400)] 
Tests: wording of trace_matches is misleading

trace_matches reports a number of "events found" in a trace while it
actually counts the number of event_name matches.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoTest lttng-modules clock override plugin
Mathieu Desnoyers [Wed, 11 May 2016 17:15:25 +0000 (13:15 -0400)] 
Test lttng-modules clock override plugin

[ For both master and stable-2.8 branches. ]

Fixes: #939

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoWarning fix: uninitialized variable may be used
Jérémie Galarneau [Sat, 14 May 2016 19:30:35 +0000 (15:30 -0400)] 
Warning fix: uninitialized variable may be used

GCC warns that discarded_events and lost_packets may be used
uninitialized (NULL).

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoTests: Replace prove by autotools tap runner
Michael Jeanson [Thu, 12 May 2016 19:20:33 +0000 (15:20 -0400)] 
Tests: Replace prove by autotools tap runner

This patch removes the dependency on the prove perl script
to run the TAP test suite. It replaces it with the autotools
shell TAP driver that only requires a shell and awk.

Custom arguments can be passed to the test runner with
env variables as follow:

  env LOG_DRIVER_FLAGS='--comments --ignore-exit' \
      TESTS='foo.test baz.test' make -e check

This tap driver also creates a log file for each test that
can then be used by another system to build a test report.

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoDrop installcheck target
Michael Jeanson [Thu, 12 May 2016 16:07:56 +0000 (12:07 -0400)] 
Drop installcheck target

The installcheck target is supposed to be used to run tests on the
installed files, however our current implementation runs the exact same
tests in the build directory as the check target, which makes it useless.

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoFix: distcheck requires that we clean version.h
Mathieu Desnoyers [Thu, 12 May 2016 20:08:47 +0000 (16:08 -0400)] 
Fix: distcheck requires that we clean version.h

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoFix: configure: forbid Python bindings if shared libraries are disabled
Mathieu Desnoyers [Thu, 12 May 2016 20:08:46 +0000 (16:08 -0400)] 
Fix: configure: forbid Python bindings if shared libraries are disabled

Fixes: #977

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoFix: tests: don't match command line arguments, match static build binary names
Mathieu Desnoyers [Thu, 12 May 2016 20:08:45 +0000 (16:08 -0400)] 
Fix: tests: don't match command line arguments, match static build binary names

Don't match command line arguments for lttng-sessiond, lttng-relayd,
lttng-consumerd, lttng-runas, lt-lttng-sessiond, lt-lttng-relayd, only
match the executables.

Otherwise, if any unrelated command on the system match those as
arguments (e.g. text editor opening a text file), it hangs the tests.

Static build don't generate a lt-lttng-sessiond as binary name. Expect
lttng-session for this case.

Static build don't generate a lt-lttng-relayd as binary name.  Expect
lttng-relayd for this case.

Fixes: #977

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoFix: tests: skip tests on static build
Mathieu Desnoyers [Thu, 12 May 2016 20:08:44 +0000 (16:08 -0400)] 
Fix: tests: skip tests on static build

Skip tests that depend on shared objects on static build rather than
bailing out, which will let the overall test suite succeed.

Fixes: #977

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoFix: tests: don't build dynamic lib tests if support disabled
Mathieu Desnoyers [Thu, 12 May 2016 20:08:43 +0000 (16:08 -0400)] 
Fix: tests: don't build dynamic lib tests if support disabled

Fixes: #977

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agobootstrap: Standardize on autoreconf -vi
Jérémie Galarneau [Thu, 12 May 2016 16:44:14 +0000 (12:44 -0400)] 
bootstrap: Standardize on autoreconf -vi

Don't overwrite already generated files.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoMove unix.h wrapper from sessiond-comm to common
Jérémie Galarneau [Thu, 5 May 2016 02:49:31 +0000 (22:49 -0400)] 
Move unix.h wrapper from sessiond-comm to common

Fixes #951

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoFix: update tests following renaming of UST statedump event
Antoine Busque [Wed, 20 Apr 2016 19:57:35 +0000 (15:57 -0400)] 
Fix: update tests following renaming of UST statedump event

This fixes regression tests that failed due to the renaming of
`lttng_ust_statedump:soinfo` to `lttng_ust_statedump:bin_info`.

Signed-off-by: Antoine Busque <abusque@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoTypo: catched -> caught
Michael Jeanson [Tue, 19 Apr 2016 20:34:55 +0000 (16:34 -0400)] 
Typo: catched -> caught

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoAdd comment describing ioctl number duplication
Jérémie Galarneau [Thu, 14 Apr 2016 19:35:33 +0000 (15:35 -0400)] 
Add comment describing ioctl number duplication

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoTest: kill sessiond,relayd and background children on SIGTERM/SIGINT
Jonathan Rajotte [Wed, 6 Apr 2016 20:28:44 +0000 (16:28 -0400)] 
Test: kill sessiond,relayd and background children on SIGTERM/SIGINT

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoDocs: Remove unnecessary exclamation mark
Jérémie Galarneau [Wed, 13 Apr 2016 22:07:20 +0000 (18:07 -0400)] 
Docs: Remove unnecessary exclamation mark

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoDocs: fix wording of dependency
Jérémie Galarneau [Wed, 13 Apr 2016 22:06:41 +0000 (18:06 -0400)] 
Docs: fix wording of dependency

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoDocs: fix "daemon" typo in README.md
Jérémie Galarneau [Wed, 13 Apr 2016 22:06:13 +0000 (18:06 -0400)] 
Docs: fix "daemon" typo in README.md

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoFix: Use get_domain_str on add context
Jonathan Rajotte [Fri, 18 Mar 2016 22:25:23 +0000 (18:25 -0400)] 
Fix: Use get_domain_str on add context

Fixes #1006

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoWarning fix: possible use of uninitialized variable
Jérémie Galarneau [Mon, 4 Apr 2016 16:41:05 +0000 (12:41 -0400)] 
Warning fix: possible use of uninitialized variable

GCC reports that discarded_events and lost_packets may be used
uninitialized. Assert that both pointers are not NULL to
silence the warning.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agodoc/man: add FILES section
Philippe Proulx [Fri, 25 Mar 2016 02:12:57 +0000 (22:12 -0400)] 
doc/man: add FILES section

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoTest: xsd validation of long path (length > 255)
Jonathan Rajotte [Tue, 29 Mar 2016 22:46:35 +0000 (18:46 -0400)] 
Test: xsd validation of long path (length > 255)

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoFix: xsd: urls and paths are not of type name_type but string
Jonathan Rajotte [Tue, 29 Mar 2016 22:56:23 +0000 (18:56 -0400)] 
Fix: xsd: urls and paths are not of type name_type but string

[v2] Update commit subject and fix spelling in of commit message.

name_type is upper bounded to 255 which make no sense for a path or url.

Reported-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoRefactor: embed mi in "add_output "to remove code duplication
Jonathan Rajotte [Tue, 22 Mar 2016 18:12:08 +0000 (14:12 -0400)] 
Refactor: embed mi in "add_output "to remove code duplication

Reduces the number of possible code paths and ensure a coherent return
path.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoRefactor: embed mi in "del_record" to remove code duplication
Jonathan Rajotte [Tue, 22 Mar 2016 18:12:07 +0000 (14:12 -0400)] 
Refactor: embed mi in "del_record" to remove code duplication

Reduces the number of possible code paths and ensure a coherent return
path.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoRefactor: embed mi in "record" to remove code duplication
Jonathan Rajotte [Tue, 22 Mar 2016 18:12:06 +0000 (14:12 -0400)] 
Refactor: embed mi in "record" to remove code duplication

Reduces the number of possible code paths and ensure a coherent return
path.

fixes #1002

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoRefactor: embed mi in "list_output" to remove code duplication
Jonathan Rajotte [Tue, 22 Mar 2016 18:12:05 +0000 (14:12 -0400)] 
Refactor: embed mi in "list_output" to remove code duplication

Reduces the number of possible code paths and ensure a coherent return
path.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoFix: do not return error on LTTNG_ERR_SNAPSHOT_NODATA
Jonathan Rajotte [Tue, 22 Mar 2016 18:12:04 +0000 (14:12 -0400)] 
Fix: do not return error on LTTNG_ERR_SNAPSHOT_NODATA

A warning is fine since the user has no control on
whether or not applications (or the kernel) have
produced any event between the start of the tracing
session and the recording of the snapshot.

MI wise the command is not a success since nothing was
recorded. The command line return code is CMD_SUCCESS.

refs #1002

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoFix: Set loopback adress in set_ip_addr if gethostbyname2 fails
Jérémie Galarneau [Fri, 19 Feb 2016 19:32:21 +0000 (14:32 -0500)] 
Fix: Set loopback adress in set_ip_addr if gethostbyname2 fails

Some systems may not have "localhost" defined in accordance with IETF
RFC 6761. According to this RFC, applications may recognize
"localhost" names as special and resolve to the appropriate loopback
address.

We choose to use the system name resolution API first to honor its
network configuration. If this fails, we resolve to the appropriate
loopback address. This is done to accomodate systems which may want to
start tracing before their network configured.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoFix: d_type validity is not guaranteed on all nfs versions
Jonathan Rajotte [Thu, 17 Mar 2016 18:56:02 +0000 (14:56 -0400)] 
Fix: d_type validity is not guaranteed on all nfs versions

When using lttng-crash on files mounted on a nfs mount the d_type from
the dirent struct is not necessarily set and results in a DT_UNKNOWN
d_type.

stat() provides the valid information on an nfs mount.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoFix: doc/man: lttng-add-context(1): add missing option macro
Philippe Proulx [Thu, 24 Mar 2016 18:28:38 +0000 (14:28 -0400)] 
Fix: doc/man: lttng-add-context(1): add missing option macro

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agodoc/man: common-footer.txt: add CI link
Philippe Proulx [Thu, 24 Mar 2016 18:26:02 +0000 (14:26 -0400)] 
doc/man: common-footer.txt: add CI link

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agodoc/man: common-footer.txt: add GH organization link
Philippe Proulx [Thu, 24 Mar 2016 18:23:59 +0000 (14:23 -0400)] 
doc/man: common-footer.txt: add GH organization link

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agodoc/man: lttng(1): clarify UST domain and add links to languages
Philippe Proulx [Thu, 24 Mar 2016 18:13:08 +0000 (14:13 -0400)] 
doc/man: lttng(1): clarify UST domain and add links to languages

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agodoc/man: add escwc macro and use it
Philippe Proulx [Thu, 24 Mar 2016 18:00:38 +0000 (14:00 -0400)] 
doc/man: add escwc macro and use it

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agodoc/man: lttng(1): link from COMMAND (synopsis) to COMMANDS section
Philippe Proulx [Thu, 24 Mar 2016 17:22:34 +0000 (13:22 -0400)] 
doc/man: lttng(1): link from COMMAND (synopsis) to COMMANDS section

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agodoc/man: use linkgenoptions macro
Philippe Proulx [Thu, 24 Mar 2016 17:18:09 +0000 (13:18 -0400)] 
doc/man: use linkgenoptions macro

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agodoc/man: add linkgenoptions AsciiDoc macro
Philippe Proulx [Thu, 24 Mar 2016 17:14:17 +0000 (13:14 -0400)] 
doc/man: add linkgenoptions AsciiDoc macro

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years ago.gitignore: ignore all generated files in doc/man
Philippe Proulx [Thu, 24 Mar 2016 16:52:51 +0000 (12:52 -0400)] 
.gitignore: ignore all generated files in doc/man

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agodoc/man: fix external links
Philippe Proulx [Thu, 24 Mar 2016 16:50:30 +0000 (12:50 -0400)] 
doc/man: fix external links

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agodoc/man: xsl: move manpage-base.xsl -> manpage-callouts.xsl
Philippe Proulx [Thu, 24 Mar 2016 16:39:57 +0000 (12:39 -0400)] 
doc/man: xsl: move manpage-base.xsl -> manpage-callouts.xsl

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agodoc/man: xsl: move manpage-ulinks.xsl -> manpage-links.xsl
Philippe Proulx [Thu, 24 Mar 2016 16:38:26 +0000 (12:38 -0400)] 
doc/man: xsl: move manpage-ulinks.xsl -> manpage-links.xsl

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agodoc/man: xsl: add <URL> after ulink text
Philippe Proulx [Thu, 24 Mar 2016 16:33:51 +0000 (12:33 -0400)] 
doc/man: xsl: add <URL> after ulink text

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agodoc/man: xsl: add (internal) link template
Philippe Proulx [Thu, 24 Mar 2016 16:33:10 +0000 (12:33 -0400)] 
doc/man: xsl: add (internal) link template

This makes the internal link titles appear underlined in
the man pager.

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agodoc/man: lttng-enable-channel(1): move limitations to own section
Philippe Proulx [Thu, 24 Mar 2016 16:31:38 +0000 (12:31 -0400)] 
doc/man: lttng-enable-channel(1): move limitations to own section

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoFix: doc/man: lttng-relayd(1) -> lttng-relayd(8)
Philippe Proulx [Thu, 24 Mar 2016 09:34:10 +0000 (05:34 -0400)] 
Fix: doc/man: lttng-relayd(1) -> lttng-relayd(8)

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agodoc/man: add nloption and genoption AsciiDoc macros
Philippe Proulx [Thu, 24 Mar 2016 07:42:10 +0000 (03:42 -0400)] 
doc/man: add nloption and genoption AsciiDoc macros

See the updated README.md for details.

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agodoc/man: add [role="term"] to terminal callouts
Philippe Proulx [Thu, 24 Mar 2016 06:52:29 +0000 (02:52 -0400)] 
doc/man: add [role="term"] to terminal callouts

This does not change the troff output, but it annotates the given
callouts in the DocBook output so that a DocBook->HTML stylesheet
can use this role to visually differentiate terminal callouts from
generic callouts.

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoClean-up shm directory tree after freeing the channel
Jonathan Rajotte [Thu, 17 Mar 2016 20:18:14 +0000 (16:18 -0400)] 
Clean-up shm directory tree after freeing the channel

On NFS, an unlinked file that is still mmaped or unclosed is kept
around by creating a .nfsXXXX file since it may still be in use. [1]

This prevents the effective cleanup of the shm tree directory because
it happens before the userspace consumer shm handles table
cleanup. [2]

Moving the tree removal to lttng_ustconsumer_free_channel ensures that
the cleanup is done when the files are completely closed/unmapped.

[1] http://nfs.sourceforge.net/ Look for "silly rename"
[2] See channel_free subcall to shm_object_table_destroy

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoFix: Build man pages if --enable-build-man-pages is used
Jérémie Galarneau [Sat, 19 Mar 2016 16:38:50 +0000 (12:38 -0400)] 
Fix: Build man pages if --enable-build-man-pages is used

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoFix: convey enum value signedness into metadata
Mathieu Desnoyers [Sun, 20 Mar 2016 18:54:18 +0000 (14:54 -0400)] 
Fix: convey enum value signedness into metadata

Currently, passing an enum range of:

    ctf_enum_range("blah", 0, UINT_MAX)

in LTTng-UST will print a range of 0 ... -1 in the generated CTF
metadata, which does not reflect signedness of the values.

Also, struct ustctl_enum_entry is missing a LTTNG_PACKED attribute,
which is against our protocol rules.

This change needs to be pushed in locked-step into lttng-tools and
lttng-ust, since it breaks the protocol between the two when UST
uses the new enumeration type (introduced in 2.8.0-rc1).

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agodoc/man: add notes about shell escaping
Philippe Proulx [Sat, 19 Mar 2016 01:35:07 +0000 (21:35 -0400)] 
doc/man: add notes about shell escaping

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
5 years agoFix: doc/man/Makefile.am for OOT builds
Philippe Proulx [Sat, 19 Mar 2016 01:28:21 +0000 (21:28 -0400)] 
Fix: doc/man/Makefile.am for OOT builds

Signed-off-by: Philippe Proulx <eeppeliteloop@gmail.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
This page took 0.065439 seconds and 4 git commands to generate.