lttng-tools.git
9 years agoChange easter egg MSG to DBG
David Goulet [Fri, 16 Dec 2011 17:26:03 +0000 (12:26 -0500)] 
Change easter egg MSG to DBG

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
9 years agoAdd debug statement
David Goulet [Fri, 16 Dec 2011 17:23:52 +0000 (12:23 -0500)] 
Add debug statement

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
9 years agoSupport creds passing between lttng and sessiond
David Goulet [Fri, 16 Dec 2011 17:15:28 +0000 (12:15 -0500)] 
Support creds passing between lttng and sessiond

From now on, the lttng command line sends it's credential at each
command along with the regular communication data.

The tracing output directory is set to those credentials (uid/gid) if
the session daemon is running as a regular user (even if the user is in
the tracing group). So *no* tracing group is ever set if the session
daemon is not running as a non-root user.

If the sessiond is running as root, the tracing group is set (if exist)
and the uid of the calling user is used.

This fixes the triple enable-channel/event needed to trace UST
applications with a non-root session daemon. This was reported by
Yannick Brosseau <yannick.brosseau@polymtl.ca>.

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
9 years agoAdd support for passing credentials over Unix sock
David Goulet [Fri, 16 Dec 2011 17:12:35 +0000 (12:12 -0500)] 
Add support for passing credentials over Unix sock

Add lttcomm_* functions for sending, receiving and setting socket option
to pass credentials over a Unix socket. Those functions allowed normal
data to be pass as well.

First commit of a series to enable credentials passing between the lttng
command line client and the session daemon.

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
9 years agoFix nested double usage of hashtable iterators
David Goulet [Thu, 15 Dec 2011 16:42:44 +0000 (11:42 -0500)] 
Fix nested double usage of hashtable iterators

Also cleanup iterator declaration by moving the nested iterator inside
the loop scope.

Reported-by: Yannick Brosseau <yannick.brosseau@polymtl.ca>
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
9 years agoAdd disable kernel tracing option to sessiond
David Goulet [Wed, 14 Dec 2011 21:24:42 +0000 (16:24 -0500)] 
Add disable kernel tracing option to sessiond

Use --no-kernel to completely disable kernel tracing.

Reported-by: Tan Dung Le Tran <tan.dung.le.tran@ericsson.com>
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
9 years agoUpdate version to 2.0-pre15 v2.0-pre15
David Goulet [Tue, 13 Dec 2011 21:25:39 +0000 (16:25 -0500)] 
Update version to 2.0-pre15

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
9 years agoChange liburcu dependency to 0.6.7
David Goulet [Tue, 13 Dec 2011 21:23:41 +0000 (16:23 -0500)] 
Change liburcu dependency to 0.6.7

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
9 years agoFix missing files needed for release
David Goulet [Tue, 13 Dec 2011 21:06:58 +0000 (16:06 -0500)] 
Fix missing files needed for release

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
9 years agoFix register consumer fd test on registration
David Goulet [Tue, 13 Dec 2011 20:50:16 +0000 (15:50 -0500)] 
Fix register consumer fd test on registration

When a kernel session is created, a consumer is immediately spawned. So,
using two sessions, the second one was not able to register it's own
consumer since the consumer_fd is set because there is a running kernel
consumer from the first created session. The flag consumer_fds_sent is
now used to test if the kernel consumer is already consuming buffers.

Reported-by: Julien Desfossez <julien.desfossez@polymtl.ca>
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
9 years agoFix code syntax
David Goulet [Mon, 12 Dec 2011 20:58:34 +0000 (15:58 -0500)] 
Fix code syntax

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
9 years agoUpdate quickstart with UST tracing howto
David Goulet [Mon, 12 Dec 2011 19:42:41 +0000 (14:42 -0500)] 
Update quickstart with UST tracing howto

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
9 years agoDeprecate lttng-cli.txt file
David Goulet [Mon, 12 Dec 2011 19:42:27 +0000 (14:42 -0500)] 
Deprecate lttng-cli.txt file

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
9 years agoFix missing consumer binary name in execl
David Goulet [Mon, 12 Dec 2011 17:58:11 +0000 (12:58 -0500)] 
Fix missing consumer binary name in execl

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
9 years agoFix flush buffer after wait quiescent
David Goulet [Mon, 12 Dec 2011 17:56:29 +0000 (12:56 -0500)] 
Fix flush buffer after wait quiescent

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
9 years agoFlush UST buffers after stop and wait quiescent
David Goulet [Mon, 12 Dec 2011 15:43:57 +0000 (10:43 -0500)] 
Flush UST buffers after stop and wait quiescent

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
9 years agoAdd missing release handle declaration
David Goulet [Mon, 12 Dec 2011 15:43:28 +0000 (10:43 -0500)] 
Add missing release handle declaration

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
9 years agoUST support: release session handle on destroy
Mathieu Desnoyers [Sun, 11 Dec 2011 16:12:57 +0000 (11:12 -0500)] 
UST support: release session handle on destroy

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoFix unused variables
David Goulet [Fri, 9 Dec 2011 14:24:58 +0000 (09:24 -0500)] 
Fix unused variables

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoFlush buffers on UST stop trace
David Goulet [Thu, 8 Dec 2011 22:03:23 +0000 (17:03 -0500)] 
Flush buffers on UST stop trace

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoAdd non-root support for UST tracing
David Goulet [Thu, 8 Dec 2011 20:49:02 +0000 (15:49 -0500)] 
Add non-root support for UST tracing

User-space tracing can now be used without root access meaning that the
session daemon can run with the user credentials and trace his own
applications.

This adds the LTTNG_HOME_RUNDIR which is located, under non privileged
user, in $HOME/.lttng. It contains all the control and consumers
sockets. It is cleanup when lttng-sessiond dies.

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoAdd error message when config file not found
David Goulet [Thu, 8 Dec 2011 19:19:22 +0000 (14:19 -0500)] 
Add error message when config file not found

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoFix kernel listing enable status
David Goulet [Thu, 8 Dec 2011 19:09:45 +0000 (14:09 -0500)] 
Fix kernel listing enable status

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoMinor fix return value
David Goulet [Thu, 8 Dec 2011 17:23:06 +0000 (12:23 -0500)] 
Minor fix return value

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoImprove UST channel code
David Goulet [Thu, 8 Dec 2011 16:40:08 +0000 (11:40 -0500)] 
Improve UST channel code

Better breakdown of the code when creating/enabling/disabling UST
channel.

No new features added. It's mostly a refactoring.

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoImprove UST context code
David Goulet [Thu, 8 Dec 2011 15:40:38 +0000 (10:40 -0500)] 
Improve UST context code

Better breakdown of code when adding context to an event or channel.
This also fix possible memory leak of ust context data structure.

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoMultiple fixes for enable/disable UST support
David Goulet [Wed, 7 Dec 2011 23:24:49 +0000 (18:24 -0500)] 
Multiple fixes for enable/disable UST support

Makes the enable/disable command inside the main.c uses the event.c
functions. For this, the disable tracepoint functions (single and all)
for UST are added to event.c

Also fix the goto error path in event.c for disable/enable functions
where the UST event was removed from the hashtable if the event already
exist on the tracer side.

Fix the wrong hashtable being used for events lookup in ust_app.c for
enable/disable event for UST global domain.

Adds the disable event per PID function call in ust_app.c

At this commit, the "lttng disable-event -a -u" command segfault
lttng-ust at commit 5cd29ace704432c7a421f7749ef8591e30e1894c.

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoFix wrong lttng_channel name size
David Goulet [Wed, 7 Dec 2011 21:19:54 +0000 (16:19 -0500)] 
Fix wrong lttng_channel name size

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoFix wrong sizeof on channel name copy
David Goulet [Wed, 7 Dec 2011 21:18:44 +0000 (16:18 -0500)] 
Fix wrong sizeof on channel name copy

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoFix enable event -u -a
Mathieu Desnoyers [Wed, 7 Dec 2011 02:50:26 +0000 (21:50 -0500)] 
Fix enable event -u -a

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoUpdate consumerd search paths comment
Mathieu Desnoyers [Tue, 6 Dec 2011 21:21:18 +0000 (16:21 -0500)] 
Update consumerd search paths comment

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoDocument wildcards for userspace tracer
Mathieu Desnoyers [Tue, 6 Dec 2011 21:20:20 +0000 (16:20 -0500)] 
Document wildcards for userspace tracer

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoPrefer using the native consumer over 32-bit consumer for kernel
Mathieu Desnoyers [Tue, 6 Dec 2011 21:07:51 +0000 (16:07 -0500)] 
Prefer using the native consumer over 32-bit consumer for kernel

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoChange lttng command line options for UST domain
David Goulet [Tue, 6 Dec 2011 20:27:15 +0000 (15:27 -0500)] 
Change lttng command line options for UST domain

lttng command line option --all is removed and replace by using -u alone
which indicates that the command must be applied to the UST global
domain.

$ lttng enable-event -u --all
is changed to
$ lttng enable-event -u

Also, the long option for -a, --all-events, is replaced by --all.

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoAPI change for lttng_list_domains prototype
David Goulet [Tue, 6 Dec 2011 19:54:13 +0000 (14:54 -0500)] 
API change for lttng_list_domains prototype

Now takes a session name and no lttng_handle anymore.

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoAPI change for lttng_start/stop_tracing prototype
David Goulet [Tue, 6 Dec 2011 19:50:18 +0000 (14:50 -0500)] 
API change for lttng_start/stop_tracing prototype

Now takes a session name and no lttng_handle anymore.

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoAPI change for lttng_destroy_session prototype
David Goulet [Tue, 6 Dec 2011 19:43:41 +0000 (14:43 -0500)] 
API change for lttng_destroy_session prototype

Now takes a session name and no lttng_handle anymore.

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoMerge branch 'master'
David Goulet [Tue, 6 Dec 2011 19:33:02 +0000 (14:33 -0500)] 
Merge branch 'master'

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoAdd support for UST enable all tracepoints
David Goulet [Tue, 6 Dec 2011 19:02:54 +0000 (14:02 -0500)] 
Add support for UST enable all tracepoints

Support to enable all tracepoints for UST global domain

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoupdate loglevel printout
Mathieu Desnoyers [Tue, 6 Dec 2011 16:50:28 +0000 (11:50 -0500)] 
update loglevel printout

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoCleanup lttng enable event command
David Goulet [Tue, 6 Dec 2011 15:58:27 +0000 (10:58 -0500)] 
Cleanup lttng enable event command

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agolisting and activation of loglevel by number
Mathieu Desnoyers [Tue, 6 Dec 2011 15:29:06 +0000 (10:29 -0500)] 
listing and activation of loglevel by number

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agologlevels: allow enable/disable
Mathieu Desnoyers [Tue, 6 Dec 2011 14:08:33 +0000 (09:08 -0500)] 
loglevels: allow enable/disable

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoAdd loglevel to event list
Mathieu Desnoyers [Tue, 6 Dec 2011 01:20:10 +0000 (20:20 -0500)] 
Add loglevel to event list

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoABIs now support 256 char event names
Mathieu Desnoyers [Tue, 6 Dec 2011 01:08:35 +0000 (20:08 -0500)] 
ABIs now support 256 char event names

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoUpdate symbol name len size limit to 256
Mathieu Desnoyers [Tue, 6 Dec 2011 01:02:01 +0000 (20:02 -0500)] 
Update symbol name len size limit to 256

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoUse the consumerd_bin variables for kernel consumers too
Alexandre Montplaisir [Mon, 5 Dec 2011 22:30:41 +0000 (17:30 -0500)] 
Use the consumerd_bin variables for kernel consumers too

Right now the sessiond will only look in its own directory for
the consumerd when starting a kernel trace. This patch makes it
check for consumerd32_bin and consumerd64_bin too.

Signed-off-by: Alexandre Montplaisir <alexandre.montplaisir@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoRename consumerd32/64_path options to _bin
Alexandre Montplaisir [Mon, 5 Dec 2011 22:30:06 +0000 (17:30 -0500)] 
Rename consumerd32/64_path options to _bin

The _path suffix was confusing as to whether it would include the
filename at the end or not. In fact it should (to allow greater
flexibility in moving/renaming the consumerd executable).

Rename all configure options, env vars and substition variables to
consumerd32/64_bin instead, and expect the user to pass a complete
basename + filename to those.

Signed-off-by: Alexandre Montplaisir <alexandre.montplaisir@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoFix ust app tracepoint list realloc
Mathieu Desnoyers [Mon, 5 Dec 2011 18:24:36 +0000 (13:24 -0500)] 
Fix ust app tracepoint list realloc

- memcpy data _after_ reallocation (corruption fix),
- fix off-by-one in size check (corruption fix),
- multiply size by 2 each time size increase is needed (optimisation).

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoFix bad return value on enable syscalls making it freeze
David Goulet [Mon, 5 Dec 2011 17:06:35 +0000 (12:06 -0500)] 
Fix bad return value on enable syscalls making it freeze

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoUpdate libpopt dependency to 1.13
Mathieu Desnoyers [Thu, 1 Dec 2011 16:43:09 +0000 (11:43 -0500)] 
Update libpopt dependency to 1.13

After careful review of popt cvs tree, after cross-correlation of CHANGE
file with source code POPT_ARGFLAG_OPTIONAL updates, identified that the
updates to this part of the code end at 1.13.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoDocument dependency on libpopt >= 1.8
Mathieu Desnoyers [Thu, 1 Dec 2011 16:17:25 +0000 (11:17 -0500)] 
Document dependency on libpopt >= 1.8

ref: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=285666

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoDescribe autotools/libtool/automake version dependency
Mathieu Desnoyers [Thu, 1 Dec 2011 15:41:08 +0000 (10:41 -0500)] 
Describe autotools/libtool/automake version dependency

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoRemove m4_ifdef for AC_PROG_LIBTOOL (deprecated)
Mathieu Desnoyers [Thu, 1 Dec 2011 15:18:53 +0000 (10:18 -0500)] 
Remove m4_ifdef for AC_PROG_LIBTOOL (deprecated)

This trick does not seem to work anyway.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoFix --disable-lttng-ust build after UST API update
Mathieu Desnoyers [Wed, 30 Nov 2011 23:58:45 +0000 (18:58 -0500)] 
Fix --disable-lttng-ust build after UST API update

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoUpdate following loglevel support UST API change
Mathieu Desnoyers [Wed, 30 Nov 2011 23:32:15 +0000 (18:32 -0500)] 
Update following loglevel support UST API change

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoAdd missing rcu read lock
David Goulet [Wed, 30 Nov 2011 22:26:00 +0000 (17:26 -0500)] 
Add missing rcu read lock

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoCleanup ust app delete functions
David Goulet [Wed, 30 Nov 2011 22:14:11 +0000 (17:14 -0500)] 
Cleanup ust app delete functions

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoFix missing declaration without UST support
David Goulet [Wed, 30 Nov 2011 22:13:39 +0000 (17:13 -0500)] 
Fix missing declaration without UST support

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoMerge branch 'master' of git://git.lttng.org/lttng-tools
David Goulet [Wed, 30 Nov 2011 21:35:37 +0000 (16:35 -0500)] 
Merge branch 'master' of git://git.lttng.org/lttng-tools

10 years agoSupport for UST context
David Goulet [Wed, 30 Nov 2011 21:34:47 +0000 (16:34 -0500)] 
Support for UST context

Adds the support to add context on channel and/or events for UST global
domain.

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoRemove function:entry option to discourage its use
Mathieu Desnoyers [Wed, 30 Nov 2011 20:39:11 +0000 (15:39 -0500)] 
Remove function:entry option to discourage its use

Removed from kernel tracer.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoAdd context exist error code
David Goulet [Wed, 30 Nov 2011 19:35:19 +0000 (14:35 -0500)] 
Add context exist error code

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoFix realloc invalid next size
David Goulet [Wed, 30 Nov 2011 16:30:14 +0000 (11:30 -0500)] 
Fix realloc invalid next size

Reported-by: Tan Dung Le Tran <tan.dung.le.tran@ericsson.com>
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoSupport older versions of autotools
Mathieu Desnoyers [Wed, 30 Nov 2011 14:05:47 +0000 (09:05 -0500)] 
Support older versions of autotools

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoAdd a --with-consumerd-only configure option
Alexandre Montplaisir [Wed, 30 Nov 2011 00:17:43 +0000 (19:17 -0500)] 
Add a --with-consumerd-only configure option

This will only build the consumer daemon (and its liblttng-consumer
library), and skip the lttng and lttng-sessiond binaries.

This will be useful when a user wants to support both 32-bit and
64-bit applications on the same system. Only one sessiond is
needed, but we need a consumer for each architecture.

Signed-off-by: Alexandre Montplaisir <alexandre.montplaisir@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoCleanup configure.ac
Alexandre Montplaisir [Wed, 30 Nov 2011 00:16:31 +0000 (19:16 -0500)] 
Cleanup configure.ac

Use AS_IF() and AS_ECHO() macros whenever possible.
Print the configuration options at the end of the script
(so they don't get lost in the sea of the configure output).

Signed-off-by: Alexandre Montplaisir <alexandre.montplaisir@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoFix ust_app_clean_list segfault
Mathieu Desnoyers [Tue, 29 Nov 2011 23:54:25 +0000 (18:54 -0500)] 
Fix ust_app_clean_list segfault

The 4th parameter of cds_lfht_for_each_entry is the member of the
structure, not a pointer to a variable. Therefore, node was never
populated.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoCheck hashtable_del return values
Mathieu Desnoyers [Tue, 29 Nov 2011 23:43:17 +0000 (18:43 -0500)] 
Check hashtable_del return values

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoMerge branch 'master' of git://git.lttng.org/lttng-tools
David Goulet [Tue, 29 Nov 2011 23:18:13 +0000 (18:18 -0500)] 
Merge branch 'master' of git://git.lttng.org/lttng-tools

10 years agoFix disable/enable channel when app registers
David Goulet [Tue, 29 Nov 2011 23:15:25 +0000 (18:15 -0500)] 
Fix disable/enable channel when app registers

Upon registration, a disable channel in the global domain was created
but not disabled afterwords being enabled by default on the tracer. This
commit fix that for channels and events as well.

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoRename ust app function for better semantic
David Goulet [Tue, 29 Nov 2011 22:42:21 +0000 (17:42 -0500)] 
Rename ust app function for better semantic

Replace _all by _glb meaning global. This family of functions (ending
with _glb) apply an action on *all* registered applications.

Also fix the setting the enabled flag on disable-event.

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoAdd UST event not found error code
David Goulet [Tue, 29 Nov 2011 22:38:44 +0000 (17:38 -0500)] 
Add UST event not found error code

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoFix enable-event for UST events
David Goulet [Tue, 29 Nov 2011 22:09:27 +0000 (17:09 -0500)] 
Fix enable-event for UST events

When enabling an existing event, a new event creation occured which was
simply the bad thing to do. This patch fix that by adding the
enable_ust_event call for the case.

Also fixes a segfault where any UST object could be release with the
data pointer being set to NULL.

This patch introduce also assert() in the UST app code for
create/enable/disable event. The purpose is to catch, in dev, the bad
code execution flow and fix it.

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoAdd UST event exist error code
David Goulet [Tue, 29 Nov 2011 22:00:11 +0000 (17:00 -0500)] 
Add UST event exist error code

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoInit point to NULL in case of free() for 64-bit too
Mathieu Desnoyers [Tue, 29 Nov 2011 21:03:16 +0000 (16:03 -0500)] 
Init point to NULL in case of free() for 64-bit too

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoApply autoupdate to configure.ac
Mathieu Desnoyers [Tue, 29 Nov 2011 20:28:19 +0000 (15:28 -0500)] 
Apply autoupdate to configure.ac

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoFix --enable-lttng-ust configure option
Alexandre Montplaisir [Tue, 29 Nov 2011 20:20:43 +0000 (15:20 -0500)] 
Fix --enable-lttng-ust configure option

Specifying either --enable-lttng-ust or --disable-lttng-ust
would DISABLE the option. This fix makes it listen to either we
want to enable or disable it (it remains enabled by default).

Signed-off-by: Alexandre Montplaisir <alexandre.montplaisir@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoAC_HELP_STRING is deprecated, use AS_HELP_STRING
Mathieu Desnoyers [Tue, 29 Nov 2011 20:17:49 +0000 (15:17 -0500)] 
AC_HELP_STRING is deprecated, use AS_HELP_STRING

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoRemove unused UST channel code
David Goulet [Tue, 29 Nov 2011 19:38:35 +0000 (14:38 -0500)] 
Remove unused UST channel code

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoRename kernel-ctl.c/.h to kernel.c/.h
David Goulet [Tue, 29 Nov 2011 19:31:28 +0000 (14:31 -0500)] 
Rename kernel-ctl.c/.h to kernel.c/.h

Just to follow the function call standard and since kernelctl exist out
of the code tree.

Also remove ust-ctl.c which is not used and not compiled at all.

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoInit pointer to NULL in case of free()
David Goulet [Tue, 29 Nov 2011 18:55:08 +0000 (13:55 -0500)] 
Init pointer to NULL in case of free()

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoMerge branch 'master' of git://git.lttng.org/lttng-tools
David Goulet [Tue, 29 Nov 2011 18:44:47 +0000 (13:44 -0500)] 
Merge branch 'master' of git://git.lttng.org/lttng-tools

10 years agoAdd missing declaration when UST is disabled
David Goulet [Tue, 29 Nov 2011 18:44:10 +0000 (13:44 -0500)] 
Add missing declaration when UST is disabled

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoRename consumerd32_bindir -> consumerd32_path
Alexandre Montplaisir [Tue, 29 Nov 2011 13:12:01 +0000 (08:12 -0500)] 
Rename consumerd32_bindir -> consumerd32_path

Fixes build error on 32-bit arches.

Signed-off-by: Alexandre Montplaisir <alexandre.montplaisir@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoSetup LD_LIBRARY_PATH if 32/64 bit consumer libdir is set
Mathieu Desnoyers [Tue, 29 Nov 2011 00:20:09 +0000 (19:20 -0500)] 
Setup LD_LIBRARY_PATH if 32/64 bit consumer libdir is set

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoImplement consumer bin/lib 32/64-bit configure/env/arg support
Mathieu Desnoyers [Mon, 28 Nov 2011 23:52:04 +0000 (18:52 -0500)] 
Implement consumer bin/lib 32/64-bit configure/env/arg support

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoIntroduce --with-consumer32-bindir and --with-consumer64-bindir
Mathieu Desnoyers [Mon, 28 Nov 2011 23:22:54 +0000 (18:22 -0500)] 
Introduce --with-consumer32-bindir and --with-consumer64-bindir

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoChange ust app clean list loop
David Goulet [Mon, 28 Nov 2011 19:57:12 +0000 (14:57 -0500)] 
Change ust app clean list loop

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agolttng disable_events: ensure end of string is set to \0
Mathieu Desnoyers [Fri, 25 Nov 2011 11:12:14 +0000 (12:12 +0100)] 
lttng disable_events: ensure end of string is set to \0

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agostreamline channel_new_default_attr switch statement with coding style
Mathieu Desnoyers [Fri, 25 Nov 2011 10:53:40 +0000 (11:53 +0100)] 
streamline channel_new_default_attr switch statement with coding style

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agochannel_new_default_attr: fix usage memory leaks
Mathieu Desnoyers [Fri, 25 Nov 2011 10:51:52 +0000 (11:51 +0100)] 
channel_new_default_attr: fix usage memory leaks

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
10 years agoAdd single disable UST event support
David Goulet [Thu, 24 Nov 2011 20:53:46 +0000 (15:53 -0500)] 
Add single disable UST event support

Support for disabling a single UST event for a specific channel.

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoNULL ptr validation across liblttngctl
David Goulet [Thu, 24 Nov 2011 20:38:48 +0000 (15:38 -0500)] 
NULL ptr validation across liblttngctl

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoDo not permit NULL pointer on enable API calls
David Goulet [Thu, 24 Nov 2011 20:22:31 +0000 (15:22 -0500)] 
Do not permit NULL pointer on enable API calls

Enable channel lttng API call now forbids the use of NULL pointer for
channel attributes.

Use lttng_channel_set_default_attr() before.

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoAdd disable all UST event(s) command
David Goulet [Thu, 24 Nov 2011 20:11:52 +0000 (15:11 -0500)] 
Add disable all UST event(s) command

Note that you can only disable all events for a specific channel (like
the kernel). So, using the UST global domain (-u -a), only the event(s)
in the specified channel will be disabled for all registered
applications.

Bottom line, it disables all events in a channel.

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoAdd new API call lttng_channel_set_default_attr
David Goulet [Wed, 23 Nov 2011 22:25:01 +0000 (17:25 -0500)] 
Add new API call lttng_channel_set_default_attr

This call takes a lttng domain and an allocated channel attributes
pointer and set the default attributes of the channel according to the
domain type.

This commit also fix a listing problem where the wrong output type of
the channel was returned for UST.

The enable-channel command is also changed to used that new API call.

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoFix events listing using the channel name
David Goulet [Wed, 23 Nov 2011 21:28:17 +0000 (16:28 -0500)] 
Fix events listing using the channel name

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoFix missing channel name copy for auto channel creation
David Goulet [Wed, 23 Nov 2011 21:22:02 +0000 (16:22 -0500)] 
Fix missing channel name copy for auto channel creation

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
10 years agoAdd disable-channel support for UST
David Goulet [Wed, 23 Nov 2011 20:49:56 +0000 (15:49 -0500)] 
Add disable-channel support for UST

The enable channel command (for UST) was not working for already created
channel so this commit fix it by adding an enable function call when the
UST channel already exist onto the session.

Signed-off-by: David Goulet <david.goulet@polymtl.ca>
This page took 0.061461 seconds and 4 git commands to generate.