Fix: wrong check on session started on stop command
authorDavid Goulet <dgoulet@efficios.com>
Wed, 19 Dec 2012 19:13:24 +0000 (14:13 -0500)
committerDavid Goulet <dgoulet@efficios.com>
Wed, 19 Dec 2012 19:13:29 +0000 (14:13 -0500)
This is problematic for application that lives longer than the tracing
session so the make check unfortunately did not catch this problem since
we either kill the applications before the stop or wait for them to die.

I will quote a colleague of mine on IRC after discovering this:
14:14 < cbab> moar tests!

:)

Signed-off-by: David Goulet <dgoulet@efficios.com>
src/bin/lttng-sessiond/ust-app.c

index dd8d103fd1d9c2773fe9f032d1389cedd09f32d3..0b32f351814bf723710105550b6bd5b1f569501a 100644 (file)
@@ -2402,7 +2402,7 @@ int ust_app_stop_trace(struct ltt_ust_session *usess, struct ust_app *app)
         * from either the application manager thread or the command thread. Simply
         * indicate that this is a stop error.
         */
-       if (ua_sess->started == 1) {
+       if (!ua_sess->started) {
                goto error_rcu_unlock;
        }
 
This page took 0.036704 seconds and 4 git commands to generate.