Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Change-Id: I2dc131c79b9014fe4d20a58ec83d69bd6986bb85
modernize-use-using,
performance-*,
-performance-no-int-to-ptr,
modernize-use-using,
performance-*,
-performance-no-int-to-ptr,
- readability-redundant-member-init'
+ readability-redundant-member-init.
+ readability-simplify-boolean-expr'
FormatStyle: 'file'
CheckOptions:
- key: bugprone-assert-side-effect.AssertMacros
FormatStyle: 'file'
CheckOptions:
- key: bugprone-assert-side-effect.AssertMacros
if (seq == -1ULL) {
return false;
}
if (seq == -1ULL) {
return false;
}
- if (seq >= tfa->tf[file_index].seq_tail && seq <= tfa->tf[file_index].seq_head) {
- return true;
- } else {
- return false;
- }
+ return seq >= tfa->tf[file_index].seq_tail && seq <= tfa->tf[file_index].seq_head;
return std::equal(a.cbegin(), a.cend(), b.cbegin(),
[](const choice& choice_a, const choice& choice_b) {
return choice_a.first == choice_b.first &&
return std::equal(a.cbegin(), a.cend(), b.cbegin(),
[](const choice& choice_a, const choice& choice_b) {
return choice_a.first == choice_b.first &&
}
wait_until_thread_is_ready(notifiers);
lttng_thread_put(thread);
}
wait_until_thread_is_ready(notifiers);
lttng_thread_put(thread);
- if (notifiers->initialization_result) {
- return false;
- }
- return true;
+ return notifiers->initialization_result == 0;
error:
cleanup_consumer_management_thread(notifiers);
error_alloc:
error:
cleanup_consumer_management_thread(notifiers);
error_alloc:
/* Safe to call as we have transitioned to the requested uid/gid. */
ret_value->u.ret = lttng_directory_handle_create_subdirectory_recursive(handle, path, mode);
ret_value->_errno = errno;
/* Safe to call as we have transitioned to the requested uid/gid. */
ret_value->u.ret = lttng_directory_handle_create_subdirectory_recursive(handle, path, mode);
ret_value->_errno = errno;
- ret_value->_error = (ret_value->u.ret) ? true : false;
+ ret_value->_error = (ret_value->u.ret) != 0;
lttng_directory_handle_put(handle);
end:
return ret_value->u.ret;
lttng_directory_handle_put(handle);
end:
return ret_value->u.ret;
/* Safe to call as we have transitioned to the requested uid/gid. */
ret_value->u.ret = lttng_directory_handle_create_subdirectory(handle, path, mode);
ret_value->_errno = errno;
/* Safe to call as we have transitioned to the requested uid/gid. */
ret_value->u.ret = lttng_directory_handle_create_subdirectory(handle, path, mode);
ret_value->_errno = errno;
- ret_value->_error = (ret_value->u.ret) ? true : false;
+ ret_value->_error = (ret_value->u.ret) != 0;
lttng_directory_handle_put(handle);
end:
return ret_value->u.ret;
lttng_directory_handle_put(handle);
end:
return ret_value->u.ret;
ret_value->u.ret = lttng_directory_handle_unlink_file(handle, data->u.unlink.path);
ret_value->_errno = errno;
ret_value->u.ret = lttng_directory_handle_unlink_file(handle, data->u.unlink.path);
ret_value->_errno = errno;
- ret_value->_error = (ret_value->u.ret) ? true : false;
+ ret_value->_error = (ret_value->u.ret) != 0;
lttng_directory_handle_put(handle);
end:
return ret_value->u.ret;
lttng_directory_handle_put(handle);
end:
return ret_value->u.ret;
ret_value->u.ret = lttng_directory_handle_remove_subdirectory(handle, data->u.rmdir.path);
ret_value->_errno = errno;
ret_value->u.ret = lttng_directory_handle_remove_subdirectory(handle, data->u.rmdir.path);
ret_value->_errno = errno;
- ret_value->_error = (ret_value->u.ret) ? true : false;
+ ret_value->_error = (ret_value->u.ret) != 0;
lttng_directory_handle_put(handle);
end:
return ret_value->u.ret;
lttng_directory_handle_put(handle);
end:
return ret_value->u.ret;
ret_value->u.ret = lttng_directory_handle_remove_subdirectory_recursive(
handle, data->u.rmdir.path, data->u.rmdir.flags);
ret_value->_errno = errno;
ret_value->u.ret = lttng_directory_handle_remove_subdirectory_recursive(
handle, data->u.rmdir.path, data->u.rmdir.flags);
ret_value->_errno = errno;
- ret_value->_error = (ret_value->u.ret) ? true : false;
+ ret_value->_error = (ret_value->u.ret) != 0;
lttng_directory_handle_put(handle);
end:
return ret_value->u.ret;
lttng_directory_handle_put(handle);
end:
return ret_value->u.ret;
lttng_directory_handle_put(old_handle);
lttng_directory_handle_put(new_handle);
ret_value->_errno = errno;
lttng_directory_handle_put(old_handle);
lttng_directory_handle_put(new_handle);
ret_value->_errno = errno;
- ret_value->_error = (ret_value->u.ret) ? true : false;
+ ret_value->_error = (ret_value->u.ret) != 0;
return ret_value->u.ret;
}
return ret_value->u.ret;
}
if (!result && tests[i].is_valid) {
fprintf(stderr, "Failed to get result\n");
goto loop;
if (!result && tests[i].is_valid) {
fprintf(stderr, "Failed to get result\n");
goto loop;
- } else if (!result && tests[i].is_valid == false) {
+ } else if (!result && !tests[i].is_valid) {
pass("Returned null as expected");
goto loop;
}
pass("Returned null as expected");
goto loop;
}