Fix: Memory leaks on error paths when exporting consumerd libdir in env

Signed-off-by: Christian Babeux <christian.babeux@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>

diff --git a/src/bin/lttng-sessiond/main.c b/src/bin/lttng-sessiond/main.c
index f57a5c911d11095a7efbdc1a5ad8a87d400f3d9f..d88bafeb6e9255febe166687c8962c42ff6e69ab 100644 (file)
--- a/src/bin/lttng-sessiond/main.c
+++ b/src/bin/lttng-sessiond/main.c
@@ -1885,6 +1885,7 @@ static pid_t spawn_consumerd(struct consumer_data *consumer_data)
                                ret = putenv(tmpnew);
                                if (ret) {
                                        ret = -errno;
                                ret = putenv(tmpnew);
                                if (ret) {
                                        ret = -errno;

+                                       free(tmpnew);

                                        goto error;
                                }
                        }
                                        goto error;
                                }
                        }


@@ -1929,6 +1930,7 @@ static pid_t spawn_consumerd(struct consumer_data *consumer_data)
                                ret = putenv(tmpnew);
                                if (ret) {
                                        ret = -errno;
                                ret = putenv(tmpnew);
                                if (ret) {
                                        ret = -errno;

+                                       free(tmpnew);

                                        goto error;
                                }
                        }
                                        goto error;
                                }
                        }