Clean-up: clang-tidy autofixes to eventfd and file-descriptor

eventfd must be marked explicit to prevent erroneous implicit
conversions.

A destructor is provided since other special member functions are
defined (see cppcoreguidelines-special-member-functions).

file_descriptor's constructor is replaced by a trivial constructor.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Change-Id: I1623a2f8db0d613201a534293f5e1476b779283c

diff --git a/src/common/eventfd.hpp b/src/common/eventfd.hpp
index 39d398ce03849ae470cd08d2cc6670036b548179..5bcd2d349f6dc06341d025b1d69f34f83b2e0558 100644 (file)
--- a/src/common/eventfd.hpp
+++ b/src/common/eventfd.hpp
@@ -17,11 +17,12 @@ namespace lttng {
 class eventfd : public file_descriptor {
 public:
        /* Throws a posix_error exception on failure to create the underlying resource. */
-       eventfd(bool use_semaphore_semantics = true, std::uint64_t initial_value = 0);
+       explicit eventfd(bool use_semaphore_semantics = true, std::uint64_t initial_value = 0);
        eventfd(const eventfd&) = delete;
        eventfd& operator=(const eventfd&) = delete;
        eventfd(eventfd&&) = delete;
        void operator=(eventfd&&) = delete;
+       ~eventfd() = default;
 
        /* Throws on error. */
        void increment(std::uint64_t value = 1);

diff --git a/src/common/file-descriptor.cpp b/src/common/file-descriptor.cpp
index 4042c61cefc476b907ebb861a5d3b66800a0def9..6f6a6be24dc6fdbfbcffab9f63633cb6e7314d1e 100644 (file)
--- a/src/common/file-descriptor.cpp
+++ b/src/common/file-descriptor.cpp
@@ -23,10 +23,6 @@ bool is_valid_fd(int fd)
 }
 } // anonymous namespace
 
-lttng::file_descriptor::file_descriptor() noexcept
-{
-}
-
 lttng::file_descriptor::file_descriptor(int raw_fd) noexcept : _raw_fd{ raw_fd }
 {
        LTTNG_ASSERT(is_valid_fd(_raw_fd));

diff --git a/src/common/file-descriptor.hpp b/src/common/file-descriptor.hpp
index c0076eb9cb5e04af5d66c0bffce63b6985ab144a..b467e2e382d5bc293380ed880b779a2b02bc591b 100644 (file)
--- a/src/common/file-descriptor.hpp
+++ b/src/common/file-descriptor.hpp
@@ -15,7 +15,7 @@ namespace lttng {
 /* RAII wrapper around a UNIX file descriptor. */
 class file_descriptor {
 public:
-       file_descriptor() noexcept;
+       file_descriptor() noexcept = default;
 
        explicit file_descriptor(int raw_fd) noexcept;
        file_descriptor(const file_descriptor&) = delete;