Clarify incorrect channel output type logging message

Recording a snapshot is only supported for channels that have
an "mmap" output type. Add the channel's name and an explanation
of the error in the consumer daemon's log as the channel's
'output' integral representation is of limited use.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>

diff --git a/src/common/kernel-consumer/kernel-consumer.c b/src/common/kernel-consumer/kernel-consumer.c
index 246ae6b59dedc6182b1628aef8065a686959bbbc..4e93bee915463bccba902d646f72f2fdd1f20f87 100644 (file)
--- a/src/common/kernel-consumer/kernel-consumer.c
+++ b/src/common/kernel-consumer/kernel-consumer.c
@@ -144,7 +144,8 @@ static int lttng_kconsumer_snapshot_channel(
 
        /* Splice is not supported yet for channel snapshot. */
        if (channel->output != CONSUMER_CHANNEL_MMAP) {
 
        /* Splice is not supported yet for channel snapshot. */
        if (channel->output != CONSUMER_CHANNEL_MMAP) {

-               ERR("Unsupported output %d", channel->output);
+               ERR("Unsupported output type for channel \"%s\": mmap output is required to record a snapshot",
+                               channel->name);

                ret = -1;
                goto end;
        }
                ret = -1;
                goto end;
        }