Fix: event: erroneous bound check on perf counter name size
authorJérémie Galarneau <jeremie.galarneau@efficios.com>
Wed, 16 Mar 2022 15:56:21 +0000 (11:56 -0400)
committerJérémie Galarneau <jeremie.galarneau@efficios.com>
Thu, 17 Mar 2022 17:34:39 +0000 (13:34 -0400)
The wrong size if used when initializing a perf counter name from a
payload. The destination size must be used to prevent out of bound
writes.

Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Change-Id: I8ea41d30815bd2c02bb2ad8b01e8cecd2d6549a8

src/common/event.c

index c52c4ee5a0ce37804006aa1b784681b9af949a6d..531c73b9f1b09a312929d118ff9b4b57a269ed4b 100644 (file)
@@ -1093,7 +1093,8 @@ static ssize_t lttng_event_context_perf_counter_populate_from_buffer(
                        goto end;
                }
 
-               ret = lttng_strncpy(event_ctx->u.perf_counter.name, name, name_len);
+               ret = lttng_strncpy(event_ctx->u.perf_counter.name, name,
+                               sizeof(event_ctx->u.perf_counter.name));
                if (ret) {
                        consumed = -1;
                        goto end;
This page took 0.02589 seconds and 4 git commands to generate.