Fix: argpar: Error out when passing an argument to long option that takes no argument

[lttng-tools.git] / src / common / argpar / argpar.c

diff --git a/src/common/argpar/argpar.c b/src/common/argpar/argpar.c
index bf19808c54715657330d926268a3f04dd17a350c..68bb5a426d5fb471747e7cd81495a959a12ec7c2 100644 (file)
--- a/src/common/argpar/argpar.c
+++ b/src/common/argpar/argpar.c
@@ -477,6 +477,15 @@ enum parse_orig_arg_opt_ret parse_long_opt(const char * const long_opt_arg,
                        opt_arg = next_orig_arg;
                        used_next_orig_arg = true;
                }
+       } else if (eq_pos) {
+               /*
+                * Unexpected `--opt=arg` style for a long option which
+                * doesn't accept an argument.
+                */
+               argpar_string_append_printf(error,
+                       "Unexpected argument for option `--%s`",
+                       long_opt_name);
+               goto error;
        }
 
        /* Create and append option argument */