Add safety assert() in session daemon

[lttng-tools.git] / src / bin / lttng-sessiond / context.c

diff --git a/src/bin/lttng-sessiond/context.c b/src/bin/lttng-sessiond/context.c
index 74afd4e0cad5ff87d307de751672ad1ae86bad61..c1b7410da00020dc541313326892d850e6810b28 100644 (file)
--- a/src/bin/lttng-sessiond/context.c
+++ b/src/bin/lttng-sessiond/context.c
@@ -39,6 +39,9 @@ static int add_kctx_all_channels(struct ltt_kernel_session *ksession,
        int ret;
        struct ltt_kernel_channel *kchan;
 
+       assert(ksession);
+       assert(kctx);
+
        DBG("Adding kernel context to all channels");
 
        /* Go over all channels */
@@ -64,6 +67,9 @@ static int add_kctx_to_channel(struct lttng_kernel_context *kctx,
 {
        int ret;
 
+       assert(kchan);
+       assert(kctx);
+
        DBG("Add kernel context to channel '%s'", kchan->channel->name);
 
        ret = kernel_add_channel_context(kchan, kctx);
@@ -89,6 +95,10 @@ static int add_uctx_to_channel(struct ltt_ust_session *usess, int domain,
        struct lttng_ht_iter iter;
        struct lttng_ht_node_ulong *uctx_node;
 
+       assert(usess);
+       assert(uchan);
+       assert(ctx);
+
        /* Create ltt UST context */
        uctx = trace_ust_create_context(ctx);
        if (uctx == NULL) {
@@ -108,16 +118,20 @@ static int add_uctx_to_channel(struct ltt_ust_session *usess, int domain,
                goto error;
        }
 
+       rcu_read_lock();
+
        /* Lookup context before adding it */
        lttng_ht_lookup(uchan->ctx, (void *)((unsigned long)uctx->ctx.ctx), &iter);
        uctx_node = lttng_ht_iter_get_node_ulong(&iter);
        if (uctx_node != NULL) {
                ret = -EEXIST;
+               rcu_read_unlock();
                goto error;
        }
 
        /* Add ltt UST context node to ltt UST channel */
        lttng_ht_add_unique_ulong(uchan->ctx, &uctx->node);
+       rcu_read_unlock();
 
        DBG("Context UST %d added to channel %s", uctx->ctx.ctx, uchan->name);
 
@@ -138,6 +152,10 @@ int context_kernel_add(struct ltt_kernel_session *ksession,
        struct ltt_kernel_channel *kchan;
        struct lttng_kernel_context kctx;
 
+       assert(ksession);
+       assert(ctx);
+       assert(channel_name);
+
        /* Setup kernel context structure */
        switch (ctx->ctx) {
        case LTTNG_EVENT_CONTEXT_PID:
@@ -219,6 +237,10 @@ int context_ust_add(struct ltt_ust_session *usess, int domain,
        struct lttng_ht *chan_ht;
        struct ltt_ust_channel *uchan = NULL;
 
+       assert(usess);
+       assert(ctx);
+       assert(channel_name);
+
        /*
         * Define which channel's hashtable to use from the domain or quit if
         * unknown domain.
@@ -250,6 +272,7 @@ int context_ust_add(struct ltt_ust_session *usess, int domain,
                /* Add ctx to channel */
                ret = add_uctx_to_channel(usess, domain, uchan, ctx);
        } else {
+               rcu_read_lock();
                /* Add ctx all events, all channels */
                cds_lfht_for_each_entry(chan_ht->ht, &iter.iter, uchan, node.node) {
                        ret = add_uctx_to_channel(usess, domain, uchan, ctx);
@@ -258,6 +281,7 @@ int context_ust_add(struct ltt_ust_session *usess, int domain,
                                continue;
                        }
                }
+               rcu_read_unlock();
        }
 
        switch (ret) {