/* Static functions */
static int set_signal_handler(void);
static int set_socket_perms(void);
-static void sighandler(int);
+static void sighandler(int sig);
static void cleanup(void);
static void copy_common_data(struct lttcomm_lttng_msg *llm, struct lttcomm_session_msg *lsm);
static int check_existing_daemon(void);
-static int notify_apps(const char*);
-static int connect_app(pid_t);
+static int notify_apps(const char* name);
+static int connect_app(pid_t pid);
static int init_daemon_socket(void);
static int process_client_msg(int sock, struct lttcomm_session_msg*);
static int send_unix_sock(int sock, void *buf, size_t len);
+static int setup_data_buffer(char **buf, size_t size, struct lttcomm_lttng_msg *llm);
/* Command function */
-static void get_list_apps(void *buf);
-static void get_list_sessions(void *buf);
+static void get_list_apps(pid_t *pids);
+static void get_list_sessions(struct lttng_session *lt);
-static void *thread_manage_clients(void *);
-static void *thread_manage_apps(void *);
+static void *thread_manage_clients(void *data);
+static void *thread_manage_apps(void *data);
-static int create_session(const char*, uuid_t *);
-static void destroy_session(uuid_t);
+static int create_session(char *name, uuid_t *session_id);
+static void destroy_session(uuid_t session_id);
-static struct ltt_session *find_session(uuid_t);
+static struct ltt_session *find_session(uuid_t session_id);
/* Variables */
const char *progname;
/*
* create_session
*
- * Create a brand new session,
+ * Create a brand new session and add it to the
+ * global session list.
*/
-static int create_session(const char *name, uuid_t *session_id)
+static int create_session(char *name, uuid_t *session_id)
{
struct ltt_session *new_session;
* List traceable user-space application and fill an
* array of pids.
*/
-static void get_list_apps(void *buf)
+static void get_list_apps(pid_t *pids)
{
- size_t index = 0;
- struct ltt_traceable_app *iter = NULL;
- pid_t *pids = (pid_t *) buf;
+ int i = 0;
+ struct ltt_traceable_app *iter;
/* TODO: Mutex needed to access this list */
cds_list_for_each_entry(iter, <t_traceable_app_list.head, list) {
- pids[index] = iter->pid;
- index++;
+ pids[i] = iter->pid;
+ i++;
}
}
*
* List sessions and fill the data buffer.
*/
-static void get_list_sessions(void *buf)
+static void get_list_sessions(struct lttng_session *lt)
{
int i = 0;
- struct ltt_session *iter = NULL;
+ struct ltt_session *iter;
struct lttng_session lsess;
- struct lttng_session *data = (struct lttng_session *) buf;
/* Iterate over session list and append data after
* the control struct in the buffer.
*/
cds_list_for_each_entry(iter, <t_session_list.head, list) {
+ /* Copy name and uuid */
uuid_unparse(iter->uuid, lsess.uuid);
strncpy(lsess.name, iter->name, sizeof(lsess.name));
- memcpy(data + (i * sizeof(struct lttng_session)), &lsess, sizeof(lsess));
+ lsess.name[sizeof(lsess.name) - 1] = '\0';
+ memcpy(<[i], &lsess, sizeof(lsess));
i++;
/* Reset struct for next pass */
memset(&lsess, 0, sizeof(lsess));
{
llm->cmd_type = lsm->cmd_type;
llm->pid = lsm->pid;
- if (!uuid_is_null(lsm->session_id)) {
- uuid_copy(llm->session_id, lsm->session_id);
+
+ /* Manage uuid */
+ if (lsm->session_id != NULL) {
+ strncpy(llm->session_id, lsm->session_id, UUID_STR_LEN);
}
- strncpy(llm->trace_name, lsm->trace_name, sizeof(llm->trace_name));
+
+ strncpy(llm->trace_name, lsm->trace_name, strlen(llm->trace_name));
}
/*
*
* Return total size of the buffer pointed by buf.
*/
-static int setup_data_buffer(void **buf, size_t s_data, struct lttcomm_lttng_msg *llm)
+static int setup_data_buffer(char **buf, size_t s_data, struct lttcomm_lttng_msg *llm)
{
int ret = 0;
- void *new_buf;
size_t buf_size;
buf_size = sizeof(struct lttcomm_lttng_msg) + s_data;
- new_buf = malloc(buf_size);
- if (new_buf == NULL) {
+ *buf = malloc(buf_size);
+ if (*buf == NULL) {
perror("malloc");
ret = -1;
goto error;
* it to the newly allocated buffer.
*/
llm->size_payload = s_data;
- memcpy(new_buf, llm, sizeof(struct lttcomm_lttng_msg));
-
- *buf = new_buf;
+ memcpy(*buf, llm, sizeof(struct lttcomm_lttng_msg));
return buf_size;
static int process_client_msg(int sock, struct lttcomm_session_msg *lsm)
{
int ret;
- struct lttcomm_lttng_msg llm;
- void *send_buf = NULL;
int buf_size;
+ char *send_buf = NULL;
+ struct lttcomm_lttng_msg llm;
/* Copy common data to identify the response
* on the lttng client side.
/* Process by command type */
switch (lsm->cmd_type) {
+ case LTTNG_CREATE_SESSION:
+ {
+ uuid_t uuid;
+ ret = create_session(lsm->session_name, &uuid);
+ if (ret < 0) {
+ goto error;
+ }
+
+ uuid_unparse(uuid, llm.session_id);
+
+ buf_size = setup_data_buffer(&send_buf, 0, &llm);
+ if (buf_size < 0) {
+ ret = LTTCOMM_FATAL;
+ goto error;
+ }
+
+ goto send;
+ break;
+ }
case UST_LIST_APPS:
{
/* Stop right now if no apps */
goto error;
}
- get_list_apps(send_buf + sizeof(struct lttcomm_lttng_msg));
-
- ret = send_unix_sock(sock, send_buf, buf_size);
- if (ret < 0) {
- goto send_error;
- }
+ get_list_apps((pid_t *)(send_buf + sizeof(struct lttcomm_lttng_msg)));
+ goto send;
break;
}
case LTTNG_LIST_SESSIONS:
goto error;
}
- get_list_sessions(send_buf + sizeof(struct lttcomm_lttng_msg));
-
- ret = send_unix_sock(sock, send_buf, buf_size);
- if (ret < 0) {
- goto send_error;
- }
+ get_list_sessions((struct lttng_session *)(send_buf + sizeof(struct lttcomm_lttng_msg)));
+ goto send;
break;
}
default:
}
}
+send:
+ ret = send_unix_sock(sock, send_buf, buf_size);
+
if (send_buf != NULL) {
free(send_buf);
}
- return 0;
-
-send_error:
return ret;
error:
projects / lttng-tools.git / blobdiff