Fix: relayd: session id is ignored by 2.11+ create session command
[lttng-tools.git] / src / bin / lttng-relayd / cmd-2-11.c
1 /*
2 * Copyright (C) 2018 Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
3 *
4 * SPDX-License-Identifier: GPL-2.0-only
5 *
6 */
7
8 #define _LGPL_SOURCE
9 #include <assert.h>
10 #include <inttypes.h>
11
12 #include <common/common.h>
13 #include <common/sessiond-comm/relayd.h>
14
15 #include <common/compat/endian.h>
16 #include <common/compat/string.h>
17 #include <lttng/constant.h>
18
19 #include "cmd-2-11.h"
20 #include "utils.h"
21
22 int cmd_create_session_2_11(const struct lttng_buffer_view *payload,
23 char *session_name, char *hostname, char *base_path,
24 uint32_t *live_timer, bool *snapshot,
25 uint64_t *id_sessiond, lttng_uuid sessiond_uuid,
26 bool *has_current_chunk, uint64_t *current_chunk_id,
27 time_t *creation_time,
28 bool *session_name_contains_creation_time)
29 {
30 int ret;
31 struct lttcomm_relayd_create_session_2_11 header;
32 size_t header_len, received_names_size, offset;
33 struct lttng_buffer_view session_name_view;
34 struct lttng_buffer_view hostname_view;
35 struct lttng_buffer_view base_path_view;
36
37 header_len = sizeof(header);
38
39 if (payload->size < header_len) {
40 ERR("Unexpected payload size in \"cmd_create_session_2_11\": expected >= %zu bytes, got %zu bytes",
41 header_len, payload->size);
42 ret = -1;
43 goto error;
44 }
45 memcpy(&header, payload->data, header_len);
46
47 header.session_name_len = be32toh(header.session_name_len);
48 header.hostname_len = be32toh(header.hostname_len);
49 header.base_path_len = be32toh(header.base_path_len);
50 header.live_timer = be32toh(header.live_timer);
51 header.current_chunk_id.value = be64toh(header.current_chunk_id.value);
52 header.current_chunk_id.is_set = !!header.current_chunk_id.is_set;
53 header.creation_time = be64toh(header.creation_time);
54 header.session_id = be64toh(header.session_id);
55
56 lttng_uuid_copy(sessiond_uuid, header.sessiond_uuid);
57
58 received_names_size = header.session_name_len + header.hostname_len +
59 header.base_path_len;
60 if (payload->size < header_len + received_names_size) {
61 ERR("Unexpected payload size in \"cmd_create_session_2_11\": expected >= %zu bytes, got %zu bytes",
62 header_len + received_names_size, payload->size);
63 ret = -1;
64 goto error;
65 }
66
67 /* Validate length against defined constant. */
68 if (header.session_name_len > LTTNG_NAME_MAX) {
69 ret = -ENAMETOOLONG;
70 ERR("Length of session name (%" PRIu32 " bytes) received in create_session command exceeds maximum length (%d bytes)", header.session_name_len, LTTNG_NAME_MAX);
71 goto error;
72 } else if (header.session_name_len == 0) {
73 ret = -EINVAL;
74 ERR("Illegal session name length of 0 received");
75 goto error;
76 }
77 if (header.hostname_len > LTTNG_HOST_NAME_MAX) {
78 ret = -ENAMETOOLONG;
79 ERR("Length of hostname (%" PRIu32 " bytes) received in create_session command exceeds maximum length (%d bytes)", header.hostname_len, LTTNG_HOST_NAME_MAX);
80 goto error;
81 }
82 if (header.base_path_len > LTTNG_PATH_MAX) {
83 ret = -ENAMETOOLONG;
84 ERR("Length of base_path (%" PRIu32 " bytes) received in create_session command exceeds maximum length (%d bytes)", header.base_path_len, PATH_MAX);
85 goto error;
86 }
87
88 offset = header_len;
89 session_name_view = lttng_buffer_view_from_view(payload, offset,
90 header.session_name_len);
91 offset += header.session_name_len;
92 hostname_view = lttng_buffer_view_from_view(payload,
93 offset, header.hostname_len);
94 offset += header.hostname_len;
95 base_path_view = lttng_buffer_view_from_view(payload,
96 offset, header.base_path_len);
97
98 /* Validate that names are NULL terminated. */
99 if (session_name_view.data[session_name_view.size - 1] != '\0') {
100 ERR("cmd_create_session_2_11 session_name is invalid (not NULL terminated)");
101 ret = -1;
102 goto error;
103 }
104
105 if (hostname_view.data[hostname_view.size - 1] != '\0') {
106 ERR("cmd_create_session_2_11 hostname is invalid (not NULL terminated)");
107 ret = -1;
108 goto error;
109 }
110
111 if (base_path_view.size != 0 &&
112 base_path_view.data[base_path_view.size - 1] != '\0') {
113 ERR("cmd_create_session_2_11 base_path is invalid (not NULL terminated)");
114 ret = -1;
115 goto error;
116 }
117
118 /*
119 * Length and null-termination check are already performed.
120 * LTTNG_NAME_MAX, LTTNG_HOST_NAME_MAX, and LTTNG_PATH_MAX max sizes are expected.
121 */
122 strcpy(session_name, session_name_view.data);
123 strcpy(hostname, hostname_view.data);
124 strcpy(base_path, base_path_view.size ? base_path_view.data : "");
125
126 *live_timer = header.live_timer;
127 *snapshot = !!header.snapshot;
128 *current_chunk_id = header.current_chunk_id.value;
129 *has_current_chunk = header.current_chunk_id.is_set;
130 *creation_time = (time_t) header.creation_time;
131 *session_name_contains_creation_time =
132 header.session_name_contains_creation_time;
133 *id_sessiond = header.session_id;
134
135 ret = 0;
136
137 error:
138 return ret;
139 }
140
141 /*
142 * cmd_recv_stream_2_11 allocates path_name and channel_name.
143 */
144 int cmd_recv_stream_2_11(const struct lttng_buffer_view *payload,
145 char **ret_path_name, char **ret_channel_name,
146 uint64_t *tracefile_size, uint64_t *tracefile_count,
147 uint64_t *trace_archive_id)
148 {
149 int ret;
150 struct lttcomm_relayd_add_stream_2_11 header;
151 size_t header_len, received_names_size;
152 struct lttng_buffer_view channel_name_view;
153 struct lttng_buffer_view pathname_view;
154 char *path_name = NULL;
155 char *channel_name = NULL;
156
157 header_len = sizeof(header);
158
159 if (payload->size < header_len) {
160 ERR("Unexpected payload size in \"cmd_recv_stream_2_11\": expected >= %zu bytes, got %zu bytes",
161 header_len, payload->size);
162 ret = -1;
163 goto error;
164 }
165 memcpy(&header, payload->data, header_len);
166
167 header.channel_name_len = be32toh(header.channel_name_len);
168 header.pathname_len = be32toh(header.pathname_len);
169 header.tracefile_size = be64toh(header.tracefile_size);
170 header.tracefile_count = be64toh(header.tracefile_count);
171 header.trace_chunk_id = be64toh(header.trace_chunk_id);
172
173 received_names_size = header.channel_name_len + header.pathname_len;
174 if (payload->size < header_len + received_names_size) {
175 ERR("Unexpected payload size in \"cmd_recv_stream_2_11\": expected >= %zu bytes, got %zu bytes",
176 header_len + received_names_size, payload->size);
177 ret = -1;
178 goto error;
179 }
180
181 /* Validate length against defined constant. */
182 if (header.channel_name_len > DEFAULT_STREAM_NAME_LEN) {
183 ret = -ENAMETOOLONG;
184 ERR("Channel name too long");
185 goto error;
186 }
187 if (header.pathname_len > LTTNG_NAME_MAX) {
188 ret = -ENAMETOOLONG;
189 ERR("Pathname too long");
190 goto error;
191 }
192
193 /* Validate that names are (NULL terminated. */
194 channel_name_view = lttng_buffer_view_from_view(payload, header_len,
195 header.channel_name_len);
196 pathname_view = lttng_buffer_view_from_view(payload,
197 header_len + header.channel_name_len, header.pathname_len);
198
199 if (channel_name_view.data[channel_name_view.size - 1] != '\0') {
200 ERR("cmd_recv_stream_2_11 channel_name is invalid (not NULL terminated)");
201 ret = -1;
202 goto error;
203 }
204
205 if (pathname_view.data[pathname_view.size - 1] != '\0') {
206 ERR("cmd_recv_stream_2_11 patname is invalid (not NULL terminated)");
207 ret = -1;
208 goto error;
209 }
210
211 channel_name = strdup(channel_name_view.data);
212 if (!channel_name) {
213 ret = -errno;
214 PERROR("Channel name allocation");
215 goto error;
216 }
217
218 path_name = strdup(pathname_view.data);
219 if (!path_name) {
220 PERROR("Path name allocation");
221 ret = -ENOMEM;
222 goto error;
223 }
224
225 *tracefile_size = header.tracefile_size;
226 *tracefile_count = header.tracefile_count;
227 *trace_archive_id = header.trace_chunk_id;
228 *ret_path_name = path_name;
229 *ret_channel_name = channel_name;
230 /* Move ownership to caller */
231 path_name = NULL;
232 channel_name = NULL;
233 ret = 0;
234 error:
235 free(channel_name);
236 free(path_name);
237 return ret;
238 }
This page took 0.045935 seconds and 4 git commands to generate.