ABI with support for compat 32/64 bits
authorJulien Desfossez <jdesfossez@efficios.com>
Mon, 1 Oct 2012 15:59:19 +0000 (11:59 -0400)
committerMathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mon, 1 Oct 2012 16:00:07 +0000 (12:00 -0400)
The current ABI does not work for compat 32/64 bits.
This patch moves the current ABI as old-abi and provides a new ABI in
which all the structures exchanged between user and kernel-space are
packed. Also this new ABI moves the "int overwrite" member of the
struct lttng_kernel_channel to remove the alignment added by the
compiler.

A patch for lttng-tools has been developed in parallel to this one to
support the new ABI. These 2 patches have been tested in all
possible configurations (applied or not) on 64-bit and 32-bit kernels
(with CONFIG_COMPAT) and a user-space in 32 and 64-bit.

Here are the results of the tests :
k 64 compat     | u 32 compat     | OK
k 64 compat     | u 64 compat     | OK
k 64 compat     | u 32 non-compat | KO
k 64 compat     | u 64 non-compat | OK

k 64 non-compat | u 64 compat     | OK
k 64 non-compat | u 32 compat     | KO
k 64 non-compat | u 64 non-compat | OK
k 64 non-compat | u 32 non-compat | KO

k 32 compat     | u compat        | OK
k 32 compat     | u non-compat    | OK

k 32 non-compat | u compat        | OK
k 32 non-compat | u non-compat    | OK

The results are as expected :
- on 32-bit user-space and kernel, every configuration works.
- on 64-bit user-space and kernel, every configuration works.
- with 32-bit user-space on a 64-bit kernel the only configuration
  where it works is when the compat patch is applied everywhere.

Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
lttng-abi-old.h [new file with mode: 0644]
lttng-abi.c
lttng-abi.h
lttng-events.c
lttng-events.h

diff --git a/lttng-abi-old.h b/lttng-abi-old.h
new file mode 100644 (file)
index 0000000..3e6b328
--- /dev/null
@@ -0,0 +1,141 @@
+#ifndef _LTTNG_ABI_OLD_H
+#define _LTTNG_ABI_OLD_H
+
+/*
+ * lttng-abi-old.h
+ *
+ * LTTng old ABI header (without support for compat 32/64 bits)
+ *
+ * Copyright (C) 2010-2012 Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; only
+ * version 2.1 of the License.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+ */
+
+#include <linux/fs.h>
+#include "lttng-abi.h"
+
+/*
+ * LTTng DebugFS ABI structures.
+ */
+#define LTTNG_KERNEL_OLD_CHANNEL_PADDING       LTTNG_KERNEL_SYM_NAME_LEN + 32
+struct lttng_kernel_old_channel {
+       int overwrite;                          /* 1: overwrite, 0: discard */
+       uint64_t subbuf_size;                   /* in bytes */
+       uint64_t num_subbuf;
+       unsigned int switch_timer_interval;     /* usecs */
+       unsigned int read_timer_interval;       /* usecs */
+       enum lttng_kernel_output output;        /* splice, mmap */
+       char padding[LTTNG_KERNEL_OLD_CHANNEL_PADDING];
+};
+
+struct lttng_kernel_old_kretprobe {
+       uint64_t addr;
+
+       uint64_t offset;
+       char symbol_name[LTTNG_KERNEL_SYM_NAME_LEN];
+};
+
+/*
+ * Either addr is used, or symbol_name and offset.
+ */
+struct lttng_kernel_old_kprobe {
+       uint64_t addr;
+
+       uint64_t offset;
+       char symbol_name[LTTNG_KERNEL_SYM_NAME_LEN];
+};
+
+struct lttng_kernel_old_function_tracer {
+       char symbol_name[LTTNG_KERNEL_SYM_NAME_LEN];
+};
+
+/*
+ * For syscall tracing, name = '\0' means "enable all".
+ */
+#define LTTNG_KERNEL_OLD_EVENT_PADDING1        16
+#define LTTNG_KERNEL_OLD_EVENT_PADDING2        LTTNG_KERNEL_SYM_NAME_LEN + 32
+struct lttng_kernel_old_event {
+       char name[LTTNG_KERNEL_SYM_NAME_LEN];   /* event name */
+       enum lttng_kernel_instrumentation instrumentation;
+       char padding[LTTNG_KERNEL_OLD_EVENT_PADDING1];
+
+       /* Per instrumentation type configuration */
+       union {
+               struct lttng_kernel_old_kretprobe kretprobe;
+               struct lttng_kernel_old_kprobe kprobe;
+               struct lttng_kernel_old_function_tracer ftrace;
+               char padding[LTTNG_KERNEL_OLD_EVENT_PADDING2];
+       } u;
+};
+
+struct lttng_kernel_old_tracer_version {
+       uint32_t major;
+       uint32_t minor;
+       uint32_t patchlevel;
+};
+
+struct lttng_kernel_old_calibrate {
+       enum lttng_kernel_calibrate_type type;  /* type (input) */
+};
+
+struct lttng_kernel_old_perf_counter_ctx {
+       uint32_t type;
+       uint64_t config;
+       char name[LTTNG_KERNEL_SYM_NAME_LEN];
+};
+
+#define LTTNG_KERNEL_OLD_CONTEXT_PADDING1      16
+#define LTTNG_KERNEL_OLD_CONTEXT_PADDING2      LTTNG_KERNEL_SYM_NAME_LEN + 32
+struct lttng_kernel_old_context {
+       enum lttng_kernel_context_type ctx;
+       char padding[LTTNG_KERNEL_OLD_CONTEXT_PADDING1];
+
+       union {
+               struct lttng_kernel_old_perf_counter_ctx perf_counter;
+               char padding[LTTNG_KERNEL_OLD_CONTEXT_PADDING2];
+       } u;
+};
+
+/* LTTng file descriptor ioctl */
+#define LTTNG_KERNEL_OLD_SESSION               _IO(0xF6, 0x40)
+#define LTTNG_KERNEL_OLD_TRACER_VERSION                \
+       _IOR(0xF6, 0x41, struct lttng_kernel_old_tracer_version)
+#define LTTNG_KERNEL_OLD_TRACEPOINT_LIST       _IO(0xF6, 0x42)
+#define LTTNG_KERNEL_OLD_WAIT_QUIESCENT                _IO(0xF6, 0x43)
+#define LTTNG_KERNEL_OLD_CALIBRATE             \
+       _IOWR(0xF6, 0x44, struct lttng_kernel_old_calibrate)
+
+/* Session FD ioctl */
+#define LTTNG_KERNEL_OLD_METADATA              \
+       _IOW(0xF6, 0x50, struct lttng_kernel_old_channel)
+#define LTTNG_KERNEL_OLD_CHANNEL               \
+       _IOW(0xF6, 0x51, struct lttng_kernel_old_channel)
+#define LTTNG_KERNEL_OLD_SESSION_START         _IO(0xF6, 0x52)
+#define LTTNG_KERNEL_OLD_SESSION_STOP          _IO(0xF6, 0x53)
+
+/* Channel FD ioctl */
+#define LTTNG_KERNEL_OLD_STREAM                        _IO(0xF6, 0x60)
+#define LTTNG_KERNEL_OLD_EVENT                 \
+       _IOW(0xF6, 0x61, struct lttng_kernel_old_event)
+
+/* Event and Channel FD ioctl */
+#define LTTNG_KERNEL_OLD_CONTEXT               \
+       _IOW(0xF6, 0x70, struct lttng_kernel_old_context)
+
+/* Event, Channel and Session ioctl */
+#define LTTNG_KERNEL_OLD_ENABLE                        _IO(0xF6, 0x80)
+#define LTTNG_KERNEL_OLD_DISABLE               _IO(0xF6, 0x81)
+
+#endif /* _LTTNG_ABI_OLD_H */
index eadf0a881e9abb6f364fc57ab44f5fde8d695528..25a350aed19c378be0909dac6235df444b014ce3 100644 (file)
@@ -47,6 +47,7 @@
 #include "wrapper/ringbuffer/vfs.h"
 #include "wrapper/poll.h"
 #include "lttng-abi.h"
+#include "lttng-abi-old.h"
 #include "lttng-events.h"
 #include "lttng-tracer.h"
 
@@ -143,34 +144,23 @@ fd_error:
 }
 
 static
-long lttng_abi_tracer_version(struct file *file, 
-       struct lttng_kernel_tracer_version __user *uversion_param)
+void lttng_abi_tracer_version(struct lttng_kernel_tracer_version *v)
 {
-       struct lttng_kernel_tracer_version v;
-
-       v.major = LTTNG_MODULES_MAJOR_VERSION;
-       v.minor = LTTNG_MODULES_MINOR_VERSION;
-       v.patchlevel = LTTNG_MODULES_PATCHLEVEL_VERSION;
-
-       if (copy_to_user(uversion_param, &v, sizeof(v)))
-               return -EFAULT;
-       return 0;
+       v->major = LTTNG_MODULES_MAJOR_VERSION;
+       v->minor = LTTNG_MODULES_MINOR_VERSION;
+       v->patchlevel = LTTNG_MODULES_PATCHLEVEL_VERSION;
 }
 
 static
 long lttng_abi_add_context(struct file *file,
-       struct lttng_kernel_context __user *ucontext_param,
+       struct lttng_kernel_context *context_param,
        struct lttng_ctx **ctx, struct lttng_session *session)
 {
-       struct lttng_kernel_context context_param;
 
        if (session->been_active)
                return -EPERM;
 
-       if (copy_from_user(&context_param, ucontext_param, sizeof(context_param)))
-               return -EFAULT;
-
-       switch (context_param.ctx) {
+       switch (context_param->ctx) {
        case LTTNG_KERNEL_CONTEXT_PID:
                return lttng_add_pid_to_ctx(ctx);
        case LTTNG_KERNEL_CONTEXT_PRIO:
@@ -188,10 +178,10 @@ long lttng_abi_add_context(struct file *file,
        case LTTNG_KERNEL_CONTEXT_VPPID:
                return lttng_add_vppid_to_ctx(ctx);
        case LTTNG_KERNEL_CONTEXT_PERF_COUNTER:
-               context_param.u.perf_counter.name[LTTNG_KERNEL_SYM_NAME_LEN - 1] = '\0';
-               return lttng_add_perf_counter_to_ctx(context_param.u.perf_counter.type,
-                               context_param.u.perf_counter.config,
-                               context_param.u.perf_counter.name,
+               context_param->u.perf_counter.name[LTTNG_KERNEL_SYM_NAME_LEN - 1] = '\0';
+               return lttng_add_perf_counter_to_ctx(context_param->u.perf_counter.type,
+                               context_param->u.perf_counter.config,
+                               context_param->u.perf_counter.name,
                                ctx);
        case LTTNG_KERNEL_CONTEXT_PROCNAME:
                return lttng_add_procname_to_ctx(ctx);
@@ -225,16 +215,60 @@ static
 long lttng_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
 {
        switch (cmd) {
+       case LTTNG_KERNEL_OLD_SESSION:
        case LTTNG_KERNEL_SESSION:
                return lttng_abi_create_session();
+       case LTTNG_KERNEL_OLD_TRACER_VERSION:
+       {
+               struct lttng_kernel_tracer_version v;
+               struct lttng_kernel_old_tracer_version oldv;
+               struct lttng_kernel_old_tracer_version *uversion =
+                       (struct lttng_kernel_old_tracer_version __user *) arg;
+
+               lttng_abi_tracer_version(&v);
+               oldv.major = v.major;
+               oldv.minor = v.minor;
+               oldv.patchlevel = v.patchlevel;
+
+               if (copy_to_user(uversion, &oldv, sizeof(oldv)))
+                       return -EFAULT;
+               return 0;
+       }
        case LTTNG_KERNEL_TRACER_VERSION:
-               return lttng_abi_tracer_version(file,
-                               (struct lttng_kernel_tracer_version __user *) arg);
+       {
+               struct lttng_kernel_tracer_version version;
+               struct lttng_kernel_tracer_version *uversion =
+                       (struct lttng_kernel_tracer_version __user *) arg;
+
+               lttng_abi_tracer_version(&version);
+               
+               if (copy_to_user(uversion, &version, sizeof(version)))
+                       return -EFAULT;
+               return 0;
+       }
+       case LTTNG_KERNEL_OLD_TRACEPOINT_LIST:
        case LTTNG_KERNEL_TRACEPOINT_LIST:
                return lttng_abi_tracepoint_list();
+       case LTTNG_KERNEL_OLD_WAIT_QUIESCENT:
        case LTTNG_KERNEL_WAIT_QUIESCENT:
                synchronize_trace();
                return 0;
+       case LTTNG_KERNEL_OLD_CALIBRATE:
+       {
+               struct lttng_kernel_old_calibrate __user *ucalibrate =
+                       (struct lttng_kernel_old_calibrate __user *) arg;
+               struct lttng_kernel_old_calibrate old_calibrate;
+               struct lttng_kernel_calibrate calibrate;
+               int ret;
+
+               if (copy_from_user(&old_calibrate, ucalibrate, sizeof(old_calibrate)))
+                       return -EFAULT;
+               calibrate.type = old_calibrate.type;
+               ret = lttng_calibrate(&calibrate);
+               if (copy_to_user(ucalibrate, &old_calibrate, sizeof(old_calibrate)))
+                       return -EFAULT;
+               return ret;
+       }
        case LTTNG_KERNEL_CALIBRATE:
        {
                struct lttng_kernel_calibrate __user *ucalibrate =
@@ -294,7 +328,7 @@ create_error:
 
 static
 int lttng_abi_create_channel(struct file *session_file,
-                            struct lttng_kernel_channel __user *uchan_param,
+                            struct lttng_kernel_channel *chan_param,
                             enum channel_type channel_type)
 {
        struct lttng_session *session = session_file->private_data;
@@ -302,12 +336,9 @@ int lttng_abi_create_channel(struct file *session_file,
        const char *transport_name;
        struct lttng_channel *chan;
        struct file *chan_file;
-       struct lttng_kernel_channel chan_param;
        int chan_fd;
        int ret = 0;
 
-       if (copy_from_user(&chan_param, uchan_param, sizeof(chan_param)))
-               return -EFAULT;
        chan_fd = get_unused_fd();
        if (chan_fd < 0) {
                ret = chan_fd;
@@ -331,20 +362,20 @@ int lttng_abi_create_channel(struct file *session_file,
        }
        switch (channel_type) {
        case PER_CPU_CHANNEL:
-               if (chan_param.output == LTTNG_KERNEL_SPLICE) {
-                       transport_name = chan_param.overwrite ?
+               if (chan_param->output == LTTNG_KERNEL_SPLICE) {
+                       transport_name = chan_param->overwrite ?
                                "relay-overwrite" : "relay-discard";
-               } else if (chan_param.output == LTTNG_KERNEL_MMAP) {
-                       transport_name = chan_param.overwrite ?
+               } else if (chan_param->output == LTTNG_KERNEL_MMAP) {
+                       transport_name = chan_param->overwrite ?
                                "relay-overwrite-mmap" : "relay-discard-mmap";
                } else {
                        return -EINVAL;
                }
                break;
        case METADATA_CHANNEL:
-               if (chan_param.output == LTTNG_KERNEL_SPLICE)
+               if (chan_param->output == LTTNG_KERNEL_SPLICE)
                        transport_name = "relay-metadata";
-               else if (chan_param.output == LTTNG_KERNEL_MMAP)
+               else if (chan_param->output == LTTNG_KERNEL_MMAP)
                        transport_name = "relay-metadata-mmap";
                else
                        return -EINVAL;
@@ -358,10 +389,10 @@ int lttng_abi_create_channel(struct file *session_file,
         * invariant for the rest of the session.
         */
        chan = lttng_channel_create(session, transport_name, NULL,
-                                 chan_param.subbuf_size,
-                                 chan_param.num_subbuf,
-                                 chan_param.switch_timer_interval,
-                                 chan_param.read_timer_interval);
+                                 chan_param->subbuf_size,
+                                 chan_param->num_subbuf,
+                                 chan_param->switch_timer_interval,
+                                 chan_param->read_timer_interval);
        if (!chan) {
                ret = -EINVAL;
                goto chan_error;
@@ -412,20 +443,76 @@ long lttng_session_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
        struct lttng_session *session = file->private_data;
 
        switch (cmd) {
+       case LTTNG_KERNEL_OLD_CHANNEL:
+       {
+               struct lttng_kernel_channel chan_param;
+               struct lttng_kernel_old_channel old_chan_param;
+
+               if (copy_from_user(&old_chan_param,
+                               (struct lttng_kernel_old_channel __user *) arg,
+                               sizeof(struct lttng_kernel_old_channel)))
+                       return -EFAULT;
+               chan_param.overwrite = old_chan_param.overwrite;
+               chan_param.subbuf_size = old_chan_param.subbuf_size;
+               chan_param.num_subbuf = old_chan_param.num_subbuf;
+               chan_param.switch_timer_interval = old_chan_param.switch_timer_interval;
+               chan_param.read_timer_interval = old_chan_param.read_timer_interval;
+               chan_param.output = old_chan_param.output;
+
+               return lttng_abi_create_channel(file, &chan_param,
+                               PER_CPU_CHANNEL);
+       }
        case LTTNG_KERNEL_CHANNEL:
-               return lttng_abi_create_channel(file,
+       {
+               struct lttng_kernel_channel chan_param;
+
+               if (copy_from_user(&chan_param,
                                (struct lttng_kernel_channel __user *) arg,
+                               sizeof(struct lttng_kernel_channel)))
+                       return -EFAULT;
+               return lttng_abi_create_channel(file, &chan_param,
                                PER_CPU_CHANNEL);
+       }
+       case LTTNG_KERNEL_OLD_SESSION_START:
+       case LTTNG_KERNEL_OLD_ENABLE:
        case LTTNG_KERNEL_SESSION_START:
        case LTTNG_KERNEL_ENABLE:
                return lttng_session_enable(session);
+       case LTTNG_KERNEL_OLD_SESSION_STOP:
+       case LTTNG_KERNEL_OLD_DISABLE:
        case LTTNG_KERNEL_SESSION_STOP:
        case LTTNG_KERNEL_DISABLE:
                return lttng_session_disable(session);
+       case LTTNG_KERNEL_OLD_METADATA:
+       {
+               struct lttng_kernel_channel chan_param;
+               struct lttng_kernel_old_channel old_chan_param;
+
+               if (copy_from_user(&old_chan_param,
+                               (struct lttng_kernel_old_channel __user *) arg,
+                               sizeof(struct lttng_kernel_old_channel)))
+                       return -EFAULT;
+               chan_param.overwrite = old_chan_param.overwrite;
+               chan_param.subbuf_size = old_chan_param.subbuf_size;
+               chan_param.num_subbuf = old_chan_param.num_subbuf;
+               chan_param.switch_timer_interval = old_chan_param.switch_timer_interval;
+               chan_param.read_timer_interval = old_chan_param.read_timer_interval;
+               chan_param.output = old_chan_param.output;
+
+               return lttng_abi_create_channel(file, &chan_param,
+                               METADATA_CHANNEL);
+       }
        case LTTNG_KERNEL_METADATA:
-               return lttng_abi_create_channel(file,
-                               (struct lttng_kernel_channel __user *) arg,
+       {
+               struct lttng_kernel_channel chan_param;
+
+               if (copy_from_user(&chan_param,
+                                       (struct lttng_kernel_channel __user *) arg,
+                                       sizeof(struct lttng_kernel_channel)))
+                       return -EFAULT;
+               return lttng_abi_create_channel(file, &chan_param,
                                METADATA_CHANNEL);
+       }
        default:
                return -ENOIOCTLCMD;
        }
@@ -505,31 +592,28 @@ fd_error:
 
 static
 int lttng_abi_create_event(struct file *channel_file,
-                          struct lttng_kernel_event __user *uevent_param)
+                          struct lttng_kernel_event *event_param)
 {
        struct lttng_channel *channel = channel_file->private_data;
        struct lttng_event *event;
-       struct lttng_kernel_event event_param;
        int event_fd, ret;
        struct file *event_file;
 
-       if (copy_from_user(&event_param, uevent_param, sizeof(event_param)))
-               return -EFAULT;
-       event_param.name[LTTNG_KERNEL_SYM_NAME_LEN - 1] = '\0';
-       switch (event_param.instrumentation) {
+       event_param->name[LTTNG_KERNEL_SYM_NAME_LEN - 1] = '\0';
+       switch (event_param->instrumentation) {
        case LTTNG_KERNEL_KRETPROBE:
-               event_param.u.kretprobe.symbol_name[LTTNG_KERNEL_SYM_NAME_LEN - 1] = '\0';
+               event_param->u.kretprobe.symbol_name[LTTNG_KERNEL_SYM_NAME_LEN - 1] = '\0';
                break;
        case LTTNG_KERNEL_KPROBE:
-               event_param.u.kprobe.symbol_name[LTTNG_KERNEL_SYM_NAME_LEN - 1] = '\0';
+               event_param->u.kprobe.symbol_name[LTTNG_KERNEL_SYM_NAME_LEN - 1] = '\0';
                break;
        case LTTNG_KERNEL_FUNCTION:
-               event_param.u.ftrace.symbol_name[LTTNG_KERNEL_SYM_NAME_LEN - 1] = '\0';
+               event_param->u.ftrace.symbol_name[LTTNG_KERNEL_SYM_NAME_LEN - 1] = '\0';
                break;
        default:
                break;
        }
-       switch (event_param.instrumentation) {
+       switch (event_param->instrumentation) {
        default:
                event_fd = get_unused_fd();
                if (event_fd < 0) {
@@ -547,7 +631,7 @@ int lttng_abi_create_event(struct file *channel_file,
                 * We tolerate no failure path after event creation. It
                 * will stay invariant for the rest of the session.
                 */
-               event = lttng_event_create(channel, &event_param, NULL, NULL);
+               event = lttng_event_create(channel, event_param, NULL, NULL);
                if (!event) {
                        ret = -EINVAL;
                        goto event_error;
@@ -561,7 +645,7 @@ int lttng_abi_create_event(struct file *channel_file,
                /*
                 * Only all-syscall tracing supported for now.
                 */
-               if (event_param.name[0] != '\0')
+               if (event_param->name[0] != '\0')
                        return -EINVAL;
                ret = lttng_syscalls_register(channel, NULL);
                if (ret)
@@ -607,21 +691,158 @@ long lttng_channel_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
        struct lttng_channel *channel = file->private_data;
 
        switch (cmd) {
+       case LTTNG_KERNEL_OLD_STREAM:
        case LTTNG_KERNEL_STREAM:
                return lttng_abi_open_stream(file);
+       case LTTNG_KERNEL_OLD_EVENT:
+       {
+               struct lttng_kernel_event *uevent_param;
+               struct lttng_kernel_old_event *old_uevent_param;
+               int ret;
+
+               uevent_param = kmalloc(sizeof(struct lttng_kernel_event),
+                               GFP_KERNEL);
+               if (!uevent_param) {
+                       ret = -ENOMEM;
+                       goto old_event_end;
+               }
+               old_uevent_param = kmalloc(
+                               sizeof(struct lttng_kernel_old_event),
+                               GFP_KERNEL);
+               if (!old_uevent_param) {
+                       ret = -ENOMEM;
+                       goto old_event_error_free_param;
+               }
+               if (copy_from_user(old_uevent_param,
+                               (struct lttng_kernel_old_event __user *) arg,
+                               sizeof(struct lttng_kernel_old_event))) {
+                       ret = -EFAULT;
+                       goto old_event_error_free_old_param;
+               }
+
+               memcpy(uevent_param->name, old_uevent_param->name,
+                               sizeof(uevent_param->name));
+               uevent_param->instrumentation =
+                       old_uevent_param->instrumentation;
+
+               switch (old_uevent_param->instrumentation) {
+               case LTTNG_KERNEL_KPROBE:
+                       uevent_param->u.kprobe.addr =
+                               old_uevent_param->u.kprobe.addr;
+                       uevent_param->u.kprobe.offset =
+                               old_uevent_param->u.kprobe.offset;
+                       memcpy(uevent_param->u.kprobe.symbol_name,
+                               old_uevent_param->u.kprobe.symbol_name,
+                               sizeof(uevent_param->u.kprobe.symbol_name));
+                       break;
+               case LTTNG_KERNEL_KRETPROBE:
+                       uevent_param->u.kretprobe.addr =
+                               old_uevent_param->u.kretprobe.addr;
+                       uevent_param->u.kretprobe.offset =
+                               old_uevent_param->u.kretprobe.offset;
+                       memcpy(uevent_param->u.kretprobe.symbol_name,
+                               old_uevent_param->u.kretprobe.symbol_name,
+                               sizeof(uevent_param->u.kretprobe.symbol_name));
+                       break;
+               case LTTNG_KERNEL_FUNCTION:
+                       memcpy(uevent_param->u.ftrace.symbol_name,
+                                       old_uevent_param->u.ftrace.symbol_name,
+                                       sizeof(uevent_param->u.ftrace.symbol_name));
+                       break;
+               default:
+                       break;
+               }
+               ret = lttng_abi_create_event(file, uevent_param);
+
+old_event_error_free_old_param:
+               kfree(old_uevent_param);
+old_event_error_free_param:
+               kfree(uevent_param);
+old_event_end:
+               return ret;
+       }
        case LTTNG_KERNEL_EVENT:
-               return lttng_abi_create_event(file, (struct lttng_kernel_event __user *) arg);
+       {
+               struct lttng_kernel_event uevent_param;
+
+               if (copy_from_user(&uevent_param,
+                               (struct lttng_kernel_event __user *) arg,
+                               sizeof(uevent_param)))
+                       return -EFAULT;
+               return lttng_abi_create_event(file, &uevent_param);
+       }
+       case LTTNG_KERNEL_OLD_CONTEXT:
+       {
+               struct lttng_kernel_context *ucontext_param;
+               struct lttng_kernel_old_context *old_ucontext_param;
+               int ret;
+
+               ucontext_param = kmalloc(sizeof(struct lttng_kernel_context),
+                               GFP_KERNEL);
+               if (!ucontext_param) {
+                       ret = -ENOMEM;
+                       goto old_ctx_end;
+               }
+               old_ucontext_param = kmalloc(sizeof(struct lttng_kernel_old_context),
+                               GFP_KERNEL);
+               if (!old_ucontext_param) {
+                       ret = -ENOMEM;
+                       goto old_ctx_error_free_param;
+               }
+
+               if (copy_from_user(old_ucontext_param,
+                               (struct lttng_kernel_old_context __user *) arg,
+                               sizeof(struct lttng_kernel_old_context))) {
+                       ret = -EFAULT;
+                       goto old_ctx_error_free_old_param;
+               }
+               ucontext_param->ctx = old_ucontext_param->ctx;
+               memcpy(ucontext_param->padding, old_ucontext_param->padding,
+                               sizeof(ucontext_param->padding));
+               /* only type that uses the union */
+               if (old_ucontext_param->ctx == LTTNG_KERNEL_CONTEXT_PERF_COUNTER) {
+                       ucontext_param->u.perf_counter.type =
+                               old_ucontext_param->u.perf_counter.type;
+                       ucontext_param->u.perf_counter.config =
+                               old_ucontext_param->u.perf_counter.config;
+                       memcpy(ucontext_param->u.perf_counter.name,
+                               old_ucontext_param->u.perf_counter.name,
+                               sizeof(ucontext_param->u.perf_counter.name));
+               }
+
+               ret = lttng_abi_add_context(file,
+                               ucontext_param,
+                               &channel->ctx, channel->session);
+
+old_ctx_error_free_old_param:
+               kfree(old_ucontext_param);
+old_ctx_error_free_param:
+               kfree(ucontext_param);
+old_ctx_end:
+               return ret;
+       }
        case LTTNG_KERNEL_CONTEXT:
-               return lttng_abi_add_context(file,
+       {
+               struct lttng_kernel_context ucontext_param;
+
+               if (copy_from_user(&ucontext_param,
                                (struct lttng_kernel_context __user *) arg,
+                               sizeof(ucontext_param)))
+                       return -EFAULT;
+               return lttng_abi_add_context(file,
+                               &ucontext_param,
                                &channel->ctx, channel->session);
+       }
+       case LTTNG_KERNEL_OLD_ENABLE:
        case LTTNG_KERNEL_ENABLE:
                return lttng_channel_enable(channel);
+       case LTTNG_KERNEL_OLD_DISABLE:
        case LTTNG_KERNEL_DISABLE:
                return lttng_channel_disable(channel);
        default:
                return -ENOIOCTLCMD;
        }
+
 }
 
 /**
@@ -641,6 +862,7 @@ static
 long lttng_metadata_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
 {
        switch (cmd) {
+       case LTTNG_KERNEL_OLD_STREAM:
        case LTTNG_KERNEL_STREAM:
                return lttng_abi_open_stream(file);
        default:
@@ -726,12 +948,72 @@ long lttng_event_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
        struct lttng_event *event = file->private_data;
 
        switch (cmd) {
+       case LTTNG_KERNEL_OLD_CONTEXT:
+       {
+               struct lttng_kernel_context *ucontext_param;
+               struct lttng_kernel_old_context *old_ucontext_param;
+               int ret;
+
+               ucontext_param = kmalloc(sizeof(struct lttng_kernel_context),
+                               GFP_KERNEL);
+               if (!ucontext_param) {
+                       ret = -ENOMEM;
+                       goto old_ctx_end;
+               }
+               old_ucontext_param = kmalloc(sizeof(struct lttng_kernel_old_context),
+                               GFP_KERNEL);
+               if (!old_ucontext_param) {
+                       ret = -ENOMEM;
+                       goto old_ctx_error_free_param;
+               }
+
+               if (copy_from_user(old_ucontext_param,
+                                       (struct lttng_kernel_old_context __user *) arg,
+                                       sizeof(struct lttng_kernel_old_context))) {
+                       ret = -EFAULT;
+                       goto old_ctx_error_free_old_param;
+               }
+               ucontext_param->ctx = old_ucontext_param->ctx;
+               memcpy(ucontext_param->padding, old_ucontext_param->padding,
+                               sizeof(ucontext_param->padding));
+               /* only type that uses the union */
+               if (old_ucontext_param->ctx == LTTNG_KERNEL_CONTEXT_PERF_COUNTER) {
+                       ucontext_param->u.perf_counter.type =
+                               old_ucontext_param->u.perf_counter.type;
+                       ucontext_param->u.perf_counter.config =
+                               old_ucontext_param->u.perf_counter.config;
+                       memcpy(ucontext_param->u.perf_counter.name,
+                                       old_ucontext_param->u.perf_counter.name,
+                                       sizeof(ucontext_param->u.perf_counter.name));
+               }
+
+               ret = lttng_abi_add_context(file,
+                               ucontext_param,
+                               &event->ctx, event->chan->session);
+
+old_ctx_error_free_old_param:
+               kfree(old_ucontext_param);
+old_ctx_error_free_param:
+               kfree(ucontext_param);
+old_ctx_end:
+               return ret;
+       }
        case LTTNG_KERNEL_CONTEXT:
+       {
+               struct lttng_kernel_context ucontext_param;
+
+               if (copy_from_user(&ucontext_param,
+                                       (struct lttng_kernel_context __user *) arg,
+                                       sizeof(ucontext_param)))
+                       return -EFAULT;
                return lttng_abi_add_context(file,
-                               (struct lttng_kernel_context __user *) arg,
+                               &ucontext_param,
                                &event->ctx, event->chan->session);
+       }
+       case LTTNG_KERNEL_OLD_ENABLE:
        case LTTNG_KERNEL_ENABLE:
                return lttng_event_enable(event);
+       case LTTNG_KERNEL_OLD_DISABLE:
        case LTTNG_KERNEL_DISABLE:
                return lttng_event_disable(event);
        default:
index cf72b12b524bdabcaff018079e730fc8e902c6ac..8d3ecddcb442224a8809be1d3ee5c36a36647a1d 100644 (file)
@@ -49,21 +49,21 @@ enum lttng_kernel_output {
  */
 #define LTTNG_KERNEL_CHANNEL_PADDING   LTTNG_KERNEL_SYM_NAME_LEN + 32
 struct lttng_kernel_channel {
-       int overwrite;                          /* 1: overwrite, 0: discard */
        uint64_t subbuf_size;                   /* in bytes */
        uint64_t num_subbuf;
        unsigned int switch_timer_interval;     /* usecs */
        unsigned int read_timer_interval;       /* usecs */
        enum lttng_kernel_output output;        /* splice, mmap */
+       int overwrite;                          /* 1: overwrite, 0: discard */
        char padding[LTTNG_KERNEL_CHANNEL_PADDING];
-};
+}__attribute__((packed));
 
 struct lttng_kernel_kretprobe {
        uint64_t addr;
 
        uint64_t offset;
        char symbol_name[LTTNG_KERNEL_SYM_NAME_LEN];
-};
+}__attribute__((packed));
 
 /*
  * Either addr is used, or symbol_name and offset.
@@ -73,11 +73,11 @@ struct lttng_kernel_kprobe {
 
        uint64_t offset;
        char symbol_name[LTTNG_KERNEL_SYM_NAME_LEN];
-};
+}__attribute__((packed));
 
 struct lttng_kernel_function_tracer {
        char symbol_name[LTTNG_KERNEL_SYM_NAME_LEN];
-};
+}__attribute__((packed));
 
 /*
  * For syscall tracing, name = '\0' means "enable all".
@@ -96,13 +96,13 @@ struct lttng_kernel_event {
                struct lttng_kernel_function_tracer ftrace;
                char padding[LTTNG_KERNEL_EVENT_PADDING2];
        } u;
-};
+}__attribute__((packed));
 
 struct lttng_kernel_tracer_version {
        uint32_t major;
        uint32_t minor;
        uint32_t patchlevel;
-};
+}__attribute__((packed));
 
 enum lttng_kernel_calibrate_type {
        LTTNG_KERNEL_CALIBRATE_KRETPROBE,
@@ -110,7 +110,7 @@ enum lttng_kernel_calibrate_type {
 
 struct lttng_kernel_calibrate {
        enum lttng_kernel_calibrate_type type;  /* type (input) */
-};
+}__attribute__((packed));
 
 enum lttng_kernel_context_type {
        LTTNG_KERNEL_CONTEXT_PID                = 0,
@@ -130,7 +130,7 @@ struct lttng_kernel_perf_counter_ctx {
        uint32_t type;
        uint64_t config;
        char name[LTTNG_KERNEL_SYM_NAME_LEN];
-};
+}__attribute__((packed));
 
 #define LTTNG_KERNEL_CONTEXT_PADDING1  16
 #define LTTNG_KERNEL_CONTEXT_PADDING2  LTTNG_KERNEL_SYM_NAME_LEN + 32
@@ -142,36 +142,36 @@ struct lttng_kernel_context {
                struct lttng_kernel_perf_counter_ctx perf_counter;
                char padding[LTTNG_KERNEL_CONTEXT_PADDING2];
        } u;
-};
+}__attribute__((packed));
 
 /* LTTng file descriptor ioctl */
-#define LTTNG_KERNEL_SESSION                   _IO(0xF6, 0x40)
+#define LTTNG_KERNEL_SESSION                   _IO(0xF6, 0x45)
 #define LTTNG_KERNEL_TRACER_VERSION            \
-       _IOR(0xF6, 0x41, struct lttng_kernel_tracer_version)
-#define LTTNG_KERNEL_TRACEPOINT_LIST           _IO(0xF6, 0x42)
-#define LTTNG_KERNEL_WAIT_QUIESCENT            _IO(0xF6, 0x43)
+       _IOR(0xF6, 0x46, struct lttng_kernel_tracer_version)
+#define LTTNG_KERNEL_TRACEPOINT_LIST           _IO(0xF6, 0x47)
+#define LTTNG_KERNEL_WAIT_QUIESCENT            _IO(0xF6, 0x48)
 #define LTTNG_KERNEL_CALIBRATE                 \
-       _IOWR(0xF6, 0x44, struct lttng_kernel_calibrate)
+       _IOWR(0xF6, 0x49, struct lttng_kernel_calibrate)
 
 /* Session FD ioctl */
 #define LTTNG_KERNEL_METADATA                  \
-       _IOW(0xF6, 0x50, struct lttng_kernel_channel)
+       _IOW(0xF6, 0x54, struct lttng_kernel_channel)
 #define LTTNG_KERNEL_CHANNEL                   \
-       _IOW(0xF6, 0x51, struct lttng_kernel_channel)
-#define LTTNG_KERNEL_SESSION_START             _IO(0xF6, 0x52)
-#define LTTNG_KERNEL_SESSION_STOP              _IO(0xF6, 0x53)
+       _IOW(0xF6, 0x55, struct lttng_kernel_channel)
+#define LTTNG_KERNEL_SESSION_START             _IO(0xF6, 0x56)
+#define LTTNG_KERNEL_SESSION_STOP              _IO(0xF6, 0x57)
 
 /* Channel FD ioctl */
-#define LTTNG_KERNEL_STREAM                    _IO(0xF6, 0x60)
+#define LTTNG_KERNEL_STREAM                    _IO(0xF6, 0x62)
 #define LTTNG_KERNEL_EVENT                     \
-       _IOW(0xF6, 0x61, struct lttng_kernel_event)
+       _IOW(0xF6, 0x63, struct lttng_kernel_event)
 
 /* Event and Channel FD ioctl */
 #define LTTNG_KERNEL_CONTEXT                   \
-       _IOW(0xF6, 0x70, struct lttng_kernel_context)
+       _IOW(0xF6, 0x71, struct lttng_kernel_context)
 
 /* Event, Channel and Session ioctl */
-#define LTTNG_KERNEL_ENABLE                    _IO(0xF6, 0x80)
-#define LTTNG_KERNEL_DISABLE                   _IO(0xF6, 0x81)
+#define LTTNG_KERNEL_ENABLE                    _IO(0xF6, 0x82)
+#define LTTNG_KERNEL_DISABLE                   _IO(0xF6, 0x83)
 
 #endif /* _LTTNG_ABI_H */
index 97efe42d4329d59cfe7bd3a7c6184977fa8a8ea7..4f30904dc0c922d7c865369387a42c4d860a45c9 100644 (file)
@@ -33,6 +33,7 @@
 #include "wrapper/tracepoint.h"
 #include "lttng-events.h"
 #include "lttng-tracer.h"
+#include "lttng-abi-old.h"
 
 static LIST_HEAD(sessions);
 static LIST_HEAD(lttng_transport_list);
index af5aa65be8fe0edcf0b519cca3466f9113583613..09d561812d77dcc8cb843046437e16e6d11385d9 100644 (file)
@@ -28,6 +28,7 @@
 #include <linux/kprobes.h>
 #include "wrapper/uuid.h"
 #include "lttng-abi.h"
+#include "lttng-abi-old.h"
 
 #undef is_signed_type
 #define is_signed_type(type)           (((type)(-1)) < 0)
@@ -301,6 +302,10 @@ struct lttng_event *lttng_event_create(struct lttng_channel *chan,
                                   struct lttng_kernel_event *event_param,
                                   void *filter,
                                   const struct lttng_event_desc *internal_desc);
+struct lttng_event *lttng_event_compat_old_create(struct lttng_channel *chan,
+               struct lttng_kernel_old_event *old_event_param,
+               void *filter,
+               const struct lttng_event_desc *internal_desc);
 
 int lttng_channel_enable(struct lttng_channel *channel);
 int lttng_channel_disable(struct lttng_channel *channel);
@@ -312,7 +317,9 @@ void lttng_transport_unregister(struct lttng_transport *transport);
 
 void synchronize_trace(void);
 int lttng_abi_init(void);
+int lttng_abi_compat_old_init(void);
 void lttng_abi_exit(void);
+void lttng_abi_compat_old_exit(void);
 
 int lttng_probe_register(struct lttng_probe_desc *desc);
 void lttng_probe_unregister(struct lttng_probe_desc *desc);
This page took 0.038894 seconds and 4 git commands to generate.