callstack context: use delimiter when stack is incomplete

[lttng-modules.git] / lttng-context.c

diff --git a/lttng-context.c b/lttng-context.c
index 9bf4d80087bff96438d1919fbb1fb583abf401a6..bed3d1c24602fde4207c4764d1cf8d6bff168121 100644 (file)
--- a/lttng-context.c
+++ b/lttng-context.c
@@ -24,9 +24,9 @@
 #include <linux/list.h>
 #include <linux/mutex.h>
 #include <linux/slab.h>
-#include "wrapper/vmalloc.h"   /* for wrapper_vmalloc_sync_all() */
-#include "lttng-events.h"
-#include "lttng-tracer.h"
+#include <wrapper/vmalloc.h>   /* for wrapper_vmalloc_sync_all() */
+#include <lttng-events.h>
+#include <lttng-tracer.h>
 
 /*
  * The filter implementation requires that two consecutive "get" for the
@@ -56,14 +56,20 @@ EXPORT_SYMBOL_GPL(lttng_find_context);
 int lttng_get_context_index(struct lttng_ctx *ctx, const char *name)
 {
        unsigned int i;
+       const char *subname;
 
        if (!ctx)
                return -1;
+       if (strncmp(name, "$ctx.", strlen("$ctx.")) == 0) {
+               subname = name + strlen("$ctx.");
+       } else {
+               subname = name;
+       }
        for (i = 0; i < ctx->nr_fields; i++) {
                /* Skip allocated (but non-initialized) contexts */
                if (!ctx->fields[i].event_field.name)
                        continue;
-               if (!strcmp(ctx->fields[i].event_field.name, name))
+               if (!strcmp(ctx->fields[i].event_field.name, subname))
                        return i;
        }
        return -1;
@@ -89,12 +95,12 @@ struct lttng_ctx_field *lttng_append_context(struct lttng_ctx **ctx_p)
                struct lttng_ctx_field *new_fields;
 
                ctx->allocated_fields = max_t(size_t, 1, 2 * ctx->allocated_fields);
-               new_fields = kzalloc(ctx->allocated_fields * sizeof(struct lttng_ctx_field), GFP_KERNEL);
+               new_fields = lttng_kvzalloc(ctx->allocated_fields * sizeof(struct lttng_ctx_field), GFP_KERNEL);
                if (!new_fields)
                        return NULL;
                if (ctx->fields)
                        memcpy(new_fields, ctx->fields, sizeof(*ctx->fields) * ctx->nr_fields);
-               kfree(ctx->fields);
+               lttng_kvfree(ctx->fields);
                ctx->fields = new_fields;
        }
        field = &ctx->fields[ctx->nr_fields];
@@ -122,6 +128,7 @@ void lttng_context_update(struct lttng_ctx *ctx)
                        field_align = type->u.basic.integer.alignment;
                        break;
                case atype_array:
+               case atype_array_bitfield:
                {
                        struct lttng_basic_type *btype;
 
@@ -135,6 +142,12 @@ void lttng_context_update(struct lttng_ctx *ctx)
 
                        case atype_array:
                        case atype_sequence:
+                       case atype_array_bitfield:
+                       case atype_sequence_bitfield:
+                       case atype_struct:
+                       case atype_array_compound:
+                       case atype_sequence_compound:
+                       case atype_variant:
                        default:
                                WARN_ON_ONCE(1);
                                break;
@@ -142,6 +155,7 @@ void lttng_context_update(struct lttng_ctx *ctx)
                        break;
                }
                case atype_sequence:
+               case atype_sequence_bitfield:
                {
                        struct lttng_basic_type *btype;
 
@@ -154,6 +168,12 @@ void lttng_context_update(struct lttng_ctx *ctx)
                        case atype_string:
                        case atype_array:
                        case atype_sequence:
+                       case atype_array_bitfield:
+                       case atype_sequence_bitfield:
+                       case atype_struct:
+                       case atype_array_compound:
+                       case atype_sequence_compound:
+                       case atype_variant:
                        default:
                                WARN_ON_ONCE(1);
                                break;
@@ -172,6 +192,12 @@ void lttng_context_update(struct lttng_ctx *ctx)
 
                        case atype_array:
                        case atype_sequence:
+                       case atype_array_bitfield:
+                       case atype_sequence_bitfield:
+                       case atype_struct:
+                       case atype_array_compound:
+                       case atype_sequence_compound:
+                       case atype_variant:
                        default:
                                WARN_ON_ONCE(1);
                                break;
@@ -181,6 +207,12 @@ void lttng_context_update(struct lttng_ctx *ctx)
                case atype_string:
                        break;
 
+               case atype_struct:
+               case atype_array_compound:
+               case atype_sequence_compound:
+               case atype_variant:
+                       break;
+
                case atype_enum:
                default:
                        WARN_ON_ONCE(1);
@@ -216,7 +248,7 @@ void lttng_destroy_context(struct lttng_ctx *ctx)
                if (ctx->fields[i].destroy)
                        ctx->fields[i].destroy(&ctx->fields[i]);
        }
-       kfree(ctx->fields);
+       lttng_kvfree(ctx->fields);
        kfree(ctx);
 }
 
@@ -276,18 +308,14 @@ int lttng_context_init(void)
        if (ret) {
                printk(KERN_WARNING "Cannot add context lttng_add_need_reschedule_to_ctx");
        }
-#if defined(CONFIG_PREEMPT_RT_FULL) || defined(CONFIG_PREEMPT)
        ret = lttng_add_preemptible_to_ctx(&lttng_static_ctx);
-       if (ret != -ENOSYS) {
+       if (ret && ret != -ENOSYS) {
                printk(KERN_WARNING "Cannot add context lttng_add_preemptible_to_ctx");
        }
-#endif
-#ifdef CONFIG_PREEMPT_RT_FULL
        ret = lttng_add_migratable_to_ctx(&lttng_static_ctx);
-       if (ret != -ENOSYS) {
+       if (ret && ret != -ENOSYS) {
                printk(KERN_WARNING "Cannot add context lttng_add_migratable_to_ctx");
        }
-#endif
        /* TODO: perf counters for filtering */
        return 0;
 }