condition: buffer usage: validation does not check for ratio and bytes threshold
authorJonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Thu, 4 Feb 2021 20:46:27 +0000 (15:46 -0500)
committerJérémie Galarneau <jeremie.galarneau@efficios.com>
Thu, 3 Jun 2021 20:09:01 +0000 (16:09 -0400)
commit70ee6d20a4f79f223b57cf4e2496ec32f0694147
tree688f8ad2e6880550bbdbb8b5dd79a2ce7cecfc6e
parent556124d78016aaf447607b5208b50c5fe802bf27
condition: buffer usage: validation does not check for ratio and bytes threshold

Buffer usage condition do not support having both ratio and bytes
threshold set.

Using `!usage->threshold_ratio.set && !usage->threshold_bytes.set` does
not error out for `threshold_ratio.set == 1` and
`usage->threshold_bytes.set == 1`

0 0 : 1
0 1 : 0
1 0 : 0
1 1 : 0

We want to check for a xnor (`usage->threshold_ratio.set == usage->threshold_bytes.set`)

0 0 : 1
0 1 : 0
1 0 : 0
1 1 : 1

We could also do 2 error check one for not set and one validating that
both are not set.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Change-Id: I5bfcf43bcaf9687ddf9fdebe5ace4f15bda28261
src/common/conditions/buffer-usage.c
This page took 0.024587 seconds and 4 git commands to generate.