Fix: tests: add `void` parameter to functions that take no parameters
authorSimon Marchi <simon.marchi@efficios.com>
Wed, 25 Mar 2020 22:39:39 +0000 (18:39 -0400)
committerJérémie Galarneau <jeremie.galarneau@efficios.com>
Thu, 26 Mar 2020 22:01:40 +0000 (18:01 -0400)
commitb670b3048650a2568e1fd782843252bb237851cb
tree6734313b6cf45c6f95dc2c72791fc408c97e1a58
parent562f936f87b994cdd940d5142f6d3aedb2d95573
Fix: tests: add `void` parameter to functions that take no parameters

In C, empty parenthesis declare a function without a prorotype (without
specifying its parameters).  This is not the same as having a `void`
parameter, which declares a function which has no parameters.

It's safer to use the later, otherwise it makes it possible to
erroneously call the function with some arguments.

Change this `test_function` to add `void`.  It fixes diagnostics like:

  CC       userspace-probe-elf-binary.o
/home/simark/src/lttng-tools/tests/utils/testapp/userspace-probe-elf-binary/userspace-probe-elf-binary.c:12:33: error: no previous prototype for ‘test_function’ [-Werror=missing-prototypes]
   12 | void __attribute__ ((noinline)) test_function()
      |

Change-Id: Iceb7636e44d45f51889667ec76f2c04c032b5df8
Signed-off-by: Simon Marchi <simon.marchi@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
tests/regression/ust/multi-lib/multi-lib-test.c
tests/utils/testapp/userspace-probe-elf-binary/userspace-probe-elf-binary.c
This page took 0.03415 seconds and 4 git commands to generate.