Fix: truncated len in lttng_event_rule_user_tracepoint_serialize()
authorMichael Jeanson <mjeanson@efficios.com>
Thu, 23 Mar 2023 16:45:18 +0000 (12:45 -0400)
committerJérémie Galarneau <jeremie.galarneau@efficios.com>
Thu, 6 Apr 2023 18:06:35 +0000 (14:06 -0400)
commita989d3e5aea516e321ebd6e021e7c3dedf215a21
treedacdc6681dad08b7f0977218e8f9684dd4387612
parent9bd44f108e4099d4c8a68cb3c951887849fec88e
Fix: truncated len in lttng_event_rule_user_tracepoint_serialize()

Observed issue
==============

On 64-bit big-endian platforms, the serialization/deserialization tests
of tracepoint event rules fail since the length of individual exclusions
is truncated in lttng_event_rule_user_tracepoint_serialize and appear as
"0" on the receiving end.

Cause
=====

The length of the exclusion name string is stored in a variable of type
`size_t`. However, since the protocol expects it to be expressed as a
uint32_t, the value is added to the payload by copying the first 4 bytes
of the value.

On a 32-bit system this would be fine since `sizeof(size_t) == 4`. Even
worse, it would work most of the time (assuming an exclusion name string
< 4GiB) on a little-endian 64-bit system as the least significant bits
would be copied and correctly express the length of the string.

On a big-endian 64-bit platform, the most-significant 4 bytes are copied
to the payload buffer thus making the string length appear as "0".

Solution
========

A temporary variable is used to hold the "casted" value and make it safe
to copy to the payload buffer regardless of the platform's endianness.

Known drawbacks
===============

None.

Change-Id: I64c03345fff7ffea2f8fcb84692a085da31c421b
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
src/common/event-rule/user-tracepoint.c
This page took 0.025177 seconds and 4 git commands to generate.