Fix: conversion from KB to bytes overflow on arm32
authorJonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Thu, 27 Jan 2022 19:22:22 +0000 (14:22 -0500)
committerJérémie Galarneau <jeremie.galarneau@efficios.com>
Mon, 28 Feb 2022 21:46:10 +0000 (16:46 -0500)
commit13dd7782d52be2dac47be5116c00d3a2ba0ad626
tree865d020538f3aadeb8851aeeed11c45e05f41889
parent4222116f0098672bbbc0fea2b994e50007929d58
Fix: conversion from KB to bytes overflow on arm32

Observed issue
==============

On enable channel the memory available check fails on arm32 when
available memory, in bytes, is larger than 2^32.

Cause
=====

`read_proc_meminfo_field` converts the read value (in KB) to bytes and
stores it into a size_t variable.

On the system running the reproducer the value of the `value_kb` variable
is 4839692, yielding an overflow when multiplied with 1024 since
`size_t` is 32 bit long. `size_t` can be larger in certain situation
(i.e LARGEFILE) but this is irrelevant to the problem at hand.

Solution
========

Convert all the checks to use uint64_t.

Known drawbacks
=========

None.

References
==========

The multiplication overflow check scheme is borrowed from
`src/common/time.c`

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Change-Id: I067da25659ab4115e5494e48aab45a1c35f56652
src/common/utils.cpp
src/common/utils.h
src/lib/lttng-ctl/lttng-ctl.cpp
This page took 0.026051 seconds and 4 git commands to generate.