Tests: notification: regroup event generators utils in a single file

[lttng-tools.git] / tests / regression / tools / notification / notification.c

diff --git a/tests/regression/tools/notification/notification.c b/tests/regression/tools/notification/notification.c
index 706f1ca43bfac1cbbe8b3abfbad1a93f8d77636d..2fece6bbde05c17ee36431266dab5a19af4d5b95 100644 (file)
--- a/tests/regression/tools/notification/notification.c
+++ b/tests/regression/tools/notification/notification.c
@@ -43,7 +43,7 @@
 
 int nb_args = 0;
 int named_pipe_args_start = 0;
-pid_t app_pid = -1;
+pid_t app_pid = 0;
 const char *app_state_file = NULL;
 
 static
@@ -156,6 +156,8 @@ int suspend_application(void)
        /*
         * Send SIGUSR1 to application instructing it to bypass tracepoint.
         */
+       assert(app_pid > 1);
+
        ret = kill(app_pid, SIGUSR1);
        if (ret) {
                fail("SIGUSR1 failed. errno %d", errno);
@@ -186,6 +188,8 @@ int resume_application(void)
                goto error;
        }
 
+       assert(app_pid > 1);
+
        ret = kill(app_pid, SIGUSR1);
        if (ret) {
                fail("SIGUSR1 failed. errno %d", errno);
@@ -662,7 +666,7 @@ end:
        lttng_condition_destroy(condition);
 }
 
-static void test_notification_channel(const char *session_name,
+static void test_buffer_usage_notification_channel(const char *session_name,
                const char *channel_name,
                const enum lttng_domain_type domain_type,
                const char **argv)
@@ -711,13 +715,13 @@ static void test_notification_channel(const char *session_name,
        nc_status = lttng_notification_channel_subscribe(
                        notification_channel, low_condition);
        ok(nc_status == LTTNG_NOTIFICATION_CHANNEL_STATUS_OK,
-                       "Subscribe to condition");
+                       "Subscribe to low condition");
 
        /* Subscribe a valid high condition */
        nc_status = lttng_notification_channel_subscribe(
                        notification_channel, high_condition);
        ok(nc_status == LTTNG_NOTIFICATION_CHANNEL_STATUS_OK,
-                       "Subscribe to condition");
+                       "Subscribe to high condition");
 
        resume_application();
 
@@ -850,28 +854,19 @@ end:
 
 int main(int argc, const char *argv[])
 {
+       int test_scenario;
        const char *session_name = NULL;
        const char *channel_name = NULL;
        const char *domain_type_string = NULL;
        enum lttng_domain_type domain_type = LTTNG_DOMAIN_NONE;
 
-       plan_tests(NUM_TESTS);
-
-       /* Argument 6 and upward are named pipe location for consumerd control */
-       named_pipe_args_start = 6;
-
-       if (argc < 7) {
-               fail("Missing parameter for tests to run %d", argc);
+       if (argc < 3) {
+               fail("Missing test scenario and/or domain type argument(s)");
                goto error;
        }
 
-       nb_args = argc;
-
-       domain_type_string = argv[1];
-       session_name = argv[2];
-       channel_name = argv[3];
-       app_pid = (pid_t) atoi(argv[4]);
-       app_state_file = argv[5];
+       test_scenario = atoi(argv[1]);
+       domain_type_string = argv[2];
 
        if (!strcmp("LTTNG_DOMAIN_UST", domain_type_string)) {
                domain_type = LTTNG_DOMAIN_UST;
@@ -884,23 +879,70 @@ int main(int argc, const char *argv[])
                goto error;
        }
 
-       /*
-        * Test cases are responsible for resuming the app when needed and
-        * making sure it's suspended when returning.
-        */
-       suspend_application();
+       switch (test_scenario) {
+       case 1:
+       {
+               plan_tests(7);
+               /* Test cases that need gen-ust-event testapp. */
+               diag("Test basic notification error paths for domain %s",
+                               domain_type_string);
+               test_invalid_channel_subscription(domain_type);
+               break;
+       }
+       case 2:
+       {
+               /* Test cases that need a tracing session enabled. */
+               plan_tests(99);
 
-       diag("Test trigger for domain %s with buffer_usage_low condition", domain_type_string);
-       test_triggers_buffer_usage_condition(session_name, channel_name, domain_type, LTTNG_CONDITION_TYPE_BUFFER_USAGE_LOW);
-       diag("Test trigger for domain %s with buffer_usage_high condition", domain_type_string);
-       test_triggers_buffer_usage_condition(session_name, channel_name, domain_type, LTTNG_CONDITION_TYPE_BUFFER_USAGE_HIGH);
+               /*
+                * Argument 7 and upward are named pipe location for consumerd
+                * control.
+                */
+               named_pipe_args_start = 7;
 
-       /* Basic error path check. */
-       test_invalid_channel_subscription(domain_type);
-       test_subscription_twice(session_name, channel_name, domain_type);
+               if (argc < 8) {
+                       fail("Missing parameter for tests to run %d", argc);
+                       goto error;
+               }
+
+               nb_args = argc;
+
+               session_name = argv[3];
+               channel_name = argv[4];
+               app_pid = (pid_t) atoi(argv[5]);
+               app_state_file = argv[6];
+
+               /*
+                * Test cases are responsible for resuming the app when needed
+                * and making sure it's suspended when returning.
+                */
+               suspend_application();
+
+               test_subscription_twice(session_name, channel_name,
+                               domain_type);
+
+               diag("Test trigger for domain %s with buffer_usage_low condition",
+                               domain_type_string);
+               test_triggers_buffer_usage_condition(session_name, channel_name,
+                               domain_type,
+                               LTTNG_CONDITION_TYPE_BUFFER_USAGE_LOW);
+
+               diag("Test trigger for domain %s with buffer_usage_high condition",
+                               domain_type_string);
+               test_triggers_buffer_usage_condition(session_name, channel_name,
+                               domain_type,
+                               LTTNG_CONDITION_TYPE_BUFFER_USAGE_HIGH);
+
+               diag("Test buffer usage notification channel api for domain %s",
+                               domain_type_string);
+               test_buffer_usage_notification_channel(session_name, channel_name,
+                               domain_type, argv);
+               break;
+       }
+       default:
+               abort();
+       }
 
-       diag("Test notification channel api for domain %s", domain_type_string);
-       test_notification_channel(session_name, channel_name, domain_type, argv);
 error:
        return exit_status();
 }