Build fix: retrieve unix socket peer PID on non-unix platforms
[lttng-tools.git] / src / common / ust-consumer / ust-consumer.c
index bdfb8a0bbd3b75a939135c127e8e51c0fe6ab66e..2948fda5043ad7b8aa4dd177e0beb04b25d38d48 100644 (file)
@@ -10,6 +10,7 @@
 #define _LGPL_SOURCE
 #include <assert.h>
 #include <lttng/ust-ctl.h>
+#include <lttng/ust-sigbus.h>
 #include <poll.h>
 #include <pthread.h>
 #include <stdlib.h>
@@ -47,6 +48,8 @@
 extern struct lttng_consumer_global_data the_consumer_data;
 extern int consumer_poll_timeout;
 
+DEFINE_LTTNG_UST_SIGBUS_STATE();
+
 /*
  * Free channel object and all streams associated with it. This MUST be used
  * only and only if the channel has _NEVER_ been added to the global channel
@@ -66,7 +69,7 @@ static void destroy_channel(struct lttng_consumer_channel *channel)
                health_code_update();
 
                cds_list_del(&stream->send_node);
-               ustctl_destroy_stream(stream->ustream);
+               lttng_ust_ctl_destroy_stream(stream->ustream);
                lttng_trace_chunk_put(stream->trace_chunk);
                free(stream);
        }
@@ -250,7 +253,7 @@ static int create_ust_streams(struct lttng_consumer_channel *channel,
                struct lttng_consumer_local_data *ctx)
 {
        int ret, cpu = 0;
-       struct ustctl_consumer_stream *ustream;
+       struct lttng_ust_ctl_consumer_stream *ustream;
        struct lttng_consumer_stream *stream;
        pthread_mutex_t *current_stream_lock = NULL;
 
@@ -261,7 +264,7 @@ static int create_ust_streams(struct lttng_consumer_channel *channel,
         * While a stream is available from ustctl. When NULL is returned, we've
         * reached the end of the possible stream for the channel.
         */
-       while ((ustream = ustctl_create_stream(channel->uchan, cpu))) {
+       while ((ustream = lttng_ust_ctl_create_stream(channel->uchan, cpu))) {
                int wait_fd;
                int ust_metadata_pipe[2];
 
@@ -275,7 +278,7 @@ static int create_ust_streams(struct lttng_consumer_channel *channel,
                        }
                        wait_fd = ust_metadata_pipe[0];
                } else {
-                       wait_fd = ustctl_stream_get_wait_fd(ustream);
+                       wait_fd = lttng_ust_ctl_stream_get_wait_fd(ustream);
                }
 
                /* Allocate consumer stream object. */
@@ -307,10 +310,10 @@ static int create_ust_streams(struct lttng_consumer_channel *channel,
                 */
                cds_list_add_tail(&stream->send_node, &channel->streams.head);
 
-               ret = ustctl_get_max_subbuf_size(stream->ustream,
+               ret = lttng_ust_ctl_get_max_subbuf_size(stream->ustream,
                                &stream->max_sb_size);
                if (ret < 0) {
-                       ERR("ustctl_get_max_subbuf_size failed for stream %s",
+                       ERR("lttng_ust_ctl_get_max_subbuf_size failed for stream %s",
                                        stream->name);
                        goto error;
                }
@@ -382,12 +385,12 @@ error_shm_path:
  * Return 0 on success or else a negative value.
  */
 static int create_ust_channel(struct lttng_consumer_channel *channel,
-               struct ustctl_consumer_channel_attr *attr,
-               struct ustctl_consumer_channel **ust_chanp)
+               struct lttng_ust_ctl_consumer_channel_attr *attr,
+               struct lttng_ust_ctl_consumer_channel **ust_chanp)
 {
        int ret, nr_stream_fds, i, j;
        int *stream_fds;
-       struct ustctl_consumer_channel *ust_channel;
+       struct lttng_ust_ctl_consumer_channel *ust_channel;
 
        assert(channel);
        assert(attr);
@@ -404,7 +407,7 @@ static int create_ust_channel(struct lttng_consumer_channel *channel,
        if (channel->type == CONSUMER_CHANNEL_TYPE_METADATA)
                nr_stream_fds = 1;
        else
-               nr_stream_fds = ustctl_get_nr_stream_per_channel();
+               nr_stream_fds = lttng_ust_ctl_get_nr_stream_per_channel();
        stream_fds = zmalloc(nr_stream_fds * sizeof(*stream_fds));
        if (!stream_fds) {
                ret = -1;
@@ -418,7 +421,7 @@ static int create_ust_channel(struct lttng_consumer_channel *channel,
                        goto error_open;
                }
        }
-       ust_channel = ustctl_create_channel(attr, stream_fds, nr_stream_fds);
+       ust_channel = lttng_ust_ctl_create_channel(attr, stream_fds, nr_stream_fds);
        if (!ust_channel) {
                ret = -1;
                goto error_create;
@@ -485,7 +488,7 @@ static int send_sessiond_stream(int sock, struct lttng_consumer_stream *stream)
        DBG("UST consumer sending stream %" PRIu64 " to sessiond", stream->key);
 
        /* Send stream to session daemon. */
-       ret = ustctl_send_stream_to_sessiond(sock, stream->ustream);
+       ret = lttng_ust_ctl_send_stream_to_sessiond(sock, stream->ustream);
        if (ret < 0) {
                goto error;
        }
@@ -549,12 +552,12 @@ static int send_channel_to_sessiond_and_relayd(int sock,
        }
 
        /* Send channel to sessiond. */
-       ret = ustctl_send_channel_to_sessiond(sock, channel->uchan);
+       ret = lttng_ust_ctl_send_channel_to_sessiond(sock, channel->uchan);
        if (ret < 0) {
                goto error;
        }
 
-       ret = ustctl_channel_close_wakeup_fd(channel->uchan);
+       ret = lttng_ust_ctl_channel_close_wakeup_fd(channel->uchan);
        if (ret < 0) {
                goto error;
        }
@@ -572,7 +575,7 @@ static int send_channel_to_sessiond_and_relayd(int sock,
        }
 
        /* Tell sessiond there is no more stream. */
-       ret = ustctl_send_stream_to_sessiond(sock, NULL);
+       ret = lttng_ust_ctl_send_stream_to_sessiond(sock, NULL);
        if (ret < 0) {
                goto error;
        }
@@ -598,7 +601,7 @@ error:
  */
 static int ask_channel(struct lttng_consumer_local_data *ctx,
                struct lttng_consumer_channel *channel,
-               struct ustctl_consumer_channel_attr *attr)
+               struct lttng_ust_ctl_consumer_channel_attr *attr)
 {
        int ret;
 
@@ -627,7 +630,7 @@ static int ask_channel(struct lttng_consumer_local_data *ctx,
                goto end;
        }
 
-       channel->wait_fd = ustctl_channel_get_wait_fd(channel->uchan);
+       channel->wait_fd = lttng_ust_ctl_channel_get_wait_fd(channel->uchan);
 
        /*
         * For the snapshots (no monitor), we create the metadata streams
@@ -727,7 +730,14 @@ static int flush_channel(uint64_t chan_key)
                }
 
                if (!stream->quiescent) {
-                       ustctl_flush_buffer(stream->ustream, 0);
+                       ret = lttng_ust_ctl_flush_buffer(stream->ustream, 0);
+                       if (ret) {
+                               ERR("Failed to flush buffer while flushing channel: channel key = %" PRIu64 ", channel name = '%s'",
+                                               chan_key, channel->name);
+                               ret = LTTNG_ERR_BUFFER_FLUSH_FAILED;
+                               pthread_mutex_unlock(&stream->lock);
+                               goto error;
+                       }
                        stream->quiescent = true;
                }
 next:
@@ -1039,7 +1049,7 @@ int get_current_subbuf_addr(struct lttng_consumer_stream *stream,
        unsigned long mmap_offset;
        const char *mmap_base;
 
-       mmap_base = ustctl_get_mmap_base(stream->ustream);
+       mmap_base = lttng_ust_ctl_get_mmap_base(stream->ustream);
        if (!mmap_base) {
                ERR("Failed to get mmap base for stream `%s`",
                                stream->name);
@@ -1047,7 +1057,7 @@ int get_current_subbuf_addr(struct lttng_consumer_stream *stream,
                goto error;
        }
 
-       ret = ustctl_get_mmap_read_offset(stream->ustream, &mmap_offset);
+       ret = lttng_ust_ctl_get_mmap_read_offset(stream->ustream, &mmap_offset);
        if (ret != 0) {
                ERR("Failed to get mmap offset for stream `%s`", stream->name);
                ret = -EINVAL;
@@ -1128,7 +1138,12 @@ static int snapshot_channel(struct lttng_consumer_channel *channel,
                 * Else, if quiescent, it has already been done by the prior stop.
                 */
                if (!stream->quiescent) {
-                       ustctl_flush_buffer(stream->ustream, 0);
+                       ret = lttng_ust_ctl_flush_buffer(stream->ustream, 0);
+                       if (ret < 0) {
+                               ERR("Failed to flush buffer during snapshot of channel: channel key = %" PRIu64 ", channel name = '%s'",
+                                               channel->key, channel->name);
+                               goto error_unlock;
+                       }
                }
 
                ret = lttng_ustconsumer_take_snapshot(stream);
@@ -1169,10 +1184,10 @@ static int snapshot_channel(struct lttng_consumer_channel *channel,
 
                        DBG("UST consumer taking snapshot at pos %lu", consumed_pos);
 
-                       ret = ustctl_get_subbuf(stream->ustream, &consumed_pos);
+                       ret = lttng_ust_ctl_get_subbuf(stream->ustream, &consumed_pos);
                        if (ret < 0) {
                                if (ret != -EAGAIN) {
-                                       PERROR("ustctl_get_subbuf snapshot");
+                                       PERROR("lttng_ust_ctl_get_subbuf snapshot");
                                        goto error_close_stream;
                                }
                                DBG("UST consumer get subbuf failed. Skipping it.");
@@ -1181,15 +1196,15 @@ static int snapshot_channel(struct lttng_consumer_channel *channel,
                                continue;
                        }
 
-                       ret = ustctl_get_subbuf_size(stream->ustream, &len);
+                       ret = lttng_ust_ctl_get_subbuf_size(stream->ustream, &len);
                        if (ret < 0) {
-                               ERR("Snapshot ustctl_get_subbuf_size");
+                               ERR("Snapshot lttng_ust_ctl_get_subbuf_size");
                                goto error_put_subbuf;
                        }
 
-                       ret = ustctl_get_padded_subbuf_size(stream->ustream, &padded_len);
+                       ret = lttng_ust_ctl_get_padded_subbuf_size(stream->ustream, &padded_len);
                        if (ret < 0) {
-                               ERR("Snapshot ustctl_get_padded_subbuf_size");
+                               ERR("Snapshot lttng_ust_ctl_get_padded_subbuf_size");
                                goto error_put_subbuf;
                        }
 
@@ -1214,9 +1229,9 @@ static int snapshot_channel(struct lttng_consumer_channel *channel,
                                }
                        }
 
-                       ret = ustctl_put_subbuf(stream->ustream);
+                       ret = lttng_ust_ctl_put_subbuf(stream->ustream);
                        if (ret < 0) {
-                               ERR("Snapshot ustctl_put_subbuf");
+                               ERR("Snapshot lttng_ust_ctl_put_subbuf");
                                goto error_close_stream;
                        }
                        consumed_pos += stream->max_sb_size;
@@ -1231,8 +1246,8 @@ static int snapshot_channel(struct lttng_consumer_channel *channel,
        return 0;
 
 error_put_subbuf:
-       if (ustctl_put_subbuf(stream->ustream) < 0) {
-               ERR("Snapshot ustctl_put_subbuf");
+       if (lttng_ust_ctl_put_subbuf(stream->ustream) < 0) {
+               ERR("Snapshot lttng_ust_ctl_put_subbuf");
        }
 error_close_stream:
        consumer_stream_close(stream);
@@ -1473,7 +1488,7 @@ int lttng_ustconsumer_recv_cmd(struct lttng_consumer_local_data *ctx,
        case LTTNG_CONSUMER_ASK_CHANNEL_CREATION:
        {
                int ret_ask_channel, ret_add_channel, ret_send;
-               struct ustctl_consumer_channel_attr attr;
+               struct lttng_ust_ctl_consumer_channel_attr attr;
                const uint64_t chunk_id = msg.u.ask_channel.chunk_id.value;
                const struct lttng_credentials buffer_credentials = {
                        .uid = LTTNG_OPTIONAL_INIT_VALUE(msg.u.ask_channel.buffer_credentials.uid),
@@ -2314,13 +2329,13 @@ end:
        return ret_func;
 }
 
-void lttng_ustctl_flush_buffer(struct lttng_consumer_stream *stream,
+int lttng_ust_flush_buffer(struct lttng_consumer_stream *stream,
                int producer_active)
 {
        assert(stream);
        assert(stream->ustream);
 
-       ustctl_flush_buffer(stream->ustream, producer_active);
+       return lttng_ust_ctl_flush_buffer(stream->ustream, producer_active);
 }
 
 /*
@@ -2333,7 +2348,7 @@ int lttng_ustconsumer_take_snapshot(struct lttng_consumer_stream *stream)
        assert(stream);
        assert(stream->ustream);
 
-       return ustctl_snapshot(stream->ustream);
+       return lttng_ust_ctl_snapshot(stream->ustream);
 }
 
 /*
@@ -2347,7 +2362,7 @@ int lttng_ustconsumer_sample_snapshot_positions(
        assert(stream);
        assert(stream->ustream);
 
-       return ustctl_snapshot_sample_positions(stream->ustream);
+       return lttng_ust_ctl_snapshot_sample_positions(stream->ustream);
 }
 
 /*
@@ -2362,7 +2377,7 @@ int lttng_ustconsumer_get_produced_snapshot(
        assert(stream->ustream);
        assert(pos);
 
-       return ustctl_snapshot_get_produced(stream->ustream, pos);
+       return lttng_ust_ctl_snapshot_get_produced(stream->ustream, pos);
 }
 
 /*
@@ -2377,24 +2392,24 @@ int lttng_ustconsumer_get_consumed_snapshot(
        assert(stream->ustream);
        assert(pos);
 
-       return ustctl_snapshot_get_consumed(stream->ustream, pos);
+       return lttng_ust_ctl_snapshot_get_consumed(stream->ustream, pos);
 }
 
-void lttng_ustconsumer_flush_buffer(struct lttng_consumer_stream *stream,
+int lttng_ustconsumer_flush_buffer(struct lttng_consumer_stream *stream,
                int producer)
 {
        assert(stream);
        assert(stream->ustream);
 
-       ustctl_flush_buffer(stream->ustream, producer);
+       return lttng_ust_ctl_flush_buffer(stream->ustream, producer);
 }
 
-void lttng_ustconsumer_clear_buffer(struct lttng_consumer_stream *stream)
+int lttng_ustconsumer_clear_buffer(struct lttng_consumer_stream *stream)
 {
        assert(stream);
        assert(stream->ustream);
 
-       ustctl_clear_buffer(stream->ustream);
+       return lttng_ust_ctl_clear_buffer(stream->ustream);
 }
 
 int lttng_ustconsumer_get_current_timestamp(
@@ -2404,7 +2419,7 @@ int lttng_ustconsumer_get_current_timestamp(
        assert(stream->ustream);
        assert(ts);
 
-       return ustctl_get_current_timestamp(stream->ustream, ts);
+       return lttng_ust_ctl_get_current_timestamp(stream->ustream, ts);
 }
 
 int lttng_ustconsumer_get_sequence_number(
@@ -2414,7 +2429,7 @@ int lttng_ustconsumer_get_sequence_number(
        assert(stream->ustream);
        assert(seq);
 
-       return ustctl_get_sequence_number(stream->ustream, seq);
+       return lttng_ust_ctl_get_sequence_number(stream->ustream, seq);
 }
 
 /*
@@ -2427,8 +2442,11 @@ void lttng_ustconsumer_on_stream_hangup(struct lttng_consumer_stream *stream)
 
        pthread_mutex_lock(&stream->lock);
        if (!stream->quiescent) {
-               ustctl_flush_buffer(stream->ustream, 0);
-               stream->quiescent = true;
+               if (lttng_ust_ctl_flush_buffer(stream->ustream, 0) < 0) {
+                       ERR("Failed to flush buffer on stream hang-up");
+               } else {
+                       stream->quiescent = true;
+               }
        }
        pthread_mutex_unlock(&stream->lock);
        stream->hangup_flush_done = 1;
@@ -2478,7 +2496,7 @@ void lttng_ustconsumer_free_channel(struct lttng_consumer_channel *chan)
        assert(chan->buffer_credentials.is_set);
 
        consumer_metadata_cache_destroy(chan);
-       ustctl_destroy_channel(chan->uchan);
+       lttng_ust_ctl_destroy_channel(chan->uchan);
        /* Try to rmdir all directories under shm_path root. */
        if (chan->root_shm_path[0]) {
                (void) run_as_rmdir_recursive(chan->root_shm_path,
@@ -2499,7 +2517,7 @@ void lttng_ustconsumer_del_stream(struct lttng_consumer_stream *stream)
        if (stream->chan->switch_timer_enabled == 1) {
                consumer_timer_switch_stop(stream->chan);
        }
-       ustctl_destroy_stream(stream->ustream);
+       lttng_ust_ctl_destroy_stream(stream->ustream);
 }
 
 int lttng_ustconsumer_get_wakeup_fd(struct lttng_consumer_stream *stream)
@@ -2507,7 +2525,7 @@ int lttng_ustconsumer_get_wakeup_fd(struct lttng_consumer_stream *stream)
        assert(stream);
        assert(stream->ustream);
 
-       return ustctl_stream_get_wakeup_fd(stream->ustream);
+       return lttng_ust_ctl_stream_get_wakeup_fd(stream->ustream);
 }
 
 int lttng_ustconsumer_close_wakeup_fd(struct lttng_consumer_stream *stream)
@@ -2515,7 +2533,7 @@ int lttng_ustconsumer_close_wakeup_fd(struct lttng_consumer_stream *stream)
        assert(stream);
        assert(stream->ustream);
 
-       return ustctl_stream_close_wakeup_fd(stream->ustream);
+       return lttng_ust_ctl_stream_close_wakeup_fd(stream->ustream);
 }
 
 /*
@@ -2568,7 +2586,7 @@ int commit_one_metadata_packet(struct lttng_consumer_stream *stream)
                }
        }
 
-       write_len = ustctl_write_one_packet_to_channel(stream->chan->uchan,
+       write_len = lttng_ust_ctl_write_one_packet_to_channel(stream->chan->uchan,
                        &stream->chan->metadata_cache->contents.data[stream->ust_metadata_pushed],
                        stream->chan->metadata_cache->contents.size -
                                        stream->ust_metadata_pushed);
@@ -2589,8 +2607,12 @@ int commit_one_metadata_packet(struct lttng_consumer_stream *stream)
         * a metadata packet. Since the subbuffer is fully filled (with padding,
         * if needed), the stream is "quiescent" after this commit.
         */
-       ustctl_flush_buffer(stream->ustream, 1);
-       stream->quiescent = true;
+       if (lttng_ust_ctl_flush_buffer(stream->ustream, 1)) {
+               ERR("Failed to flush buffer while commiting one metadata packet");
+               ret = -EIO;
+       } else {
+               stream->quiescent = true;
+       }
 end:
        pthread_mutex_unlock(&stream->chan->metadata_cache->lock);
        return ret;
@@ -2660,7 +2682,7 @@ enum sync_metadata_status lttng_ustconsumer_sync_metadata(
                goto end;
        }
 
-       ret = ustctl_snapshot(metadata_stream->ustream);
+       ret = lttng_ust_ctl_snapshot(metadata_stream->ustream);
        if (ret < 0) {
                ERR("Failed to take a snapshot of the metadata ring-buffer positions, ret = %d", ret);
                status = SYNC_METADATA_STATUS_ERROR;
@@ -2678,7 +2700,7 @@ static int notify_if_more_data(struct lttng_consumer_stream *stream,
                struct lttng_consumer_local_data *ctx)
 {
        int ret;
-       struct ustctl_consumer_stream *ustream;
+       struct lttng_ust_ctl_consumer_stream *ustream;
 
        assert(stream);
        assert(ctx);
@@ -2690,7 +2712,7 @@ static int notify_if_more_data(struct lttng_consumer_stream *stream,
         * before reading the stream wait_fd.
         */
        /* Get the next subbuffer */
-       ret = ustctl_get_next_subbuf(ustream);
+       ret = lttng_ust_ctl_get_next_subbuf(ustream);
        if (ret) {
                /* No more data found, flag the stream. */
                stream->has_data = 0;
@@ -2698,7 +2720,7 @@ static int notify_if_more_data(struct lttng_consumer_stream *stream,
                goto end;
        }
 
-       ret = ustctl_put_subbuf(ustream);
+       ret = lttng_ust_ctl_put_subbuf(ustream);
        assert(!ret);
 
        /* This stream still has data. Flag it and wake up the data thread. */
@@ -2755,13 +2777,13 @@ static int extract_common_subbuffer_info(struct lttng_consumer_stream *stream,
 {
        int ret;
 
-       ret = ustctl_get_subbuf_size(
+       ret = lttng_ust_ctl_get_subbuf_size(
                        stream->ustream, &subbuf->info.data.subbuf_size);
        if (ret) {
                goto end;
        }
 
-       ret = ustctl_get_padded_subbuf_size(
+       ret = lttng_ust_ctl_get_padded_subbuf_size(
                        stream->ustream, &subbuf->info.data.padded_subbuf_size);
        if (ret) {
                goto end;
@@ -2797,42 +2819,42 @@ static int extract_data_subbuffer_info(struct lttng_consumer_stream *stream,
                goto end;
        }
 
-       ret = ustctl_get_packet_size(
+       ret = lttng_ust_ctl_get_packet_size(
                        stream->ustream, &subbuf->info.data.packet_size);
        if (ret < 0) {
                PERROR("Failed to get sub-buffer packet size");
                goto end;
        }
 
-       ret = ustctl_get_content_size(
+       ret = lttng_ust_ctl_get_content_size(
                        stream->ustream, &subbuf->info.data.content_size);
        if (ret < 0) {
                PERROR("Failed to get sub-buffer content size");
                goto end;
        }
 
-       ret = ustctl_get_timestamp_begin(
+       ret = lttng_ust_ctl_get_timestamp_begin(
                        stream->ustream, &subbuf->info.data.timestamp_begin);
        if (ret < 0) {
                PERROR("Failed to get sub-buffer begin timestamp");
                goto end;
        }
 
-       ret = ustctl_get_timestamp_end(
+       ret = lttng_ust_ctl_get_timestamp_end(
                        stream->ustream, &subbuf->info.data.timestamp_end);
        if (ret < 0) {
                PERROR("Failed to get sub-buffer end timestamp");
                goto end;
        }
 
-       ret = ustctl_get_events_discarded(
+       ret = lttng_ust_ctl_get_events_discarded(
                        stream->ustream, &subbuf->info.data.events_discarded);
        if (ret) {
                PERROR("Failed to get sub-buffer events discarded count");
                goto end;
        }
 
-       ret = ustctl_get_sequence_number(stream->ustream,
+       ret = lttng_ust_ctl_get_sequence_number(stream->ustream,
                        &subbuf->info.data.sequence_number.value);
        if (ret) {
                /* May not be supported by older LTTng-modules. */
@@ -2844,14 +2866,14 @@ static int extract_data_subbuffer_info(struct lttng_consumer_stream *stream,
                subbuf->info.data.sequence_number.is_set = true;
        }
 
-       ret = ustctl_get_stream_id(
+       ret = lttng_ust_ctl_get_stream_id(
                        stream->ustream, &subbuf->info.data.stream_id);
        if (ret < 0) {
                PERROR("Failed to get stream id");
                goto end;
        }
 
-       ret = ustctl_get_instance_id(stream->ustream,
+       ret = lttng_ust_ctl_get_instance_id(stream->ustream,
                        &subbuf->info.data.stream_instance_id.value);
        if (ret) {
                /* May not be supported by older LTTng-modules. */
@@ -2890,25 +2912,45 @@ end:
        return ret;
 }
 
-static int get_next_subbuffer(struct lttng_consumer_stream *stream,
+static enum get_next_subbuffer_status get_next_subbuffer(
+               struct lttng_consumer_stream *stream,
                struct stream_subbuffer *subbuffer)
 {
        int ret;
+       enum get_next_subbuffer_status status;
 
-       ret = ustctl_get_next_subbuf(stream->ustream);
-       if (ret) {
+       ret = lttng_ust_ctl_get_next_subbuf(stream->ustream);
+       switch (ret) {
+       case 0:
+               status = GET_NEXT_SUBBUFFER_STATUS_OK;
+               break;
+       case -ENODATA:
+               case -EAGAIN:
+               /*
+                * The caller only expects -ENODATA when there is no data to
+                * read, but the kernel tracer returns -EAGAIN when there is
+                * currently no data for a non-finalized stream, and -ENODATA
+                * when there is no data for a finalized stream. Those can be
+                * combined into a -ENODATA return value.
+                */
+               status = GET_NEXT_SUBBUFFER_STATUS_NO_DATA;
+               goto end;
+       default:
+               status = GET_NEXT_SUBBUFFER_STATUS_ERROR;
                goto end;
        }
 
        ret = get_next_subbuffer_common(stream, subbuffer);
        if (ret) {
+               status = GET_NEXT_SUBBUFFER_STATUS_ERROR;
                goto end;
        }
 end:
-       return ret;
+       return status;
 }
 
-static int get_next_subbuffer_metadata(struct lttng_consumer_stream *stream,
+static enum get_next_subbuffer_status get_next_subbuffer_metadata(
+               struct lttng_consumer_stream *stream,
                struct stream_subbuffer *subbuffer)
 {
        int ret;
@@ -2917,15 +2959,17 @@ static int get_next_subbuffer_metadata(struct lttng_consumer_stream *stream,
        bool coherent;
        bool buffer_empty;
        unsigned long consumed_pos, produced_pos;
+       enum get_next_subbuffer_status status;
 
        do {
-               ret = ustctl_get_next_subbuf(stream->ustream);
+               ret = lttng_ust_ctl_get_next_subbuf(stream->ustream);
                if (ret == 0) {
                        got_subbuffer = true;
                } else {
                        got_subbuffer = false;
                        if (ret != -EAGAIN) {
                                /* Fatal error. */
+                               status = GET_NEXT_SUBBUFFER_STATUS_ERROR;
                                goto end;
                        }
                }
@@ -2937,11 +2981,12 @@ static int get_next_subbuffer_metadata(struct lttng_consumer_stream *stream,
                if (!got_subbuffer) {
                        ret = commit_one_metadata_packet(stream);
                        if (ret < 0 && ret != -ENOBUFS) {
+                               status = GET_NEXT_SUBBUFFER_STATUS_ERROR;
                                goto end;
                        } else if (ret == 0) {
                                /* Not an error, the cache is empty. */
                                cache_empty = true;
-                               ret = -ENODATA;
+                               status = GET_NEXT_SUBBUFFER_STATUS_NO_DATA;
                                goto end;
                        } else {
                                cache_empty = false;
@@ -2957,6 +3002,7 @@ static int get_next_subbuffer_metadata(struct lttng_consumer_stream *stream,
        /* Populate sub-buffer infos and view. */
        ret = get_next_subbuffer_common(stream, subbuffer);
        if (ret) {
+               status = GET_NEXT_SUBBUFFER_STATUS_ERROR;
                goto end;
        }
 
@@ -2967,18 +3013,21 @@ static int get_next_subbuffer_metadata(struct lttng_consumer_stream *stream,
                 * pushed the consumption position yet (on put_next).
                 */
                PERROR("Failed to take a snapshot of metadata buffer positions");
+               status = GET_NEXT_SUBBUFFER_STATUS_ERROR;
                goto end;
        }
 
        ret = lttng_ustconsumer_get_consumed_snapshot(stream, &consumed_pos);
        if (ret) {
                PERROR("Failed to get metadata consumed position");
+               status = GET_NEXT_SUBBUFFER_STATUS_ERROR;
                goto end;
        }
 
        ret = lttng_ustconsumer_get_produced_snapshot(stream, &produced_pos);
        if (ret) {
                PERROR("Failed to get metadata produced position");
+               status = GET_NEXT_SUBBUFFER_STATUS_ERROR;
                goto end;
        }
 
@@ -2994,14 +3043,15 @@ static int get_next_subbuffer_metadata(struct lttng_consumer_stream *stream,
        coherent = got_subbuffer && cache_empty && buffer_empty;
 
        LTTNG_OPTIONAL_SET(&subbuffer->info.metadata.coherent, coherent);
+       status = GET_NEXT_SUBBUFFER_STATUS_OK;
 end:
-       return ret;
+       return status;
 }
 
 static int put_next_subbuffer(struct lttng_consumer_stream *stream,
                struct stream_subbuffer *subbuffer)
 {
-       const int ret = ustctl_put_next_subbuf(stream->ustream);
+       const int ret = lttng_ust_ctl_put_next_subbuf(stream->ustream);
 
        assert(ret == 0);
        return ret;
@@ -3133,13 +3183,13 @@ int lttng_ustconsumer_data_pending(struct lttng_consumer_stream *stream)
                        goto end;
                }
        } else {
-               ret = ustctl_get_next_subbuf(stream->ustream);
+               ret = lttng_ust_ctl_get_next_subbuf(stream->ustream);
                if (ret == 0) {
                        /*
                         * There is still data so let's put back this
                         * subbuffer.
                         */
-                       ret = ustctl_put_subbuf(stream->ustream);
+                       ret = lttng_ust_ctl_put_subbuf(stream->ustream);
                        assert(ret == 0);
                        ret = 1;        /* Data is pending */
                        goto end;
@@ -3229,7 +3279,7 @@ void lttng_ustconsumer_close_stream_wakeup(struct lttng_consumer_stream *stream)
 {
        int ret;
 
-       ret = ustctl_stream_close_wakeup_fd(stream->ustream);
+       ret = lttng_ust_ctl_stream_close_wakeup_fd(stream->ustream);
        if (ret < 0) {
                ERR("Unable to close wakeup fd");
        }
@@ -3380,5 +3430,10 @@ int lttng_ustconsumer_get_stream_id(struct lttng_consumer_stream *stream,
        assert(stream);
        assert(stream_id);
 
-       return ustctl_get_stream_id(stream->ustream, stream_id);
+       return lttng_ust_ctl_get_stream_id(stream->ustream, stream_id);
+}
+
+void lttng_ustconsumer_sigbus_handle(void *addr)
+{
+       lttng_ust_ctl_sigbus_handle(addr);
 }
This page took 0.034325 seconds and 4 git commands to generate.