Fix: run_as error handling

[lttng-tools.git] / src / common / runas.c

diff --git a/src/common/runas.c b/src/common/runas.c
index bee107951d8664e6f111ed5ff260574407f0c3a3..cdc9cb79e604177467dd815992e12bdbe875e4f9 100644 (file)
--- a/src/common/runas.c
+++ b/src/common/runas.c
@@ -217,6 +217,7 @@ int run_as(int (*cmd)(void *data), void *data, uid_t uid, gid_t gid)
        ret = pipe(retval_pipe);
        if (ret < 0) {
                perror("pipe");
+               retval.i = ret;
                goto end;
        }
        run_as_data.data = data;
@@ -230,19 +231,18 @@ int run_as(int (*cmd)(void *data), void *data, uid_t uid, gid_t gid)
                -1, 0);
        if (child_stack == MAP_FAILED) {
                perror("mmap");
-               ret = -ENOMEM;
+               retval.i = -ENOMEM;
                goto close_pipe;
        }
        /*
         * Pointing to the middle of the stack to support architectures
         * where the stack grows up (HPPA).
         */
-       pid = clone(child_run_as, child_stack + (RUNAS_CHILD_STACK_SIZE / 2),
-               CLONE_FILES | SIGCHLD,
-               &run_as_data, NULL);
+       pid = lttng_clone_files(child_run_as, child_stack + (RUNAS_CHILD_STACK_SIZE / 2),
+               &run_as_data);
        if (pid < 0) {
                perror("clone");
-               ret = pid;
+               retval.i = pid;
                goto unmap_stack;
        }
        /* receive return value */
@@ -266,12 +266,13 @@ int run_as(int (*cmd)(void *data), void *data, uid_t uid, gid_t gid)
        pid = waitpid(pid, &status, 0);
        if (pid < 0 || !WIFEXITED(status) || WEXITSTATUS(status) != 0) {
                perror("wait");
-               ret = -1;
+               retval.i = -1;
        }
 unmap_stack:
        ret = munmap(child_stack, RUNAS_CHILD_STACK_SIZE);
        if (ret < 0) {
                perror("munmap");
+               retval.i = ret;
        }
 close_pipe:
        close(retval_pipe[0]);