projects
/
lttng-tools.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Fix: directory-handle: use of free'd handle on fstat() error
[lttng-tools.git]
/
src
/
common
/
compat
/
directory-handle.c
diff --git
a/src/common/compat/directory-handle.c
b/src/common/compat/directory-handle.c
index eb1cd926e6e2df0979d041a21532a7a6b141b050..a790c5b79960d7933efe4221949070698b59eea9 100644
(file)
--- a/
src/common/compat/directory-handle.c
+++ b/
src/common/compat/directory-handle.c
@@
-164,6
+164,8
@@
struct lttng_directory_handle *lttng_directory_handle_create_from_dirfd(
if (ret) {
PERROR("Failed to fstat directory file descriptor %i", dirfd);
lttng_directory_handle_release(&handle->ref);
if (ret) {
PERROR("Failed to fstat directory file descriptor %i", dirfd);
lttng_directory_handle_release(&handle->ref);
+ handle = NULL;
+ goto end;
}
} else {
handle->directory_inode = RESERVED_AT_FDCWD_INO;
}
} else {
handle->directory_inode = RESERVED_AT_FDCWD_INO;
@@
-181,6
+183,10
@@
void lttng_directory_handle_release(struct urcu_ref *ref)
struct lttng_directory_handle *handle =
container_of(ref, struct lttng_directory_handle, ref);
struct lttng_directory_handle *handle =
container_of(ref, struct lttng_directory_handle, ref);
+ if (handle->destroy_cb) {
+ handle->destroy_cb(handle, handle->destroy_cb_data);
+ }
+
if (handle->dirfd == AT_FDCWD || handle->dirfd == -1) {
goto end;
}
if (handle->dirfd == AT_FDCWD || handle->dirfd == -1) {
goto end;
}
@@
-587,7
+593,7
@@
LTTNG_HIDDEN
bool lttng_directory_handle_equals(const struct lttng_directory_handle *lhs,
const struct lttng_directory_handle *rhs)
{
bool lttng_directory_handle_equals(const struct lttng_directory_handle *lhs,
const struct lttng_directory_handle *rhs)
{
- return strcmp(lhs->
path, rhs->
path) == 0;
+ return strcmp(lhs->
base_path, rhs->base_
path) == 0;
}
static
}
static
This page took
0.024395 seconds
and
4
git commands to generate.