Make execution path with uninitialized domain fail

[lttng-tools.git] / src / bin / lttng / commands / list.c

diff --git a/src/bin/lttng/commands/list.c b/src/bin/lttng/commands/list.c
index ef1efc79371876406eccea376fcec64083d2575c..7c33046ebec1490f798ca4a63e71f0778f91c1db 100644 (file)
--- a/src/bin/lttng/commands/list.c
+++ b/src/bin/lttng/commands/list.c
@@ -145,9 +145,9 @@ const char *enabled_string(int value)
 }
 
 static
-const char *loglevel_string_pre(const char *loglevel)
+const char *loglevel_string_pre(int loglevel)
 {
-       if (loglevel[0] == '\0') {
+       if (loglevel == -1) {
                return "";
        } else {
                return " (loglevel: ";
@@ -155,15 +155,39 @@ const char *loglevel_string_pre(const char *loglevel)
 }
 
 static
-const char *loglevel_string_post(const char *loglevel)
+const char *loglevel_string_post(int loglevel)
 {
-       if (loglevel[0] == '\0') {
+       if (loglevel == -1) {
                return "";
        } else {
                return ")";
        }
 }
 
+static const char *loglevel_string(int value)
+{
+       switch (value) {
+       case -1: return "";
+       case 0: return "TRACE_EMERG";
+       case 1: return "TRACE_ALERT";
+       case 2: return "TRACE_CRIT";
+       case 3: return "TRACE_ERR";
+       case 4: return "TRACE_WARNING";
+       case 5: return "TRACE_NOTICE";
+       case 6: return "TRACE_INFO";
+       case 7: return "TRACE_SYSTEM";
+       case 8: return "TRACE_PROGRAM";
+       case 9: return "TRACE_PROCESS";
+       case 10: return "TRACE_MODULE";
+       case 11: return "TRACE_UNIT";
+       case 12: return "TRACE_FUNCTION";
+       case 13: return "TRACE_DEFAULT";
+       case 14: return "TRACE_VERBOSE";
+       case 15: return "TRACE_DEBUG";
+       default: return "<<UNKNOWN>>";
+       }
+}
+
 /*
  * Pretty print single event.
  */
@@ -172,22 +196,10 @@ static void print_events(struct lttng_event *event)
        switch (event->type) {
        case LTTNG_EVENT_TRACEPOINT:
        {
-               char ll_value[LTTNG_SYMBOL_NAME_LEN] = "";
-
-               if (event->loglevel[0] != '\0') {
-                       int ret;
-
-                       ret = snprintf(ll_value, LTTNG_SYMBOL_NAME_LEN,
-                               " (%lld)", (long long) event->loglevel_value);
-                       if (ret < 0) {
-                               ERR("snprintf error");
-                       }
-               }
-               MSG("%s%s%s%s%s%s (type: tracepoint)%s", indent6,
+               MSG("%s%s%s%s%s (type: tracepoint)%s", indent6,
                                event->name,
                                loglevel_string_pre(event->loglevel),
-                               event->loglevel,
-                               ll_value,
+                               loglevel_string(event->loglevel),
                                loglevel_string_post(event->loglevel),
                                enabled_string(event->enabled));
                break;
@@ -234,6 +246,8 @@ static int list_ust_events(void)
        struct lttng_event *event_list;
        pid_t cur_pid = 0;
 
+       memset(&domain, 0, sizeof(domain));
+
        DBG("Getting UST tracing events");
 
        domain.type = LTTNG_DOMAIN_UST;
@@ -283,6 +297,8 @@ static int list_kernel_events(void)
        struct lttng_handle *handle;
        struct lttng_event *event_list;
 
+       memset(&domain, 0, sizeof(domain));
+
        DBG("Getting kernel tracing events");
 
        domain.type = LTTNG_DOMAIN_KERNEL;
@@ -467,7 +483,8 @@ static int list_sessions(const char *session_name)
                        continue;
                }
 
-               MSG("  %d) %s (%s)%s", i + 1, sessions[i].name, sessions[i].path, active_string(sessions[i].enabled));
+               MSG("  %d) %s (%s)%s", i + 1, sessions[i].name, sessions[i].path,
+                               active_string(sessions[i].enabled));
 
                if (session_found) {
                        break;
@@ -477,7 +494,9 @@ static int list_sessions(const char *session_name)
        free(sessions);
 
        if (!session_found && session_name != NULL) {
-               ERR("Session %s not found", session_name);
+               ERR("Session '%s' not found", session_name);
+               ret = CMD_ERROR;
+               goto error;
        }
 
        if (session_name == NULL) {
@@ -541,6 +560,8 @@ int cmd_list(int argc, const char **argv)
        struct lttng_domain domain;
        struct lttng_domain *domains = NULL;
 
+       memset(&domain, 0, sizeof(domain));
+
        if (argc < 1) {
                usage(stderr);
                ret = CMD_ERROR;
@@ -577,6 +598,10 @@ int cmd_list(int argc, const char **argv)
        } else if (opt_userspace) {
                DBG2("Listing userspace global domain");
                domain.type = LTTNG_DOMAIN_UST;
+       } else {
+               usage(stderr);
+               ret = CMD_UNDEFINED;
+               goto end;
        }
 
        handle = lttng_create_handle(session_name, &domain);
@@ -588,39 +613,32 @@ int cmd_list(int argc, const char **argv)
        if (session_name == NULL) {
                if (!opt_kernel && !opt_userspace) {
                        ret = list_sessions(NULL);
-                       if (ret < 0) {
-                               ret = CMD_ERROR;
+                       if (ret != 0) {
                                goto end;
                        }
                }
                if (opt_kernel) {
                        ret = list_kernel_events();
                        if (ret < 0) {
-                               ret = CMD_ERROR;
                                goto end;
                        }
                }
                if (opt_userspace) {
                        ret = list_ust_events();
                        if (ret < 0) {
-                               ret = CMD_ERROR;
                                goto end;
                        }
                }
        } else {
                /* List session attributes */
                ret = list_sessions(session_name);
-               if (ret < 0) {
-                       ret = CMD_ERROR;
+               if (ret != 0) {
                        goto end;
                }
 
                /* Domain listing */
                if (opt_domain) {
                        ret = list_domains(session_name);
-                       if (ret < 0) {
-                               ret = CMD_ERROR;
-                       }
                        goto end;
                }
 
@@ -628,14 +646,13 @@ int cmd_list(int argc, const char **argv)
                        /* Channel listing */
                        ret = list_channels(opt_channel);
                        if (ret < 0) {
-                               ret = CMD_ERROR;
                                goto end;
                        }
                } else {
                        /* We want all domain(s) */
                        nb_domain = lttng_list_domains(session_name, &domains);
                        if (nb_domain < 0) {
-                               ret = CMD_ERROR;
+                               ret = nb_domain;
                                goto end;
                        }
 
@@ -663,7 +680,6 @@ int cmd_list(int argc, const char **argv)
 
                                ret = list_channels(opt_channel);
                                if (ret < 0) {
-                                       ret = CMD_ERROR;
                                        goto end;
                                }
                        }