projects
/
lttng-tools.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Remove unnecessary RCU read lock
[lttng-tools.git]
/
src
/
bin
/
lttng-sessiond
/
agent.c
diff --git
a/src/bin/lttng-sessiond/agent.c
b/src/bin/lttng-sessiond/agent.c
index ab6905190e0eb7082923832398fdababae09efbc..0821630865106182365cd404fecaf0cd9bcb64cc 100644
(file)
--- a/
src/bin/lttng-sessiond/agent.c
+++ b/
src/bin/lttng-sessiond/agent.c
@@
-303,9
+303,7
@@
static ssize_t list_events(struct agent_app *app, struct lttng_event **events)
data_size = be32toh(reply_hdr.data_size) + sizeof(*reply);
break;
default:
data_size = be32toh(reply_hdr.data_size) + sizeof(*reply);
break;
default:
- ERR("Agent returned an unknown code: %" PRIu32,
- be32toh(reply_hdr.ret_code));
- ret = LTTNG_ERR_FATAL;
+ ret = LTTNG_ERR_UNK;
goto error;
}
goto error;
}
@@
-402,9
+400,7
@@
static int enable_event(struct agent_app *app, struct agent_event *event)
ret = LTTNG_ERR_UST_EVENT_NOT_FOUND;
goto error;
default:
ret = LTTNG_ERR_UST_EVENT_NOT_FOUND;
goto error;
default:
- ERR("Agent returned an unknown code: %" PRIu32,
- be32toh(reply.ret_code));
- ret = LTTNG_ERR_FATAL;
+ ret = LTTNG_ERR_UNK;
goto error;
}
goto error;
}
@@
-465,9
+461,7
@@
static int disable_event(struct agent_app *app, struct agent_event *event)
ret = LTTNG_ERR_UST_EVENT_NOT_FOUND;
goto error;
default:
ret = LTTNG_ERR_UST_EVENT_NOT_FOUND;
goto error;
default:
- ERR("Agent returned an unknown code: %" PRIu32,
- be32toh(reply.ret_code));
- ret = LTTNG_ERR_FATAL;
+ ret = LTTNG_ERR_UNK;
goto error;
}
goto error;
}
@@
-722,10
+716,7
@@
void agent_add_app(struct agent_app *app)
assert(app);
DBG3("Agent adding app sock: %d and pid: %d to ht", app->sock->fd, app->pid);
assert(app);
DBG3("Agent adding app sock: %d and pid: %d to ht", app->sock->fd, app->pid);
-
- rcu_read_lock();
lttng_ht_add_unique_ulong(agent_apps_ht_by_sock, &app->node);
lttng_ht_add_unique_ulong(agent_apps_ht_by_sock, &app->node);
- rcu_read_unlock();
}
/*
}
/*
@@
-798,9
+789,7
@@
void agent_add(struct agent *agt, struct lttng_ht *ht)
DBG3("Agent adding from domain %d", agt->domain);
DBG3("Agent adding from domain %d", agt->domain);
- rcu_read_lock();
lttng_ht_add_unique_u64(ht, &agt->node);
lttng_ht_add_unique_u64(ht, &agt->node);
- rcu_read_unlock();
}
/*
}
/*
@@
-813,7
+802,7
@@
struct agent *agent_create(enum lttng_domain_type domain)
int ret;
struct agent *agt;
int ret;
struct agent *agt;
- agt = zmalloc(sizeof(
*ag
t));
+ agt = zmalloc(sizeof(
struct agen
t));
if (!agt) {
goto error;
}
if (!agt) {
goto error;
}
@@
-872,10
+861,7
@@
void agent_add_event(struct agent_event *event, struct agent *agt)
assert(agt->events);
DBG3("Agent adding event %s", event->name);
assert(agt->events);
DBG3("Agent adding event %s", event->name);
-
- rcu_read_lock();
add_unique_agent_event(agt->events, event);
add_unique_agent_event(agt->events, event);
- rcu_read_unlock();
agt->being_used = 1;
}
agt->being_used = 1;
}
@@
-964,6
+950,7
@@
void agent_destroy_event(struct agent_event *event)
assert(event);
free(event->filter);
assert(event);
free(event->filter);
+ free(event->filter_expression);
free(event);
}
free(event);
}
This page took
0.023945 seconds
and
4
git commands to generate.