#include <common/macros.h>
#include <common/optional.h>
#include <lttng/action/action-internal.h>
+#include <lttng/action/group-internal.h>
#include <lttng/action/group.h>
#include <lttng/action/notify-internal.h>
#include <lttng/action/notify.h>
*/
typedef int (*action_executor_handler)(struct action_executor *executor,
const struct action_work_item *,
- const struct lttng_action *action);
+ struct lttng_action *action);
static int action_executor_notify_handler(struct action_executor *executor,
const struct action_work_item *,
- const struct lttng_action *);
-static int action_executor_start_session_handler(struct action_executor *executor,
+ struct lttng_action *);
+static int action_executor_start_session_handler(
+ struct action_executor *executor,
const struct action_work_item *,
- const struct lttng_action *);
-static int action_executor_stop_session_handler(struct action_executor *executor,
+ struct lttng_action *);
+static int action_executor_stop_session_handler(
+ struct action_executor *executor,
const struct action_work_item *,
- const struct lttng_action *);
-static int action_executor_rotate_session_handler(struct action_executor *executor,
+ struct lttng_action *);
+static int action_executor_rotate_session_handler(
+ struct action_executor *executor,
const struct action_work_item *,
- const struct lttng_action *);
-static int action_executor_snapshot_session_handler(struct action_executor *executor,
+ struct lttng_action *);
+static int action_executor_snapshot_session_handler(
+ struct action_executor *executor,
const struct action_work_item *,
- const struct lttng_action *);
+ struct lttng_action *);
static int action_executor_group_handler(struct action_executor *executor,
const struct action_work_item *,
- const struct lttng_action *);
+ struct lttng_action *);
static int action_executor_generic_handler(struct action_executor *executor,
const struct action_work_item *,
- const struct lttng_action *);
+ struct lttng_action *);
static const action_executor_handler action_executors[] = {
[LTTNG_ACTION_TYPE_NOTIFY] = action_executor_notify_handler,
[LTTNG_ACTION_TYPE_GROUP] = action_executor_group_handler,
};
-static const char *action_type_names[] = {
- [LTTNG_ACTION_TYPE_NOTIFY] = "Notify",
- [LTTNG_ACTION_TYPE_START_SESSION] = "Start session",
- [LTTNG_ACTION_TYPE_STOP_SESSION] = "Stop session",
- [LTTNG_ACTION_TYPE_ROTATE_SESSION] = "Rotate session",
- [LTTNG_ACTION_TYPE_SNAPSHOT_SESSION] = "Snapshot session",
- [LTTNG_ACTION_TYPE_GROUP] = "Group",
-};
-
static const char *get_action_name(const struct lttng_action *action)
{
const enum lttng_action_type action_type = lttng_action_get_type(action);
assert(action_type != LTTNG_ACTION_TYPE_UNKNOWN);
- return action_type_names[action_type];
+ return lttng_action_type_string(action_type);
}
/* Check if this trigger allowed to interect with a given session. */
static int action_executor_notify_handler(struct action_executor *executor,
const struct action_work_item *work_item,
- const struct lttng_action *action)
+ struct lttng_action *action)
{
return notification_client_list_send_evaluation(work_item->client_list,
work_item->trigger,
client_handle_transmission_status, executor);
}
-static int action_executor_start_session_handler(struct action_executor *executor,
+static int action_executor_start_session_handler(
+ struct action_executor *executor,
const struct action_work_item *work_item,
- const struct lttng_action *action)
+ struct lttng_action *action)
{
int ret = 0;
const char *session_name;
WARN("Failed to start session `%s` on behalf of trigger `%s`: %s",
session_name, get_trigger_name(work_item->trigger),
lttng_strerror(-cmd_ret));
+ lttng_action_increase_execution_failure_count(action);
break;
}
return ret;
}
-static int action_executor_stop_session_handler(struct action_executor *executor,
+static int action_executor_stop_session_handler(
+ struct action_executor *executor,
const struct action_work_item *work_item,
- const struct lttng_action *action)
+ struct lttng_action *action)
{
int ret = 0;
const char *session_name;
DBG("Failed to find session `%s` by name while executing `%s` action of trigger `%s`",
session_name, get_action_name(action),
get_trigger_name(work_item->trigger));
+ lttng_action_increase_execution_failure_count(action);
goto error_unlock_list;
}
WARN("Failed to stop session `%s` on behalf of trigger `%s`: %s",
session_name, get_trigger_name(work_item->trigger),
lttng_strerror(-cmd_ret));
+ lttng_action_increase_execution_failure_count(action);
break;
}
return ret;
}
-static int action_executor_rotate_session_handler(struct action_executor *executor,
+static int action_executor_rotate_session_handler(
+ struct action_executor *executor,
const struct action_work_item *work_item,
- const struct lttng_action *action)
+ struct lttng_action *action)
{
int ret = 0;
const char *session_name;
DBG("Failed to find session `%s` by name while executing `%s` action of trigger `%s`",
session_name, get_action_name(action),
get_trigger_name(work_item->trigger));
+ lttng_action_increase_execution_failure_count(action);
goto error_unlock_list;
}
case LTTNG_ERR_ROTATION_PENDING:
DBG("Attempted to start a rotation of session `%s` on behalf of trigger `%s` but a rotation is already ongoing",
session_name, get_trigger_name(work_item->trigger));
+ lttng_action_increase_execution_failure_count(action);
break;
case LTTNG_ERR_ROTATION_MULTIPLE_AFTER_STOP:
case LTTNG_ERR_ROTATION_AFTER_STOP_CLEAR:
WARN("Failed to start a rotation of session `%s` on behalf of trigger `%s`: %s",
session_name, get_trigger_name(work_item->trigger),
lttng_strerror(-cmd_ret));
+ lttng_action_increase_execution_failure_count(action);
break;
}
return ret;
}
-static int action_executor_snapshot_session_handler(struct action_executor *executor,
+static int action_executor_snapshot_session_handler(
+ struct action_executor *executor,
const struct action_work_item *work_item,
- const struct lttng_action *action)
+ struct lttng_action *action)
{
int ret = 0;
const char *session_name;
DBG("Failed to find session `%s` by name while executing `%s` action of trigger `%s`",
session_name, get_action_name(action),
get_trigger_name(work_item->trigger));
+ lttng_action_increase_execution_failure_count(action);
goto error_unlock_list;
}
WARN("Failed to record snapshot of session `%s` on behalf of trigger `%s`: %s",
session_name, get_trigger_name(work_item->trigger),
lttng_strerror(-cmd_ret));
+ lttng_action_increase_execution_failure_count(action);
break;
}
static int action_executor_group_handler(struct action_executor *executor,
const struct action_work_item *work_item,
- const struct lttng_action *action_group)
+ struct lttng_action *action_group)
{
int ret = 0;
unsigned int i, count;
DBG("Action group has %u action%s", count, count != 1 ? "s" : "");
for (i = 0; i < count; i++) {
- const struct lttng_action *action =
- lttng_action_group_get_at_index(
+ struct lttng_action *action =
+ lttng_action_group_borrow_mutable_at_index(
action_group, i);
ret = action_executor_generic_handler(
static int action_executor_generic_handler(struct action_executor *executor,
const struct action_work_item *work_item,
- const struct lttng_action *action)
+ struct lttng_action *action)
{
+ int ret;
const enum lttng_action_type action_type = lttng_action_get_type(action);
assert(action_type != LTTNG_ACTION_TYPE_UNKNOWN);
+ lttng_action_increase_execution_request_count(action);
+ if (!lttng_action_should_execute(action)) {
+ DBG("Policy prevented execution of action `%s` of trigger `%s` action work item %" PRIu64,
+ get_action_name(action),
+ get_trigger_name(work_item->trigger),
+ work_item->id);
+ ret = 0;
+ goto end;
+ }
+
+ lttng_action_increase_execution_count(action);
DBG("Executing action `%s` of trigger `%s` action work item %" PRIu64,
get_action_name(action),
get_trigger_name(work_item->trigger),
work_item->id);
-
- return action_executors[action_type](
- executor, work_item, action);
+ ret = action_executors[action_type](executor, work_item, action);
+end:
+ return ret;
}
static int action_work_item_execute(struct action_executor *executor,
struct action_work_item *work_item)
{
int ret;
- const struct lttng_action *action =
- lttng_trigger_get_const_action(work_item->trigger);
+ struct lttng_action *action =
+ lttng_trigger_get_action(work_item->trigger);
DBG("Starting execution of action work item %" PRIu64 " of trigger `%s`",
work_item->id, get_trigger_name(work_item->trigger));
* allowing new items to be queued.
*/
pthread_mutex_unlock(&executor->work.lock);
+
+ /* Execute item only if a trigger is registered. */
+ lttng_trigger_lock(work_item->trigger);
+ if (!lttng_trigger_is_registered(work_item->trigger)) {
+ const char *trigger_name = NULL;
+ uid_t trigger_owner_uid;
+ enum lttng_trigger_status trigger_status;
+
+ trigger_status = lttng_trigger_get_name(
+ work_item->trigger, &trigger_name);
+ switch (trigger_status) {
+ case LTTNG_TRIGGER_STATUS_OK:
+ break;
+ case LTTNG_TRIGGER_STATUS_UNSET:
+ trigger_name = "(unset)";
+ break;
+ default:
+ abort();
+ }
+
+ trigger_status = lttng_trigger_get_owner_uid(
+ work_item->trigger, &trigger_owner_uid);
+ assert(trigger_status == LTTNG_TRIGGER_STATUS_OK);
+
+ DBG("Work item skipped since the associated trigger is no longer registered: work item id = %" PRIu64 ", trigger name = '%s', trigger owner uid = %d",
+ work_item->id, trigger_name,
+ (int) trigger_owner_uid);
+ ret = 0;
+ goto skip_execute;
+ }
+
ret = action_work_item_execute(executor, work_item);
+
+ skip_execute:
+ lttng_trigger_unlock(work_item->trigger);
action_work_item_destroy(work_item);
if (ret) {
/* Fatal error. */
projects / lttng-tools.git / blobdiff