Fix: possible null dereference

[lttng-tools.git] / src / bin / lttng-relayd / cmd-2-4.c

diff --git a/src/bin/lttng-relayd/cmd-2-4.c b/src/bin/lttng-relayd/cmd-2-4.c
index f199b8396707746bb1144ef7f8f2b7c1d321f89a..02edb7713e54245b2c55beb6ec6ffb94ed4499e6 100644 (file)
--- a/src/bin/lttng-relayd/cmd-2-4.c
+++ b/src/bin/lttng-relayd/cmd-2-4.c
@@ -1,52 +1,64 @@
 /*
- * Copyright (C) 2013 - Julien Desfossez <jdesfossez@efficios.com>
- *                      David Goulet <dgoulet@efficios.com>
+ * Copyright (C) 2013 Julien Desfossez <jdesfossez@efficios.com>
+ * Copyright (C) 2013 David Goulet <dgoulet@efficios.com>
+ * Copyright (C) 2015 Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
  *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License, version 2 only, as
- * published by the Free Software Foundation.
+ * SPDX-License-Identifier: GPL-2.0-only
  *
- * This program is distributed in the hope that it will be useful, but WITHOUT
- * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
- * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
- * more details.
- *
- * You should have received a copy of the GNU General Public License along with
- * this program; if not, write to the Free Software Foundation, Inc., 51
- * Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
  */
 
-#define _GNU_SOURCE
+#define _LGPL_SOURCE
 #include <assert.h>
-#include <string.h>
 
 #include <common/common.h>
 #include <common/sessiond-comm/relayd.h>
 
-#include "cmd-generic.h"
+#include <common/compat/endian.h>
+#include <common/compat/string.h>
+#include <lttng/constant.h>
+
+#include "cmd-2-4.h"
 #include "lttng-relayd.h"
 
-int cmd_create_session_2_4(struct relay_command *cmd,
-               struct relay_session *session)
+int cmd_create_session_2_4(const struct lttng_buffer_view *payload,
+               char *session_name, char *hostname,
+               uint32_t *live_timer, bool *snapshot)
 {
        int ret;
        struct lttcomm_relayd_create_session_2_4 session_info;
+       size_t len;
+
+       if (payload->size < sizeof(session_info)) {
+               ERR("Unexpected payload size in \"cmd_create_session_2_4\": expected >= %zu bytes, got %zu bytes",
+                               sizeof(session_info), payload->size);
+               ret = -1;
+               goto error;
+       }
+       memcpy(&session_info, payload->data, sizeof(session_info));
 
-       assert(cmd);
-       assert(session);
+       len = lttng_strnlen(session_info.session_name, sizeof(session_info.session_name));
+       /* Ensure that NULL-terminated and fits in local filename length. */
+       if (len == sizeof(session_info.session_name) || len >= LTTNG_NAME_MAX) {
+               ret = -ENAMETOOLONG;
+               ERR("Session name too long");
+               goto error;
+       } else if (len == 0) {
+               ret = -EINVAL;
+               ERR("Session name can't be of length 0");
+               goto error;
+       }
+       strncpy(session_name, session_info.session_name, LTTNG_NAME_MAX);
 
-       ret = cmd_recv(cmd->sock, &session_info, sizeof(session_info));
-       if (ret < 0) {
-               ERR("Unable to recv session info version 2.4");
+       len = lttng_strnlen(session_info.hostname, sizeof(session_info.hostname));
+       if (len == sizeof(session_info.hostname) || len >= LTTNG_HOST_NAME_MAX) {
+               ret = -ENAMETOOLONG;
+               ERR("Session name too long");
                goto error;
        }
+       strncpy(hostname, session_info.hostname, LTTNG_HOST_NAME_MAX);
 
-       strncpy(session->session_name, session_info.session_name,
-                       sizeof(session->session_name));
-       strncpy(session->hostname, session_info.hostname,
-                       sizeof(session->hostname));
-       session->live_timer = be32toh(session_info.live_timer);
-       session->snapshot = be32toh(session_info.snapshot);
+       *live_timer = be32toh(session_info.live_timer);
+       *snapshot = be32toh(session_info.snapshot);
 
        ret = 0;