projects
/
lttng-tools.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
clang-tidy: add a subset of cppcoreguidelines and other style checks
[lttng-tools.git]
/
src
/
common
/
pthread-lock.hpp
diff --git
a/src/common/pthread-lock.hpp
b/src/common/pthread-lock.hpp
index 35fde097cadbf92ea6f6744bc236272c2120c5e7..d772187172f2987409190a3f3f1b8b3f07e03373 100644
(file)
--- a/
src/common/pthread-lock.hpp
+++ b/
src/common/pthread-lock.hpp
@@
-26,13
+26,17
@@
namespace details {
*/
class mutex {
public:
*/
class mutex {
public:
-
mutex(pthread_mutex_t& mutex_p) : _mutex{mutex_p
}
+
explicit mutex(pthread_mutex_t& mutex_p) : _mutex{ mutex_p
}
{
}
{
}
+ ~mutex() = default;
+
/* "Not copyable" and "not moveable" Mutex requirements. */
/* "Not copyable" and "not moveable" Mutex requirements. */
- mutex(mutex const &) = delete;
- mutex &operator=(mutex const &) = delete;
+ mutex(mutex const&) = delete;
+ mutex(mutex&&) = delete;
+ mutex& operator=(mutex const&) = delete;
+ mutex& operator=(mutex&&) = delete;
void lock()
{
void lock()
{
@@
-57,7
+61,10
@@
public:
void unlock()
{
if (pthread_mutex_unlock(&_mutex) != 0) {
void unlock()
{
if (pthread_mutex_unlock(&_mutex) != 0) {
- LTTNG_THROW_POSIX("Failed to unlock mutex", errno);
+ /*
+ * Unlock cannot throw as it is called as part of lock_guard's destructor.
+ */
+ abort();
}
}
}
}
@@
-73,11
+80,16
@@
private:
*/
class lock_guard {
public:
*/
class lock_guard {
public:
-
lock_guard(pthread_mutex_t& mutex) : _mutex{mutex
}, _guard(_mutex)
+
explicit lock_guard(pthread_mutex_t& mutex) : _mutex{ mutex
}, _guard(_mutex)
{
}
{
}
- lock_guard(const lock_guard &) = delete;
+ ~lock_guard() = default;
+
+ lock_guard(const lock_guard&) = delete;
+ lock_guard(lock_guard&&) = delete;
+ lock_guard& operator=(const lock_guard&) = delete;
+ lock_guard& operator=(lock_guard&&) = delete;
private:
details::mutex _mutex;
private:
details::mutex _mutex;
This page took
0.024161 seconds
and
4
git commands to generate.