projects
/
lttng-tools.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Fix: sessiond: rotation trigger leak
[lttng-tools.git]
/
src
/
bin
/
lttng-sessiond
/
rotation-thread.c
diff --git
a/src/bin/lttng-sessiond/rotation-thread.c
b/src/bin/lttng-sessiond/rotation-thread.c
index 5e6042e85671b88ad0b12dd5ea848b51b84529c2..b6bf2def32d2314829356feed287f99b8ed98068 100644
(file)
--- a/
src/bin/lttng-sessiond/rotation-thread.c
+++ b/
src/bin/lttng-sessiond/rotation-thread.c
@@
-27,6
+27,7
@@
#include <lttng/rotate-internal.h>
#include <lttng/location-internal.h>
#include <lttng/condition/condition-internal.h>
#include <lttng/rotate-internal.h>
#include <lttng/location-internal.h>
#include <lttng/condition/condition-internal.h>
+#include <lttng/notification/notification-internal.h>
#include "rotation-thread.h"
#include "lttng-sessiond.h"
#include "rotation-thread.h"
#include "lttng-sessiond.h"
@@
-622,8
+623,7
@@
end:
}
static
}
static
-int handle_condition(const struct lttng_condition *condition,
- const struct lttng_evaluation *evaluation,
+int handle_condition(const struct lttng_notification *notification,
struct notification_thread_handle *notification_thread_handle)
{
int ret = 0;
struct notification_thread_handle *notification_thread_handle)
{
int ret = 0;
@@
-633,6
+633,10
@@
int handle_condition(const struct lttng_condition *condition,
enum lttng_evaluation_status evaluation_status;
uint64_t consumed;
struct ltt_session *session;
enum lttng_evaluation_status evaluation_status;
uint64_t consumed;
struct ltt_session *session;
+ const struct lttng_condition *condition =
+ lttng_notification_get_const_condition(notification);
+ const struct lttng_evaluation *evaluation =
+ lttng_notification_get_const_evaluation(notification);
condition_type = lttng_condition_get_type(condition);
condition_type = lttng_condition_get_type(condition);
@@
-673,6
+677,13
@@
int handle_condition(const struct lttng_condition *condition,
}
session_lock(session);
}
session_lock(session);
+ if (!lttng_trigger_is_equal(session->rotate_trigger,
+ lttng_notification_get_const_trigger(notification))) {
+ /* Notification does not originate from our rotation trigger. */
+ ret = 0;
+ goto end_unlock;
+ }
+
ret = unsubscribe_session_consumed_size_rotation(session,
notification_thread_handle);
if (ret) {
ret = unsubscribe_session_consumed_size_rotation(session,
notification_thread_handle);
if (ret) {
@@
-715,8
+726,6
@@
int handle_notification_channel(int fd,
bool notification_pending;
struct lttng_notification *notification = NULL;
enum lttng_notification_channel_status status;
bool notification_pending;
struct lttng_notification *notification = NULL;
enum lttng_notification_channel_status status;
- const struct lttng_evaluation *notification_evaluation;
- const struct lttng_condition *notification_condition;
status = lttng_notification_channel_has_pending_notification(
rotate_notification_channel, ¬ification_pending);
status = lttng_notification_channel_has_pending_notification(
rotate_notification_channel, ¬ification_pending);
@@
-754,10
+763,7
@@
int handle_notification_channel(int fd,
goto end;
}
goto end;
}
- notification_condition = lttng_notification_get_condition(notification);
- notification_evaluation = lttng_notification_get_evaluation(notification);
-
- ret = handle_condition(notification_condition, notification_evaluation,
+ ret = handle_condition(notification,
handle->notification_thread_handle);
end:
handle->notification_thread_handle);
end:
This page took
0.024325 seconds
and
4
git commands to generate.