UST markers: fix structure alignment for recent gcc
[ust.git] / include / ust / marker.h
index 641df8fd6f9460d3ff667479d58b991604f504d7..a1f55b0b76338f6db9fa7d4c7309b3f7f6ba862c 100644 (file)
 #define _UST_MARKER_H
 
 #include <stdarg.h>
-//ust// #include <linux/types.h>
 #include <ust/immediate.h>
-//ust// #include <linux/ltt-channels.h>
-#include <ust/kernelcompat.h>
-#include <kcompat/list.h>
+#include <ust/core.h>
+#include <urcu/list.h>
 #include <ust/processor.h>
+#include <ust/kcompat/kcompat.h>
+#include <ust/kcompat/stringify.h>
 
 #include <bits/wordsize.h>
 
-//ust// struct module;
-//ust// struct task_struct;
 struct marker;
 
-/* To stringify the expansion of a define */
-#define XSTR(d) STR(d)
-#define STR(s) #s
-
 /**
  * marker_probe_func - Type of a marker probe function
  * @mdata: marker data
@@ -70,7 +64,7 @@ struct marker {
        const char *format;     /* Marker format string, describing the
                                 * variable argument list.
                                 */
-       DEFINE_IMV(char, state);/* Immediate value state. */
+       DEFINE_IMV(char, state);/* Immediate value state. */
        char ptype;             /* probe type : 0 : single, 1 : multi */
                                /* Probe wrapper */
        u16 channel_id;         /* Numeric channel identifier, dynamic */
@@ -81,61 +75,85 @@ struct marker {
        const char *tp_name;    /* Optional tracepoint name */
        void *tp_cb;            /* Optional tracepoint callback */
        void *location;         /* Address of marker in code */
-} __attribute__((aligned(8)));
+} __attribute__((aligned(128)));/*
+                                * Aligned on 128 bytes because it is
+                                * globally visible and gcc happily
+                                * align these on the structure size.
+                                */
 
-#define CONFIG_MARKERS
-#ifdef CONFIG_MARKERS
+#define GET_MARKER(channel, name)      (__mark_##channel##_##name)
 
-#define _DEFINE_MARKER(channel, name, tp_name_str, tp_cb, format, unique)                      \
+#define _DEFINE_MARKER(channel, name, tp_name_str, tp_cb, format, unique, m)                   \
                struct registers regs;                                                          \
-               /* make asm label visible to C */                                               \
-               extern struct marker make_mark_struct_name(channel, name, unique);              \
                                                                                                \
                /* This next asm has to be a basic inline asm (no input/output/clobber),        \
-                  because it must not require %-sign escaping, as we most certainly            \
-                  have some %-signs in the format string. */                                   \
-               asm volatile (                                                                  \
-                    ".section __markers_strings,\"aw\",@progbits\n\t"                          \
-                    "__mstrtab_" XSTR(channel) "_" XSTR(name) "_channel_" XSTR(unique) ":\n\t" \
-                    ".string \"" XSTR(channel) "\"\n\t"                                        \
-                    "__mstrtab_" XSTR(channel) "_" XSTR(name) "_name_" XSTR(unique) ":\n\t"    \
-                    ".string \"" XSTR(name) "\"\n\t"                                           \
-                    "__mstrtab_" XSTR(channel) "_" XSTR(name) "_format_" XSTR(unique) ":\n\t"  \
-                    ".string " "\"" format "\"" "\n\t"                                         \
-                    ".previous\n\t"                                                            \
-                    ".section __markers,\"aw\",@progbits\n\t"                                  \
-                    ".align 8\n\t"                                                             \
-                    XSTR(make_mark_struct_name(channel, name, unique)) ":\n\t"                 \
-                    ".global " XSTR(make_mark_struct_name(channel, name, unique)) "\n\t"       \
-                    ".local " XSTR(make_mark_struct_name(channel, name, unique)) "\n\t"        \
-                    _ASM_PTR "(__mstrtab_" XSTR(channel) "_" XSTR(name) "_channel_" XSTR(unique) ")\n\t" /* channel string */ \
-                    _ASM_PTR "(__mstrtab_" XSTR(channel) "_" XSTR(name) "_name_" XSTR(unique) ")\n\t" /* name string */ \
-                    _ASM_PTR "(__mstrtab_" XSTR(channel) "_" XSTR(name) "_format_" XSTR(unique) ")\n\t" /* format string */ \
-                    ".byte 0\n\t" /* state imv */                                              \
-                    ".byte 0\n\t" /* ptype */                                                  \
-                    ".word 0\n\t" /* channel_id */                                             \
-                    ".word 0\n\t" /* event_id */                                               \
-                    ".align " XSTR(__WORDSIZE) " / 8\n\t" /* alignment */                      \
-                    _ASM_PTR "(marker_probe_cb)\n\t" /* call */                                \
-                    _ASM_PTR "(__mark_empty_function)\n\t" /* marker_probe_closure single.field1 */ \
-                    _ASM_PTR "0\n\t" /* marker_probe_closure single.field2 */                  \
-                    _ASM_PTR "0\n\t" /* marker_probe_closure *multi */                         \
-                    _ASM_PTR "0\n\t" /* tp_name */                                             \
-                    _ASM_PTR "0\n\t" /* tp_cb */                                               \
-                    "__mark_location_" XSTR(unique) ":\n\t"                                    \
-                    _ASM_PTR "(1f)\n\t" /* location */                                         \
-                    ".previous\n\t"                                                            \
-                    "1:\n\t"                                                                   \
+                * because it must not require %-sign escaping, as we most certainly            \
+                * have some %-signs in the format string.                                      \
+                */                                                                             \
+               asm volatile (                                                                  \
+                       /* We only define these symbols if they have not yet been defined. Indeed, \
+                        * if two markers with the same channel/name are on the same line, they \
+                        * will try to create the same symbols, resulting in a conflict. This   \
+                        * is not unusual as it can be the result of function inlining.         \
+                        */                                                                     \
+                       ".ifndef __mstrtab_" __stringify(channel) "_" __stringify(name) "_channel_" __stringify(unique) "\n\t"  \
+                       /*".section __markers_strings\n\t"*/                                    \
+                       ".section __markers_strings,\"aw\",@progbits\n\t"                               \
+                       "__mstrtab_" __stringify(channel) "_" __stringify(name) "_channel_" __stringify(unique) ":\n\t" \
+                       ".string \"" __stringify(channel) "\"\n\t"                                      \
+                       "__mstrtab_" __stringify(channel) "_" __stringify(name) "_name_" __stringify(unique) ":\n\t"    \
+                       ".string \"" __stringify(name) "\"\n\t"                                         \
+                       "__mstrtab_" __stringify(channel) "_" __stringify(name) "_format_" __stringify(unique) ":\n\t"  \
+                       ".string " "\"" format "\"" "\n\t"                                              \
+                       ".previous\n\t"                                                         \
+                       ".endif\n\t"                                                            \
                );                                                                              \
+               asm volatile (                                                                  \
+                       /*".section __markers\n\t"*/ \
+                       ".section __markers,\"aw\",@progbits\n\t"                                       \
+                       ".balign 8\n\t"                                                         \
+                       "2:\n\t" \
+                       _ASM_PTR "(__mstrtab_" __stringify(channel) "_" __stringify(name) "_channel_" __stringify(unique) ")\n\t" /* channel string */ \
+                       _ASM_PTR "(__mstrtab_" __stringify(channel) "_" __stringify(name) "_name_" __stringify(unique) ")\n\t" /* name string */ \
+                       _ASM_PTR "(__mstrtab_" __stringify(channel) "_" __stringify(name) "_format_" __stringify(unique) ")\n\t" /* format string */ \
+                       ".byte 0\n\t" /* state imv */                                           \
+                       ".byte 0\n\t" /* ptype */                                                       \
+                       ".word 0\n\t" /* channel_id */                                          \
+                       ".word 0\n\t" /* event_id */                                            \
+                       ".balign " __stringify(__WORDSIZE) " / 8\n\t" /* alignment */                   \
+                       _ASM_PTR "(marker_probe_cb)\n\t" /* call */                             \
+                       _ASM_PTR "(__mark_empty_function)\n\t" /* marker_probe_closure single.field1 */ \
+                       _ASM_PTR "0\n\t" /* marker_probe_closure single.field2 */                       \
+                       _ASM_PTR "0\n\t" /* marker_probe_closure *multi */                              \
+                       _ASM_PTR "0\n\t" /* tp_name */                                          \
+                       _ASM_PTR "0\n\t" /* tp_cb */                                            \
+                       _ASM_PTR "(1f)\n\t" /* location */                                              \
+                       ".previous\n\t"                                                         \
+                       "1:\n\t"                                                                        \
+                       ARCH_COPY_ADDR("%[outptr]")                                             \
+               : [outptr] "=r" (m) );                                                          \
                                                                                                \
                save_registers(&regs)
 
 
-#define DEFINE_MARKER(channel, name, format, unique)                           \
-               _DEFINE_MARKER(channel, name, NULL, NULL, format, unique)
+#define DEFINE_MARKER(channel, name, format, unique, m)                                \
+               _DEFINE_MARKER(channel, name, NULL, NULL, format, unique, m)
 
-#define DEFINE_MARKER_TP(channel, name, tp_name, tp_cb, format, unique)                \
-               _DEFINE_MARKER(channel, name, #tp_name, tp_cb, format, unique)
+#define DEFINE_MARKER_TP(channel, name, tp_name, tp_cb, format)                \
+               _DEFINE_MARKER_TP(channel, name, #tp_name, tp_cb, format)
+
+#define _DEFINE_MARKER_TP(channel, name, tp_name_str, tp_cb, format) \
+               static const char __mstrtab_##channel##_##name[]        \
+               __attribute__((section("__markers_strings")))           \
+               = #channel "\0" #name "\0" format;                      \
+               static struct marker GET_MARKER(channel, name)          \
+               __attribute__((section("__markers"), aligned(128))) =   \
+               { __mstrtab_##channel##_##name,                         \
+                       &__mstrtab_##channel##_##name[sizeof(#channel)],        \
+                       &__mstrtab_##channel##_##name[sizeof(#channel) + sizeof(#name)],                \
+                       0, 0, 0, 0, marker_probe_cb,                            \
+                       { __mark_empty_function, NULL},                 \
+                       NULL, tp_name_str, tp_cb }
 
 /*
  * Make sure the alignment of the structure in the __markers section will
@@ -147,31 +165,20 @@ struct marker {
  * If generic is false, immediate values are used.
  */
 
-#define make_mark_struct_name(channel, name, unique) \
-       make_mark_struct_name2(channel, name, unique)
-
-#define make_mark_struct_name2(channel, name, unique) \
-       __mark_struct_##channel##_##name##_##unique
-
 #define __trace_mark(generic, channel, name, call_private, format, args...) \
        __trace_mark_counter(generic, channel, name, __LINE__, call_private, format, ## args)
 
 #define __trace_mark_counter(generic, channel, name, unique, call_private, format, args...) \
        do {                                                            \
-               DEFINE_MARKER(channel, name, format, unique);                   \
+               struct marker *m;                                       \
+               DEFINE_MARKER(channel, name, format, unique, m);                        \
                __mark_check_format(format, ## args);                   \
                if (!generic) {                                         \
-                       if (unlikely(imv_read(                          \
-                                       make_mark_struct_name(channel, name, unique).state))) \
-                               (make_mark_struct_name(channel, name, unique).call)     \
-                                       (&make_mark_struct_name(channel, name, unique), \
-                                       call_private, &regs, ## args);          \
+                       if (unlikely(imv_read(m->state))) \
+                               (m->call)(m, call_private, &regs, ## args);             \
                } else {                                                \
-                       if (unlikely(_imv_read(                         \
-                                       make_mark_struct_name(channel, name, unique).state))) \
-                               (make_mark_struct_name(channel, name, unique).call)     \
-                                       (&make_mark_struct_name(channel, name, unique), \
-                                       call_private, &regs, ## args);          \
+                       if (unlikely(_imv_read(m->state))) \
+                               (m->call)(m, call_private, &regs, ## args);             \
                }                                                       \
        } while (0)
 
@@ -180,40 +187,20 @@ struct marker {
 
 #define __trace_mark_tp_counter(channel, name, unique, call_private, tp_name, tp_cb, format, args...) \
        do {                                                            \
+               struct registers regs;                                                          \
                void __check_tp_type(void)                              \
                {                                                       \
-                       register_trace_##tp_name(tp_cb);                \
+                       register_trace_##tp_name(tp_cb, call_private);          \
                }                                                       \
-               DEFINE_MARKER_TP(channel, name, tp_name, tp_cb, format, unique);\
+               DEFINE_MARKER_TP(channel, name, tp_name, tp_cb, format);\
                __mark_check_format(format, ## args);                   \
-               (*__mark_##channel##_##name.call)(&__mark_##channel##_##name, \
+               (*GET_MARKER(channel, name).call)(&GET_MARKER(channel, name), \
                        call_private, &regs, ## args);                          \
        } while (0)
 
 extern void marker_update_probe_range(struct marker *begin,
        struct marker *end);
 
-#define GET_MARKER(channel, name)      (__mark_##channel##_##name)
-
-#else /* !CONFIG_MARKERS */
-#define DEFINE_MARKER(channel, name, tp_name, tp_cb, format)
-#define __trace_mark(generic, channel, name, call_private, format, args...) \
-               __mark_check_format(format, ## args)
-#define __trace_mark_tp(channel, name, call_private, tp_name, tp_cb,   \
-               format, args...)                                        \
-       do {                                                            \
-               void __check_tp_type(void)                              \
-               {                                                       \
-                       register_trace_##tp_name(tp_cb);                \
-               }                                                       \
-               __mark_check_format(format, ## args);                   \
-       } while (0)
-static inline void marker_update_probe_range(struct marker *begin,
-       struct marker *end)
-{ }
-#define GET_MARKER(channel, name)
-#endif /* CONFIG_MARKERS */
-
 /**
  * trace_mark - Marker using code patching
  * @channel: marker channel (where to send the data), not quoted.
@@ -347,10 +334,11 @@ struct lib {
        struct marker_addr *markers_addr_start;
 #endif
        int markers_count;
-       struct list_head list;
+       struct cds_list_head list;
 };
 
 extern int marker_register_lib(struct marker *markers_start, int markers_count);
+extern int marker_unregister_lib(struct marker *markers_start);
 
 #define MARKER_LIB                                                     \
        extern struct marker __start___markers[] __attribute__((weak, visibility("hidden"))); \
@@ -359,6 +347,11 @@ extern int marker_register_lib(struct marker *markers_start, int markers_count);
        static void __attribute__((constructor)) __markers__init(void)  \
        {                                                               \
                marker_register_lib(__start___markers, (((long)__stop___markers)-((long)__start___markers))/sizeof(struct marker)); \
+       } \
+       \
+       static void __attribute__((destructor)) __markers__destroy(void)        \
+       {                                                               \
+               marker_unregister_lib(__start___markers); \
        }
 
 extern void marker_set_new_marker_cb(void (*cb)(struct marker *));
This page took 0.025779 seconds and 4 git commands to generate.