ust.git
7 years agoUpdate version to 0.16 master v0.16
Mathieu Desnoyers [Thu, 15 Dec 2011 22:11:43 +0000 (17:11 -0500)] 
Update version to 0.16

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoUse caa_unlikely, depend on liburcu >= 0.6.6
Mathieu Desnoyers [Thu, 15 Dec 2011 22:10:50 +0000 (17:10 -0500)] 
Use caa_unlikely, depend on liburcu >= 0.6.6

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agousttrace: allow spaces in command-line arguments
Stefan Hajnoczi [Wed, 16 Nov 2011 12:17:21 +0000 (07:17 -0500)] 
usttrace: allow spaces in command-line arguments

The usttrace uses $*, which expands arguments without preserving their
boundaries.  This causes arguments that include spaces to be mangled:

[0] "echo"
[1] "hello world"

becomes:

[0] "echo"
[1] "hello"
[2] "world"

Use "$@" instead so that argument boundaries are preserved.

Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoFix tracepoint test with deprecated API
Yannick Brosseau [Mon, 17 Oct 2011 15:00:20 +0000 (11:00 -0400)] 
Fix tracepoint test with deprecated API

Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
7 years agoAdd powerpc64 host_cpu to configure.ac
Matthew McClintock [Thu, 29 Sep 2011 20:12:53 +0000 (16:12 -0400)] 
Add powerpc64 host_cpu to configure.ac

Seems like autoconf uses powerpc64 as our host cpu type, this
patch is to fix build issues in openembedded/yocto targets

Signed-off-by: Matthew McClintock <msm@freescale.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoMark __tp_cb_data as possibly unused for backward compat API
Mathieu Desnoyers [Tue, 20 Sep 2011 16:21:40 +0000 (12:21 -0400)] 
Mark __tp_cb_data as possibly unused for backward compat API

Thanks to Lluís Vilanova for proposing this.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoFix git URL
Yannick Brosseau [Mon, 25 Jul 2011 18:51:49 +0000 (14:51 -0400)] 
Fix git URL

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoUpdate version to 0.15 v0.15
Mathieu Desnoyers [Fri, 15 Jul 2011 18:52:33 +0000 (14:52 -0400)] 
Update version to 0.15

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoAdd backward compatibility for tracepoints (qemu-kvm is using them)
Mathieu Desnoyers [Fri, 15 Jul 2011 18:44:09 +0000 (14:44 -0400)] 
Add backward compatibility for tracepoints (qemu-kvm is using them)

Don't break compatibility needlessly before UST 2.0.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoFix compilation with uclibc
Mathieu Desnoyers [Mon, 13 Jun 2011 14:24:46 +0000 (10:24 -0400)] 
Fix compilation with uclibc

Reported-by: Khem Raj <raj.khem@gmail.com>
Reported-by: Dexuan Cui <dexuan.cui@intel.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoRemove execinfo.h include
Mathieu Desnoyers [Mon, 13 Jun 2011 14:19:46 +0000 (10:19 -0400)] 
Remove execinfo.h include

Not required, and breaks uclibc build.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoUpdate changelog and version to UST 0.14 v0.14
Mathieu Desnoyers [Sun, 12 Jun 2011 16:19:41 +0000 (12:19 -0400)] 
Update changelog and version to UST 0.14

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoUpdate info page for 0.14 API
Mathieu Desnoyers [Sun, 12 Jun 2011 16:19:26 +0000 (12:19 -0400)] 
Update info page for 0.14 API

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoDisable exit fast test (known issue)
Mathieu Desnoyers [Fri, 10 Jun 2011 22:40:02 +0000 (18:40 -0400)] 
Disable exit fast test (known issue)

Disable this test before the release, as we are working on a solution
that involves redesign of the way libust is controlled (synchronization
with a lttng-tools session daemon). We don't want to flood testers with
known issues.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoUpdate to urcu/ref.h and urcu/uatomic.h
Mathieu Desnoyers [Fri, 10 Jun 2011 22:21:21 +0000 (18:21 -0400)] 
Update to urcu/ref.h and urcu/uatomic.h

liburcu 0.6 is changing the name of these two headers.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoUpdate dependency to liburcu 0.6
Mathieu Desnoyers [Thu, 9 Jun 2011 16:52:45 +0000 (12:52 -0400)] 
Update dependency to liburcu 0.6

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoUpdate liburcu version check
Mathieu Desnoyers [Thu, 9 Jun 2011 15:27:11 +0000 (11:27 -0400)] 
Update liburcu version check

liburcu symbols have changed (_bp suffix added for the -bp flavor used
by UST), and we now depend on urcu 0.5.5 for struct rcu_head definition.
Therefore, check for synchronize_rcu_bp and call_rcu_bp.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoUpdate following liburcu changes
Mathieu Desnoyers [Thu, 9 Jun 2011 00:42:46 +0000 (20:42 -0400)] 
Update following liburcu changes

Addition of call_rcu in liburcu deprecates the simple.h kcompat header.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoAdd a version.h header
Yannick Brosseau [Wed, 1 Jun 2011 15:06:32 +0000 (11:06 -0400)] 
Add a version.h header

It contains the major and minor version numbers

[ edit: coding style fixes by Mathieu Desnoyers ]

Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoAdd pkg-config file generation
Yannick Brosseau [Wed, 1 Jun 2011 15:01:16 +0000 (11:01 -0400)] 
Add pkg-config file generation

Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoUpdate note in buffer.c
Mathieu Desnoyers [Fri, 20 May 2011 20:33:52 +0000 (16:33 -0400)] 
Update note in buffer.c

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoRemove installed headers, cleanup header names
Mathieu Desnoyers [Fri, 20 May 2011 20:11:13 +0000 (16:11 -0400)] 
Remove installed headers, cleanup header names

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoFix make check includes
Mathieu Desnoyers [Fri, 20 May 2011 19:29:42 +0000 (15:29 -0400)] 
Fix make check includes

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoCleanup leftover UST comments, add comments about current implementation limitations
Mathieu Desnoyers [Fri, 20 May 2011 17:58:06 +0000 (13:58 -0400)] 
Cleanup leftover UST comments, add comments about current implementation limitations

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoTRACEPOINT_EVENT: standardize locking wrt tracepoints and markers
Mathieu Desnoyers [Fri, 20 May 2011 17:22:08 +0000 (13:22 -0400)] 
TRACEPOINT_EVENT: standardize locking wrt tracepoints and markers

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoTracepoints and markers: cleanup init, add missing mutex lock/unlock
Mathieu Desnoyers [Fri, 20 May 2011 17:11:42 +0000 (13:11 -0400)] 
Tracepoints and markers: cleanup init, add missing mutex lock/unlock

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoMarkers: sync from LTTng 0.249 marker code
Mathieu Desnoyers [Thu, 19 May 2011 22:29:38 +0000 (18:29 -0400)] 
Markers: sync from LTTng 0.249 marker code

- Add missing mutexes.
- Cleanup RCU usage.
- Remove unused code.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoPrivatize headers
Mathieu Desnoyers [Thu, 19 May 2011 21:03:11 +0000 (17:03 -0400)] 
Privatize headers

Remove most installed headers, which should be internal. The header
kcompat (kernel-style compatibility header) only makes sense within the
UST package: this should never be exported, nor be included into
instrumented applications.

Move the type-serializer header back into libust/. It is so internal it
does not even belong to include/ust/.

Standardize all the installed headers on non-kcompat style: use uint64_t
instead of u64 for types, open-code likely/unlikely.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoAdd Maintainer and Mailing list contact information to README
Mathieu Desnoyers [Thu, 19 May 2011 19:49:37 +0000 (15:49 -0400)] 
Add Maintainer and Mailing list contact information to README

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoChange libtap.so to a local static library which is not installed
Yannick Brosseau [Thu, 19 May 2011 19:39:29 +0000 (15:39 -0400)] 
Change libtap.so to a local static library which is not installed

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoPrivatize part of marker.h, and type-serializer.h
Mathieu Desnoyers [Thu, 19 May 2011 16:02:19 +0000 (12:02 -0400)] 
Privatize part of marker.h, and type-serializer.h

The current interface we publish is ust_marker(), tracepoint() and
TRACEPOINT_EVENT() (and associated _NOARGS, CLASS, INSTANCE and
TRACEPOINT_CREATE_PROBES). Besides that, consider any lower-level API
showing the UST internals as, well, internal.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoTracepoint and TRACEPOINT_EVENT API cleanup
Mathieu Desnoyers [Thu, 19 May 2011 15:29:57 +0000 (11:29 -0400)] 
Tracepoint and TRACEPOINT_EVENT API cleanup

We want to move towards a TRACEPOINT_EVENT-based API only, so start
cleaning up right now.

Prefix with _ or __ all members that are internal to UST. Move all the
non-exported API members (that don't need to be around in program
inclusion) to tracepoint-internal.h (which is not meant to be installed
on the system).

Unit tests can still use the internal API members for now, but should
gradually move to use TRACEPOINT_EVENT as we start implementing the
FIELDS() declaration.

TRACEPOINT_EVENT is changed from the kernel incarnation (TRACE_EVENT):
we take only 3 arguments: proto, args and fields. The "fields" describe
the event layout _and_ targets the data source.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoMark old trace_mark API deprecated (gcc attribute)
Mathieu Desnoyers [Thu, 19 May 2011 13:31:38 +0000 (09:31 -0400)] 
Mark old trace_mark API deprecated (gcc attribute)

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoversion update to 0.13 v0.13
Nils Carlson [Thu, 19 May 2011 07:32:10 +0000 (09:32 +0200)] 
version update to 0.13

8 years agoChangeLog updates for 0.13 v2
Nils Carlson [Wed, 18 May 2011 20:00:59 +0000 (22:00 +0200)] 
ChangeLog updates for 0.13 v2

8 years agoadd missing usterr_signal_safe.h to makefile
Nils Carlson [Thu, 19 May 2011 07:43:16 +0000 (09:43 +0200)] 
add missing usterr_signal_safe.h to makefile

Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
8 years agoNew fast-exit test-case
Nils Carlson [Tue, 17 May 2011 13:16:47 +0000 (15:16 +0200)] 
New fast-exit test-case

A fast-exit test-case that just writes one marker and exits,
tests that the consumer daemon maps the buffers before the
program exits. Exiting is tested both by normal return
and by commiting suicide (SIGKILL to self).

Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoMake libustctl list only online pids v3
Nils Carlson [Mon, 16 May 2011 13:57:15 +0000 (15:57 +0200)] 
Make libustctl list only online pids v3

Changes since v2:
Botox.

Changes since v1:
Cosmetic surgery at a european cost

Previously libustctl would list all pids. This patch changes this
so only online pids are listed. This is done by appending on each
socket name the mtime from the proc/<pid> directory. This way a
socket can be checked to see if the appended mtime matches the
mtime of the proc dir for the current pid, thus allowing us to
distinguish between old and new socket files.

Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agochange runtests GPL version
Nils Carlson [Fri, 6 May 2011 12:32:54 +0000 (14:32 +0200)] 
change runtests GPL version

Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
8 years agoarmv5 archs require write alignment
Jason Wessel [Wed, 4 May 2011 19:35:20 +0000 (15:35 -0400)] 
armv5 archs require write alignment

Reads and writes to unsigned int 32 bit numbers must be address
aligned or the l2 cache can return junk in the high order 16 bits on
reads.

This patch activates the original work done for alignment in ltt for
the UST code.  The config.ac changes will isolate the use of alignment
to the known arch type with the problem.

Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoOnly ignore the top config.h.in
Jason Wessel [Wed, 4 May 2011 19:32:59 +0000 (15:32 -0400)] 
Only ignore the top config.h.in

Only he top config.h.in is autogenerated the include/ust/config.h.in
is a source controled file.

Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoadd mips support
Jason Wessel [Tue, 26 Apr 2011 21:55:55 +0000 (23:55 +0200)] 
add mips support

The recent changes to UST make it trivial to add MIPS support.

The trick for MIPS is that there are many different library formats
and the gcc 4.x compiler will correctly choose the default one so long
as the libust.ldscript.in does not not make a reference to the library
format.

Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
8 years agosupport busybox for manual trace tests
Jason Wessel [Wed, 27 Apr 2011 20:22:16 +0000 (22:22 +0200)] 
support busybox for manual trace tests

The busybox version of find does not support using -L, and it does not
appear to be needed in order to pass the test.  In the interest of
being able to run internal UST tests on a busybox based rootfs,
appropriately detect if -L is available as an argument to find and use
it when it is available.

Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
8 years agoust-consumerd: fix exit race log corruption
Jason Wessel [Wed, 27 Apr 2011 20:22:15 +0000 (22:22 +0200)] 
ust-consumerd: fix exit race log corruption

In the following scenario on an SMP system the ust-consumerd can end
up not properly closing out file handles which leads to log
corruption:
  * usttrace -m -l small_quick_app_lots_of_malloc_and_free
  * The app completes and usttrace sees and sends the SIGTERM to ust-consumerd
  * The ust-consumerd main thread will exit and the _exit() handlers
    kills off the remaining pthreads without everything getting closed out

The solution to the problem is to introduce an active_thread count for
the private ustconsumer_instance.  This counter will be zeroed out
when it is safe to completely shutdown the main thread, which will
subsequently run the _exit() handlers.

Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
8 years agoust-consumerd: fix exit race crashes
Jason Wessel [Wed, 27 Apr 2011 20:22:14 +0000 (22:22 +0200)] 
ust-consumerd: fix exit race crashes

The ust-consumerd gets shutdown by the SIGTERM signal and a number of
places in the ust-consumerd did not properly deal with the case where
a system call returns EINTR in errno as a result of a signal to the
process.  The failure to handle EINTR properly was leading to some
data corruption in the buffer code and causing some random "victim"
crashes in lowlevel.c

The way all the offending functions were tracked down was to
temporarily add an abort() in the SIGTERM signal handler.  Then it was
a matter of looking at what threads were blocked on system calls at
the time outside of the thread that received the signal.

Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
8 years agoMarkers: temporarily remove GDB support
Mathieu Desnoyers [Tue, 26 Apr 2011 21:31:35 +0000 (17:31 -0400)] 
Markers: temporarily remove GDB support

Remove GDB support temporarily, awaiting a better implementation that
does not require so much asm trickery. Imported the kernel LTTng code
back into UST to use C declarations for the marker structures.

The plan is to move to a SDT-based implementation (using variable
number of arguments).

This patch is required to make the MIPS port work. Tested by Jason
Wessel.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Tested-by: Jason Wessel <jason.wessel@windriver.com>
8 years agoTracepoint: make tracepoint ptrs section rw
Mathieu Desnoyers [Tue, 26 Apr 2011 16:18:45 +0000 (12:18 -0400)] 
Tracepoint: make tracepoint ptrs section rw

The pointer section needs to be rw so that the linker can update the
pointers at link-time, thus allowing the code to be compiled with -fPIC.

The previous behavior would cause section flag mismatch, because
TRACEPOINT_LIB declared the ptr with "= NULL", which is not a void *
const, but rather a void *, which forces the element it is assigned to
to become non-const.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoAdd missing string.h include in libustctl_function_tests
Mathieu Desnoyers [Tue, 26 Apr 2011 15:52:31 +0000 (11:52 -0400)] 
Add missing string.h include in libustctl_function_tests

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoMarkers: ust_marker_[A-Z] -> UST_MARKER_[A-Z] cleanup
Mathieu Desnoyers [Mon, 25 Apr 2011 19:02:50 +0000 (15:02 -0400)] 
Markers: ust_marker_[A-Z] -> UST_MARKER_[A-Z] cleanup

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoMarkers: Add MARKER_LIB backward compatibility
Mathieu Desnoyers [Mon, 25 Apr 2011 17:53:18 +0000 (13:53 -0400)] 
Markers: Add MARKER_LIB backward compatibility

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoMarkers: trace_mark should not pass "ust" to ust_mark
Mathieu Desnoyers [Mon, 25 Apr 2011 17:44:46 +0000 (13:44 -0400)] 
Markers: trace_mark should not pass "ust" to ust_mark

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoMarkers: fix compatility trace_mark
Mathieu Desnoyers [Mon, 25 Apr 2011 17:38:52 +0000 (13:38 -0400)] 
Markers: fix compatility trace_mark

When providing no args, we need to paste args with ## args.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoAdd MARK_NOARGS compatibility API, marked for deprecation.
Mathieu Desnoyers [Mon, 25 Apr 2011 17:34:40 +0000 (13:34 -0400)] 
Add MARK_NOARGS compatibility API, marked for deprecation.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoAdd "trace_mark()" compatibility API (progressive deprecation)
Mathieu Desnoyers [Mon, 25 Apr 2011 17:25:41 +0000 (13:25 -0400)] 
Add "trace_mark()" compatibility API (progressive deprecation)

Add back the trace_mark() API for backward compability, tagging it as
being slowly being deprecated.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoUpdate manual
Mathieu Desnoyers [Fri, 22 Apr 2011 18:25:49 +0000 (14:25 -0400)] 
Update manual

Update info manual to reflect the latest instrumentation API changes for
both tracepoints and markers.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoTracepoints: Introduce DEFINE/DECLARE_TRACEPOINT, TRACEPOINT_EVENT...
Mathieu Desnoyers [Fri, 22 Apr 2011 18:22:44 +0000 (14:22 -0400)] 
Tracepoints: Introduce DEFINE/DECLARE_TRACEPOINT, TRACEPOINT_EVENT...

* Instrumentation API change *

Introduce the upcoming "TRACEPOINT_EVENT" API:

TRACEPOINT_EVENT
TRACEPOINT_CREATE_PROBES
TRACEPOINT_EVENT_LIB

And move the current tracepoint declaration/definition to a more
standard name (these will become internal API when we switch to
TRACEPOINT_EVENT):

DEFINE_TRACEPOINT
DECLARE_TRACEPOINT

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoRemove #define _LGPL_SOURCE from public headers
Mathieu Desnoyers [Fri, 22 Apr 2011 17:19:18 +0000 (13:19 -0400)] 
Remove #define _LGPL_SOURCE from public headers

this header can be included by non-LGPL applications. Ensure that
use it.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoMarkers: make __ust_marker_ptrs PIC
Mathieu Desnoyers [Tue, 19 Apr 2011 01:21:31 +0000 (21:21 -0400)] 
Markers: make __ust_marker_ptrs PIC

> As I prepared the 0.12 release for Debian, I noticed that libust.so was
> not PIC:
>
>     $ readelf -d libust/.libs/libust.so.0.0.0 | grep TEXTREL
>     0x0000000000000016 (TEXTREL)            0x0
>
> Since all of the objects in libust are built with -fPIC, I thought
> perhaps there was some assembly added between 0.11 and 0.12 that
> contained text relocations. I bisected the two tags down to the
> offending commit:
>
>     eb5d20c68aaf73661ffc02ba8fea3683c0358702
>
> Within that commit, it seems to be a problem in include/ust/marker.h
> with these lines:
>
> @@ -129,7 +124,12 @@ struct marker {
> [...]
> +                       /*".section __markers_ptrs\n\t"*/ \
> +                       ".section __markers_ptrs,\"a\",@progbits\n\t"                           \
>
> If I make the __markers_ptrs section writable, with:
>
>                         ".section __markers_ptrs,\"aw\"\n\t
>
> TEXTREL goes away and everything seems okay, tests pass. Is this
> a correct solution? I don't understand why the section must be writable
> to avoid relocations, can anyone explain?

Oh.. I think I see. __markers_ptrs contains pointers to another section
that must be populated by the dynamic linker (thus at runtime). If the
section is read-only, the linker cannot update them at load time, so a
relocation table is probably needed.

Reported-by: Jon Bernard <jbernard@debian.org>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoLGPLv2.1 relicensing agreements
Mathieu Desnoyers [Wed, 13 Apr 2011 20:45:38 +0000 (16:45 -0400)] 
LGPLv2.1 relicensing agreements

Steven just stated clearly that he only accepts relicencing to
LGPLv2.1 (not later). So I think we might have been interpreting his
previous acceptance a little too broadly when specifying "LGPLV2.1+".
Change the licensing text to reflect this.

If some of the contributors specifically said they were OK with "or
later", we could add this back upon rechecking their original acceptance
email. The pointers to the original public emails should have been
present in the relicensing file to make our current job easier, but this
is unfortunately not the case.

Also updated the stringify.h, tracepoint.c, marker.c and trace_event.c
files.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoTracepoints: namespace cleanups
Mathieu Desnoyers [Wed, 13 Apr 2011 20:17:57 +0000 (16:17 -0400)] 
Tracepoints: namespace cleanups

All internal symbols, no API change. Enforce "tracepoint_" or "tp_"
prefixes to local symbols, as well as rename struct probes to struct
tracepoint_probes.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoRemove "struct module" from tracepoint.h (unused)
Mathieu Desnoyers [Wed, 13 Apr 2011 20:00:34 +0000 (16:00 -0400)] 
Remove "struct module" from tracepoint.h (unused)

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoRemove immediate values code (non-effective anyway)
Mathieu Desnoyers [Wed, 13 Apr 2011 19:57:39 +0000 (15:57 -0400)] 
Remove immediate values code (non-effective anyway)

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoMarkers: Namespace cleanup, with API change.
Mathieu Desnoyers [Wed, 13 Apr 2011 19:45:48 +0000 (15:45 -0400)] 
Markers: Namespace cleanup, with API change.

** API change: MARK_NOARGS becomes UST_MARKER_NOARGS **

Cleanup the "marker" namespace by using "ust_marker/UST_MARKER".

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoTest empty argument tracepoint
Mathieu Desnoyers [Wed, 13 Apr 2011 18:01:01 +0000 (14:01 -0400)] 
Test empty argument tracepoint

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Acked-by: Nils Carlson <nils.carlson@ericsson.com>
8 years agoTracepoints: add noargs support
Mathieu Desnoyers [Wed, 13 Apr 2011 18:00:21 +0000 (14:00 -0400)] 
Tracepoints: add noargs support

Add support for tracepoints receiving no argument as parameters. Copied
from Linux kernel:

commit 38516ab59fbc5b3bb278cf5e1fe2867c70cff32e
Author: Steven Rostedt <srostedt@redhat.com>
Date:   Tue Apr 20 17:04:50 2010 -0400

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
CC: Nils Carlson <nils.carlson@ericsson.com>
CC: Steven Rostedt <rostedt@goodmis.org>
8 years agoTracepoints: add wrapper tracepoint() macro
Mathieu Desnoyers [Wed, 13 Apr 2011 17:59:16 +0000 (13:59 -0400)] 
Tracepoints: add wrapper tracepoint() macro

** Instrumentation API change **

Moving tracepoints from

trace_name(args)
register_trace_name(...)
unregister_trace_name(...)

to

tracepoint(name, args)
register_tracepoint(name, ...)
unregister_tracepoint(name, ...)

This will allow doing macro tricks at the "tracepoint()" macro expansion
site. This will be useful for integration with SystemTAP probes, which
needs to expand an inline assembly with constraints on the arguments.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
CC: Nils Carlson <nils.carlson@ericsson.com>
CC: Steven Rostedt <srostedt@redhat.com>
CC: Josh Stone <jistone@redhat.com>
8 years agoMarkers: API change: rename trace_mark() to ust_marker()
Mathieu Desnoyers [Wed, 13 Apr 2011 17:46:23 +0000 (13:46 -0400)] 
Markers: API change: rename trace_mark() to ust_marker()

Given that the markers will stay as debug-only "quick and dirty"
tracing interface, make them UST-specific. Make it clear by turning the
API to ust_marker().

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoMerge branch 'master' of ssh://git.lttng.org/home/git/ust
Mathieu Desnoyers [Wed, 13 Apr 2011 17:28:53 +0000 (13:28 -0400)] 
Merge branch 'master' of ssh://git.lttng.org/home/git/ust

8 years agoFix up all use of /dev/stderr for portability to busybox /bin/sh
Jason Wessel [Tue, 12 Apr 2011 19:11:36 +0000 (21:11 +0200)] 
Fix up all use of /dev/stderr for portability to busybox /bin/sh

The typical shell on a small embedded target using busybox does
not have support for /dev/stderr.  A more portable way to send
output to stderr with echo is to redirect stdout to stderr with
1>&2.

In the usttrace script it did something that was effectively
a NOP.  The result of echo "" 2>/dev/stderr is not actually
going to send anything to stderr because the echo is going
to write to stdout.  This case was also fixed.

Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
8 years agoMarkers: remove channel name from trace_mark()
Mathieu Desnoyers [Sun, 10 Apr 2011 22:15:40 +0000 (15:15 -0700)] 
Markers: remove channel name from trace_mark()

*** This is an instrumentation API change ***

Given that UST will gradually move to a scheme where channels are
dynamically associated with markers on a per tracing session basis (and
thus associated dynamically rather than fixed statically), it does not
make sense to specify the "channel name" in addition to the marker name
in the trace_mark() arguments.

API touched:

GET_MARKER()
DEFINE_MARKER()
DEFINE_MARKER_TP()
trace_mark()
_trace_mark()

I'm introducing this API change without changing the underlying
implementation, trying to minimize the impact of API changes by doing
them sooner than later.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoMake only libust and libustconsumer use a signal safe usterr.h
Nils Carlson [Mon, 4 Apr 2011 10:49:56 +0000 (12:49 +0200)] 
Make only libust and libustconsumer use a signal safe usterr.h

Copy usterr.h to usterr_signal_safe.h and rewrite those parts of
usterr.h that depended on libustsnprintf. This removes the dependency
on libustsnprintf from all parts of ust except libust.

Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agolibustctl: cleanup ustctl_get_online_pids functions
Nils Carlson [Fri, 1 Apr 2011 12:38:38 +0000 (14:38 +0200)] 
libustctl: cleanup ustctl_get_online_pids functions

Cleanup the ustctl_get_online_pids functions, checking more errors
and making the allocation strategy sane.

Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
8 years agoMake root able to connect to any traceable app
Nils Carlson [Thu, 31 Mar 2011 08:25:11 +0000 (10:25 +0200)] 
Make root able to connect to any traceable app

Make root able to connect to any traceable app, checking
(geteuid == 0).

Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
8 years agoMake root see all available pids v2
Nils Carlson [Wed, 30 Mar 2011 14:55:38 +0000 (16:55 +0200)] 
Make root see all available pids v2

Changes since v1:
* Fix a whitespace
* Make functions that should be static static

Allow root (geteuid() == 0) to see all pids. This way the super-user
can connect to any program. A step on the way of carefully outlining
what UST does and doesn't.

Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
8 years agoAdd list-pids command to ustctl v2
Nils Carlson [Tue, 29 Mar 2011 13:15:44 +0000 (15:15 +0200)] 
Add list-pids command to ustctl v2

Changes since v1:
* Case pid_t to long

Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
8 years agoRestructure the ustctl_get_online_pids command v2
Nils Carlson [Tue, 29 Mar 2011 13:11:33 +0000 (15:11 +0200)] 
Restructure the ustctl_get_online_pids command v2

Changes since v1:
* Use list length, not the size in bytes
* Fix a possible bug for pid_t in a sscanf
* Use list length in the dir scanning function

Restructure the command to separate the pid gathering.
This will allow a root user to gather pid from multiple user
directories.

Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
8 years agoAdd mode setting to socket directory creation
Nils Carlson [Tue, 29 Mar 2011 09:27:55 +0000 (11:27 +0200)] 
Add mode setting to socket directory creation

Set the mode when creating the personal socket directory,
this way all app sockets are private.

Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
8 years agoMake app socket directories per-user v2
Nils Carlson [Tue, 29 Mar 2011 08:27:46 +0000 (10:27 +0200)] 
Make app socket directories per-user v2

Changes since v1:
* Document memory allocation

Make a separate app socket directories for each user, providing
some basic security and also the possibility of consistent cleanup.

Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
8 years agoRename local variables "m" and "regs" to less conflicting names
Mathieu Desnoyers [Mon, 28 Mar 2011 22:12:29 +0000 (18:12 -0400)] 
Rename local variables "m" and "regs" to less conflicting names

Rename "m" local macro variable to "__marker_counter_ptr".
Rename "regs" local macro variable to "__marker_regs".

Initial report:

The following trivial piece of code will result in corrupt events:

void dump_ackerman_current( int m, int n )
{
    trace_mark( ackerman, current, "m %d n %d", m, n );
}

This is because in ust/marker.h line 173 the definition of the
__trace_mark_counter macro uses a temporary named m (which shadows the
original m). It might be a good idea to use underscore variable names
inside these macros to make naming conflicts less likely.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Reported-by: Paul Wögerer <paul_woegerer@mentor.com>
8 years agolibust: Remove lots of dead code and comments in tracer.c
Nils Carlson [Tue, 15 Mar 2011 14:08:33 +0000 (15:08 +0100)] 
libust: Remove lots of dead code and comments in tracer.c

Remove lots of code that wasn't being called or did nothing
as well as lots of commented code and unnecessary comments.

Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agolibust: New transport mutex v2
Nils Carlson [Tue, 15 Mar 2011 13:17:34 +0000 (14:17 +0100)] 
libust: New transport mutex v2

Changes since v1:
Add a nesting comment

Make the locking around the transport list more intelligent, give
it its own mutex.

Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
8 years agoChangelog and version updates for v0.12 v0.12
Nils Carlson [Tue, 15 Mar 2011 09:49:17 +0000 (10:49 +0100)] 
Changelog and version updates for v0.12

8 years agolibustfork: link against libust
Nils Carlson [Thu, 10 Mar 2011 12:55:27 +0000 (13:55 +0100)] 
libustfork: link against libust

libustfork needs to link against libust as it makes calls into
libust.

Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
8 years agolibust: Remove some unused variables
Nils Carlson [Thu, 10 Mar 2011 10:27:42 +0000 (11:27 +0100)] 
libust: Remove some unused variables

More spring cleaning.

Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
8 years agolibust: Remove the now useless open_buffers list.
Nils Carlson [Thu, 10 Mar 2011 10:23:24 +0000 (11:23 +0100)] 
libust: Remove the now useless open_buffers list.

Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
8 years agolibust: remove process_simple_client_cmd function
Nils Carlson [Thu, 10 Mar 2011 10:12:35 +0000 (11:12 +0100)] 
libust: remove process_simple_client_cmd function

It was only used by one command, so move the command into
the big case statement and remove a now unnecessary function.

Spring cleaning.

Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
8 years agoChange force_subbuffer switch to be per trace
Nils Carlson [Thu, 10 Mar 2011 09:58:44 +0000 (10:58 +0100)] 
Change force_subbuffer switch to be per trace

Change force_subbuffer switch to act on a per trace basis becuase this
is what we want almost all the time. This will simplify periodic flushing
of some traces and other features we might want in the future.

Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
8 years agolibustconsumer: Fix a fd leak of the pipe_fd
Nils Carlson [Mon, 7 Mar 2011 16:20:34 +0000 (17:20 +0100)] 
libustconsumer: Fix a fd leak of the pipe_fd

libustconsumer wasn't properly closing pipe_fds sent by
libust. Make it do so.

Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
8 years agoAdd a test for urcu 0.5.4 which we now depends on
Yannick Brosseau [Fri, 4 Mar 2011 18:53:40 +0000 (13:53 -0500)] 
Add a test for urcu 0.5.4 which we now depends on

Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoUpdate liburcu dependency to 0.5.4
Mathieu Desnoyers [Fri, 4 Mar 2011 17:32:35 +0000 (12:32 -0500)] 
Update liburcu dependency to 0.5.4

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoUse liburcu-bp before/after fork (parent/child) callbacks
Mathieu Desnoyers [Fri, 4 Mar 2011 17:31:32 +0000 (12:31 -0500)] 
Use liburcu-bp before/after fork (parent/child) callbacks

Handle fork() gracefully with urcu-bp. Dependency on urcu-bp 0.5.4.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agotest: fix the valgrind test-case to not hang if valgrind crashes
Nils Carlson [Fri, 4 Mar 2011 15:08:39 +0000 (16:08 +0100)] 
test: fix the valgrind test-case to not hang if valgrind crashes

In previous version of the test-case the test-case would hang forever
if valgrind crashes (which it does on my debian squeeze PPC).

Fix this by checking that valgrind is alive.

Also cleanup leftover fifos in /tmp

Signed-off-by: Nils Carlson <nils.carlson@ericsson.com>
8 years agoRemove duplicated marker id dump
Mathieu Desnoyers [Fri, 4 Mar 2011 14:13:15 +0000 (09:13 -0500)] 
Remove duplicated marker id dump

Marker ID is already dumped at:
- trace start (with marker dump)
- when a marker is enabled (probe callback associated with marker).

So this should cover all cases:
- either we have a marker in a lib/program that is already enabled, and start
  tracing after a library is loaded, for which the marker dump will catch the
  marker id.
- or we have a marker in a lib/program that is not enabled, and start tracing
  after a library is loaded. If after that we enable the marker, an event
  describing the marker ID will be generated.
- or if have tracing running, and then we enable a marker (connect probe to
  marker) for a marker located in a yet-unloaded library. In this case, the
  marker ID event is generated when we connect the probe to the marker, even if
  the library is not yet loaded.

The cases are similar for the marker format, except that it is valid to have an
unknown marker format when we connect a marker probe. In that case, the format
will be written into the trace by marker_set_format, called upon library load.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoFix off-by-one in open_memstream
Mathieu Desnoyers [Fri, 4 Mar 2011 14:10:40 +0000 (09:10 -0500)] 
Fix off-by-one in open_memstream

size returned by open_memstream does not include the final \0. We have to add
1 to the size of the message sent.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoDebug message cleanup
Mathieu Desnoyers [Fri, 4 Mar 2011 13:01:50 +0000 (08:01 -0500)] 
Debug message cleanup

We cannot use the number of pointers - 1 to know the number of markers/tp/tc,
because we can have more than one NULL pointer per shared object.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoAdd pthread cleanup to listener (to cleanup mutex)
Mathieu Desnoyers [Thu, 3 Mar 2011 23:21:52 +0000 (18:21 -0500)] 
Add pthread cleanup to listener (to cleanup mutex)

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agoRemove dummy markers/tracepoints/trace events
Mathieu Desnoyers [Thu, 3 Mar 2011 20:57:14 +0000 (15:57 -0500)] 
Remove dummy markers/tracepoints/trace events

Add a null pointer in the marker/tp/te tables instead of a full-blown dummy
marker. Skip the null pointers in the marker/tp/te iterators.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agofinish_consuming_dead_subbuffer: cleanup
Mathieu Desnoyers [Thu, 3 Mar 2011 18:17:16 +0000 (13:17 -0500)] 
finish_consuming_dead_subbuffer: cleanup

Use the same iterator as error printing to iterate on the last subbuffers.
Removes a lot of iterator duplication and extra unneeded modulo operations.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agofinish_consuming_dead_subbuffer: fix data_size read race, reread new consumed count
Mathieu Desnoyers [Thu, 3 Mar 2011 17:53:52 +0000 (12:53 -0500)] 
finish_consuming_dead_subbuffer: fix data_size read race, reread new consumed count

Make sure finish_consuming_dead_subbuffer always see a data_size that is non
0xffffffff only when the buffer data is entirely readable, else the code rely on
the commit_seq counter which is the proper solution.

The consumed count should be re-read in each test within the loop, otherwise the
mathematic formula to get the amount of data to read does not work wrt
buffer-size wrap-around.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
8 years agolibustconsumer: check read subuffer return value
Mathieu Desnoyers [Thu, 3 Mar 2011 16:59:42 +0000 (11:59 -0500)] 
libustconsumer: check read subuffer return value

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
This page took 0.094521 seconds and 4 git commands to generate.