UST markers: fix structure alignment for recent gcc
[ust.git] / include / ust / marker.h
index 287f20f5feebe1a466e59cde943b45c723d1581f..a1f55b0b76338f6db9fa7d4c7309b3f7f6ba862c 100644 (file)
@@ -64,7 +64,7 @@ struct marker {
        const char *format;     /* Marker format string, describing the
                                 * variable argument list.
                                 */
-       DEFINE_IMV(char, state);/* Immediate value state. */
+       DEFINE_IMV(char, state);/* Immediate value state. */
        char ptype;             /* probe type : 0 : single, 1 : multi */
                                /* Probe wrapper */
        u16 channel_id;         /* Numeric channel identifier, dynamic */
@@ -75,10 +75,11 @@ struct marker {
        const char *tp_name;    /* Optional tracepoint name */
        void *tp_cb;            /* Optional tracepoint callback */
        void *location;         /* Address of marker in code */
-} __attribute__((aligned(8)));
-
-#define CONFIG_MARKERS
-#ifdef CONFIG_MARKERS
+} __attribute__((aligned(128)));/*
+                                * Aligned on 128 bytes because it is
+                                * globally visible and gcc happily
+                                * align these on the structure size.
+                                */
 
 #define GET_MARKER(channel, name)      (__mark_##channel##_##name)
 
@@ -89,47 +90,47 @@ struct marker {
                 * because it must not require %-sign escaping, as we most certainly            \
                 * have some %-signs in the format string.                                      \
                 */                                                                             \
-               asm volatile (                                                                  \
-                    /* We only define these symbols if they have not yet been defined. Indeed, \
-                     * if two markers with the same channel/name are on the same line, they    \
-                     * will try to create the same symbols, resulting in a conflict. This      \
-                     * is not unusual as it can be the result of function inlining.            \
-                     */                                                                        \
-                    ".ifndef __mstrtab_" __stringify(channel) "_" __stringify(name) "_channel_" __stringify(unique) "\n\t"     \
-                    /*".section __markers_strings\n\t"*/                                       \
-                    ".section __markers_strings,\"aw\",@progbits\n\t"                          \
-                    "__mstrtab_" __stringify(channel) "_" __stringify(name) "_channel_" __stringify(unique) ":\n\t"    \
-                    ".string \"" __stringify(channel) "\"\n\t"                                 \
-                    "__mstrtab_" __stringify(channel) "_" __stringify(name) "_name_" __stringify(unique) ":\n\t"       \
-                    ".string \"" __stringify(name) "\"\n\t"                                            \
-                    "__mstrtab_" __stringify(channel) "_" __stringify(name) "_format_" __stringify(unique) ":\n\t"     \
-                    ".string " "\"" format "\"" "\n\t"                                         \
-                    ".previous\n\t"                                                            \
-                    ".endif\n\t"                                                               \
+               asm volatile (                                                                  \
+                       /* We only define these symbols if they have not yet been defined. Indeed, \
+                        * if two markers with the same channel/name are on the same line, they \
+                        * will try to create the same symbols, resulting in a conflict. This   \
+                        * is not unusual as it can be the result of function inlining.         \
+                        */                                                                     \
+                       ".ifndef __mstrtab_" __stringify(channel) "_" __stringify(name) "_channel_" __stringify(unique) "\n\t"  \
+                       /*".section __markers_strings\n\t"*/                                    \
+                       ".section __markers_strings,\"aw\",@progbits\n\t"                               \
+                       "__mstrtab_" __stringify(channel) "_" __stringify(name) "_channel_" __stringify(unique) ":\n\t" \
+                       ".string \"" __stringify(channel) "\"\n\t"                                      \
+                       "__mstrtab_" __stringify(channel) "_" __stringify(name) "_name_" __stringify(unique) ":\n\t"    \
+                       ".string \"" __stringify(name) "\"\n\t"                                         \
+                       "__mstrtab_" __stringify(channel) "_" __stringify(name) "_format_" __stringify(unique) ":\n\t"  \
+                       ".string " "\"" format "\"" "\n\t"                                              \
+                       ".previous\n\t"                                                         \
+                       ".endif\n\t"                                                            \
                );                                                                              \
                asm volatile (                                                                  \
-                    /*".section __markers\n\t"*/ \
-                    ".section __markers,\"aw\",@progbits\n\t"                                  \
-                    ".balign 8\n\t"                                                            \
-                    "2:\n\t" \
-                    _ASM_PTR "(__mstrtab_" __stringify(channel) "_" __stringify(name) "_channel_" __stringify(unique) ")\n\t" /* channel string */ \
-                    _ASM_PTR "(__mstrtab_" __stringify(channel) "_" __stringify(name) "_name_" __stringify(unique) ")\n\t" /* name string */ \
-                    _ASM_PTR "(__mstrtab_" __stringify(channel) "_" __stringify(name) "_format_" __stringify(unique) ")\n\t" /* format string */ \
-                    ".byte 0\n\t" /* state imv */                                              \
-                    ".byte 0\n\t" /* ptype */                                                  \
-                    ".word 0\n\t" /* channel_id */                                             \
-                    ".word 0\n\t" /* event_id */                                               \
-                    ".balign " __stringify(__WORDSIZE) " / 8\n\t" /* alignment */                      \
-                    _ASM_PTR "(marker_probe_cb)\n\t" /* call */                                \
-                    _ASM_PTR "(__mark_empty_function)\n\t" /* marker_probe_closure single.field1 */ \
-                    _ASM_PTR "0\n\t" /* marker_probe_closure single.field2 */                  \
-                    _ASM_PTR "0\n\t" /* marker_probe_closure *multi */                         \
-                    _ASM_PTR "0\n\t" /* tp_name */                                             \
-                    _ASM_PTR "0\n\t" /* tp_cb */                                               \
-                    _ASM_PTR "(1f)\n\t" /* location */                                         \
-                    ".previous\n\t"                                                            \
-                    "1:\n\t"                                                                   \
-                    ARCH_COPY_ADDR("%[outptr]")                                                \
+                       /*".section __markers\n\t"*/ \
+                       ".section __markers,\"aw\",@progbits\n\t"                                       \
+                       ".balign 8\n\t"                                                         \
+                       "2:\n\t" \
+                       _ASM_PTR "(__mstrtab_" __stringify(channel) "_" __stringify(name) "_channel_" __stringify(unique) ")\n\t" /* channel string */ \
+                       _ASM_PTR "(__mstrtab_" __stringify(channel) "_" __stringify(name) "_name_" __stringify(unique) ")\n\t" /* name string */ \
+                       _ASM_PTR "(__mstrtab_" __stringify(channel) "_" __stringify(name) "_format_" __stringify(unique) ")\n\t" /* format string */ \
+                       ".byte 0\n\t" /* state imv */                                           \
+                       ".byte 0\n\t" /* ptype */                                                       \
+                       ".word 0\n\t" /* channel_id */                                          \
+                       ".word 0\n\t" /* event_id */                                            \
+                       ".balign " __stringify(__WORDSIZE) " / 8\n\t" /* alignment */                   \
+                       _ASM_PTR "(marker_probe_cb)\n\t" /* call */                             \
+                       _ASM_PTR "(__mark_empty_function)\n\t" /* marker_probe_closure single.field1 */ \
+                       _ASM_PTR "0\n\t" /* marker_probe_closure single.field2 */                       \
+                       _ASM_PTR "0\n\t" /* marker_probe_closure *multi */                              \
+                       _ASM_PTR "0\n\t" /* tp_name */                                          \
+                       _ASM_PTR "0\n\t" /* tp_cb */                                            \
+                       _ASM_PTR "(1f)\n\t" /* location */                                              \
+                       ".previous\n\t"                                                         \
+                       "1:\n\t"                                                                        \
+                       ARCH_COPY_ADDR("%[outptr]")                                             \
                : [outptr] "=r" (m) );                                                          \
                                                                                                \
                save_registers(&regs)
@@ -146,14 +147,13 @@ struct marker {
                __attribute__((section("__markers_strings")))           \
                = #channel "\0" #name "\0" format;                      \
                static struct marker GET_MARKER(channel, name)          \
-               __attribute__((section("__markers"), aligned(8))) =     \
+               __attribute__((section("__markers"), aligned(128))) =   \
                { __mstrtab_##channel##_##name,                         \
-                 &__mstrtab_##channel##_##name[sizeof(#channel)],      \
-                 &__mstrtab_##channel##_##name[sizeof(#channel) +      \
-                                               sizeof(#name)],         \
-                 0, 0, 0, 0, marker_probe_cb,                          \
-                 { __mark_empty_function, NULL},                       \
-                 NULL, tp_name_str, tp_cb }
+                       &__mstrtab_##channel##_##name[sizeof(#channel)],        \
+                       &__mstrtab_##channel##_##name[sizeof(#channel) + sizeof(#name)],                \
+                       0, 0, 0, 0, marker_probe_cb,                            \
+                       { __mark_empty_function, NULL},                 \
+                       NULL, tp_name_str, tp_cb }
 
 /*
  * Make sure the alignment of the structure in the __markers section will
@@ -201,25 +201,6 @@ struct marker {
 extern void marker_update_probe_range(struct marker *begin,
        struct marker *end);
 
-#else /* !CONFIG_MARKERS */
-#define DEFINE_MARKER(channel, name, tp_name, tp_cb, format, m)
-#define __trace_mark(generic, channel, name, call_private, format, args...) \
-               __mark_check_format(format, ## args)
-#define __trace_mark_tp(channel, name, call_private, tp_name, tp_cb,   \
-               format, args...)                                        \
-       do {                                                            \
-               void __check_tp_type(void)                              \
-               {                                                       \
-                       register_trace_##tp_name(tp_cb, call_private);          \
-               }                                                       \
-               __mark_check_format(format, ## args);                   \
-       } while (0)
-static inline void marker_update_probe_range(struct marker *begin,
-       struct marker *end)
-{ }
-#define GET_MARKER(channel, name)
-#endif /* CONFIG_MARKERS */
-
 /**
  * trace_mark - Marker using code patching
  * @channel: marker channel (where to send the data), not quoted.
@@ -353,7 +334,7 @@ struct lib {
        struct marker_addr *markers_addr_start;
 #endif
        int markers_count;
-       struct list_head list;
+       struct cds_list_head list;
 };
 
 extern int marker_register_lib(struct marker *markers_start, int markers_count);
This page took 0.027284 seconds and 4 git commands to generate.