Fix: lttng-ust-comm.c: return number of fd rather size of array
authorFrancis Deslauriers <francis.deslauriers@efficios.com>
Tue, 26 Nov 2019 16:16:30 +0000 (11:16 -0500)
committerMathieu Desnoyers <mathieu.desnoyers@efficios.com>
Wed, 4 Mar 2020 15:10:19 +0000 (10:10 -0500)
There are two conflicting comments for this function. One says it
returns the size of the received data and the other says it returns the
number of fd received.

It's more useful to receive the number of fd.

Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Change-Id: I74084b461d396c3e623fa55100e6dd7e59dbea83

liblttng-ust-comm/lttng-ust-comm.c

index 36095a1c48027f09e7ef5fddb869a08ebe005418..beeee60b9b7a02b3c63e182d9932db90538c6a05 100644 (file)
@@ -438,8 +438,6 @@ ssize_t ustcomm_send_fds_unix_sock(int sock, int *fds, size_t nb_fd)
 /*
  * Recv a message accompanied by fd(s) from a unix socket.
  *
- * Returns the size of received data, or negative error value.
- *
  * Expect at most "nb_fd" file descriptors. Returns the number of fd
  * actually received in nb_fd.
  * Returns -EPIPE on orderly shutdown.
@@ -509,7 +507,7 @@ ssize_t ustcomm_recv_fds_unix_sock(int sock, int *fds, size_t nb_fd)
                goto end;
        }
        memcpy(fds, CMSG_DATA(cmsg), sizeof_fds);
-       ret = sizeof_fds;
+       ret = nb_fd;
 end:
        return ret;
 }
This page took 0.024691 seconds and 4 git commands to generate.