Fix: atomic_add_unless() returns true/false rather than prior value
authorFrancis Deslauriers <francis.deslauriers@efficios.com>
Wed, 8 Mar 2017 16:50:38 +0000 (11:50 -0500)
committerMathieu Desnoyers <mathieu.desnoyers@efficios.com>
Wed, 8 Mar 2017 16:55:28 +0000 (11:55 -0500)
commit4c4d77dacf277775cb395190cf827c7f0c226a99
tree0faece9c299a7f3f12a38e3b00c8b157030bda75
parent678dd1c8d1f38ee5fdefafb8451fc544eb743f00
Fix: atomic_add_unless() returns true/false rather than prior value

The previous implementation assumed that `atomic_add_unless` returned
the prior value of the atomic counter when in fact it returned if the
addition was performed (true) or not performed (false).
Since `atomic_add_unless` can not return INT_MAX, the `lttng_kref_get`
always returned that the call was successful.

This issue had a low likelihood of being triggered since the two refcounts
of the counters used with this call are both bounded by the maximum
number of file descriptors on the system.

Signed-off-by: Francis Deslauriers <francis.deslauriers@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
wrapper/kref.h
This page took 0.025251 seconds and 4 git commands to generate.