Cleanup: rotation-thread: enforce conding standard following fix
authorJérémie Galarneau <jeremie.galarneau@efficios.com>
Tue, 4 Apr 2023 17:45:24 +0000 (13:45 -0400)
committerJérémie Galarneau <jeremie.galarneau@efficios.com>
Wed, 12 Apr 2023 14:48:33 +0000 (10:48 -0400)
commit0038180de36c422cfaeade1145fa9fbc9436b8ad
tree7e1bc286e8b7a18414adbaeded88ec3f975f9565
parent8b75cd779ffe332281fec189cdf808e4ee452572
Cleanup: rotation-thread: enforce conding standard following fix

A fix introducing
rotate_notification_channel_subscription_change_eventfd didn't follow
the current coding standard so as to make it easier to backport to the
stable branches.

Clean-up the affected code to follow the current standard:
  - Replace the use of a raw eventfd to use the eventfd utility,
  - Subscribe and unsubscribe functions made use of global variables to
    communicate with the rotation thread: replace that with the
    rotation_thread class to centralize the interface,
  - Make the code using eventfd exception-safe (automatic memory
    management, use of various RAII utils),
  - Replacement of non-null pointers by references.

Change-Id: I7e363e21b829fd0939a336aca2570fdbcc346967
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
25 files changed:
include/lttng/notification/channel-internal.hpp
include/lttng/notification/notification-internal.hpp
src/bin/lttng-sessiond/Makefile.am
src/bin/lttng-sessiond/client.cpp
src/bin/lttng-sessiond/cmd.cpp
src/bin/lttng-sessiond/cmd.hpp
src/bin/lttng-sessiond/globals.cpp
src/bin/lttng-sessiond/kernel.cpp
src/bin/lttng-sessiond/lttng-sessiond.hpp
src/bin/lttng-sessiond/main.cpp
src/bin/lttng-sessiond/rotate.cpp [deleted file]
src/bin/lttng-sessiond/rotate.hpp [deleted file]
src/bin/lttng-sessiond/rotation-thread.cpp
src/bin/lttng-sessiond/rotation-thread.hpp
src/bin/lttng-sessiond/session.cpp
src/bin/lttng-sessiond/session.hpp
src/bin/lttng-sessiond/timer.cpp
src/bin/lttng-sessiond/timer.hpp
src/bin/lttng-sessiond/ust-app.cpp
src/common/error.hpp
src/common/exception.cpp
src/common/exception.hpp
src/common/file-descriptor.cpp
src/common/file-descriptor.hpp
src/common/pipe.hpp
This page took 0.026731 seconds and 4 git commands to generate.