Fix: sessiond: notification: missing unlock on client skip
authorJérémie Galarneau <jeremie.galarneau@efficios.com>
Mon, 19 Jul 2021 21:17:39 +0000 (17:17 -0400)
committerJérémie Galarneau <jeremie.galarneau@efficios.com>
Mon, 19 Jul 2021 21:23:19 +0000 (17:23 -0400)
commit70eb2f6fb8b5ee08fce4c970a498c0cdc3e69bf3
treee256dd0b47cf620e83531f237488a835803542f0
parent2fdab47db9cf2b8413516fc3f3491f3dcaff2931
Fix: sessiond: notification: missing unlock on client skip

Skipping a client must be performed by using the dedicated "skip_client"
label which will unlock the client's lock before continuing the loop
rather than using 'continue' directly.

Currently, a client will remain locked when an hidden trigger emits
a notification to which it is subscribed.

1458230 Missing unlock

May result in deadlock if there is another attempt to acquire the lock.

In notification_client_list_send_evaluation: Missing a release of a lock
on a path (CWE-667)

Reported-by: Coverity Scan
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Change-Id: I8b69395b91b0ea59ae5e0beadebd9099db623121
src/bin/lttng-sessiond/notification-thread-events.c
This page took 0.024362 seconds and 4 git commands to generate.