clang-tidy: add most bugprone warnings

[lttng-tools.git] / src / common / event-rule / python-logging.cpp

diff --git a/src/common/event-rule/python-logging.cpp b/src/common/event-rule/python-logging.cpp
index 2f2187267615cc24c4a2a97da0a823b2b6753cf7..eb23b337bfd2c365f90e0fa84b1e8ed81ae020e7 100644 (file)
--- a/src/common/event-rule/python-logging.cpp
+++ b/src/common/event-rule/python-logging.cpp
@@ -145,12 +145,12 @@ static bool lttng_event_rule_python_logging_is_equal(const struct lttng_event_ru
        /* Long check. */
        LTTNG_ASSERT(a->pattern);
        LTTNG_ASSERT(b->pattern);
        /* Long check. */
        LTTNG_ASSERT(a->pattern);
        LTTNG_ASSERT(b->pattern);

-       if (strcmp(a->pattern, b->pattern)) {
+       if (strcmp(a->pattern, b->pattern) != 0) {

                goto end;
        }
 
        if (a->filter_expression && b->filter_expression) {
                goto end;
        }
 
        if (a->filter_expression && b->filter_expression) {

-               if (strcmp(a->filter_expression, b->filter_expression)) {
+               if (strcmp(a->filter_expression, b->filter_expression) != 0) {

                        goto end;
                }
        } else if (!!a->filter_expression != !!b->filter_expression) {
                        goto end;
                }
        } else if (!!a->filter_expression != !!b->filter_expression) {