sessiond: document RCU locking assumption during channel metadata statedump

[lttng-tools.git] / src / bin / lttng-sessiond / ust-metadata.cpp

diff --git a/src/bin/lttng-sessiond/ust-metadata.cpp b/src/bin/lttng-sessiond/ust-metadata.cpp
index 566799efd08b2016e7ce24edeeadb3cd70937d04..5f031a9c41f7f074fda80129828b0c6688508576 100644 (file)
--- a/src/bin/lttng-sessiond/ust-metadata.cpp
+++ b/src/bin/lttng-sessiond/ust-metadata.cpp
@@ -906,12 +906,16 @@ end:
 
 /*
  * Should be called with session registry mutex held.
 
 /*
  * Should be called with session registry mutex held.

+ *
+ * RCU read lock must be held by the caller.

  */
 int ust_metadata_channel_statedump(struct ust_registry_session *session,
                struct ust_registry_channel *chan)
 {
        int ret;
 
  */
 int ust_metadata_channel_statedump(struct ust_registry_session *session,
                struct ust_registry_channel *chan)
 {
        int ret;
 

+       ASSERT_RCU_READ_LOCKED();
+

        /* Don't dump metadata events */
        if (chan->chan_id == -1U)
                return 0;
        /* Don't dump metadata events */
        if (chan->chan_id == -1U)
                return 0;