Fix: relayd: session id is ignored by 2.11+ create session command
[lttng-tools.git] / src / bin / lttng-relayd / cmd-2-11.cpp
CommitLineData
f86f6389 1/*
ab5be9fa 2 * Copyright (C) 2018 Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
f86f6389 3 *
ab5be9fa 4 * SPDX-License-Identifier: GPL-2.0-only
f86f6389 5 *
f86f6389
JR
6 */
7
8#define _LGPL_SOURCE
f86f6389
JR
9#include <inttypes.h>
10
11#include <common/common.h>
12#include <common/sessiond-comm/relayd.h>
13
14#include <common/compat/endian.h>
15#include <common/compat/string.h>
16#include <lttng/constant.h>
17
18#include "cmd-2-11.h"
2f21a469 19#include "utils.h"
f86f6389
JR
20
21int cmd_create_session_2_11(const struct lttng_buffer_view *payload,
6fa5fe7c 22 char *session_name, char *hostname, char *base_path,
23c8ff50 23 uint32_t *live_timer, bool *snapshot,
1e791a74 24 uint64_t *id_sessiond, lttng_uuid sessiond_uuid,
db1da059 25 bool *has_current_chunk, uint64_t *current_chunk_id,
46ef2188
MD
26 time_t *creation_time,
27 bool *session_name_contains_creation_time)
f86f6389
JR
28{
29 int ret;
30 struct lttcomm_relayd_create_session_2_11 header;
6fa5fe7c 31 size_t header_len, received_names_size, offset;
f86f6389
JR
32 struct lttng_buffer_view session_name_view;
33 struct lttng_buffer_view hostname_view;
6fa5fe7c 34 struct lttng_buffer_view base_path_view;
f86f6389
JR
35
36 header_len = sizeof(header);
37
38 if (payload->size < header_len) {
39 ERR("Unexpected payload size in \"cmd_create_session_2_11\": expected >= %zu bytes, got %zu bytes",
40 header_len, payload->size);
41 ret = -1;
42 goto error;
43 }
44 memcpy(&header, payload->data, header_len);
45
46 header.session_name_len = be32toh(header.session_name_len);
47 header.hostname_len = be32toh(header.hostname_len);
6fa5fe7c 48 header.base_path_len = be32toh(header.base_path_len);
f86f6389 49 header.live_timer = be32toh(header.live_timer);
84fa4db5
JG
50 header.current_chunk_id.value = be64toh(header.current_chunk_id.value);
51 header.current_chunk_id.is_set = !!header.current_chunk_id.is_set;
db1da059 52 header.creation_time = be64toh(header.creation_time);
d1bc11c3 53 header.session_id = be64toh(header.session_id);
f86f6389 54
23c8ff50
JG
55 lttng_uuid_copy(sessiond_uuid, header.sessiond_uuid);
56
6fa5fe7c
MD
57 received_names_size = header.session_name_len + header.hostname_len +
58 header.base_path_len;
f86f6389
JR
59 if (payload->size < header_len + received_names_size) {
60 ERR("Unexpected payload size in \"cmd_create_session_2_11\": expected >= %zu bytes, got %zu bytes",
61 header_len + received_names_size, payload->size);
62 ret = -1;
63 goto error;
64 }
65
66 /* Validate length against defined constant. */
67 if (header.session_name_len > LTTNG_NAME_MAX) {
68 ret = -ENAMETOOLONG;
69 ERR("Length of session name (%" PRIu32 " bytes) received in create_session command exceeds maximum length (%d bytes)", header.session_name_len, LTTNG_NAME_MAX);
70 goto error;
e7f8eff3
JG
71 } else if (header.session_name_len == 0) {
72 ret = -EINVAL;
73 ERR("Illegal session name length of 0 received");
74 goto error;
f86f6389
JR
75 }
76 if (header.hostname_len > LTTNG_HOST_NAME_MAX) {
77 ret = -ENAMETOOLONG;
78 ERR("Length of hostname (%" PRIu32 " bytes) received in create_session command exceeds maximum length (%d bytes)", header.hostname_len, LTTNG_HOST_NAME_MAX);
79 goto error;
80 }
6fa5fe7c
MD
81 if (header.base_path_len > LTTNG_PATH_MAX) {
82 ret = -ENAMETOOLONG;
83 ERR("Length of base_path (%" PRIu32 " bytes) received in create_session command exceeds maximum length (%d bytes)", header.base_path_len, PATH_MAX);
84 goto error;
85 }
f86f6389 86
6fa5fe7c
MD
87 offset = header_len;
88 session_name_view = lttng_buffer_view_from_view(payload, offset,
f86f6389 89 header.session_name_len);
3e6e0df2
JG
90 if (!lttng_buffer_view_is_valid(&session_name_view)) {
91 ERR("Invalid payload in \"cmd_create_session_2_11\": buffer too short to contain session name");
92 ret = -1;
93 goto error;
94 }
95
6fa5fe7c 96 offset += header.session_name_len;
f86f6389 97 hostname_view = lttng_buffer_view_from_view(payload,
6fa5fe7c 98 offset, header.hostname_len);
3e6e0df2
JG
99 if (!lttng_buffer_view_is_valid(&hostname_view)) {
100 ERR("Invalid payload in \"cmd_create_session_2_11\": buffer too short to contain hostname");
101 ret = -1;
102 goto error;
103 }
104
6fa5fe7c
MD
105 offset += header.hostname_len;
106 base_path_view = lttng_buffer_view_from_view(payload,
107 offset, header.base_path_len);
3e6e0df2
JG
108 if (header.base_path_len > 0 && !lttng_buffer_view_is_valid(&base_path_view)) {
109 ERR("Invalid payload in \"cmd_create_session_2_11\": buffer too short to contain base path");
110 ret = -1;
111 goto error;
112 }
f86f6389
JR
113
114 /* Validate that names are NULL terminated. */
115 if (session_name_view.data[session_name_view.size - 1] != '\0') {
116 ERR("cmd_create_session_2_11 session_name is invalid (not NULL terminated)");
117 ret = -1;
118 goto error;
119 }
120
121 if (hostname_view.data[hostname_view.size - 1] != '\0') {
122 ERR("cmd_create_session_2_11 hostname is invalid (not NULL terminated)");
123 ret = -1;
124 goto error;
125 }
126
6fa5fe7c
MD
127 if (base_path_view.size != 0 &&
128 base_path_view.data[base_path_view.size - 1] != '\0') {
129 ERR("cmd_create_session_2_11 base_path is invalid (not NULL terminated)");
130 ret = -1;
131 goto error;
132 }
133
f86f6389
JR
134 /*
135 * Length and null-termination check are already performed.
6fa5fe7c 136 * LTTNG_NAME_MAX, LTTNG_HOST_NAME_MAX, and LTTNG_PATH_MAX max sizes are expected.
f86f6389
JR
137 */
138 strcpy(session_name, session_name_view.data);
139 strcpy(hostname, hostname_view.data);
6fa5fe7c 140 strcpy(base_path, base_path_view.size ? base_path_view.data : "");
f86f6389
JR
141
142 *live_timer = header.live_timer;
143 *snapshot = !!header.snapshot;
84fa4db5
JG
144 *current_chunk_id = header.current_chunk_id.value;
145 *has_current_chunk = header.current_chunk_id.is_set;
db1da059 146 *creation_time = (time_t) header.creation_time;
46ef2188
MD
147 *session_name_contains_creation_time =
148 header.session_name_contains_creation_time;
d1bc11c3 149 *id_sessiond = header.session_id;
f86f6389
JR
150
151 ret = 0;
152
153error:
154 return ret;
155}
2f21a469
JR
156
157/*
158 * cmd_recv_stream_2_11 allocates path_name and channel_name.
159 */
160int cmd_recv_stream_2_11(const struct lttng_buffer_view *payload,
161 char **ret_path_name, char **ret_channel_name,
0b50e4b3
JG
162 uint64_t *tracefile_size, uint64_t *tracefile_count,
163 uint64_t *trace_archive_id)
2f21a469
JR
164{
165 int ret;
166 struct lttcomm_relayd_add_stream_2_11 header;
167 size_t header_len, received_names_size;
168 struct lttng_buffer_view channel_name_view;
169 struct lttng_buffer_view pathname_view;
170 char *path_name = NULL;
171 char *channel_name = NULL;
172
173 header_len = sizeof(header);
174
175 if (payload->size < header_len) {
176 ERR("Unexpected payload size in \"cmd_recv_stream_2_11\": expected >= %zu bytes, got %zu bytes",
177 header_len, payload->size);
178 ret = -1;
179 goto error;
180 }
181 memcpy(&header, payload->data, header_len);
182
183 header.channel_name_len = be32toh(header.channel_name_len);
184 header.pathname_len = be32toh(header.pathname_len);
185 header.tracefile_size = be64toh(header.tracefile_size);
186 header.tracefile_count = be64toh(header.tracefile_count);
348a81dc 187 header.trace_chunk_id = be64toh(header.trace_chunk_id);
2f21a469
JR
188
189 received_names_size = header.channel_name_len + header.pathname_len;
190 if (payload->size < header_len + received_names_size) {
191 ERR("Unexpected payload size in \"cmd_recv_stream_2_11\": expected >= %zu bytes, got %zu bytes",
192 header_len + received_names_size, payload->size);
193 ret = -1;
194 goto error;
195 }
196
197 /* Validate length against defined constant. */
198 if (header.channel_name_len > DEFAULT_STREAM_NAME_LEN) {
199 ret = -ENAMETOOLONG;
200 ERR("Channel name too long");
201 goto error;
202 }
203 if (header.pathname_len > LTTNG_NAME_MAX) {
204 ret = -ENAMETOOLONG;
205 ERR("Pathname too long");
206 goto error;
207 }
208
209 /* Validate that names are (NULL terminated. */
210 channel_name_view = lttng_buffer_view_from_view(payload, header_len,
3e6e0df2
JG
211 header.channel_name_len);
212 if (!lttng_buffer_view_is_valid(&channel_name_view)) {
213 ERR("Invalid payload received in \"cmd_recv_stream_2_11\": buffer too short for channel name");
214 ret = -1;
215 goto error;
216 }
2f21a469
JR
217
218 if (channel_name_view.data[channel_name_view.size - 1] != '\0') {
219 ERR("cmd_recv_stream_2_11 channel_name is invalid (not NULL terminated)");
220 ret = -1;
221 goto error;
222 }
223
3e6e0df2
JG
224 pathname_view = lttng_buffer_view_from_view(payload,
225 header_len + header.channel_name_len, header.pathname_len);
226 if (!lttng_buffer_view_is_valid(&pathname_view)) {
227 ERR("Invalid payload received in \"cmd_recv_stream_2_11\": buffer too short for path name");
228 ret = -1;
229 goto error;
230 }
231
2f21a469
JR
232 if (pathname_view.data[pathname_view.size - 1] != '\0') {
233 ERR("cmd_recv_stream_2_11 patname is invalid (not NULL terminated)");
234 ret = -1;
235 goto error;
236 }
237
238 channel_name = strdup(channel_name_view.data);
239 if (!channel_name) {
240 ret = -errno;
241 PERROR("Channel name allocation");
242 goto error;
243 }
244
348a81dc 245 path_name = strdup(pathname_view.data);
2f21a469
JR
246 if (!path_name) {
247 PERROR("Path name allocation");
248 ret = -ENOMEM;
249 goto error;
250 }
251
252 *tracefile_size = header.tracefile_size;
253 *tracefile_count = header.tracefile_count;
348a81dc 254 *trace_archive_id = header.trace_chunk_id;
2f21a469
JR
255 *ret_path_name = path_name;
256 *ret_channel_name = channel_name;
257 /* Move ownership to caller */
258 path_name = NULL;
259 channel_name = NULL;
260 ret = 0;
261error:
262 free(channel_name);
263 free(path_name);
264 return ret;
265}
This page took 0.051791 seconds and 4 git commands to generate.