lttng-tools.git
12 years agoSupport XSI strerror_r in error.h
Mathieu Desnoyers [Tue, 21 Feb 2012 18:54:20 +0000 (13:54 -0500)] 
Support XSI strerror_r in error.h

Acked-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoAdd FreeBSD compat layer for socket.h
David Goulet [Tue, 21 Feb 2012 18:12:55 +0000 (13:12 -0500)] 
Add FreeBSD compat layer for socket.h

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoAdd FreeBSD compat layer for endian.h
David Goulet [Tue, 21 Feb 2012 18:11:47 +0000 (13:11 -0500)] 
Add FreeBSD compat layer for endian.h

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoFix FreeBSD support for rculfhash mmap
David Goulet [Tue, 21 Feb 2012 18:12:20 +0000 (13:12 -0500)] 
Fix FreeBSD support for rculfhash mmap

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoRevert FreeBSD compatibility layer
David Goulet [Wed, 22 Feb 2012 21:53:12 +0000 (16:53 -0500)] 
Revert FreeBSD compatibility layer

Move those commits to the compat-freebsd branch instead of master branch
which is currently between release canditate and stable and this compat
layer will NOT go into 2.0-stable.

Revert "Fix rest of the code to support compat layer"
This reverts commit a440509044c2828bf6dbfb05e8d9d6d0277ce1a4.

Revert "Fix consumer to handle compat layer"
This reverts commit fbb2c21aac1386b7752f6254b2bd0bf001fa0ac1.

Revert "Multiple fix for FreeBSD compat layer"
This reverts commit bcc5eeb02fcad910c4de961b040351dad31b6f9f.

Revert "Add multiple FreeBSD compat layer"
This reverts commit d50813007e79158828e8ee6e1b5444950bc90847.

Revert "Add FreeBSD compat layer for splice and sync_file_range"
This reverts commit 826a02a292d2bd409be87ea96ba2fccbccee76b1.

Revert "Support XSI strerror_r in error.h"
This reverts commit e672cc585c3d67ee80278e29b538a3aed65df825.

Revert "Add FreeBSD compat layer for socket.h"
This reverts commit ef50a575de02a28aa158d7ba34b3d20ea329751a.

Revert "Fix FreeBSD support for rculfhash mmap"
This reverts commit e21193ea4abf7d93112b8ad3144ba11484d623c6.

Revert "Add FreeBSD compat layer for endian.h"
This reverts commit ae9d96fe577c198df432102cde69a28e82cccc1b.

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoFix: documented number of subbuffers is incorrect
Mathieu Desnoyers [Wed, 22 Feb 2012 01:18:33 +0000 (20:18 -0500)] 
Fix: documented number of subbuffers is incorrect

Reported-by: Tan Dung Le Tran <tan.dung.le.tran@ericsson.com>
Acked-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoDocument that num-subbuf and subbuf-size need to be power of 2
Mathieu Desnoyers [Wed, 22 Feb 2012 01:07:29 +0000 (20:07 -0500)] 
Document that num-subbuf and subbuf-size need to be power of 2

Reported-by: Tan Dung Le Tran <tan.dung.le.tran@ericsson.com>
Acked-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoMerge branch 'master' of git://git.lttng.org/lttng-tools
David Goulet [Tue, 21 Feb 2012 22:53:02 +0000 (17:53 -0500)] 
Merge branch 'master' of git://git.lttng.org/lttng-tools

12 years agoFix rest of the code to support compat layer
David Goulet [Tue, 21 Feb 2012 22:46:49 +0000 (17:46 -0500)] 
Fix rest of the code to support compat layer

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoFix consumer to handle compat layer
David Goulet [Tue, 21 Feb 2012 22:46:24 +0000 (17:46 -0500)] 
Fix consumer to handle compat layer

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoMultiple fix for FreeBSD compat layer
David Goulet [Tue, 21 Feb 2012 22:45:50 +0000 (17:45 -0500)] 
Multiple fix for FreeBSD compat layer

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoAdd multiple FreeBSD compat layer
David Goulet [Tue, 21 Feb 2012 22:43:53 +0000 (17:43 -0500)] 
Add multiple FreeBSD compat layer

Adds clone, posix_fadvise and splice compatibility layer.

This commit ENOSYS those function for now and better implementation
will come in the future.

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoAdd FreeBSD compat layer for splice and sync_file_range
David Goulet [Tue, 21 Feb 2012 20:36:59 +0000 (15:36 -0500)] 
Add FreeBSD compat layer for splice and sync_file_range

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoSupport XSI strerror_r in error.h
Mathieu Desnoyers [Tue, 21 Feb 2012 18:54:20 +0000 (13:54 -0500)] 
Support XSI strerror_r in error.h

Acked-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoAdd FreeBSD compat layer for socket.h
David Goulet [Tue, 21 Feb 2012 18:12:55 +0000 (13:12 -0500)] 
Add FreeBSD compat layer for socket.h

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoFix FreeBSD support for rculfhash mmap
David Goulet [Tue, 21 Feb 2012 18:12:20 +0000 (13:12 -0500)] 
Fix FreeBSD support for rculfhash mmap

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoAdd FreeBSD compat layer for endian.h
David Goulet [Tue, 21 Feb 2012 18:11:47 +0000 (13:11 -0500)] 
Add FreeBSD compat layer for endian.h

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoUpdate version to v2.0.0-rc1 v2.0.0-rc1
David Goulet [Mon, 20 Feb 2012 19:28:11 +0000 (14:28 -0500)] 
Update version to v2.0.0-rc1

Signed-off-by: David Goulet <dgoulet@ev0ke.net>
12 years agoStandardize lttng-modules header version
Mathieu Desnoyers [Mon, 20 Feb 2012 19:53:20 +0000 (14:53 -0500)] 
Standardize lttng-modules header version

refs #79

Signed-off-by: David Goulet <dgoulet@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agolttng-sessiond: Set group permissions explicitly
Juha Niskanen [Thu, 16 Feb 2012 20:32:12 +0000 (22:32 +0200)] 
lttng-sessiond: Set group permissions explicitly

If root has a restrictive umask, e.g. 0077 when starting the session
daemon, users in kernel tracing group cannot access the global run
directory.

This patch drops unnecessary group mode bits and always sets the global
run dir permission regardless of umask.

Signed-off-by: Juha Niskanen <juniskane@gmail.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoFix lttcomm_close_unix_sock to actually close the socket
David Goulet [Thu, 16 Feb 2012 22:29:37 +0000 (17:29 -0500)] 
Fix lttcomm_close_unix_sock to actually close the socket

To all soul out there, shutdown(sock, SHUT_RDWR) does NOT close the
socket keeping it open after the call. I have to say for my defense that
the man page does not specify it clearly :P.

Reported-by: Irina Guilman <irina.guilman@ericsson.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoUpdate version to v2.0-pre23 v2.0-pre23
David Goulet [Thu, 16 Feb 2012 18:23:46 +0000 (13:23 -0500)] 
Update version to v2.0-pre23

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agomodprobe timer instrumentation module
Mathieu Desnoyers [Thu, 16 Feb 2012 16:01:09 +0000 (11:01 -0500)] 
modprobe timer instrumentation module

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agomodprobe lttng-probe-signal
Mathieu Desnoyers [Thu, 16 Feb 2012 15:48:28 +0000 (10:48 -0500)] 
modprobe lttng-probe-signal

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoAutomatically load new lttng-probe-statedump.ko module
Mathieu Desnoyers [Thu, 16 Feb 2012 02:15:55 +0000 (21:15 -0500)] 
Automatically load new lttng-probe-statedump.ko module

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoFix ust app session started state on start trace
David Goulet [Wed, 15 Feb 2012 16:29:16 +0000 (11:29 -0500)] 
Fix ust app session started state on start trace

The started flag must be set as soon as possible in the start trace
function since if the start fails, it is still consider started for the
code logic.

Added one test to validate the restart tracing in UST.

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoFix double start/stop trace
David Goulet [Wed, 15 Feb 2012 00:00:56 +0000 (19:00 -0500)] 
Fix double start/stop trace

The started flag, use to detect start vs restart, was set to 0 when
stopping tracing which is really not suppose to. An assert has been
addedd to detect a started = 0 at this stage which is a bad execution
flow error.

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoSmall fix to lttng list session
David Goulet [Tue, 14 Feb 2012 22:31:57 +0000 (17:31 -0500)] 
Small fix to lttng list session

This patch makes lttng_list_sessions return 0 (not an error) when there
is in fact zero registered sessions. Also adding a MSG() to the user to
inform that no sessions exist and the error code is 0.

Reported-by: Tan Dung Le Tran <tan.dung.le.tran@ericsson.com>
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoFix return value on ust app session create
David Goulet [Tue, 14 Feb 2012 20:40:17 +0000 (15:40 -0500)] 
Fix return value on ust app session create

Two possible error can occur here where the malloc() failed or the
tracer is gone (app unregistered) so two error code is needed.

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoFix missing session locks
David Goulet [Tue, 14 Feb 2012 20:35:31 +0000 (15:35 -0500)] 
Fix missing session locks

When an application registers, an update is triggered to create pending
events of the global event registry. This process MUST held the session
lock and the session list locks since it's iterating over all sessions.

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoFix existing session daemon check
David Goulet [Tue, 14 Feb 2012 20:33:20 +0000 (15:33 -0500)] 
Fix existing session daemon check

On unclean exit, the session daemon socket are not removed making the
access() test valid on the next session daemon execution and failing to
recover from a fatal error.

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoImprove create sessions test to show progress
David Goulet [Tue, 14 Feb 2012 17:40:25 +0000 (12:40 -0500)] 
Improve create sessions test to show progress

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoFix hyphens in man pages
David Goulet [Tue, 14 Feb 2012 17:18:39 +0000 (12:18 -0500)] 
Fix hyphens in man pages

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoconfigure.ac: Fix consumerd64-libdir typo
Mathieu Desnoyers [Tue, 14 Feb 2012 15:14:10 +0000 (10:14 -0500)] 
configure.ac: Fix consumerd64-libdir typo

Reported-by: Devon MacDougall <devon.macdougall@ericsson.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoUpdate version to 2.0-pre22 v2.0-pre22
David Goulet [Tue, 14 Feb 2012 14:18:56 +0000 (09:18 -0500)] 
Update version to 2.0-pre22

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoAdd the LICENSE file too
Alexandre Montplaisir [Mon, 13 Feb 2012 22:44:26 +0000 (17:44 -0500)] 
Add the LICENSE file too

Signed-off-by: Alexandre Montplaisir <alexandre.montplaisir@gmail.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoAdd the bash-completion file to the dist tarball
Alexandre Montplaisir [Mon, 13 Feb 2012 22:31:06 +0000 (17:31 -0500)] 
Add the bash-completion file to the dist tarball

Signed-off-by: Alexandre Montplaisir <alexandre.montplaisir@gmail.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoUpdate version to 2.0-pre21 v2.0-pre21
David Goulet [Mon, 13 Feb 2012 15:40:57 +0000 (10:40 -0500)] 
Update version to 2.0-pre21

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoFix memory leak
Daniel U. Thibault [Mon, 13 Feb 2012 15:36:16 +0000 (10:36 -0500)] 
Fix memory leak

Signed-off-by: Daniel U. Thibault <daniel.thibault@drdc-rddc.gc.ca>
Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoInstall man pages, lulz
Alexandre Montplaisir [Sat, 11 Feb 2012 01:11:39 +0000 (20:11 -0500)] 
Install man pages, lulz

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoInitial import of man lttng.1 and lttng-sessiond.8
David Goulet [Tue, 24 Jan 2012 22:29:14 +0000 (17:29 -0500)] 
Initial import of man lttng.1 and lttng-sessiond.8

This is the first import and first draft of lttng-tools man pages. It is
most likely that they still contain a lot of mistakes.

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoenable-event: Remove "<all> from MSG() when no loglevel is selected
Mathieu Desnoyers [Fri, 10 Feb 2012 18:26:54 +0000 (13:26 -0500)] 
enable-event: Remove "<all> from MSG() when no loglevel is selected

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoPrint loglevel value in list -u
Mathieu Desnoyers [Fri, 10 Feb 2012 18:22:11 +0000 (13:22 -0500)] 
Print loglevel value in list -u

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agolttng cmd: use enum instead of value for mapping
Mathieu Desnoyers [Fri, 10 Feb 2012 18:10:03 +0000 (13:10 -0500)] 
lttng cmd: use enum instead of value for mapping

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoFix licensing for hashtable/utils.c
David Goulet [Thu, 9 Feb 2012 22:22:28 +0000 (17:22 -0500)] 
Fix licensing for hashtable/utils.c

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoFix date in Changelog
David Goulet [Thu, 9 Feb 2012 21:49:18 +0000 (16:49 -0500)] 
Fix date in Changelog

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoUpdate version to 2.0-pre20 v2.0-pre20
David Goulet [Thu, 9 Feb 2012 21:44:55 +0000 (16:44 -0500)] 
Update version to 2.0-pre20

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoIncrease sleep time for ust-nprocesses test
David Goulet [Wed, 8 Feb 2012 21:02:25 +0000 (16:02 -0500)] 
Increase sleep time for ust-nprocesses test

On slower system, the sleep time of ust-nprocesses can be too short
making the test fail. However, there is not much we can do to make sure
all app. registers to the session daemon and there is no time guarantee
also.

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoAdd trace directory option to lttng view
David Goulet [Wed, 8 Feb 2012 20:34:10 +0000 (15:34 -0500)] 
Add trace directory option to lttng view

With -t, --trace-path, you can specify a trace directory to be used by
the viewer. This option override the session name.

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoRemove fork() for the lttng view spawn viewer
David Goulet [Wed, 8 Feb 2012 20:22:39 +0000 (15:22 -0500)] 
Remove fork() for the lttng view spawn viewer

We can now ctrl+c the viewer :). The fork() is useless since the command
does nothing else after the exec().

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoFix unitilialized ret value (revisited)
Mathieu Desnoyers [Tue, 7 Feb 2012 22:46:54 +0000 (17:46 -0500)] 
Fix unitilialized ret value (revisited)

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoUpdate hardcoded loglevels, allow shortcuts, add to lttng.h API
Mathieu Desnoyers [Tue, 7 Feb 2012 22:36:05 +0000 (17:36 -0500)] 
Update hardcoded loglevels, allow shortcuts, add to lttng.h API

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoFix uninitialized ret value
David Goulet [Tue, 7 Feb 2012 22:02:44 +0000 (17:02 -0500)] 
Fix uninitialized ret value

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoChange default options to lttng view
David Goulet [Tue, 7 Feb 2012 21:51:21 +0000 (16:51 -0500)] 
Change default options to lttng view

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoRemove forgotten debug printf
David Goulet [Tue, 7 Feb 2012 21:48:38 +0000 (16:48 -0500)] 
Remove forgotten debug printf

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoFix session syscall listing
David Goulet [Tue, 7 Feb 2012 21:44:30 +0000 (16:44 -0500)] 
Fix session syscall listing

This problem occured because the "syscall" event was not added to the
event list since his kernel FD is not valid (fd=0). However, this fd is
only usefull if we want to add context or disable events. Those two
operations are not supported for now.

So, we can safely add the event to the list and add a hardcoded name in
the lttng cli list command.

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoAdd the lttng view command
David Goulet [Tue, 7 Feb 2012 19:13:20 +0000 (14:13 -0500)] 
Add the lttng view command

This adds "view" to the lttng command line interface. It's used to
visualize traces with a given viewers (default: babeltrace).

The -e, --viewer options is available to override the default viewer
settings or add arguments to the viewer.

For example:

$ lttng view -e "babeltrace -n scope --no-delta --clock-raw"

The trace directory path is automatically appended using the current
session or the given session name to lttng view.

The default behavior is to simply spawn babeltrace with "-n all".

$ lttng view
[...]

LTTv support is now disabled but is planned for the stable release.

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoFix list command
Mathieu Desnoyers [Tue, 7 Feb 2012 18:28:19 +0000 (13:28 -0500)] 
Fix list command

Broken by commit 081311398b0deca05eebaac8672efbc9af272d36

Fix by only creating the handle if kernel or ust is specified (so it
still fixes the valgrind warning).

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoZero-initialize struct msghdr
Mathieu Desnoyers [Tue, 7 Feb 2012 03:59:36 +0000 (22:59 -0500)] 
Zero-initialize struct msghdr

==27395== Syscall param socketcall.sendmsg(msg.msg_iov[i]) points to uninitialised byte(s)
==27395==    at 0x546C6A0: __sendmsg_nocancel (syscall-template.S:82)
==27395==    by 0x4E30880: lttcomm_send_creds_unix_sock (sessiond-comm.c:449)
==27395==    by 0x4E2F584: ask_sessiond (lttng-ctl.c:99)
==27395==    by 0x4E2FC85: lttng_list_tracepoints (lttng-ctl.c:667)
==27395==    by 0x4039C1: cmd_list (list.c:314)
==27395==    by 0x40217C: main (lttng.c:266)

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoFix memleak in lttng list.c
Mathieu Desnoyers [Tue, 7 Feb 2012 03:49:20 +0000 (22:49 -0500)] 
Fix memleak in lttng list.c

==26825== 580 bytes in 1 blocks are definitely lost in loss record 13 of 13
==26825==    at 0x4C2779D: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==26825==    by 0x4E2F702: lttng_create_handle (lttng-ctl.c:385)
==26825==    by 0x403A5F: cmd_list (list.c:255)
==26825==    by 0x40217C: main (lttng.c:266)

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agocompat poll: remove useless "void" and semicolons
Mathieu Desnoyers [Tue, 7 Feb 2012 03:26:21 +0000 (22:26 -0500)] 
compat poll: remove useless "void" and semicolons

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agotest session: tmp_name needs to be used twice
Mathieu Desnoyers [Tue, 7 Feb 2012 03:09:11 +0000 (22:09 -0500)] 
test session: tmp_name needs to be used twice

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoMake execution path with uninitialized domain fail
Mathieu Desnoyers [Tue, 7 Feb 2012 03:06:39 +0000 (22:06 -0500)] 
Make execution path with uninitialized domain fail

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agotests: ensure all get random string don't free
Mathieu Desnoyers [Tue, 7 Feb 2012 03:06:24 +0000 (22:06 -0500)] 
tests: ensure all get random string don't free

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoCleanup tests coding style
Mathieu Desnoyers [Tue, 7 Feb 2012 02:59:42 +0000 (21:59 -0500)] 
Cleanup tests coding style

4 spaces -> tab

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoFix memory leak in get random string
Mathieu Desnoyers [Tue, 7 Feb 2012 02:59:29 +0000 (21:59 -0500)] 
Fix memory leak in get random string

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoInitialize all stack variables to zero, fix uninitialized loglevel variables
Mathieu Desnoyers [Tue, 7 Feb 2012 02:50:16 +0000 (21:50 -0500)] 
Initialize all stack variables to zero, fix uninitialized loglevel variables

If we want the padding behavior to be always the same (for future
extensibility), we need to set those variables to zero when they are
declared on the stack.

Also fix uninitialized loglevel variables in tests, which were failing
on x86_32 due to this.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoLoglevel fixes
Mathieu Desnoyers [Mon, 6 Feb 2012 22:18:22 +0000 (17:18 -0500)] 
Loglevel fixes

- fix event list bug due to loglevel error,
- enforce "-1" loglevel value in the sessiond when ALL loglevels are
  selected.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoInstall quickstart.txt and ChangeLog into system doc/
Mathieu Desnoyers [Sat, 4 Feb 2012 21:46:21 +0000 (16:46 -0500)] 
Install quickstart.txt and ChangeLog into system doc/

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoCleanup list command printout for loglevel
Mathieu Desnoyers [Sat, 4 Feb 2012 17:42:19 +0000 (12:42 -0500)] 
Cleanup list command printout for loglevel

was:

(loglevel: TRACE_DEFAULT13)

should be:

(loglevel: TRACE_DEFAULT)

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoUpdate version to 2.0-pre19 v2.0-pre19
David Goulet [Thu, 2 Feb 2012 17:48:16 +0000 (12:48 -0500)] 
Update version to 2.0-pre19

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoUpdate lttng-kernel.h with padding
David Goulet [Thu, 2 Feb 2012 17:27:35 +0000 (12:27 -0500)] 
Update lttng-kernel.h with padding

Rename LTTNG_SYM_NAME_LEN to LTTNG_KERNEL_SYM_NAME_LEN. (following
lttng-modules ABI).

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoUpdate lttng.h with padding
David Goulet [Thu, 2 Feb 2012 17:27:28 +0000 (12:27 -0500)] 
Update lttng.h with padding

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoMerge branch 'master' of git://git.lttng.org/lttng-tools
David Goulet [Thu, 2 Feb 2012 16:55:22 +0000 (11:55 -0500)] 
Merge branch 'master' of git://git.lttng.org/lttng-tools

12 years agoShow error if kernel tracer version don't match
Mathieu Desnoyers [Thu, 2 Feb 2012 16:55:39 +0000 (11:55 -0500)] 
Show error if kernel tracer version don't match

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoFix EEXIST handling on epoll_ctl add
David Goulet [Thu, 2 Feb 2012 16:47:37 +0000 (11:47 -0500)] 
Fix EEXIST handling on epoll_ctl add

Creating a second channel on the kernel tracer triggers a
update_kernel_poll which iterates over all channels and add the file
descriptors to the epoll set. Collision occurs with the first previously
added channel so EEXIST is acceptable and we simply do not perror() to
keep the session daemon stderr clean.

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoFix session listing msg when session name not found
David Goulet [Thu, 2 Feb 2012 16:47:31 +0000 (11:47 -0500)] 
Fix session listing msg when session name not found

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoVerify UST comm proto version
Mathieu Desnoyers [Thu, 2 Feb 2012 16:41:58 +0000 (11:41 -0500)] 
Verify UST comm proto version

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoUpdate local copy of UST ABI, for padding
Mathieu Desnoyers [Thu, 2 Feb 2012 16:19:49 +0000 (11:19 -0500)] 
Update local copy of UST ABI, for padding

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoMerge branch 'master' of git://git.lttng.org/lttng-tools
David Goulet [Thu, 2 Feb 2012 15:26:45 +0000 (10:26 -0500)] 
Merge branch 'master' of git://git.lttng.org/lttng-tools

12 years agoRevert "Simplify create_session of lttng create command"
David Goulet [Thu, 2 Feb 2012 15:19:04 +0000 (10:19 -0500)] 
Revert "Simplify create_session of lttng create command"

This reverts commit 318e4c832cc9a4209dcea885ef2a66cfd16f99d2.

The create_session function was changed making the session name not
having the date and time append to it anymore. This completely broke the
default behavior of automatic session creation. Only one possible
session name was 'auto'.

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoFix return value of list command
David Goulet [Thu, 2 Feb 2012 15:17:16 +0000 (10:17 -0500)] 
Fix return value of list command

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoFix missing strncmp return value comparison
David Goulet [Thu, 2 Feb 2012 15:10:42 +0000 (10:10 -0500)] 
Fix missing strncmp return value comparison

Remove CMD_ERROR forced value in lttng cli list command.

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoUpdate loglevel names
Mathieu Desnoyers [Thu, 2 Feb 2012 15:07:13 +0000 (10:07 -0500)] 
Update loglevel names

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoFix loglevel selection, implement loglevel help.
Mathieu Desnoyers [Thu, 2 Feb 2012 04:23:32 +0000 (23:23 -0500)] 
Fix loglevel selection, implement loglevel help.

Some loglevel information was not passed across the chain.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoABI update: only send loglevel value to UST: fixed loglevels
Mathieu Desnoyers [Thu, 2 Feb 2012 00:24:47 +0000 (19:24 -0500)] 
ABI update: only send loglevel value to UST: fixed loglevels

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoFix memory leak in lttng cli
David Goulet [Wed, 1 Feb 2012 23:38:13 +0000 (18:38 -0500)] 
Fix memory leak in lttng cli

Reported-by: Daniel U. Thibault <daniel.thibault@drdc-rddc.gc.ca>
Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoFix wording in lttng cli usage
David Goulet [Wed, 1 Feb 2012 23:29:02 +0000 (18:29 -0500)] 
Fix wording in lttng cli usage

Fix cherry picked from Daniel U. Thibault
<daniel.thibault@drdc-rddc.gc.ca> patches.

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoFix enable channel usage and add enable event error msg
David Goulet [Wed, 1 Feb 2012 23:19:20 +0000 (18:19 -0500)] 
Fix enable channel usage and add enable event error msg

Channel options were missing details to the usage text.

Also, add an error message if an event option is passed to user-space
that is not supported.

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoImprove error handling of lttng cli
David Goulet [Wed, 1 Feb 2012 23:09:11 +0000 (18:09 -0500)] 
Improve error handling of lttng cli

Most of the commands were not returning a valid error code to the user.

Add "UST invalid context" lttcomm code and enforce "-t TYPE" for
add-context command.

Change error message for enable/disable event/channel in order to make
it standard for those commands and more meaningful to the user.

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoDon't spawen session daemon on version command
David Goulet [Wed, 1 Feb 2012 20:56:31 +0000 (15:56 -0500)] 
Don't spawen session daemon on version command

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoFix return value and mem leak for all commands
Thibault, Daniel [Wed, 1 Feb 2012 18:59:50 +0000 (13:59 -0500)] 
Fix return value and mem leak for all commands

Add poptFreeContext(), send --help to stdout and default return value to
CMD_SUCCESS

Also fix some return values for list.c

Signed-off-by: Daniel U. Thibault <daniel.thibault@drdc-rddc.gc.ca>
Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoFix loglevel handling in test case (API change) and lttng command
Mathieu Desnoyers [Wed, 1 Feb 2012 19:39:49 +0000 (14:39 -0500)] 
Fix loglevel handling in test case (API change) and lttng command

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoRevert "Revert "Update loglevel ABI""
Mathieu Desnoyers [Wed, 1 Feb 2012 19:01:28 +0000 (14:01 -0500)] 
Revert "Revert "Update loglevel ABI""

This reverts commit 69892bbba677a6695b216046d586e58bfa0f82c9.

Revert of revert, need to go forward for ABI change.

Will fix problems in a following commit.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoRevert "Update loglevel ABI"
David Goulet [Wed, 1 Feb 2012 18:43:05 +0000 (13:43 -0500)] 
Revert "Update loglevel ABI"

Segfault on lttng enable-event when no loglevel is specified.

UST tests failed.

This implementation forces a loglevel to each event which is fine
however the default level is never set when no loglevel is specified.

The internal UST ABI/API (used when lttng-ust is disabled) was not
updated also making it fail when disablin the lttng-ust support.

This broke too much stuff in lttng-tools so the commit is reverted and
test must pass before commiting it again.

lttng-ust HEAD will *NOT* work with lttng-tools head so stay on commit
939950af98d044a3b0632cad5293f91cb1493ef8 for UST.

This reverts commit dad47fc4c65ec0acbfedc676895833b465d25cd6.

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoFix memory leak in create command
Thibault, Daniel [Tue, 31 Jan 2012 19:32:56 +0000 (14:32 -0500)] 
Fix memory leak in create command

Signed-off-by: Daniel U. Thibault <daniel.thibault@drdc-rddc.gc.ca>
Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoHarmonise lttng.h and lttng-ctl.c documentation
Thibault, Daniel [Tue, 31 Jan 2012 17:31:02 +0000 (12:31 -0500)] 
Harmonise lttng.h and lttng-ctl.c documentation

Fix comments alignment.

Signed-off-by: Daniel U. Thibault <daniel.thibault@drdc-rddc.gc.ca>
Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoUpdate loglevel ABI
Mathieu Desnoyers [Tue, 31 Jan 2012 22:18:54 +0000 (17:18 -0500)] 
Update loglevel ABI

Loglevels are now an attribute part of an event, rather than an event
per se.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
12 years agoUse lttng-consumerd of the code tree for tests
David Goulet [Tue, 31 Jan 2012 15:47:54 +0000 (10:47 -0500)] 
Use lttng-consumerd of the code tree for tests

Better use the consumer daemon in tree that we just built and not the
one installed on the system that might be quite old ;)

Signed-off-by: David Goulet <dgoulet@efficios.com>
12 years agoFixing memory leaks in add-context command
Thibault, Daniel [Mon, 30 Jan 2012 21:58:22 +0000 (16:58 -0500)] 
Fixing memory leaks in add-context command

Besides enforcing the return values and outputting --help to stdout, the
problem lay with the instances of struct ctx_type *type being created
but not assigned to the doubly-linked list under various error
conditions.

Signed-off-by: Daniel U. Thibault <daniel.thibault@drdc-rddc.gc.ca>
Signed-off-by: David Goulet <dgoulet@efficios.com>
This page took 0.041855 seconds and 4 git commands to generate.