From: Jonathan Rajotte Date: Tue, 1 Mar 2022 14:09:04 +0000 (-0500) Subject: Fix: lttng-ctl: uninitialized pointer read X-Git-Url: https://git.lttng.org/?a=commitdiff_plain;ds=sidebyside;h=821a8b53753b1d39932ae8e208cb5d3e675a760d;p=lttng-tools.git Fix: lttng-ctl: uninitialized pointer read Reported by Coverity: CID 1475822: Uninitialized pointer read (UNINIT) Using uninitialized value reply._fd_handles.array.size when calling lttng_payload_reset. Signed-off-by: Jonathan Rajotte Signed-off-by: Jérémie Galarneau Change-Id: Ied7f5de61d736e8d8f9c869a36322262a4d79cd5 --- diff --git a/src/lib/lttng-ctl/lttng-ctl.cpp b/src/lib/lttng-ctl/lttng-ctl.cpp index c7fb313f9..f99ce672c 100644 --- a/src/lib/lttng-ctl/lttng-ctl.cpp +++ b/src/lib/lttng-ctl/lttng-ctl.cpp @@ -2416,14 +2416,14 @@ int lttng_list_events(struct lttng_handle *handle, (const char *) &lsm, 0, sizeof(lsm)); unsigned int nb_events = 0; + lttng_payload_init(&reply); + /* Safety check. An handle and channel name are mandatory. */ if (handle == NULL || channel_name == NULL) { ret = -LTTNG_ERR_INVALID; goto end; } - lttng_payload_init(&reply); - /* Initialize command parameters. */ lsm.cmd_type = LTTNG_LIST_EVENTS; ret = lttng_strncpy(lsm.session.name, handle->session_name,