- Protect variables
- use /bin/sh instead of /bin/bash
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
# Copyright (C) 2009 Benjamin Poirier
# This program is free software; you can redistribute it and/or modify
# Copyright (C) 2009 Benjamin Poirier
# This program is free software; you can redistribute it and/or modify
-if [ ! "$DEBUGFSROOT" ]; then
+if [ ! "${DEBUGFSROOT}" ]; then
echo "Error: debugfs not mounted" > /dev/stderr
exit 1;
fi
echo "Error: debugfs not mounted" > /dev/stderr
exit 1;
fi
-if [ ! -d "$MARKERSROOT" ]; then
+if [ ! -d "${MARKERSROOT}" ]; then
echo "Error: LTT trace controller not found (did you compile and load LTTng?)" > /dev/stderr
exit 1;
fi
while getopts "lnqh" options; do
echo "Error: LTT trace controller not found (did you compile and load LTTng?)" > /dev/stderr
exit 1;
fi
while getopts "lnqh" options; do
l) LOCKING="0";;
n) NETWORK="0";;
q) QUIET="0";;
l) LOCKING="0";;
n) NETWORK="0";;
q) QUIET="0";;
+shift $((${OPTIND} - 1))
+if [ ! ${LOCKING} ]; then
TESTS="${TESTS} -name lockdep -prune -o -name locking -prune -o"
fi
TESTS="${TESTS} -name lockdep -prune -o -name locking -prune -o"
fi
+if [ ! ${NETWORK} ]; then
TESTS="${TESTS} -path '*/net/*_extended' -prune -o"
fi
while read -r -d $'\0' marker; do
TESTS="${TESTS} -path '*/net/*_extended' -prune -o"
fi
while read -r -d $'\0' marker; do
+ if [ ! ${QUIET} ]; then
echo "Connecting ${marker%/enable}"
fi
echo "Connecting ${marker%/enable}"
fi
- echo 1 > $marker
-done < <(eval "find '$MARKERSROOT' $TESTS -name metadata -prune -o -name enable -print0")
+ echo 1 > ${marker}
+done < <(eval "find '${MARKERSROOT}' ${TESTS} -name metadata -prune -o -name enable -print0")
# Copyright (C) 2009 Benjamin Poirier
# This program is free software; you can redistribute it and/or modify
# Copyright (C) 2009 Benjamin Poirier
# This program is free software; you can redistribute it and/or modify
-if [ ! "$DEBUGFSROOT" ]; then
+if [ ! "${DEBUGFSROOT}" ]; then
echo "Error: debugfs not mounted" > /dev/stderr
exit 1;
fi
echo "Error: debugfs not mounted" > /dev/stderr
exit 1;
fi
-if [ ! -d "$MARKERSROOT" ]; then
+if [ ! -d "${MARKERSROOT}" ]; then
echo "Error: LTT trace controller not found (did you compile and load LTTng?)" > /dev/stderr
exit 1;
fi
while getopts "qh" options; do
echo "Error: LTT trace controller not found (did you compile and load LTTng?)" > /dev/stderr
exit 1;
fi
while getopts "qh" options; do
q) QUIET="0";;
h) usage;
exit 0;;
q) QUIET="0";;
h) usage;
exit 0;;
+shift $((${OPTIND} - 1))
while read -r -d $'\0' marker; do
while read -r -d $'\0' marker; do
- grep "^1$" "$marker" -q
+ grep "^1$" "${marker}" -q
if [ $? -ne 0 ]; then
continue
fi
if [ $? -ne 0 ]; then
continue
fi
+ if [ ! ${QUIET} ]; then
echo "Disconnecting ${marker%/enable}"
fi
echo "Disconnecting ${marker%/enable}"
fi
- echo 0 > $marker
-done < <(eval "find '$MARKERSROOT' -name metadata -prune -o -name enable -print0")
+ echo 0 > ${marker}
+done < <(eval "find '${MARKERSROOT}' -name metadata -prune -o -name enable -print0")