Errors encountered in relay_close_trace_chunk are not reported to the
caller as the 'ret' value is re-used to check for the successful
'append' to a dynamic buffer. Use a separate variable.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
struct relay_connection *conn,
const struct lttng_buffer_view *payload)
{
struct relay_connection *conn,
const struct lttng_buffer_view *payload)
{
ssize_t send_ret;
struct relay_session *session = conn->session;
struct lttcomm_relayd_close_trace_chunk *msg;
ssize_t send_ret;
struct relay_session *session = conn->session;
struct lttcomm_relayd_close_trace_chunk *msg;
end:
reply.generic.ret_code = htobe32((uint32_t) reply_code);
reply.path_length = htobe32((uint32_t) path_length);
end:
reply.generic.ret_code = htobe32((uint32_t) reply_code);
reply.path_length = htobe32((uint32_t) path_length);
- ret = lttng_dynamic_buffer_append(
+ buf_ret = lttng_dynamic_buffer_append(
&reply_payload, &reply, sizeof(reply));
&reply_payload, &reply, sizeof(reply));
ERR("Failed to append \"close trace chunk\" command reply header to payload buffer");
goto end_no_reply;
}
if (reply_code == LTTNG_OK) {
ERR("Failed to append \"close trace chunk\" command reply header to payload buffer");
goto end_no_reply;
}
if (reply_code == LTTNG_OK) {
- ret = lttng_dynamic_buffer_append(&reply_payload,
+ buf_ret = lttng_dynamic_buffer_append(&reply_payload,
closed_trace_chunk_path, path_length);
closed_trace_chunk_path, path_length);
ERR("Failed to append \"close trace chunk\" command reply path to payload buffer");
goto end_no_reply;
}
ERR("Failed to append \"close trace chunk\" command reply path to payload buffer");
goto end_no_reply;
}