X-Git-Url: https://git.lttng.org/?a=blobdiff_plain;f=tests%2Funit%2Ftest_utils_parse_size_suffix.cpp;h=840d4fc5bd93b88347d4709ae534f9b695a70c75;hb=fa9870ceddc6f5ddd4bbf8cda2a87365b78fdf0e;hp=04f2fffe1ea0cfad74def9db809eec1075e8c74f;hpb=740da7d5000ca1ffdcf14bda5096bf7ccfb86bdd;p=lttng-tools.git

diff --git a/tests/unit/test_utils_parse_size_suffix.cpp b/tests/unit/test_utils_parse_size_suffix.cpp
index 04f2fffe1..840d4fc5b 100644
--- a/tests/unit/test_utils_parse_size_suffix.cpp
+++ b/tests/unit/test_utils_parse_size_suffix.cpp
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2013 Simon Marchi <simon.marchi@polymtl.ca>
+ * Copyright (C) 2013 EfficiOS Inc.
  *
  * SPDX-License-Identifier: GPL-2.0-only
  *
@@ -10,20 +10,21 @@
 
 #include <tap/tap.h>
 
-#include <common/utils.h>
+#include <common/utils.hpp>
 
 /* For error.h */
 int lttng_opt_quiet = 1;
 int lttng_opt_verbose = 3;
 int lttng_opt_mi;
 
+namespace {
 struct valid_test_input {
 	const char *input;
 	uint64_t expected_result;
 };
 
 /* Valid test cases */
-static struct valid_test_input valid_tests_inputs[] = {
+struct valid_test_input valid_tests_inputs[] = {
 		{ "0", 0 },
 		{ "1234", 1234 },
 		{ "0x400", 1024 },
@@ -65,10 +66,10 @@ static struct valid_test_input valid_tests_inputs[] = {
 		{ "0XA0M", 167772160 },
 		{ "0xA0G", 171798691840ULL },
 };
-static const int num_valid_tests = sizeof(valid_tests_inputs) / sizeof(valid_tests_inputs[0]);
+const int num_valid_tests = sizeof(valid_tests_inputs) / sizeof(valid_tests_inputs[0]);
 
 /* Invalid test cases */
-static const char *invalid_tests_inputs[] = {
+const char *invalid_tests_inputs[] = {
 		"",
 		" ",
 		"-1",
@@ -90,7 +91,8 @@ static const char *invalid_tests_inputs[] = {
 		"0B",
 };
 
-static const int num_invalid_tests = sizeof(invalid_tests_inputs) / sizeof(invalid_tests_inputs[0]);
+const int num_invalid_tests = sizeof(invalid_tests_inputs) / sizeof(invalid_tests_inputs[0]);
+} /* namespace */
 
 static void test_utils_parse_size_suffix(void)
 {
@@ -104,7 +106,7 @@ static void test_utils_parse_size_suffix(void)
 		sprintf(name, "valid test case: %s", valid_tests_inputs[i].input);
 
 		ret = utils_parse_size_suffix(valid_tests_inputs[i].input, &result);
-		ok(ret == 0 && result == valid_tests_inputs[i].expected_result, name);
+		ok(ret == 0 && result == valid_tests_inputs[i].expected_result, "%s", name);
 	}
 
 	/* Test invalid cases */
@@ -113,11 +115,11 @@ static void test_utils_parse_size_suffix(void)
 		sprintf(name, "invalid test case: %s", invalid_tests_inputs[i]);
 
 		ret = utils_parse_size_suffix(invalid_tests_inputs[i], &result);
-		ok(ret != 0, name);
+		ok(ret != 0, "%s", name);
 	}
 }
 
-int main(int argc, char **argv)
+int main(void)
 {
 	plan_tests(num_valid_tests + num_invalid_tests);