X-Git-Url: https://git.lttng.org/?a=blobdiff_plain;f=tests%2Funit%2Ftest_session.c;h=b538bddc6bac261ca2a6615d065ebcce11b71126;hb=3517bb6841bfddf35ef13f173055c53fad5fc16a;hp=fa3e367d20b121f5a7da4dfbb8e73a041d483eaf;hpb=b178f53e90c376dd44b020535c32649edef8f80e;p=lttng-tools.git diff --git a/tests/unit/test_session.c b/tests/unit/test_session.c index fa3e367d2..b538bddc6 100644 --- a/tests/unit/test_session.c +++ b/tests/unit/test_session.c @@ -132,7 +132,7 @@ static int create_one_session(char *name) struct ltt_session *session = NULL; session_lock_list(); - ret_code = session_create(name, geteuid(), getegid(), &session); + ret_code = session_create(name, geteuid(), getegid(), NULL, &session); session_put(session); if (ret_code == LTTNG_OK) { /* Validate */ @@ -141,21 +141,17 @@ static int create_one_session(char *name) /* Session not found by name */ printf("session not found after creation\n"); ret = -1; - goto end; } else { /* Success */ ret = 0; - goto end; } } else { if (ret_code == LTTNG_ERR_EXIST_SESS) { printf("(session already exists) "); } ret = -1; - goto end; } - ret = 0; -end: + session_unlock_list(); return ret; } @@ -243,13 +239,19 @@ void test_validate_session(void) ok(tmp != NULL, "Validating session: session found"); - ok(tmp->kernel_session == NULL && - strlen(tmp->name), - "Validating session: basic sanity check"); + if (tmp) { + ok(tmp->kernel_session == NULL && + strlen(tmp->name), + "Validating session: basic sanity check"); + } else { + skip(1, "Skipping session validation check as session was not found"); + goto end; + } session_lock(tmp); session_unlock(tmp); session_put(tmp); +end: session_unlock_list(); } @@ -263,9 +265,13 @@ void test_destroy_session(void) ok(tmp != NULL, "Destroying session: session found"); - ok(destroy_one_session(tmp) == 0, - "Destroying session: %s destroyed", - SESSION1); + if (tmp) { + ok(destroy_one_session(tmp) == 0, + "Destroying session: %s destroyed", + SESSION1); + } else { + skip(1, "Skipping session destruction as it was not found"); + } session_unlock_list(); } @@ -282,7 +288,7 @@ void test_session_name_generation(void) const char *expected_session_name_prefix = DEFAULT_SESSION_NAME; session_lock_list(); - ret_code = session_create(NULL, geteuid(), getegid(), &session); + ret_code = session_create(NULL, geteuid(), getegid(), NULL, &session); ok(ret_code == LTTNG_OK, "Create session with a NULL name (auto-generate a name)"); if (!session) {