X-Git-Url: https://git.lttng.org/?a=blobdiff_plain;f=tests%2Fregression%2Ftools%2Fhealth%2Ftest_tp_fail;h=fdb8745a2acf8167446d00b0b3664412747e349d;hb=33c820d6c1f3b742a0028e0219b21e364baade78;hp=0b474fa7896396a593d04f09e84aae2e4e82102a;hpb=ef8343605f92072ca2ed7174b0cc2594ee33dfab;p=lttng-tools.git

diff --git a/tests/regression/tools/health/test_tp_fail b/tests/regression/tools/health/test_tp_fail
index 0b474fa78..fdb8745a2 100755
--- a/tests/regression/tools/health/test_tp_fail
+++ b/tests/regression/tools/health/test_tp_fail
@@ -24,14 +24,14 @@ SESSION_NAME="health_tp_fail"
 EVENT_NAME="bogus"
 HEALTH_CHECK_BIN="health_check"
 SESSIOND_PRELOAD=".libs/libhealthtpfail.so"
+NUM_TESTS=9
 
 source $TESTDIR/utils/utils.sh
 
 print_test_banner "$TEST_DESC"
 
 if [ ! -f "$CURDIR/$SESSIOND_PRELOAD" ]; then
-	echo -e "libhealthtpfail.so not available for this test. Skipping."
-	exit 0
+	BAIL_OUT "libhealthtpfail.so not available for this test."
 fi
 
 function test_tp_fail
@@ -39,8 +39,7 @@ function test_tp_fail
 	test_tp_fail_name="$1"
 	test_tp_fail_code="$2"
 
-	echo ""
-	echo -e "=== Testing health failure with ${test_tp_fail_name}"
+	diag "Test health failure with ${test_tp_fail_name}"
 
 	# Activate testpoints
 	export LTTNG_TESTPOINT_ENABLE=1
@@ -56,31 +55,29 @@ function test_tp_fail
 	unset LD_PRELOAD
 	unset ${test_tp_fail_name}_TP_FAIL
 
-	echo -n "Validating thread ${test_tp_fail_name} failure... "
-
 	# Check health status, exit code should indicate failure
 	$CURDIR/$HEALTH_CHECK_BIN &> /dev/null
 
 	health_check_exit_code=$?
 
 	if [ $health_check_exit_code -eq $test_tp_fail_code ]; then
-		print_ok
+		pass "Validate thread ${test_tp_fail_name} failure"
 		stop_lttng_sessiond
 	else
-		print_fail
-		echo -e "Health returned: $health_check_exit_code\n"
-
+		fail "Validate thread ${test_tp_fail_name} failure"
+		diag "Health returned: $health_check_exit_code"
 		stop_lttng_sessiond
 		return 1
 	fi
 }
 
+plan_tests $NUM_TESTS
+
 THREAD=("LTTNG_THREAD_MANAGE_CLIENTS"
-	"LTTNG_THREAD_MANAGE_APPS"
-	"LTTNG_THREAD_MANAGE_KERNEL")
+	"LTTNG_THREAD_MANAGE_APPS")
 
 # Exit code value to indicate specific thread failure
-EXIT_CODE=(1 2 8)
+EXIT_CODE=(1 2)
 
 THREAD_COUNT=${#THREAD[@]}
 i=0
@@ -94,5 +91,18 @@ while [ "$i" -lt "$THREAD_COUNT" ]; do
 	let "i++"
 done
 
-# Special case manage consumer, need to spawn consumer via commands.
+# The manage kernel thread is only spawned if we are root
+if [ "$(id -u)" == "0" ]; then
+	isroot=1
+else
+	isroot=0
+fi
+
+skip $isroot "Root access is needed. Skipping LTTNG_THREAD_MANAGE_KERNEL tests." "3" ||
+{
+	test_tp_fail "LTTNG_THREAD_MANAGE_KERNEL" "8"
+}
+
+
+# TODO: Special case manage consumer, need to spawn consumer via commands.
 #"LTTNG_THREAD_MANAGE_CONSUMER"