X-Git-Url: https://git.lttng.org/?a=blobdiff_plain;f=src%2Flttng-bytecode.c;h=38c2d18380c3a5e4c510a6123c13b4c8b9262c43;hb=684a1e4d7e9a4cf1070e5202e419e1b9f6e9853c;hp=79c581c812c54541d24a38909f4d941e8ba9fa86;hpb=80c2a69a8298768c9010052e6c3668914191b9e7;p=lttng-modules.git

diff --git a/src/lttng-bytecode.c b/src/lttng-bytecode.c
index 79c581c8..38c2d183 100644
--- a/src/lttng-bytecode.c
+++ b/src/lttng-bytecode.c
@@ -244,12 +244,29 @@ int apply_field_reloc(const struct lttng_event_desc *event_desc,
 			op->op = BYTECODE_OP_LOAD_FIELD_REF_S64;
 			break;
 		case atype_array_nestable:
+		{
+			const struct lttng_type *elem_type = field->type.u.array_nestable.elem_type;
+
+			if (!lttng_is_bytewise_integer(elem_type) || elem_type->u.integer.encoding == lttng_encode_none)
+				return -EINVAL;
+			if (field->user)
+				op->op = BYTECODE_OP_LOAD_FIELD_REF_USER_SEQUENCE;
+			else
+				op->op = BYTECODE_OP_LOAD_FIELD_REF_SEQUENCE;
+			break;
+		}
 		case atype_sequence_nestable:
+		{
+			const struct lttng_type *elem_type = field->type.u.sequence_nestable.elem_type;
+
+			if (!lttng_is_bytewise_integer(elem_type) || elem_type->u.integer.encoding == lttng_encode_none)
+				return -EINVAL;
 			if (field->user)
 				op->op = BYTECODE_OP_LOAD_FIELD_REF_USER_SEQUENCE;
 			else
 				op->op = BYTECODE_OP_LOAD_FIELD_REF_SEQUENCE;
 			break;
+		}
 		case atype_string:
 			if (field->user)
 				op->op = BYTECODE_OP_LOAD_FIELD_REF_USER_STRING;
@@ -314,17 +331,25 @@ int apply_context_reloc(struct bytecode_runtime *runtime,
 			op->op = BYTECODE_OP_GET_CONTEXT_REF_STRING;
 			break;
 		case atype_array_nestable:
-			if (!lttng_is_bytewise_integer(ctx_field->event_field.type.u.array_nestable.elem_type))
+		{
+			const struct lttng_type *elem_type = ctx_field->event_field.type.u.array_nestable.elem_type;
+
+			if (!lttng_is_bytewise_integer(elem_type) || elem_type->u.integer.encoding == lttng_encode_none)
 				return -EINVAL;
 			BUG_ON(ctx_field->event_field.user);
 			op->op = BYTECODE_OP_GET_CONTEXT_REF_STRING;
 			break;
+		}
 		case atype_sequence_nestable:
-			if (!lttng_is_bytewise_integer(ctx_field->event_field.type.u.sequence_nestable.elem_type))
+		{
+			const struct lttng_type *elem_type = ctx_field->event_field.type.u.sequence_nestable.elem_type;
+
+			if (!lttng_is_bytewise_integer(elem_type) || elem_type->u.integer.encoding == lttng_encode_none)
 				return -EINVAL;
 			BUG_ON(ctx_field->event_field.user);
 			op->op = BYTECODE_OP_GET_CONTEXT_REF_STRING;
 			break;
+		}
 		case atype_struct_nestable:	/* Unsupported. */
 		case atype_variant_nestable:	/* Unsupported. */
 		default:
@@ -395,9 +420,10 @@ int bytecode_is_linked(struct lttng_bytecode_node *bytecode,
  * bytecode runtime.
  */
 static
-int _lttng_filter_link_bytecode(const struct lttng_event_desc *event_desc,
+int link_bytecode(const struct lttng_event_desc *event_desc,
 		struct lttng_ctx *ctx,
 		struct lttng_bytecode_node *bytecode,
+		struct list_head *bytecode_runtime_head,
 		struct list_head *insert_loc)
 {
 	int ret, offset, next_offset;
@@ -407,7 +433,7 @@ int _lttng_filter_link_bytecode(const struct lttng_event_desc *event_desc,
 	if (!bytecode)
 		return 0;
 	/* Bytecode already linked */
-	if (bytecode_is_linked(bytecode, insert_loc))
+	if (bytecode_is_linked(bytecode, bytecode_runtime_head))
 		return 0;
 
 	dbg_printk("Linking...\n");
@@ -452,14 +478,35 @@ int _lttng_filter_link_bytecode(const struct lttng_event_desc *event_desc,
 	if (ret) {
 		goto link_error;
 	}
-	runtime->p.filter = lttng_bytecode_filter_interpret;
+
+	switch (bytecode->type) {
+	case LTTNG_BYTECODE_NODE_TYPE_FILTER:
+		runtime->p.interpreter_funcs.filter = lttng_bytecode_filter_interpret;
+		break;
+	case LTTNG_BYTECODE_NODE_TYPE_CAPTURE:
+		runtime->p.interpreter_funcs.capture = lttng_bytecode_capture_interpret_false;
+		break;
+	default:
+		WARN_ON(1);
+	}
+
 	runtime->p.link_failed = 0;
 	list_add_rcu(&runtime->p.node, insert_loc);
 	dbg_printk("Linking successful.\n");
 	return 0;
 
 link_error:
-	runtime->p.filter = lttng_bytecode_filter_interpret_false;
+
+	switch (bytecode->type) {
+	case LTTNG_BYTECODE_NODE_TYPE_FILTER:
+		runtime->p.interpreter_funcs.filter = lttng_bytecode_filter_interpret_false;
+		break;
+	case LTTNG_BYTECODE_NODE_TYPE_CAPTURE:
+		runtime->p.interpreter_funcs.capture = lttng_bytecode_capture_interpret_false;
+		break;
+	default:
+		WARN_ON(1);
+	}
 	runtime->p.link_failed = 1;
 	list_add_rcu(&runtime->p.node, insert_loc);
 alloc_error:
@@ -467,43 +514,64 @@ alloc_error:
 	return ret;
 }
 
-void lttng_filter_sync_state(struct lttng_bytecode_runtime *runtime)
+void lttng_bytecode_filter_sync_state(struct lttng_bytecode_runtime *runtime)
 {
 	struct lttng_bytecode_node *bc = runtime->bc;
 
 	if (!bc->enabler->enabled || runtime->link_failed)
-		runtime->filter = lttng_bytecode_filter_interpret_false;
+		runtime->interpreter_funcs.filter = lttng_bytecode_filter_interpret_false;
 	else
-		runtime->filter = lttng_bytecode_filter_interpret;
+		runtime->interpreter_funcs.filter = lttng_bytecode_filter_interpret;
+}
+
+void lttng_bytecode_capture_sync_state(struct lttng_bytecode_runtime *runtime)
+{
+	struct lttng_bytecode_node *bc = runtime->bc;
+
+	if (!bc->enabler->enabled || runtime->link_failed)
+		runtime->interpreter_funcs.capture = lttng_bytecode_capture_interpret_false;
+	else
+		runtime->interpreter_funcs.capture = lttng_bytecode_capture_interpret;
 }
 
 /*
- * Link bytecode for all enablers referenced by an event.
+ * Given the lists of bytecode programs of an instance (event or event
+ * notifier) and of a matching enabler, try to link all the enabler's bytecode
+ * programs with the instance.
+ *
+ * This function is called after we confirmed that name enabler and the
+ * instance are matching names (or glob pattern matching).
  */
 void lttng_enabler_link_bytecode(const struct lttng_event_desc *event_desc,
 		struct lttng_ctx *ctx,
-		struct list_head *bytecode_runtime_head,
-		struct lttng_enabler *enabler)
+		struct list_head *instance_bytecode_head,
+		struct list_head *enabler_bytecode_head)
 {
-	struct lttng_bytecode_node *bc;
+	struct lttng_bytecode_node *enabler_bc;
 	struct lttng_bytecode_runtime *runtime;
 
-	/* Can only be called for events with desc attached */
 	WARN_ON_ONCE(!event_desc);
 
-	/* Link each bytecode. */
-	list_for_each_entry(bc, &enabler->filter_bytecode_head, node) {
+	/* Go over all the bytecode programs of the enabler.  */
+	list_for_each_entry(enabler_bc, enabler_bytecode_head, node) {
 		int found = 0, ret;
 		struct list_head *insert_loc;
 
-		list_for_each_entry(runtime,
-				bytecode_runtime_head, node) {
-			if (runtime->bc == bc) {
+		/*
+		 * Check if the current enabler bytecode program is already
+		 * linked with the instance.
+		 */
+		list_for_each_entry(runtime, instance_bytecode_head, node) {
+			if (runtime->bc == enabler_bc) {
 				found = 1;
 				break;
 			}
 		}
-		/* Skip bytecode already linked */
+
+		/*
+		 * Skip bytecode already linked, go to the next enabler
+		 * bytecode program.
+		 */
 		if (found)
 			continue;
 
@@ -513,19 +581,18 @@ void lttng_enabler_link_bytecode(const struct lttng_event_desc *event_desc,
 		 * insert the new bytecode right after it.
 		 */
 		list_for_each_entry_reverse(runtime,
-				bytecode_runtime_head, node) {
-			if (runtime->bc->bc.seqnum <= bc->bc.seqnum) {
+				instance_bytecode_head, node) {
+			if (runtime->bc->bc.seqnum <= enabler_bc->bc.seqnum) {
 				/* insert here */
 				insert_loc = &runtime->node;
 				goto add_within;
 			}
 		}
 		/* Add to head to list */
-		insert_loc = bytecode_runtime_head;
+		insert_loc = instance_bytecode_head;
 	add_within:
 		dbg_printk("linking bytecode\n");
-		ret = _lttng_filter_link_bytecode(event_desc, ctx, bc,
-			insert_loc);
+		ret = link_bytecode(event_desc, ctx, enabler_bc, instance_bytecode_head, insert_loc);
 		if (ret) {
 			dbg_printk("[lttng filter] warning: cannot link event bytecode\n");
 		}
@@ -562,3 +629,14 @@ void lttng_free_event_filter_runtime(struct lttng_event *event)
 		kfree(runtime);
 	}
 }
+
+void lttng_free_event_notifier_filter_runtime(struct lttng_event_notifier *event_notifier)
+{
+	struct bytecode_runtime *runtime, *tmp;
+
+	list_for_each_entry_safe(runtime, tmp,
+			&event_notifier->filter_bytecode_runtime_head, p.node) {
+		kfree(runtime->data);
+		kfree(runtime);
+	}
+}