X-Git-Url: https://git.lttng.org/?a=blobdiff_plain;f=src%2Fbin%2Flttng-sessiond%2Fust-app.c;h=6e1dd60fd6b060a1437589a6594b30c0e69deefe;hb=80e327fa80045f6b470ac76963fc4b5d396a80a9;hp=335c20ff18556f6df3705be8be6440ff14b1f00e;hpb=9bc07046c0e2a572eb3821e276949537614f74e0;p=lttng-tools.git

diff --git a/src/bin/lttng-sessiond/ust-app.c b/src/bin/lttng-sessiond/ust-app.c
index 335c20ff1..6e1dd60fd 100644
--- a/src/bin/lttng-sessiond/ust-app.c
+++ b/src/bin/lttng-sessiond/ust-app.c
@@ -198,7 +198,10 @@ void delete_ust_app(struct ust_app *app)
 	 * closing this socket, otherwise an application could re-use the socket ID
 	 * and race with the teardown, using the same hash table entry.
 	 */
-	close(sock);
+	ret = close(sock);
+	if (ret) {
+		PERROR("close");
+	}
 
 	DBG2("UST app pid %d deleted", app->key.pid);
 	free(app);
@@ -1268,20 +1271,27 @@ error:
 int ust_app_register(struct ust_register_msg *msg, int sock)
 {
 	struct ust_app *lta;
+	int ret;
 
 	if ((msg->bits_per_long == 64 && ust_consumerd64_fd == -EINVAL)
 			|| (msg->bits_per_long == 32 && ust_consumerd32_fd == -EINVAL)) {
 		ERR("Registration failed: application \"%s\" (pid: %d) has "
 			"%d-bit long, but no consumerd for this long size is available.\n",
 			msg->name, msg->pid, msg->bits_per_long);
-		close(sock);
+		ret = close(sock);
+		if (ret) {
+			PERROR("close");
+		}
 		return -EINVAL;
 	}
 	if (msg->major != LTTNG_UST_COMM_MAJOR) {
 		ERR("Registration failed: application \"%s\" (pid: %d) has "
 			"communication protocol version %u.%u, but sessiond supports 2.x.\n",
 			msg->name, msg->pid, msg->major, msg->minor);
-		close(sock);
+		ret = close(sock);
+		if (ret) {
+			PERROR("close");
+		}
 		return -EINVAL;
 	}
 	lta = zmalloc(sizeof(struct ust_app));
@@ -1935,6 +1945,9 @@ int ust_app_start_trace(struct ltt_ust_session *usess, struct ust_app *app)
 		goto skip_setup;
 	}
 
+	/* Indicate that the session has been started once */
+	ua_sess->started = 1;
+
 	ret = create_ust_app_metadata(ua_sess, usess->pathname, app);
 	if (ret < 0) {
 		goto error_rcu_unlock;
@@ -1991,7 +2004,6 @@ int ust_app_start_trace(struct ltt_ust_session *usess, struct ust_app *app)
 	if (ret < 0) {
 		goto error_rcu_unlock;
 	}
-	ua_sess->started = 1;
 
 skip_setup:
 	/* This start the UST tracing */