X-Git-Url: https://git.lttng.org/?a=blobdiff_plain;f=src%2Fbin%2Flttng%2Fcommands%2Fstart.c;h=af93665d0ae16f74aec32044d0f27668696e86eb;hb=f1f887c09fa00f365bd56c025159524aa0d3ac50;hp=b2a4980055f4c480a1798b5c599e872a81c1ac93;hpb=679b4943c3b0f451e7f4fbcd804dd8a7a679e253;p=lttng-tools.git

diff --git a/src/bin/lttng/commands/start.c b/src/bin/lttng/commands/start.c
index b2a498005..af93665d0 100644
--- a/src/bin/lttng/commands/start.c
+++ b/src/bin/lttng/commands/start.c
@@ -63,7 +63,7 @@ static void usage(FILE *ofp)
  */
 static int start_tracing(void)
 {
-	int ret = CMD_SUCCESS;
+	int ret;
 	char *session_name;
 
 	if (opt_session_name == NULL) {
@@ -80,9 +80,12 @@ static int start_tracing(void)
 
 	ret = lttng_start_tracing(session_name);
 	if (ret < 0) {
+		/* Don't set ret so lttng can interpret the sessiond error. */
 		goto free_name;
 	}
 
+	ret = CMD_SUCCESS;
+
 	MSG("Tracing started for session %s", session_name);
 
 free_name:
@@ -100,7 +103,7 @@ error:
  */
 int cmd_start(int argc, const char **argv)
 {
-	int opt, ret;
+	int opt, ret = CMD_SUCCESS;
 	static poptContext pc;
 
 	pc = poptGetContext(NULL, argc, argv, long_options, 0);
@@ -109,12 +112,10 @@ int cmd_start(int argc, const char **argv)
 	while ((opt = poptGetNextOpt(pc)) != -1) {
 		switch (opt) {
 		case OPT_HELP:
-			usage(stderr);
-			ret = CMD_SUCCESS;
+			usage(stdout);
 			goto end;
 		case OPT_LIST_OPTIONS:
 			list_cmd_options(stdout, long_options);
-			ret = CMD_SUCCESS;
 			goto end;
 		default:
 			usage(stderr);
@@ -128,5 +129,6 @@ int cmd_start(int argc, const char **argv)
 	ret = start_tracing();
 
 end:
+	poptFreeContext(pc);
 	return ret;
 }