X-Git-Url: https://git.lttng.org/?a=blobdiff_plain;f=lttng%2Fcommands%2Fadd_context.c;h=1e6a807effb7393a30091bfb68e9a69c1d0cdeef;hb=636167b6d43e1b9e9e96c90672001c735dd61087;hp=afec9dab73ee469c754f53d2dd6734ec2401125d;hpb=d65106b1011efccf8fa5f9d7c8f2dfb0de38f5e8;p=lttng-tools.git

diff --git a/lttng/commands/add_context.c b/lttng/commands/add_context.c
index afec9dab7..1e6a807ef 100644
--- a/lttng/commands/add_context.c
+++ b/lttng/commands/add_context.c
@@ -32,10 +32,10 @@
 static char *opt_event_name;
 static char *opt_channel_name;
 static char *opt_perf_name;
+static char *opt_session_name;
 static int *opt_kernel;
 static int opt_pid_all;
 static int opt_userspace;
-static int opt_ctx_type;
 static int opt_perf_type;
 static int opt_perf_id;
 static pid_t opt_pid;
@@ -48,6 +48,7 @@ enum {
 static struct poptOption long_options[] = {
 	/* longName, shortName, argInfo, argPtr, value, descrip, argDesc */
 	{"help",           'h', POPT_ARG_NONE, 0, OPT_HELP, 0, 0},
+	{"session",        's', POPT_ARG_STRING, &opt_session_name, 0, 0, 0},
 	{"channel",        'c', POPT_ARG_STRING, &opt_channel_name, 0, 0, 0},
 	{"event",          'e', POPT_ARG_STRING, &opt_event_name, 0, 0, 0},
 	{"kernel",         'k', POPT_ARG_VAL, &opt_kernel, 1, 0, 0},
@@ -70,6 +71,7 @@ static void usage(FILE *ofp)
 	fprintf(ofp, "\n");
 	fprintf(ofp, "Options:\n");
 	fprintf(ofp, "  -h, --help               Show this help\n");
+	fprintf(ofp, "  -s, --session            Apply on session name\n");
 	fprintf(ofp, "  -c, --channel NAME       Apply on channel\n");
 	fprintf(ofp, "  -e, --event NAME         Apply on event\n");
 	fprintf(ofp, "  -k, --kernel             Apply for the kernel tracer\n");
@@ -118,18 +120,18 @@ static void usage(FILE *ofp)
  *
  *  Add context to channel or event.
  */
-static int add_context(void)
+static int add_context(int type)
 {
 	int ret = CMD_SUCCESS;
 	struct lttng_kernel_context context;
 
-	if (set_session_name() < 0) {
+	if (set_session_name(opt_session_name) < 0) {
 		ret = CMD_ERROR;
 		goto error;
 	}
 
-	context.ctx = opt_ctx_type;
-	if (opt_ctx_type == LTTNG_KERNEL_CONTEXT_PERF_COUNTER) {
+	context.ctx = type;
+	if (type == LTTNG_KERNEL_CONTEXT_PERF_COUNTER) {
 		context.u.perf_counter.type = opt_perf_type;
 		context.u.perf_counter.config = opt_perf_id;
 		strncpy(context.u.perf_counter.name, opt_perf_name,
@@ -137,7 +139,7 @@ static int add_context(void)
 	}
 
 	if (opt_kernel) {
-		DBG("Adding kernel context\n");
+		DBG("Adding kernel context");
 		ret = lttng_kernel_add_context(&context, opt_event_name, opt_channel_name);
 		if (ret < 0) {
 			goto error;
@@ -169,10 +171,15 @@ error:
  */
 int cmd_add_context(int argc, const char **argv)
 {
-	int opt, ret;
+	int opt, ret = CMD_SUCCESS;
 	char *tmp;
 	static poptContext pc;
 
+	if (argc < 2) {
+		usage(stderr);
+		goto end;
+	}
+
 	pc = poptGetContext(NULL, argc, argv, long_options, 0);
 	poptReadDefaultConfig(pc, 0);
 
@@ -188,9 +195,15 @@ int cmd_add_context(int argc, const char **argv)
 			if (tmp == NULL) {
 				usage(stderr);
 				ret = CMD_ERROR;
+				free(tmp);
 				goto end;
 			}
-			opt_ctx_type = atoi(tmp);
+			ret = add_context(atoi(tmp));
+			if (ret < 0) {
+				free(tmp);
+				goto end;
+			}
+			free(tmp);
 			break;
 		default:
 			usage(stderr);
@@ -199,8 +212,6 @@ int cmd_add_context(int argc, const char **argv)
 		}
 	}
 
-	ret = add_context();
-
 end:
 	return ret;
 }