X-Git-Url: https://git.lttng.org/?a=blobdiff_plain;f=ltt%2Fbranches%2Fpoly%2Fltt%2Fparser.c;h=7ac11e7ec8492fb683169fd5004c4cbd0fb2df18;hb=d27446d1c753dc4d628c3072f11e6b7581ccfcd8;hp=785cb652aaf2a47e7771024817649956274c6f28;hpb=0dee0e75e8a541ad435e9af431c426c53f155d71;p=lttv.git

diff --git a/ltt/branches/poly/ltt/parser.c b/ltt/branches/poly/ltt/parser.c
index 785cb652..7ac11e7e 100644
--- a/ltt/branches/poly/ltt/parser.c
+++ b/ltt/branches/poly/ltt/parser.c
@@ -1,11 +1,14 @@
+
+
+
 /*
 
 parser.c: Generate helper declarations and functions to trace events
   from an event description file.
 
-	    Copyright (C) 2005, Mathieu Desnoyers
+      Copyright (C) 2005, Mathieu Desnoyers
       Copyright (C) 2002, Xianxiu Yang
-      Copyright (C) 2002, Michel Dagenais 
+      Copyright (C) 2002, Michel Dagenais
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
    the Free Software Foundation; version 2 of the License.
@@ -20,9 +23,9 @@ parser.c: Generate helper declarations and functions to trace events
    Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307 USA
 */
 
-/* This program reads the ".xml" event definitions input files 
+/* This program reads the ".xml" event definitions input files
    and constructs structure for each event.
- 
+
    The program uses a very simple tokenizer, called from a hand written
    recursive descent parser to fill a data structure describing the events.
    The result is a sequence of events definitions which refer to type
@@ -30,14 +33,14 @@ parser.c: Generate helper declarations and functions to trace events
 
    A table of named types is maintained to allow refering to types by name
    when the same type is used at several places. Finally a sequence of
-   all types is maintained to facilitate the freeing of all type 
+   all types is maintained to facilitate the freeing of all type
    information when the processing of an ".xml" file is finished. */
 
-#include <stdlib.h> 
+#include <stdlib.h>
 #include <string.h>
 #include <stdio.h>
 #include <stdarg.h>
-#include <linux/errno.h>  
+#include <linux/errno.h>
 #include <assert.h>
 #include <ctype.h>
 
@@ -60,16 +63,16 @@ char *floatOutputTypes[] = {
 void strupper(char *string)
 {
   char *ptr = string;
-  
+
   while(*ptr != '\0') {
     *ptr = toupper(*ptr);
-		ptr++;
+    ptr++;
   }
 }
 
 
 int getSizeindex(unsigned int value)
-{ 
+{
   switch(value) {
     case 1:
       return 0;
@@ -88,20 +91,39 @@ int getSizeindex(unsigned int value)
 /*****************************************************************************
  *Function name
  *    getSize    : translate from string to integer
- *Input params 
+ *Input params
  *    in         : input file handle
- *Return values  
- *    size                           
+ *Return values
+ *    size
  *****************************************************************************/
 
 unsigned long long int getSize(parse_file_t *in)
 {
-  char *token;
+  char *token, *token2;
+  unsigned long long int ret;
 
   token = getToken(in);
+
+
+  if(in->type == QUOTEDSTRING) {
+    in->type = NUMBER;
+    token2 = token;
+    do {
+      if (!isdigit(*token2)) {
+        in->type = QUOTEDSTRING;
+        break;
+      }
+    } while (*(++token2) != '\0');
+  }
+
   if(in->type == NUMBER) {
-		return strtoull(token, NULL, 0);
+    ret = strtoull(token, NULL, 0);
+  } else {
+    goto error;
   }
+
+  return ret;
+error:
   in->error(in,"incorrect size specification");
   return -1;
 }
@@ -111,7 +133,7 @@ unsigned long long int getSize(parse_file_t *in)
  *    error_callback  : print out error info
  *Input params
  *    in              : input file handle
- *    msg             : message to be printed                  
+ *    msg             : message to be printed
  ****************************************************************************/
 
 void error_callback(parse_file_t *in, char *msg)
@@ -126,11 +148,11 @@ void error_callback(parse_file_t *in, char *msg)
 
 /*****************************************************************************
  *Function name
- *    memAlloc  : allocate memory                    
- *Input params 
- *    size      : required memory size               
- *return value 
- *    void *    : pointer to allocate memory or NULL 
+ *    memAlloc  : allocate memory
+ *Input params
+ *    size      : required memory size
+ *return value
+ *    void *    : pointer to allocate memory or NULL
  ****************************************************************************/
 
 void * memAlloc(int size)
@@ -139,18 +161,18 @@ void * memAlloc(int size)
   if(size == 0) return NULL;
   addr = malloc(size);
   if(!addr){
-    printf("Failed to allocate memory");    
+    printf("Failed to allocate memory");
     exit(1);
   }
-  return addr;	  
+  return addr;
 }
 
 /*****************************************************************************
  *Function name
- *    allocAndCopy : allocate memory and initialize it  
- *Input params 
- *    str          : string to be put in memory         
- *return value 
+ *    allocAndCopy : allocate memory and initialize it
+ *Input params
+ *    str          : string to be put in memory
+ *return value
  *    char *       : pointer to allocate memory or NULL
  ****************************************************************************/
 
@@ -176,24 +198,27 @@ char *allocAndCopy(char *str)
  **************************************************************************/
 
 void getTypeAttributes(parse_file_t *in, type_descriptor_t *t,
-			   sequence_t * unnamed_types, table_t * named_types) 
+         sequence_t * unnamed_types, table_t * named_types)
 {
   char * token;
+  int car;
 
   t->fmt = NULL;
   t->size = 0;
   t->custom_write = 0;
-  
+  t->network = 0;
+
   while(1) {
-    token = getToken(in); 
+    token = getToken(in);
     if(strcmp("/",token) == 0 || strcmp(">",token) == 0){
       ungetToken(in);
       break;
     }
-    
+
     if(!strcmp("format",token)) {
       getEqual(in);
       t->fmt = allocAndCopy(getQuotedString(in));
+      // printf("%s - ",t->fmt);
     //} else if(!strcmp("name",token)) {
      // getEqual(in);
      // car = seekNextChar(in);
@@ -205,6 +230,24 @@ void getTypeAttributes(parse_file_t *in, type_descriptor_t *t,
       t->size = getSize(in);
     } else if(!strcmp("custom_write", token)) {
       t->custom_write = 1;
+    } else if(!strcmp("byte_order",token)) {
+      getEqual(in);
+      car = seekNextChar(in);
+      if(car == EOF) in->error(in,"byte order was expected (network?)");
+      else if(car == '\"') token = getQuotedString(in);
+      else token = getName(in);
+      if(!strcmp("network", token)) {
+        t->network = 1;
+      }
+    } else if(!strcmp("write",token)) {
+      getEqual(in);
+      car = seekNextChar(in);
+      if(car == EOF) in->error(in,"write type was expected (custom?)");
+      else if(car == '\"') token = getQuotedString(in);
+      else token = getName(in);
+      if(!strcmp("custom", token)) {
+        t->custom_write = 1;
+      }
     }
   }
 }
@@ -224,14 +267,19 @@ void getTypeAttributes(parse_file_t *in, type_descriptor_t *t,
 void getEventAttributes(parse_file_t *in, event_t *ev)
 {
   char * token;
-  char car;
-  
+  int car;
+
   ev->name = NULL;
   ev->per_trace = 0;
   ev->per_tracefile = 0;
+  ev->param_buffer = 0;
+  ev->no_instrument_function = 0;
+  ev->high_priority = 0;
+  ev->force = 0;
+  ev->compact_data = 0;
 
   while(1) {
-    token = getToken(in); 
+    token = getToken(in);
     if(strcmp("/",token) == 0 || strcmp(">",token) == 0){
       ungetToken(in);
       break;
@@ -243,12 +291,36 @@ void getEventAttributes(parse_file_t *in, event_t *ev)
       if(car == EOF) in->error(in,"name was expected");
       else if(car == '\"') ev->name = allocAndCopy(getQuotedString(in));
       else ev->name = allocAndCopy(getName(in));
-    } else if(!strcmp("per_trace", token)) {
-      ev->per_trace = 1;
-    } else if(!strcmp("per_tracefile", token)) {
-      ev->per_tracefile = 1;
+    } else if(!strcmp("scope", token)) {
+      getEqual(in);
+      car = seekNextChar(in);
+      if(car == EOF) in->error(in,"scope was expected");
+      else if(car == '\"') token = getQuotedString(in);
+      else token = getName(in);
+      if(!strcmp(token, "trace")) ev->per_trace = 1;
+      else if(!strcmp(token, "tracefile")) ev->per_tracefile = 1;
+    } else if(!strcmp("param", token)) {
+      getEqual(in);
+      car = seekNextChar(in);
+      if(car == EOF) in->error(in,"parameter type was expected");
+      else if(car == '\"') token = getQuotedString(in);
+      else token = getName(in);
+      if(!strcmp(token, "buffer")) ev->param_buffer = 1;
+    } else if(!strcmp("attribute", token)) {
+      getEqual(in);
+      car = seekNextChar(in);
+      if(car == EOF) in->error(in,"attribute was expected");
+      else if(car == '\"') token = getQuotedString(in);
+      else token = getName(in);
+      if(!strcmp(token, "no_instrument_function"))
+        ev->no_instrument_function = 1;
+      else if(!strcmp(token, "high_priority"))
+        ev->high_priority = 1;
+      else if(!strcmp(token, "force"))
+        ev->force = 1;
+      else if(!strcmp(token, "compact_data"))
+        ev->compact_data = 1;
     }
-
   }
 }
 
@@ -267,13 +339,15 @@ void getEventAttributes(parse_file_t *in, event_t *ev)
 void getFacilityAttributes(parse_file_t *in, facility_t *fac)
 {
   char * token;
-  char car;
-  
+  int car;
+
   fac->name = NULL;
   fac->arch = NULL;
+  fac->align = 1;
+  fac->user = 0;
 
   while(1) {
-    token = getToken(in); 
+    token = getToken(in);
     if(strcmp("/",token) == 0 || strcmp(">",token) == 0){
       ungetToken(in);
       break;
@@ -285,12 +359,18 @@ void getFacilityAttributes(parse_file_t *in, facility_t *fac)
       if(car == EOF) in->error(in,"name was expected");
       else if(car == '\"') fac->name = allocAndCopy(getQuotedString(in));
       else fac->name = allocAndCopy(getName(in));
+      if(!strncmp(fac->name, "user_", sizeof("user_")-1))
+        fac->user = 1;
     } else if(!strcmp("arch", token)) {
       getEqual(in);
       car = seekNextChar(in);
-      if(car == '\"') fac->name = allocAndCopy(getQuotedString(in));
-			else fac->arch = allocAndCopy(getName(in));
-		}
+      if(car == '\"') fac->arch = allocAndCopy(getQuotedString(in));
+      else fac->arch = allocAndCopy(getName(in));
+    } else if(!strcmp("align", token)) {
+      getEqual(in);
+      fac->align = getSize(in);
+    }
+
   }
 }
 
@@ -309,12 +389,12 @@ void getFacilityAttributes(parse_file_t *in, facility_t *fac)
 void getFieldAttributes(parse_file_t *in, field_t *f)
 {
   char * token;
-  char car;
+  int car;
 
   f->name = NULL;
 
   while(1) {
-    token = getToken(in); 
+    token = getToken(in);
     if(strcmp("/",token) == 0 || strcmp(">",token) == 0){
       ungetToken(in);
       break;
@@ -334,10 +414,10 @@ char *getNameAttribute(parse_file_t *in)
 {
   char * token;
   char *name = NULL;
-  char car;
-  
+  int car;
+
   while(1) {
-    token = getToken(in); 
+    token = getToken(in);
     if(!strcmp("name",token)) {
       getEqual(in);
       car = seekNextChar(in);
@@ -356,28 +436,37 @@ char *getNameAttribute(parse_file_t *in)
 
 
 
-//for <label name=label_name value=n format="..."/>, value is an option
-char * getValueStrAttribute(parse_file_t *in)
+//for <label name=label_name value=n format="...">, value is an option
+//Return value : 0 : no value,   1 : has a value
+int getValueAttribute(parse_file_t *in, long long *value)
 {
-  char * token;
+  char * token, * endptr;
+
+  token = getToken(in);
 
-  token = getToken(in); 
-  if(strcmp("/",token) == 0){
+  if(strcmp("/",token) == 0 || strcmp(">", token) == 0){
     ungetToken(in);
-    return NULL;
+    return 0;
   }
-  
   if(strcmp("value",token))in->error(in,"value was expected");
+
   getEqual(in);
   token = getToken(in);
-  if(in->type != NUMBER) in->error(in,"number was expected");
-  return token;  
+
+  *value = strtoll(token, &endptr, 0);
+  if(*endptr != '\0')
+    goto error;
+  return 1;
+error:
+  in->error(in,"invalid number specified");
+  return 0;
 }
 
 char * getDescription(parse_file_t *in)
 {
   long int pos;
-  char * token, car, *str;
+  char * token, *str;
+  int car;
 
   pos = ftell(in->fp);
 
@@ -387,7 +476,7 @@ char * getDescription(parse_file_t *in)
     fseek(in->fp, pos, SEEK_SET);
     return NULL;
   }
-  
+
   getRAnglebracket(in);
 
   pos = 0;
@@ -412,9 +501,9 @@ char * getDescription(parse_file_t *in)
 
 /*****************************************************************************
  *Function name
- *    parseFacility : generate event list  
- *Input params 
- *    in            : input file handle          
+ *    parseFacility : generate event list
+ *Input params
+ *    in            : input file handle
  *    fac           : empty facility
  *Output params
  *    fac           : facility filled with event list
@@ -424,18 +513,18 @@ void parseFacility(parse_file_t *in, facility_t * fac)
 {
   char * token;
   event_t *ev;
-  
+
   getFacilityAttributes(in, fac);
   if(fac->name == NULL) in->error(in, "Attribute not named");
-	
+
   fac->capname = allocAndCopy(fac->name);
-	strupper(fac->capname);
-  getRAnglebracket(in);    
-  
+  strupper(fac->capname);
+  getRAnglebracket(in);
+
   fac->description = getDescription(in);
-  
+
   while(1){
-    getLAnglebracket(in);    
+    getLAnglebracket(in);
 
     token = getToken(in);
     if(in->type == ENDFILE)
@@ -444,9 +533,9 @@ void parseFacility(parse_file_t *in, facility_t * fac)
     if(strcmp("event",token) == 0){
       ev = (event_t*) memAlloc(sizeof(event_t));
       sequence_push(&(fac->events),ev);
-      parseEvent(in,ev, &(fac->unnamed_types), &(fac->named_types));    
+      parseEvent(fac, in, ev, &(fac->unnamed_types), &(fac->named_types));
     }else if(strcmp("type",token) == 0){
-      parseTypeDefinition(in, &(fac->unnamed_types), &(fac->named_types));
+      parseTypeDefinition(fac, in, &(fac->unnamed_types), &(fac->named_types));
     }else if(in->type == FORWARDSLASH){
       break;
     }else in->error(in,"event or type token expected\n");
@@ -459,144 +548,151 @@ void parseFacility(parse_file_t *in, facility_t * fac)
 
 /*****************************************************************************
  *Function name
- *    parseEvent    : generate event from event definition 
- *Input params 
- *    in            : input file handle          
- *    ev            : new event                              
+ *    parseEvent    : generate event from event definition
+ *Input params
+ *    fac           : facility holding the event
+ *    in            : input file handle
+ *    ev            : new event
  *    unnamed_types : array of unamed types
  *    named_types   : array of named types
- *Output params    
- *    ev            : new event (parameters are passed to it)   
+ *Output params
+ *    ev            : new event (parameters are passed to it)
  ****************************************************************************/
 
-void parseEvent(parse_file_t *in, event_t * ev, sequence_t * unnamed_types, 
-		table_t * named_types) 
+void parseEvent(facility_t *fac, parse_file_t *in, event_t * ev, sequence_t * unnamed_types,
+                table_t * named_types)
 {
   char *token;
-	field_t *f;
+  field_t *f;
 
-	sequence_init(&(ev->fields));
+  ev->fac = fac;
+  sequence_init(&(ev->fields));
   //<event name=eventtype_name>
   getEventAttributes(in, ev);
   if(ev->name == NULL) in->error(in, "Event not named");
-  getRAnglebracket(in);  
+  getRAnglebracket(in);
 
   //<description>...</description>
-  ev->description = getDescription(in); 
-  
-	int got_end = 0;
-	/* Events can have multiple fields. each field form at least a function
-	 * parameter of the logging function. */
-	while(!got_end) {
-		getLAnglebracket(in);
-		token = getToken(in);
-		
-		switch(in->type) {
-		case FORWARDSLASH:	/* </event> */
-			token = getName(in);
-			if(strcmp("event",token))in->error(in,"not an event definition");
-			getRAnglebracket(in);  //</event>
-			got_end = 1;
-			break;
-		case NAME: /* a field */
-			if(strcmp("field",token))in->error(in,"expecting a field");
-			f = (field_t *)memAlloc(sizeof(field_t));
-			sequence_push(&(ev->fields),f);
-			parseFields(in, f, unnamed_types, named_types, 1);
-			break;
-		default:
-			in->error(in, "expecting </event> or <field >");
-			break;
-		}
-	}
+  ev->description = getDescription(in);
+
+  int got_end = 0;
+  /* Events can have multiple fields. each field form at least a function
+   * parameter of the logging function. */
+  while(!got_end) {
+    getLAnglebracket(in);
+    token = getToken(in);
+
+    switch(in->type) {
+    case FORWARDSLASH:  /* </event> */
+      token = getName(in);
+      if(strcmp("event",token))in->error(in,"not an event definition");
+      getRAnglebracket(in);  //</event>
+      got_end = 1;
+      break;
+    case NAME: /* a field */
+      if(strcmp("field",token))in->error(in,"expecting a field");
+      f = (field_t *)memAlloc(sizeof(field_t));
+      sequence_push(&(ev->fields),f);
+      parseFields(fac, in, f, unnamed_types, named_types, 1);
+      break;
+    default:
+      in->error(in, "expecting </event> or <field >");
+      break;
+    }
+  }
 #if 0
-		if(in->type == FORWARDSLASH){ //</event> NOTHING
-			ev->type = NULL;
-		}else if(in->type == NAME){
-			if(strcmp("struct",token)==0 || strcmp("typeref",token)==0){
-				ungetToken(in);
-				ev->type = parseType(in,NULL, unnamed_types, named_types);
-				if(ev->type->type != STRUCT && ev->type->type != NONE) 
-		in->error(in,"type must be a struct");     
-			}else in->error(in, "not a valid type");
-
-			getLAnglebracket(in);
-			getForwardslash(in);    
-		}else in->error(in,"not a struct type");
-		getLAnglebracket(in);
-		getForwardslash(in);    
-		token = getName(in);
-		if(strcmp("event",token))in->error(in,"not an event definition");
-		getRAnglebracket(in);  //</event>
+    if(in->type == FORWARDSLASH){ //</event> NOTHING
+      ev->type = NULL;
+    }else if(in->type == NAME){
+      if(strcmp("struct",token)==0 || strcmp("typeref",token)==0){
+        ungetToken(in);
+        ev->type = parseType(in,NULL, unnamed_types, named_types);
+        if(ev->type->type != STRUCT && ev->type->type != NONE)
+    in->error(in,"type must be a struct");
+      }else in->error(in, "not a valid type");
+
+      getLAnglebracket(in);
+      getForwardslash(in);
+    }else in->error(in,"not a struct type");
+    getLAnglebracket(in);
+    getForwardslash(in);
+    token = getName(in);
+    if(strcmp("event",token))in->error(in,"not an event definition");
+    getRAnglebracket(in);  //</event>
 #endif //0
 }
 
 /*****************************************************************************
  *Function name
- *    parseField    : get field infomation from buffer 
- *Input params 
+ *    parseField    : get field infomation from buffer
+ *Input params
+ *    fac           : facility holding the field
  *    in            : input file handle
  *    f             : field
  *    unnamed_types : array of unamed types
  *    named_types   : array of named types
- *    tag						: is field surrounded by a <field> </field> tag ?
+ *    tag           : is field surrounded by a <field> </field> tag ?
  ****************************************************************************/
 
-void parseFields(parse_file_t *in, field_t *f,
+void parseFields(facility_t *fac, parse_file_t *in, field_t *f,
     sequence_t * unnamed_types,
-		table_t * named_types,
-		int tag) 
+    table_t * named_types,
+    int tag)
 {
   char * token;
-	if(tag) {
-		//<field name=field_name> <description> <type> </field>
-		getFieldAttributes(in, f);
-		if(f->name == NULL) in->error(in, "Field not named");
-		getRAnglebracket(in);
+  f->fac = fac;
+  if(tag) {
+    //<field name=field_name> <description> <type> </field>
+    getFieldAttributes(in, f);
+    if(f->name == NULL) in->error(in, "Field not named");
+    getRAnglebracket(in);
 
-		f->description = getDescription(in);
-	}
+    f->description = getDescription(in);
+  } else {
+    f->description = NULL;
+  }
 
   //<int size=...>
   getLAnglebracket(in);
-  f->type = parseType(in,NULL, unnamed_types, named_types);
-
-	if(tag) {
-		getLAnglebracket(in);
-		getForwardslash(in);
-		token = getName(in);
-		if(strcmp("field",token))in->error(in,"not a valid field definition");
-		getRAnglebracket(in); //</field>
-	}
+  f->type = parseType(fac, in,NULL, unnamed_types, named_types);
+
+  if(tag) {
+    getLAnglebracket(in);
+    getForwardslash(in);
+    token = getName(in);
+    if(strcmp("field",token))in->error(in,"not a valid field definition");
+    getRAnglebracket(in); //</field>
+  }
 }
 
 
 /*****************************************************************************
  *Function name
- *    parseType      : get type information, type can be : 
+ *    parseType      : get type information, type can be :
  *                     Primitive:
- *                        int(size,fmt); uint(size,fmt); float(size,fmt); 
+ *                        int(size,fmt); uint(size,fmt); float(size,fmt);
  *                        string(fmt); enum(size,fmt,(label1,label2...))
  *                     Compound:
  *                        array(arraySize, type); sequence(lengthSize,type)
- *		          struct(field(name,type,description)...)
+ *                        struct(field(name,type,description)...)
  *                     type name:
  *                        type(name,type)
- *Input params 
+ *Input params
+ *    fac              : facility
  *    in               : input file handle
- *    inType           : a type descriptor          
+ *    inType           : a type descriptor
  *    unnamed_types    : array of unamed types
  *    named_types      : array of named types
- *Return values  
- *    type_descriptor* : a type descriptor             
+ *Return values
+ *    type_descriptor* : a type descriptor
  ****************************************************************************/
 
-type_descriptor_t *parseType(parse_file_t *in, type_descriptor_t *inType, 
-			   sequence_t * unnamed_types, table_t * named_types) 
+type_descriptor_t *parseType(facility_t *fac, parse_file_t *in, type_descriptor_t *inType,
+                             sequence_t * unnamed_types, table_t * named_types)
 {
   char *token;
   type_descriptor_t *t;
-	field_t *f;
+  field_t *f;
 
   if(inType == NULL) {
     t = (type_descriptor_t *) memAlloc(sizeof(type_descriptor_t));
@@ -606,6 +702,7 @@ type_descriptor_t *parseType(parse_file_t *in, type_descriptor_t *inType,
     sequence_push(unnamed_types,t);
   }
   else t = inType;
+  t->fac = fac;
 
   token = getName(in);
 
@@ -617,14 +714,14 @@ type_descriptor_t *parseType(parse_file_t *in, type_descriptor_t *inType,
     token = getToken(in);
     sequence_init(&(t->fields));
     while(strcmp("field",token) == 0){
-			f = (field_t *)memAlloc(sizeof(field_t));
-			sequence_push(&(t->fields),f);
+      f = (field_t *)memAlloc(sizeof(field_t));
+      sequence_push(&(t->fields),f);
+
+      parseFields(fac, in, f, unnamed_types, named_types, 1);
 
-      parseFields(in, f, unnamed_types, named_types, 1);
-      
       //next field
       getLAnglebracket(in);
-      token = getToken(in);	
+      token = getToken(in);
     }
     if(strcmp("/",token))in->error(in,"not a valid structure definition");
     token = getName(in);
@@ -641,18 +738,18 @@ type_descriptor_t *parseType(parse_file_t *in, type_descriptor_t *inType,
     token = getToken(in);
     sequence_init(&(t->fields));
     while(strcmp("field",token) == 0){
-			f = (field_t *)memAlloc(sizeof(field_t));
-			sequence_push(&(t->fields),f);
-      parseFields(in, f, unnamed_types, named_types, 1);
-      
+      f = (field_t *)memAlloc(sizeof(field_t));
+      sequence_push(&(t->fields),f);
+      parseFields(fac, in, f, unnamed_types, named_types, 1);
+
       //next field
       getLAnglebracket(in);
-      token = getToken(in);	
+      token = getToken(in);
     }
     if(strcmp("/",token))in->error(in,"not a valid union definition");
     token = getName(in);
     if(strcmp("union",token)!=0)
-      in->error(in,"not a valid union definition");        
+      in->error(in,"not a valid union definition");
     getRAnglebracket(in); //</union>
   }
   else if(strcmp(token,"array") == 0) {
@@ -663,13 +760,15 @@ type_descriptor_t *parseType(parse_file_t *in, type_descriptor_t *inType,
     getForwardslash(in);
     getRAnglebracket(in); //<array size=n>
 
-    //getLAnglebracket(in); //<subtype> 
-		/* subfield */
-		f = (field_t *)memAlloc(sizeof(field_t));
-		sequence_push(&(t->fields),f);
-    parseFields(in, f, unnamed_types, named_types, 0);
+    //getLAnglebracket(in); //<subtype>
+    /* subfield */
+    f = (field_t *)memAlloc(sizeof(field_t));
+
+    f->name = NULL;
+    sequence_push(&(t->fields),f);
+    parseFields(fac, in, f, unnamed_types, named_types, 0);
 
-    //getLAnglebracket(in); //<type struct> 
+    //getLAnglebracket(in); //<type struct>
     //t->nested_type = parseType(in, NULL, unnamed_types, named_types);
 
     getLAnglebracket(in); //</array>
@@ -685,39 +784,41 @@ type_descriptor_t *parseType(parse_file_t *in, type_descriptor_t *inType,
     getForwardslash(in);
     getRAnglebracket(in); //<sequence>
 
-    //getLAnglebracket(in); //<sequence size type> 
-		/* subfield */
-		f = (field_t *)memAlloc(sizeof(field_t));
-		sequence_push(&(t->fields),f);
-    parseFields(in, f, unnamed_types, named_types, 0);
-
-    //getLAnglebracket(in); //<subtype> 
-		/* subfield */
-		f = (field_t *)memAlloc(sizeof(field_t));
-		sequence_push(&(t->fields),f);
-    parseFields(in, f, unnamed_types, named_types, 0);
-
-    //getLAnglebracket(in); //<type sequence> 
+    //getLAnglebracket(in); //<sequence size type>
+    /* subfield */
+    f = (field_t *)memAlloc(sizeof(field_t));
+    f->name = NULL;
+    sequence_push(&(t->fields),f);
+    parseFields(fac, in, f, unnamed_types, named_types, 0);
+
+    //getLAnglebracket(in); //<subtype>
+    /* subfield */
+    f = (field_t *)memAlloc(sizeof(field_t));
+    f->name = NULL;
+    sequence_push(&(t->fields),f);
+    parseFields(fac, in, f, unnamed_types, named_types, 0);
+
+    //getLAnglebracket(in); //<type sequence>
     //t->length_type = parseType(in, NULL, unnamed_types, named_types);
 
-    //getLAnglebracket(in); //<type sequence> 
+    //getLAnglebracket(in); //<type sequence>
 
     //t->nested_type = parseType(in, NULL, unnamed_types, named_types);
 
     if(t->fields.position < 1) in->error(in, "Sequence has no length type");
     if(t->fields.position < 2) in->error(in, "Sequence has no subtype");
-		switch(((field_t*)t->fields.array[0])->type->type) {
-			case UINT_FIXED :
-			case UCHAR :
-			case USHORT :
-			case UINT :
-			case ULONG :
-			case SIZE_T :
-			case OFF_T :
-				break;
-			default:
-				in->error(in, "Wrong length type for sequence");
-		}
+    switch(((field_t*)t->fields.array[0])->type->type) {
+      case UINT_FIXED :
+      case UCHAR :
+      case USHORT :
+      case UINT :
+      case ULONG :
+      case SIZE_T :
+      case OFF_T :
+        break;
+      default:
+        in->error(in, "Wrong length type for sequence");
+    }
 
     getLAnglebracket(in); //</sequence>
     getForwardslash(in);
@@ -727,19 +828,19 @@ type_descriptor_t *parseType(parse_file_t *in, type_descriptor_t *inType,
   }
   else if(strcmp(token,"enum") == 0) {
     char * str;
-    int value = -1;
+    long long value = -1;
 
     t->type = ENUM;
     sequence_init(&(t->labels));
     sequence_init(&(t->labels_values));
     sequence_init(&(t->labels_description));
-		t->already_printed = 0;
+    t->already_printed = 0;
     getTypeAttributes(in, t, unnamed_types, named_types);
     //if(t->size == 0) in->error(in, "Sequence has empty size");
-		//Mathieu : we fix enum size to target int size. GCC is always like this.
-		//fox copy optimisation.
+    //Mathieu : we fix enum size to target int size. GCC is always like this.
+    //fox copy optimisation.
     if(t->size != 0) in->error(in, "Enum has fixed size of target int.");
-		t->size = 0;
+    t->size = 0;
     getRAnglebracket(in);
 
     //<label name=label1 value=n/>
@@ -747,13 +848,15 @@ type_descriptor_t *parseType(parse_file_t *in, type_descriptor_t *inType,
     token = getToken(in); //"label" or "/"
     while(strcmp("label",token) == 0){
       int *label_value = malloc(sizeof(int));
-      
+      int has_value = 0;
+      long long loc_value;
+
       str   = allocAndCopy(getNameAttribute(in));
-      token = getValueStrAttribute(in);
-      
-     	sequence_push(&(t->labels),str);
+      has_value = getValueAttribute(in, &loc_value);
 
-      if(token) value = strtol(token, NULL, 0);
+      sequence_push(&(t->labels),str);
+
+      if(has_value) value = loc_value;
       else value++;
 
       *label_value = value;
@@ -761,14 +864,14 @@ type_descriptor_t *parseType(parse_file_t *in, type_descriptor_t *inType,
 
       getForwardslash(in);
       getRAnglebracket(in);
-      
+
       //read description if any. May be NULL.
       str = allocAndCopy(getDescription(in));
-			sequence_push(&(t->labels_description),str);
-			      
+      sequence_push(&(t->labels_description),str);
+
       //next label definition
       getLAnglebracket(in);
-      token = getToken(in); //"label" or "/"      
+      token = getToken(in); //"label" or "/"
     }
     if(strcmp("/",token))in->error(in, "not a valid enum definition");
     token = getName(in);
@@ -780,134 +883,134 @@ type_descriptor_t *parseType(parse_file_t *in, type_descriptor_t *inType,
     getTypeAttributes(in, t, unnamed_types, named_types);
     if(t->size == 0) in->error(in, "int has empty size");
     getForwardslash(in);
-    getRAnglebracket(in); 
+    getRAnglebracket(in);
   }
   else if(strcmp(token,"uint_fixed") == 0) {
     t->type = UINT_FIXED;
     getTypeAttributes(in, t, unnamed_types, named_types);
     if(t->size == 0) in->error(in, "uint has empty size");
     getForwardslash(in);
-    getRAnglebracket(in); 
+    getRAnglebracket(in);
   }
   else if(strcmp(token,"char") == 0) {
     t->type = CHAR;
     getTypeAttributes(in, t, unnamed_types, named_types);
-		t->size = 1;
+    t->size = 1;
     getForwardslash(in);
-    getRAnglebracket(in); 
+    getRAnglebracket(in);
   }
   else if(strcmp(token,"uchar") == 0) {
     t->type = UCHAR;
     getTypeAttributes(in, t, unnamed_types, named_types);
-		t->size = 1;
+    t->size = 1;
     getForwardslash(in);
-    getRAnglebracket(in); 
+    getRAnglebracket(in);
   }
   else if(strcmp(token,"short") == 0) {
     t->type = SHORT;
     getTypeAttributes(in, t, unnamed_types, named_types);
-		t->size = 2;
+    t->size = 2;
     getForwardslash(in);
-    getRAnglebracket(in); 
+    getRAnglebracket(in);
   }
   else if(strcmp(token,"ushort") == 0) {
     t->type = USHORT;
     getTypeAttributes(in, t, unnamed_types, named_types);
-		t->size = 2;
+    t->size = 2;
     getForwardslash(in);
-    getRAnglebracket(in); 
+    getRAnglebracket(in);
   }
   else if(strcmp(token,"int") == 0) {
     t->type = INT;
     getTypeAttributes(in, t, unnamed_types, named_types);
     getForwardslash(in);
-    getRAnglebracket(in); 
+    getRAnglebracket(in);
   }
   else if(strcmp(token,"uint") == 0) {
     t->type = UINT;
     getTypeAttributes(in, t, unnamed_types, named_types);
     getForwardslash(in);
-    getRAnglebracket(in); 
+    getRAnglebracket(in);
   }
 
   else if(strcmp(token,"pointer") == 0) {
     t->type = POINTER;
     getTypeAttributes(in, t, unnamed_types, named_types);
     getForwardslash(in);
-    getRAnglebracket(in); 
+    getRAnglebracket(in);
   }
   else if(strcmp(token,"long") == 0) {
     t->type = LONG;
     getTypeAttributes(in, t, unnamed_types, named_types);
     getForwardslash(in);
-    getRAnglebracket(in); 
+    getRAnglebracket(in);
   }
   else if(strcmp(token,"ulong") == 0) {
     t->type = ULONG;
     getTypeAttributes(in, t, unnamed_types, named_types);
     getForwardslash(in);
-    getRAnglebracket(in); 
+    getRAnglebracket(in);
   }
   else if(strcmp(token,"size_t") == 0) {
     t->type = SIZE_T;
     getTypeAttributes(in, t, unnamed_types, named_types);
     getForwardslash(in);
-    getRAnglebracket(in); 
+    getRAnglebracket(in);
   }
   else if(strcmp(token,"ssize_t") == 0) {
     t->type = SSIZE_T;
     getTypeAttributes(in, t, unnamed_types, named_types);
     getForwardslash(in);
-    getRAnglebracket(in); 
+    getRAnglebracket(in);
   }
   else if(strcmp(token,"off_t") == 0) {
     t->type = OFF_T;
     getTypeAttributes(in, t, unnamed_types, named_types);
     getForwardslash(in);
-    getRAnglebracket(in); 
+    getRAnglebracket(in);
   }
   else if(strcmp(token,"float") == 0) {
     t->type = FLOAT;
     getTypeAttributes(in, t, unnamed_types, named_types);
     getForwardslash(in);
-    getRAnglebracket(in); 
+    getRAnglebracket(in);
   }
   else if(strcmp(token,"string") == 0) {
     t->type = STRING;
     getTypeAttributes(in, t, unnamed_types, named_types);
     getForwardslash(in);
-    getRAnglebracket(in); 
+    getRAnglebracket(in);
   }
   else if(strcmp(token,"typeref") == 0){
     // Must be a named type
-		free(t);
-		sequence_pop(unnamed_types);
-		token = getNameAttribute(in);
-		t = find_named_type(token, named_types);
-		if(t == NULL) in->error(in,"Named referred to must be pre-declared.");
-		getForwardslash(in);  //<typeref name=type_name/>
-		getRAnglebracket(in);
-		return t;
+    free(t);
+    sequence_pop(unnamed_types);
+    token = getNameAttribute(in);
+    t = find_named_type(token, named_types);
+    if(t == NULL) in->error(in,"Named referred to must be pre-declared.");
+    getForwardslash(in);  //<typeref name=type_name/>
+    getRAnglebracket(in);
+    return t;
   }else in->error(in,"not a valid type");
 
   return t;
-}    
+}
 
 /*****************************************************************************
  *Function name
- *    find_named_type     : find a named type from hash table 
- *Input params 
- *    name                : type name          
+ *    find_named_type     : find a named type from hash table
+ *Input params
+ *    name                : type name
  *    named_types         : array of named types
- *Return values  
- *    type_descriptor *   : a type descriptor                       
+ *Return values
+ *    type_descriptor *   : a type descriptor
  *****************************************************************************/
 
 type_descriptor_t * find_named_type(char *name, table_t * named_types)
-{ 
+{
   type_descriptor_t *t;
 
-  t = table_find(named_types,name);
+  t = (type_descriptor_t*)table_find(named_types,name);
 
   return t;
 }
@@ -916,26 +1019,27 @@ type_descriptor_t * create_named_type(char *name, table_t * named_types)
 {
   type_descriptor_t *t;
 
-	t = (type_descriptor_t *)memAlloc(sizeof(type_descriptor_t));
-	t->type_name = allocAndCopy(name);
-	t->type = NONE;
-	t->fmt = NULL;
-	table_insert(named_types,t->type_name,t);
-	//    table_insert(named_types,allocAndCopy(name),t);
-	return t;
+  t = (type_descriptor_t *)memAlloc(sizeof(type_descriptor_t));
+  t->type_name = allocAndCopy(name);
+  t->type = NONE;
+  t->fmt = NULL;
+  table_insert(named_types,t->type_name,t);
+  //    table_insert(named_types,allocAndCopy(name),t);
+  return t;
 }
 
 /*****************************************************************************
  *Function name
- *    parseTypeDefinition : get type information from type definition 
- *Input params 
- *    in                  : input file handle          
+ *    parseTypeDefinition : get type information from type definition
+ *Input params
+ *    fac                 : facility
+ *    in                  : input file handle
  *    unnamed_types       : array of unamed types
  *    named_types         : array of named types
  *****************************************************************************/
 
-void parseTypeDefinition(parse_file_t * in, sequence_t * unnamed_types,
-			 table_t * named_types)
+void parseTypeDefinition(facility_t *fac, parse_file_t * in, sequence_t * unnamed_types,
+                         table_t * named_types)
 {
   char *token;
   type_descriptor_t *t;
@@ -950,13 +1054,13 @@ void parseTypeDefinition(parse_file_t * in, sequence_t * unnamed_types,
   token = getName(in);
   //MD ??if(strcmp("struct",token))in->error(in,"not a valid type definition");
   ungetToken(in);
-  parseType(in,t, unnamed_types, named_types);
-  
+  parseType(fac, in,t, unnamed_types, named_types);
+
   //</type>
   getLAnglebracket(in);
   getForwardslash(in);
   token = getName(in);
-  if(strcmp("type",token))in->error(in,"not a valid type definition");  
+  if(strcmp("type",token))in->error(in,"not a valid type definition");
   getRAnglebracket(in); //</type>
 }
 
@@ -974,17 +1078,17 @@ void parseTypeDefinition(parse_file_t * in, sequence_t * unnamed_types,
  *
  **************************************************************************/
 
-char *getName(parse_file_t * in) 
+char *getName(parse_file_t * in)
 {
   char *token;
 
   token = getToken(in);
   // Optional descriptions
-	// if(in->type != NAME) in->error(in,"Name token was expected");
+  // if(in->type != NAME) in->error(in,"Name token was expected");
   return token;
 }
 
-int getNumber(parse_file_t * in) 
+int getNumber(parse_file_t * in)
 {
   char *token;
 
@@ -993,19 +1097,19 @@ int getNumber(parse_file_t * in)
   return atoi(token);
 }
 
-char *getForwardslash(parse_file_t * in) 
+char *getForwardslash(parse_file_t * in)
 {
   char *token;
 
   token = getToken(in);
   //if(in->type != FORWARDSLASH) in->error(in, "forward slash token was expected");
-	/* Mathieu : final / is optional now. */
+  /* Mathieu : final / is optional now. */
   if(in->type != FORWARDSLASH) ungetToken(in);
 
   return token;
 }
 
-char *getLAnglebracket(parse_file_t * in) 
+char *getLAnglebracket(parse_file_t * in)
 {
   char *token;
 
@@ -1014,7 +1118,7 @@ char *getLAnglebracket(parse_file_t * in)
   return token;
 }
 
-char *getRAnglebracket(parse_file_t * in) 
+char *getRAnglebracket(parse_file_t * in)
 {
   char *token;
 
@@ -1023,7 +1127,7 @@ char *getRAnglebracket(parse_file_t * in)
   return token;
 }
 
-char *getQuotedString(parse_file_t * in) 
+char *getQuotedString(parse_file_t * in)
 {
   char *token;
 
@@ -1041,15 +1145,15 @@ char * getEqual(parse_file_t *in)
   return token;
 }
 
-char seekNextChar(parse_file_t *in)
+int seekNextChar(parse_file_t *in)
 {
-  char car;
+  int car;
   while((car = getc(in->fp)) != EOF) {
     if(!isspace(car)){
       ungetc(car,in->fp);
       return car;
     }
-  }  
+  }
   return EOF;
 }
 
@@ -1076,7 +1180,7 @@ void ungetToken(parse_file_t * in)
 char *getToken(parse_file_t * in)
 {
   FILE *fp = in->fp;
-  char car, car1;
+  int car, car1;
   int pos = 0, escaped;
 
   if(in->unget == 1) {
@@ -1088,10 +1192,10 @@ char *getToken(parse_file_t * in)
 
   while((car = getc(fp)) != EOF) {
     if(car == '/') {
-      car1 = getc(fp); 
+      car1 = getc(fp);
       if(car1 == '*') skipComment(in);
       else if(car1 == '/') skipEOL(in);
-      else { 
+      else {
         car1 = ungetc(car1,fp);
         break;
       }
@@ -1128,8 +1232,8 @@ char *getToken(parse_file_t * in)
       escaped = 0;
       while((car = getc(fp)) != EOF && pos < BUFFER_SIZE) {
         if(car == '\\' && escaped == 0) {
-	  in->buffer[pos] = car;
-	  pos++;
+          in->buffer[pos] = car;
+          pos++;
           escaped = 1;
           continue;
         }
@@ -1158,10 +1262,10 @@ char *getToken(parse_file_t * in)
           in->buffer[pos] = car;
           pos++;
         }
-	if(car == EOF) ungetc(car,fp);
+        if(car == EOF) ungetc(car,fp);
         if(pos == BUFFER_SIZE) in->error(in, "number token too large");
         in->type = NUMBER;
-      }    
+      }
       else if(isalnum(car) || car == '_' || car == '-') {
         in->buffer[0] = car;
         pos = 1;
@@ -1173,9 +1277,12 @@ char *getToken(parse_file_t * in)
           in->buffer[pos] = car;
           pos++;
         }
-	if(car == EOF) ungetc(car,fp);
+      if(car == EOF) ungetc(car,fp);
         if(pos == BUFFER_SIZE) in->error(in, "name token too large");
         in->type = NAME;
+      } else if(car == '?') {
+        in->buffer[0] = car;
+        pos++;
       }
       else in->error(in, "invalid character, unrecognized token");
   }
@@ -1185,7 +1292,7 @@ char *getToken(parse_file_t * in)
 
 void skipComment(parse_file_t * in)
 {
-  char car;
+  int car;
   while((car = getc(in->fp)) != EOF) {
     if(car == '\n') in->lineno++;
     else if(car == '*') {
@@ -1200,7 +1307,7 @@ void skipComment(parse_file_t * in)
 
 void skipEOL(parse_file_t * in)
 {
-  char car;
+  int car;
   while((car = getc(in->fp)) != EOF) {
     if(car == '\n') {
       ungetc(car,in->fp);
@@ -1226,7 +1333,7 @@ void checkNamedTypesImplemented(table_t * named_types)
     if(t->type == NONE){
       sprintf(str,"named type '%s' has no definition",
           (char*)named_types->keys.array[pos]);
-      error_callback(NULL,str);   
+      error_callback(NULL,str);
     }
   }
 }
@@ -1253,11 +1360,11 @@ void generateChecksum(char* facName,
   for(pos = 0; pos < events->position; pos++){
     ev = (event_t *)(events->array[pos]);
     crc = partial_crc32(ev->name, crc);
-		for(i = 0; i < ev->fields.position; i++) {
-			field_t *f = (field_t*)ev->fields.array[i];
+    for(i = 0; i < ev->fields.position; i++) {
+      field_t *f = (field_t*)ev->fields.array[i];
       crc = partial_crc32(f->name, crc);
       crc = getTypeChecksum(crc, f->type);
-		}
+    }
   }
   *checksum = crc;
 }
@@ -1268,8 +1375,8 @@ void generateChecksum(char* facName,
  *Input Params
  *    crc               : checksum generated so far
  *    type              : type descriptor containing type info
- *Return value          
- *    unsigned long     : checksum 
+ *Return value
+ *    unsigned long     : checksum
  *****************************************************************************/
 
 unsigned long getTypeChecksum(unsigned long aCrc, type_descriptor_t * type)
@@ -1288,51 +1395,51 @@ unsigned long getTypeChecksum(unsigned long aCrc, type_descriptor_t * type)
       break;
     case POINTER:
       str = allocAndCopy("void *");
-			flag = 1;
+      flag = 1;
       break;
     case CHAR:
       str = allocAndCopy("signed char");
-			flag = 1;
+      flag = 1;
       break;
     case UCHAR:
       str = allocAndCopy("unsigned char");
-			flag = 1;
+      flag = 1;
       break;
     case SHORT:
       str = allocAndCopy("short");
-			flag = 1;
+      flag = 1;
       break;
     case USHORT:
       str = allocAndCopy("unsigned short");
-			flag = 1;
+      flag = 1;
       break;
     case INT:
       str = allocAndCopy("int");
-			flag = 1;
+      flag = 1;
       break;
     case UINT:
       str = allocAndCopy("uint");
-			flag = 1;
+      flag = 1;
       break;
     case LONG:
       str = allocAndCopy("long");
-			flag = 1;
+      flag = 1;
       break;
     case ULONG:
       str = allocAndCopy("unsigned long");
-			flag = 1;
+      flag = 1;
       break;
     case SIZE_T:
       str = allocAndCopy("size_t");
-			flag = 1;
+      flag = 1;
       break;
     case SSIZE_T:
       str = allocAndCopy("ssize_t");
-			flag = 1;
+      flag = 1;
       break;
     case OFF_T:
       str = allocAndCopy("off_t");
-			flag = 1;
+      flag = 1;
       break;
     case FLOAT:
       str = floatOutputTypes[getSizeindex(type->size)];
@@ -1371,19 +1478,21 @@ unsigned long getTypeChecksum(unsigned long aCrc, type_descriptor_t * type)
   crc = partial_crc32(str,crc);
   if(flag) free(str);
 
-  if(type->fmt) crc = partial_crc32(type->fmt,crc);
-    
+  //the format string is not included in the crc calculation
+
+  //if(type->fmt) crc = partial_crc32(type->fmt,crc);
+
   if(type->type == ARRAY){
     crc = getTypeChecksum(crc,((field_t*)type->fields.array[0])->type);
   } else if(type->type ==SEQUENCE) {
     crc = getTypeChecksum(crc,((field_t*)type->fields.array[0])->type);
     crc = getTypeChecksum(crc,((field_t*)type->fields.array[1])->type);
-	} else if(type->type == STRUCT || type->type == UNION){
+  } else if(type->type == STRUCT || type->type == UNION){
     for(pos =0; pos < type->fields.position; pos++){
       fld = (field_t *) type->fields.array[pos];
       crc = partial_crc32(fld->name,crc);
       crc = getTypeChecksum(crc, fld->type);
-    }    
+    }
   }else if(type->type == ENUM){
     for(pos = 0; pos < type->labels.position; pos++)
       crc = partial_crc32((char*)type->labels.array[pos],crc);
@@ -1434,7 +1543,7 @@ void freeNamedType(table_t * t)
   }
 }
 
-void freeTypes(sequence_t *t) 
+void freeTypes(sequence_t *t)
 {
   int pos;
   type_descriptor_t *tp;
@@ -1446,7 +1555,7 @@ void freeTypes(sequence_t *t)
   }
 }
 
-void freeEvents(sequence_t *t) 
+void freeEvents(sequence_t *t)
 {
   int pos;
   event_t *ev;
@@ -1455,7 +1564,7 @@ void freeEvents(sequence_t *t)
     ev = (event_t *) t->array[pos];
     free(ev->name);
     free(ev->description);
-		sequence_dispose(&ev->fields);
+    sequence_dispose(&ev->fields);
     free(ev);
   }
 
@@ -1464,21 +1573,21 @@ void freeEvents(sequence_t *t)
 
 /* Extensible array */
 
-void sequence_init(sequence_t *t) 
+void sequence_init(sequence_t *t)
 {
   t->size = 10;
   t->position = 0;
   t->array = (void **)memAlloc(t->size * sizeof(void *));
 }
 
-void sequence_dispose(sequence_t *t) 
+void sequence_dispose(sequence_t *t)
 {
   t->size = 0;
   free(t->array);
   t->array = NULL;
 }
 
-void sequence_push(sequence_t *t, void *elem) 
+void sequence_push(sequence_t *t, void *elem)
 {
   void **tmp;
 
@@ -1493,33 +1602,34 @@ void sequence_push(sequence_t *t, void *elem)
   t->position++;
 }
 
-void *sequence_pop(sequence_t *t) 
+void *sequence_pop(sequence_t *t)
 {
-  return t->array[t->position--];
+  if(t->position == 0) printf("Error : trying to pop an empty sequence");
+  return t->array[--t->position];
 }
 
 
 /* Hash table API, implementation is just linear search for now */
 
-void table_init(table_t *t) 
+void table_init(table_t *t)
 {
   sequence_init(&(t->keys));
   sequence_init(&(t->values));
 }
 
-void table_dispose(table_t *t) 
+void table_dispose(table_t *t)
 {
   sequence_dispose(&(t->keys));
   sequence_dispose(&(t->values));
 }
 
-void table_insert(table_t *t, char *key, void *value) 
+void table_insert(table_t *t, char *key, void *value)
 {
   sequence_push(&(t->keys),key);
   sequence_push(&(t->values),value);
 }
 
-void *table_find(table_t *t, char *key) 
+void *table_find(table_t *t, char *key)
 {
   int pos;
   for(pos = 0 ; pos < t->keys.position; pos++) {
@@ -1548,13 +1658,13 @@ void *table_find_int(table_t *t, int *key)
 
 /* Concatenate strings */
 
-char *appendString(char *s, char *suffix) 
+char *appendString(char *s, char *suffix)
 {
   char *tmp;
   if(suffix == NULL) return s;
 
   tmp = (char *)memAlloc(strlen(s) + strlen(suffix) + 1);
   strcpy(tmp,s);
-  strcat(tmp,suffix);  
+  strcat(tmp,suffix);
   return tmp;
 }